[jira] [Commented] (NIFI-4405) GenerateFlowFile should allow charset for custom text

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174909#comment-16174909
 ] 

ASF GitHub Bot commented on NIFI-4405:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2168


> GenerateFlowFile should allow charset for custom text
> -
>
> Key: NIFI-4405
> URL: https://issues.apache.org/jira/browse/NIFI-4405
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> The user should be allowed to configure a charset used to get the bytes of 
> the custom text.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4405) GenerateFlowFile should allow charset for custom text

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174905#comment-16174905
 ] 

ASF GitHub Bot commented on NIFI-4405:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2168
  
+1, merging to master, build with contrib-check OK and confirmed expected 
behavior, thanks @bbende 


> GenerateFlowFile should allow charset for custom text
> -
>
> Key: NIFI-4405
> URL: https://issues.apache.org/jira/browse/NIFI-4405
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> The user should be allowed to configure a charset used to get the bytes of 
> the custom text.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4405) GenerateFlowFile should allow charset for custom text

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174908#comment-16174908
 ] 

ASF subversion and git services commented on NIFI-4405:
---

Commit 329dbe3a64f70e283ee131f8313dadf8ec96f3d4 in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=329dbe3 ]

NIFI-4405 Adding charset property to GenerateFlowFile

Signed-off-by: Pierre Villard 

This closes #2168.


> GenerateFlowFile should allow charset for custom text
> -
>
> Key: NIFI-4405
> URL: https://issues.apache.org/jira/browse/NIFI-4405
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> The user should be allowed to configure a charset used to get the bytes of 
> the custom text.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4405) GenerateFlowFile should allow charset for custom text

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174898#comment-16174898
 ] 

ASF GitHub Bot commented on NIFI-4405:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2168
  
reviewing...


> GenerateFlowFile should allow charset for custom text
> -
>
> Key: NIFI-4405
> URL: https://issues.apache.org/jira/browse/NIFI-4405
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> The user should be allowed to configure a charset used to get the bytes of 
> the custom text.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4405) GenerateFlowFile should allow charset for custom text

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174885#comment-16174885
 ] 

ASF GitHub Bot commented on NIFI-4405:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/2168

NIFI-4405 Adding charset property to GenerateFlowFile

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-4405

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2168


commit f5230b9c45a6f24659efdc4e8c9edc8bdcfecb20
Author: Bryan Bende 
Date:   2017-09-21T14:57:03Z

NIFI-4405 Adding charset property to GenerateFlowFile




> GenerateFlowFile should allow charset for custom text
> -
>
> Key: NIFI-4405
> URL: https://issues.apache.org/jira/browse/NIFI-4405
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> The user should be allowed to configure a charset used to get the bytes of 
> the custom text.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)