[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367374#comment-16367374
 ] 

ASF GitHub Bot commented on NIFI-4884:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2472
  
Thanks @bbende! This has been merged to master.


> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367373#comment-16367373
 ] 

ASF subversion and git services commented on NIFI-4884:
---

Commit b855d0acaef7aa399469529b3133a7027bbb2f24 in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b855d0a ]

NIFI-4884 Fixing ordering during import from registry so that we set schedule 
strategy on a processor before setting scheduling duration. This closes #2472


> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367376#comment-16367376
 ] 

ASF GitHub Bot commented on NIFI-4884:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2472


> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367362#comment-16367362
 ] 

ASF GitHub Bot commented on NIFI-4884:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2472
  
Will review...


> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366004#comment-16366004
 ] 

ASF GitHub Bot commented on NIFI-4884:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/2472

NIFI-4884 Fixing ordering during import from registry so that we set …

…schedule strategy on a processor before setting scheduling duration

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-4884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2472


commit 15ac547d6b7d1d2541456b0c380b38b731f29c4b
Author: Bryan Bende 
Date:   2018-02-15T17:42:47Z

NIFI-4884 Fixing ordering during import from registry so that we set 
schedule strategy on a processor before setting scheduling duration




> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4884) Failed to import flow from registry when processor has CRON schedule

[Bryan Bende (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365990#comment-16365990
 ] 

Bryan Bende commented on NIFI-4884:
---

I believe the issue is that when we apply values from the versioned processor 
to the actual processor, we are setting the schedule duration before the 
schedule strategy.

Testing a change and will submit a PR if it works.

> Failed to import flow from registry when processor has CRON schedule
> 
>
> Key: NIFI-4884
> URL: https://issues.apache.org/jira/browse/NIFI-4884
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Steps to reproduce:
>  * Make a new process group
>  * Go into new PG
>  * Create a GenerateFlowFile processor
>  * Set scheduling strategy to CRON
>  * Start Version Control
>  * Create a new PG by importing V1 that was saved in previous step
> This will produce a modal pop up saying that the cron expression is not a 
> valid scheduling strategy and will result in an empty PG.
> Tested on a large PG with 50+ processors where only one had CRON, and still 
> results in empty PG with nothing imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)