[jira] [Commented] (NIFI-4951) convertToAvroObject does not utilize AvroTypeUtil when trying to convert Date, Time, or Timestamps

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402290#comment-16402290
 ] 

ASF GitHub Bot commented on NIFI-4951:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2526


> convertToAvroObject does not utilize AvroTypeUtil when trying to convert 
> Date, Time, or Timestamps
> --
>
> Key: NIFI-4951
> URL: https://issues.apache.org/jira/browse/NIFI-4951
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Derek Straka
>Priority: Major
>
> Currently, AvroTypeUtil::convertToAvroObject assumes that the logical types 
> have already been converted into their internal representation.  While this 
> may sometimes be the case, it would be useful to allow String->Logical type 
> conversion.  The feature can be added by using the appropriate 
> DataTypeUtils::to method rather than blindly attempting to use 
> the underlying type.  The DataTypeUtils already performs the integral type 
> parsing, so the existing functionality remains intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4951) convertToAvroObject does not utilize AvroTypeUtil when trying to convert Date, Time, or Timestamps

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402287#comment-16402287
 ] 

ASF GitHub Bot commented on NIFI-4951:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2526
  
@derekstraka that's a good catch. Definitely an oversight. Thanks for the 
fix! Merged to master.


> convertToAvroObject does not utilize AvroTypeUtil when trying to convert 
> Date, Time, or Timestamps
> --
>
> Key: NIFI-4951
> URL: https://issues.apache.org/jira/browse/NIFI-4951
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Derek Straka
>Priority: Major
>
> Currently, AvroTypeUtil::convertToAvroObject assumes that the logical types 
> have already been converted into their internal representation.  While this 
> may sometimes be the case, it would be useful to allow String->Logical type 
> conversion.  The feature can be added by using the appropriate 
> DataTypeUtils::to method rather than blindly attempting to use 
> the underlying type.  The DataTypeUtils already performs the integral type 
> parsing, so the existing functionality remains intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4951) convertToAvroObject does not utilize AvroTypeUtil when trying to convert Date, Time, or Timestamps

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402286#comment-16402286
 ] 

ASF subversion and git services commented on NIFI-4951:
---

Commit c056ede6cccb4a93426425fa0c5dbc02d555b6cc in nifi's branch 
refs/heads/master from [~derekstraka]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c056ede ]

NIFI-4951: Update convertToAvroObject to use the DataTypeUtils conversion 
function

The feature allows users to convert from non-integral types to the correct 
underlying type.  The
original behavior is maintained; however, now simple conversions take place 
automatically for some
logical types (date, time, and timestamp).

This closes #2526.

Signed-off-by: Derek Straka 
Signed-off-by: Mark Payne 


> convertToAvroObject does not utilize AvroTypeUtil when trying to convert 
> Date, Time, or Timestamps
> --
>
> Key: NIFI-4951
> URL: https://issues.apache.org/jira/browse/NIFI-4951
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Derek Straka
>Priority: Major
>
> Currently, AvroTypeUtil::convertToAvroObject assumes that the logical types 
> have already been converted into their internal representation.  While this 
> may sometimes be the case, it would be useful to allow String->Logical type 
> conversion.  The feature can be added by using the appropriate 
> DataTypeUtils::to method rather than blindly attempting to use 
> the underlying type.  The DataTypeUtils already performs the integral type 
> parsing, so the existing functionality remains intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)