[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537954#comment-16537954
 ] 

ASF subversion and git services commented on NIFI-5376:
---

Commit f60585a9b6df6b3b28be1eb80a0a60deac6c0493 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=f60585a ]

NIFI-5376 Removed deprecation warnings.
Updated Javadoc for SiteToSiteClient#createTransaction() and HttpClient 
implementation.
Reverted exception listing in method contract for 
SiteToSiteClient#createTransaction and HttpClient tion of same.
Reverted import ordering in TestSiteToSiteClient.
Reverted exception listing in TestGetHDFSFileInfo, TestListHDFS, and 
StandardHttpFlowFileServerProtocol.
Restored @SuppressWarnings annotation and removed unnecessary "public static" 
keywords from inner classes in SiteToSiteClient.

This closes #2841.

Signed-off-by: Joe Witt 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537955#comment-16537955
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2841


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,22]
>  

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537951#comment-16537951
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/2841
  
ok cool.  Am +1 then on all of it.  Builds great on travis, my local linux 
machine, osx.

Thanks


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537942#comment-16537942
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201208939
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/flow/TestPopularVoteFlowElection.java
 ---
@@ -46,6 +45,19 @@
 
 public class TestPopularVoteFlowElection {
 
+/**
+ * Utility method which accepts {@link NiFiProperties} object but 
calls {@link StringEncryptor#createEncryptor(String, String, String)} with 
extracted properties.
--- End diff --

ok yeah this method seems like a good candidate for being in 'nifi-mock' or 
some nifi test utils module.  This call is needed in a lot of tests.  But we 
dont want/need additional deps to some module in mainline code as the framework 
can pull from nifi props as this is doing and avoid another dependency just to 
share across code and tests..


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537940#comment-16537940
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201208738
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/flow/PopularVoteFlowElectionFactoryBean.java
 ---
@@ -44,8 +43,10 @@ public PopularVoteFlowElection getObject() throws 
Exception {
 }
 
 final Integer maxNodes = properties.getFlowElectionMaxCandidates();
-
-final StringEncryptor encryptor = 
StringEncryptor.createEncryptor(properties);
--- End diff --

it seems like this building of the encryptor needs to only be in the 
framework/main code one time using the properties as shown here.  Then for all 
the tests we could have a util method.  Perhaps in nifi-mock?


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537941#comment-16537941
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201208816
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/flow/PopularVoteFlowElectionFactoryBean.java
 ---
@@ -44,8 +43,10 @@ public PopularVoteFlowElection getObject() throws 
Exception {
 }
 
 final Integer maxNodes = properties.getFlowElectionMaxCandidates();
-
-final StringEncryptor encryptor = 
StringEncryptor.createEncryptor(properties);
--- End diff --

Will open a separate Jira to cover this and remove the deprecated method 
from the codebase as it is no longer used/exposed. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537930#comment-16537930
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201206790
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -720,7 +728,6 @@ public HttpProxy getHttpProxy() {
 }
 
 
-@SuppressWarnings("deprecation")
--- End diff --

i think you do want this line included


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537925#comment-16537925
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201205703
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/PasswordBasedEncryptor.java
 ---
@@ -121,8 +122,8 @@ public void process(final InputStream in, final 
OutputStream out) throws IOExcep
 byte[] salt;
 try {
 // NiFi legacy code determined the salt length based on 
the cipher block size
-if (cipherProvider instanceof NiFiLegacyCipherProvider) {
-salt = ((NiFiLegacyCipherProvider) 
cipherProvider).readSalt(encryptionMethod, in);
+if (cipherProvider instanceof 
org.apache.nifi.security.util.crypto.NiFiLegacyCipherProvider) {
--- End diff --

chatted with andy and he taught me about deprecation handling.  importing 
the class would have caused a deprecation warning.  doing the long form usage 
of the class each time is the way to explicitly reference/intentionally, a 
deprecated class. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537922#comment-16537922
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201204269
  
--- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestListHDFS.java
 ---
@@ -496,7 +496,7 @@ public boolean delete(final Path f, final boolean 
recursive) throws IOException
 }
 
 @Override
-public FileStatus[] listStatus(final Path f) throws 
FileNotFoundException, IOException {
--- End diff --

api change out of scope for now


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537921#comment-16537921
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201204232
  
--- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestGetHDFSFileInfo.java
 ---
@@ -656,7 +656,7 @@ public boolean delete(final Path f, final boolean 
recursive) throws IOException
 }
 
 @Override
-public FileStatus[] listStatus(final Path f) throws 
FileNotFoundException, IOException {
--- End diff --

another API change probably out of scope for this pR


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537918#comment-16537918
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201204152
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/http/StandardHttpFlowFileServerProtocol.java
 ---
@@ -68,7 +66,7 @@ public FlowFileCodec getPreNegotiatedCodec() {
 }
 
 @Override
-protected HandshakeProperties doHandshake(Peer peer) throws 
IOException, HandshakeException {
--- End diff --

Ack. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537916#comment-16537916
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201204095
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/http/StandardHttpFlowFileServerProtocol.java
 ---
@@ -68,7 +66,7 @@ public FlowFileCodec getPreNegotiatedCodec() {
 }
 
 @Override
-protected HandshakeProperties doHandshake(Peer peer) throws 
IOException, HandshakeException {
--- End diff --

another spot where we're changing the API/exception handling that we should 
back out for now in my opinion


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537909#comment-16537909
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201202360
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/http/HttpClient.java
 ---
@@ -122,7 +120,7 @@ public PeerDescription getBootstrapPeerDescription() 
throws IOException {
 }
 
 @Override
-public Transaction createTransaction(final TransferDirection 
direction) throws HandshakeException, PortNotRunningException, 
ProtocolException, UnknownPortException, IOException {
--- End diff --

Ack. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537908#comment-16537908
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201202337
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -107,12 +102,9 @@
  *
  * @return a Transaction to use for sending or receiving data, or
  * null if all nodes are penalized.
- * @throws org.apache.nifi.remote.exception.HandshakeException he
- * @throws org.apache.nifi.remote.exception.PortNotRunningException 
pnre
- * @throws IOException ioe
- * @throws org.apache.nifi.remote.exception.UnknownPortException upe
+ * @throws IOException if unable to determine the identifier of the 
port
  */
-Transaction createTransaction(TransferDirection direction) throws 
HandshakeException, PortNotRunningException, ProtocolException, 
UnknownPortException, IOException;
--- End diff --

I agree; will revert this change. I think opening a separate Jira to 
discuss error handling (and enforcing consistent behavior across the 
application) is a good idea. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537907#comment-16537907
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201202035
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/http/HttpClient.java
 ---
@@ -122,7 +120,7 @@ public PeerDescription getBootstrapPeerDescription() 
throws IOException {
 }
 
 @Override
-public Transaction createTransaction(final TransferDirection 
direction) throws HandshakeException, PortNotRunningException, 
ProtocolException, UnknownPortException, IOException {
--- End diff --

same comment as above


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537905#comment-16537905
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r201201974
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -107,12 +102,9 @@
  *
  * @return a Transaction to use for sending or receiving data, or
  * null if all nodes are penalized.
- * @throws org.apache.nifi.remote.exception.HandshakeException he
- * @throws org.apache.nifi.remote.exception.PortNotRunningException 
pnre
- * @throws IOException ioe
- * @throws org.apache.nifi.remote.exception.UnknownPortException upe
+ * @throws IOException if unable to determine the identifier of the 
port
  */
-Transaction createTransaction(TransferDirection direction) throws 
HandshakeException, PortNotRunningException, ProtocolException, 
UnknownPortException, IOException;
--- End diff --

i dont believe we can or want to dump these just yet.  I see they all 
subclass IOException so just throwing IOException would do the job so to speak 
but then again they express a specific type of failure that a caller could 
elect to handle specifically.  We could change this logic later such that the 
cause is of a specific type should the called care but that isn't how it is 
done now.  We should consider such a change as part of some API improvements 
over time but for now I'd suggest we keep it out of this pr.


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535098#comment-16535098
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200708592
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
 ---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File 
workingDirectory, final by
 String name = jarEntry.getName();
 File f = new File(workingDirectory, name);
 if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --

The deprecated method was one line simply calling the method with which I 
replaced it. There is no behavioral change. I imagine the original fix changed 
behavior but did not update all calling references. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535074#comment-16535074
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200703862
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
 ---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File 
workingDirectory, final by
 String name = jarEntry.getName();
 File f = new File(workingDirectory, name);
 if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --

this looks like a change fixing a bug whereby we checked for simple access 
instead of ability to write files.  Can we link this to an existing JIRA or 
expand the scope of NIFI-5376 so we dont lose track of this.


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534865#comment-16534865
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200671407
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/integration/Cluster.java
 ---
@@ -131,7 +130,11 @@ public Node createNode() {
 
 final NiFiProperties nifiProperties = 
NiFiProperties.createBasicNiFiProperties("src/test/resources/conf/nifi.properties",
 addProps);
 
--- End diff --

Thanks for the info @alopresto, I see there there was a utility function of 
some sort.  Why was it removed?  Would putting a builder or factory/default be 
a bad idea?


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533836#comment-16533836
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200402965
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/integration/Cluster.java
 ---
@@ -131,7 +130,11 @@ public Node createNode() {
 
 final NiFiProperties nifiProperties = 
NiFiProperties.createBasicNiFiProperties("src/test/resources/conf/nifi.properties",
 addProps);
 
--- End diff --

I think that should be addressed through a different Jira. The deprecation 
of the initial method was done in NIFI-3116 and followed up by NIFI-4608. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533831#comment-16533831
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200402352
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -112,7 +107,7 @@
  * @throws IOException ioe
  * @throws org.apache.nifi.remote.exception.UnknownPortException upe
--- End diff --

This was an automatic IDE cleanup. Will update Javadoc. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533773#comment-16533773
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200379559
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/integration/Cluster.java
 ---
@@ -131,7 +130,11 @@ public Node createNode() {
 
 final NiFiProperties nifiProperties = 
NiFiProperties.createBasicNiFiProperties("src/test/resources/conf/nifi.properties",
 addProps);
 
--- End diff --

Would there be a way to have an encryptor builder or factory that could 
just build this default method?


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533774#comment-16533774
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200381807
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/PasswordBasedEncryptor.java
 ---
@@ -121,8 +122,8 @@ public void process(final InputStream in, final 
OutputStream out) throws IOExcep
 byte[] salt;
 try {
 // NiFi legacy code determined the salt length based on 
the cipher block size
-if (cipherProvider instanceof NiFiLegacyCipherProvider) {
-salt = ((NiFiLegacyCipherProvider) 
cipherProvider).readSalt(encryptionMethod, in);
+if (cipherProvider instanceof 
org.apache.nifi.security.util.crypto.NiFiLegacyCipherProvider) {
--- End diff --

This pattern is repeated a few times, is there a way to reduce the 
repetition?


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533772#comment-16533772
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200376584
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -112,7 +107,7 @@
  * @throws IOException ioe
  * @throws org.apache.nifi.remote.exception.UnknownPortException upe
--- End diff --

Javadoc should match new throws


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533775#comment-16533775
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2841#discussion_r200379889
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/integration/Node.java
 ---
@@ -137,6 +136,19 @@ private static NodeIdentifier createNodeId() {
 return new NodeIdentifier(UUID.randomUUID().toString(), 
"localhost", createPort(), "localhost", createPort(), "localhost", null, null, 
false, null);
 }
 
+/**
+ * Utility method which accepts {@link NiFiProperties} object but 
calls {@link StringEncryptor#createEncryptor(String, String, String)} with 
extracted properties.
+ *
+ * @param nifiProperties the NiFiProperties object
+ * @return the StringEncryptor
+ */
--- End diff --

Same comment obviously, if this same 5 lines of code are going to be copy 
pasted everywhere, there should be a builder / factory / utility with a default


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533012#comment-16533012
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2841
  
Some were simply suppressed with an annotation if they were in a test class 
that specifically covered a deprecated class. The `NiFiLegacyCipherProvider` is 
an example. Some deprecated methods were switched to their follow-on methods, 
like `IOUtils.toString(Object)` to `IOUtils.toString(Object, Charset)`. The 
`StringEncryptor.createEncryptor()` switch is the only one that stands out to 
me as having logic changed, so that may be a good place to examine. 


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532846#comment-16532846
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2841
  
build with contrib check is fine as well


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532829#comment-16532829
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2841
  
Before :

``` bash
grep -o 'deprecation' ../build.log | wc -l
 795
```

After:

```bash
grep -o 'deprecation' build.log | wc -l
 260
```

There seems to be a mix of deprecation fixes and formatting changes, are 
there any specific changes that warrant attention that you can point out?

Is there some other way to measure or test this that you would recommend?


> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
>  [deprecation] ByteArrayOutputStream in 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532389#comment-16532389
 ] 

ASF GitHub Bot commented on NIFI-5376:
--

GitHub user alopresto opened a pull request:

https://github.com/apache/nifi/pull/2841

NIFI-5376 Removed deprecation warnings

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alopresto/nifi NIFI-5376

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2841


commit bdee6889ee7ed9212cf5d25c7c1c356184f18e60
Author: Andy LoPresto 
Date:   2018-07-04T07:30:32Z

NIFI-5376 Removed deprecation warnings.




> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references 
> to deprecated custom versions of 
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and 
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced 
> with 
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. 
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
>  [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
>  [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been 
> deprecated
> [WARNING] 
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
>  [deprecation] 

[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project

2018-07-04 Thread Andy LoPresto (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532383#comment-16532383
 ] 

Andy LoPresto commented on NIFI-5376:
-

There were quite a few other deprecation warnings I was able to remove. I've 
included a list of the outstanding warnings that require either:

1. more in-depth analysis
1. updates to dependencies/libraries
1. analysis of legacy components

{code}
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[27,31]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[61,38]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[62,40]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[21,31]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[22,46]
 [deprecation] CharSequenceTranslator in 
org.apache.commons.lang3.text.translate has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[30,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[34,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[38,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[42,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[46,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[50,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[54,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[58,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[62,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[66,58]
 [deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING] 
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[70,18]
 [deprecation] CharSequenceTranslator in 
org.apache.commons.lang3.text.translate has been deprecated
[WARNING]