[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578474#comment-16578474 ] ASF GitHub Bot commented on NIFI-5499: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2941 > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578472#comment-16578472 ] ASF GitHub Bot commented on NIFI-5499: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2941 Thanks @scottyaslan! This has been merged to master. > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578470#comment-16578470 ] ASF subversion and git services commented on NIFI-5499: --- Commit 59a79c134f1def152ae17c0d0b4dd7218a0c7f87 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=59a79c1 ] [NIFI-5499] upgrade AngularJS to v1.7.2 [NIFI-5499] update package-lock.json This closes #2941 > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578469#comment-16578469 ] ASF subversion and git services commented on NIFI-5499: --- Commit 59a79c134f1def152ae17c0d0b4dd7218a0c7f87 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=59a79c1 ] [NIFI-5499] upgrade AngularJS to v1.7.2 [NIFI-5499] update package-lock.json This closes #2941 > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574848#comment-16574848 ] ASF GitHub Bot commented on NIFI-5499: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2941 I have updated the package-lock.json file and added a commit to this PR. Nice catch @mcgilman! > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574826#comment-16574826 ] ASF GitHub Bot commented on NIFI-5499: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2941 @scottyaslan I believe we also need to update the package-lock.json that is checked into source control. I noticed the package-lock.json is updated in the front end working directory. > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573339#comment-16573339 ] ASF GitHub Bot commented on NIFI-5499: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2941 Will review... > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5499) Upgrade AngularJS to v1.7.2
[ https://issues.apache.org/jira/browse/NIFI-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573331#comment-16573331 ] ASF GitHub Bot commented on NIFI-5499: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/2941 [NIFI-5499] upgrade AngularJS to v1.7.2 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-5499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2941 commit c452cc4c1ba80b070bad2147439178cbb17b0e32 Author: Scott Aslan Date: 2018-08-08T15:00:21Z [NIFI-5499] upgrade AngularJS to v1.7.2 > Upgrade AngularJS to v1.7.2 > --- > > Key: NIFI-5499 > URL: https://issues.apache.org/jira/browse/NIFI-5499 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 1.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
