[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[ https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686084#comment-16686084 ] ASF GitHub Bot commented on NIFI-5815: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/3169 LGTM +1, merging. Thanks @pvillard31! > PutORC processor "Restricted" still requires access to restricted components > regardless of restriction > -- > > Key: NIFI-5815 > URL: https://issues.apache.org/jira/browse/NIFI-5815 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Matthew Clarke >Assignee: Pierre Villard >Priority: Major > > When the new more granular policies were introduced for the "Access > Restricted Components" access policy, the PutORC processor was missed. It > still requires that users have full access to all restricted components in > order to use this processor. This has side affect of any user who needs to > use this components having access to all components in every sub policy of > restricted-components. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[ https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686085#comment-16686085 ] ASF subversion and git services commented on NIFI-5815: --- Commit 9e7610ac70c389ecfb3a4d389e4e28a41249af2b in nifi's branch refs/heads/master from [~pvillard] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9e7610a ] NIFI-5815 - PutORC processor 'Restricted' still requires access to restricted components regardless of restriction This closes #3169. Signed-off-by: Koji Kawamura > PutORC processor "Restricted" still requires access to restricted components > regardless of restriction > -- > > Key: NIFI-5815 > URL: https://issues.apache.org/jira/browse/NIFI-5815 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Matthew Clarke >Assignee: Pierre Villard >Priority: Major > > When the new more granular policies were introduced for the "Access > Restricted Components" access policy, the PutORC processor was missed. It > still requires that users have full access to all restricted components in > order to use this processor. This has side affect of any user who needs to > use this components having access to all components in every sub policy of > restricted-components. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[ https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686086#comment-16686086 ] ASF GitHub Bot commented on NIFI-5815: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3169 > PutORC processor "Restricted" still requires access to restricted components > regardless of restriction > -- > > Key: NIFI-5815 > URL: https://issues.apache.org/jira/browse/NIFI-5815 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Matthew Clarke >Assignee: Pierre Villard >Priority: Major > > When the new more granular policies were introduced for the "Access > Restricted Components" access policy, the PutORC processor was missed. It > still requires that users have full access to all restricted components in > order to use this processor. This has side affect of any user who needs to > use this components having access to all components in every sub policy of > restricted-components. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[
https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684878#comment-16684878
]
ASF GitHub Bot commented on NIFI-5815:
--
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3169#discussion_r232937372
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/orc/PutORC.java
---
@@ -63,7 +65,11 @@
+ "the path is the directory that contains this ORC file
on HDFS. For example, this processor can send flow files downstream to
ReplaceText to set the content "
+ "to this DDL (plus the LOCATION clause as described),
then to PutHiveQL processor to create the table if it doesn't exist.")
})
-@Restricted("Provides operator the ability to write to any file that NiFi
has access to in HDFS or the local filesystem.")
+@Restricted(restrictions = {
+@Restriction(
+requiredPermission = RequiredPermission.WRITE_FILESYSTEM,
+explanation = "Provides operator the ability to delete any
file that NiFi has access to in HDFS or the local filesystem.")
--- End diff --
copy/paste stupid error... thanks @ijokarumawak !
> PutORC processor "Restricted" still requires access to restricted components
> regardless of restriction
> --
>
> Key: NIFI-5815
> URL: https://issues.apache.org/jira/browse/NIFI-5815
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1
>Reporter: Matthew Clarke
>Assignee: Pierre Villard
>Priority: Major
>
> When the new more granular policies were introduced for the "Access
> Restricted Components" access policy, the PutORC processor was missed. It
> still requires that users have full access to all restricted components in
> order to use this processor. This has side affect of any user who needs to
> use this components having access to all components in every sub policy of
> restricted-components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[
https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684716#comment-16684716
]
ASF GitHub Bot commented on NIFI-5815:
--
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3169#discussion_r232895405
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/orc/PutORC.java
---
@@ -63,7 +65,11 @@
+ "the path is the directory that contains this ORC file
on HDFS. For example, this processor can send flow files downstream to
ReplaceText to set the content "
+ "to this DDL (plus the LOCATION clause as described),
then to PutHiveQL processor to create the table if it doesn't exist.")
})
-@Restricted("Provides operator the ability to write to any file that NiFi
has access to in HDFS or the local filesystem.")
+@Restricted(restrictions = {
+@Restriction(
+requiredPermission = RequiredPermission.WRITE_FILESYSTEM,
+explanation = "Provides operator the ability to delete any
file that NiFi has access to in HDFS or the local filesystem.")
--- End diff --
Is the term 'delete' correct?
> PutORC processor "Restricted" still requires access to restricted components
> regardless of restriction
> --
>
> Key: NIFI-5815
> URL: https://issues.apache.org/jira/browse/NIFI-5815
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1
>Reporter: Matthew Clarke
>Assignee: Pierre Villard
>Priority: Major
>
> When the new more granular policies were introduced for the "Access
> Restricted Components" access policy, the PutORC processor was missed. It
> still requires that users have full access to all restricted components in
> order to use this processor. This has side affect of any user who needs to
> use this components having access to all components in every sub policy of
> restricted-components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5815) PutORC processor "Restricted" still requires access to restricted components regardless of restriction
[ https://issues.apache.org/jira/browse/NIFI-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684274#comment-16684274 ] ASF GitHub Bot commented on NIFI-5815: -- GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/3169 NIFI-5815 - PutORC processor 'Restricted' still requires access to re… …stricted components regardless of restriction Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-5815 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3169 commit 1f211c37d63ef50dbfecb3596306d118cc3f8865 Author: Pierre Villard Date: 2018-11-12T19:22:03Z NIFI-5815 - PutORC processor 'Restricted' still requires access to restricted components regardless of restriction > PutORC processor "Restricted" still requires access to restricted components > regardless of restriction > -- > > Key: NIFI-5815 > URL: https://issues.apache.org/jira/browse/NIFI-5815 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Matthew Clarke >Assignee: Pierre Villard >Priority: Major > > When the new more granular policies were introduced for the "Access > Restricted Components" access policy, the PutORC processor was missed. It > still requires that users have full access to all restricted components in > order to use this processor. This has side affect of any user who needs to > use this components having access to all components in every sub policy of > restricted-components. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
