[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706217#comment-16706217 ] ASF subversion and git services commented on NIFI-5850: --- Commit 7df537aecaf48b533da5cb6a2e1c26979b82e965 in nifi's branch refs/heads/master from zenfenan [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=7df537a ] NIFI-5850: Replaced custom AWS regions enum with the one from AWS Java SDK Signed-off-by: Pierre Villard This closes #3190. This closes #3187. > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706219#comment-16706219 ] ASF GitHub Bot commented on NIFI-5850: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3190 > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706218#comment-16706218 ] ASF GitHub Bot commented on NIFI-5850: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3190 Thanks @zenfenan - merged to master. > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706126#comment-16706126 ] ASF GitHub Bot commented on NIFI-5850: -- Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3190 > > > @zenfenan agree that bumping the version just before a release is a good idea (and we should try to do it for multiple bundles) but I still suggest to bump the version in this PR so that we can also close #3187 and allow the community to use NiFi or the AWS NAR (built from master) with the new region. @pvillard31 Fair point. Updated the version to the latest stable one and confirmed the new region comes up. > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704508#comment-16704508 ] ASF GitHub Bot commented on NIFI-5850: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3190 @zenfenan agree that bumping the version just before a release is a good idea (and we should try to do it for multiple bundles) but I still suggest to bump the version in this PR so that we can also close #3187 and allow the community to use NiFi or the AWS NAR (built from master) with the new region. > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5850) Replace custom AWS Region Enums with AWS SDK Region enums
[ https://issues.apache.org/jira/browse/NIFI-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702919#comment-16702919 ] ASF GitHub Bot commented on NIFI-5850: -- GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/3190 NIFI-5850: Replaced custom AWS regions enum with the one from AWS Jav… …a SDK Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zenfenan/nifi NIFI-5850 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3190 commit 0688425f971d14e258a4955cd2d2ed7046c28466 Author: zenfenan Date: 2018-11-29T09:29:23Z NIFI-5850: Replaced custom AWS regions enum with the one from AWS Java SDK > Replace custom AWS Region Enums with AWS SDK Region enums > - > > Key: NIFI-5850 > URL: https://issues.apache.org/jira/browse/NIFI-5850 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.7.1 >Reporter: Sivaprasanna Sethuraman >Assignee: Sivaprasanna Sethuraman >Priority: Major > > With NIFI-5129, we introduced a custom Enum for displaying readable AWS > regions. This readable names have now been added to the official AWS Java SDK > so ideally this custom AWS Regions enum have to removed and the region names > should be read from the AWS SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
