[jira] [Commented] (NIFI-5868) Instrument robust timing information for ListFile
[ https://issues.apache.org/jira/browse/NIFI-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710424#comment-16710424 ] ASF GitHub Bot commented on NIFI-5868: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3202 > Instrument robust timing information for ListFile > - > > Key: NIFI-5868 > URL: https://issues.apache.org/jira/browse/NIFI-5868 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > ListFile is used in many different contexts. We often see users with a > specific use case, though, which is to run ListFile on a Primary Node in a > cluster, in order to obtain a file listing of an NFS-mounted share. This > works well in most cases, but whenever problems do arise, it is very > difficult to understand what the problem is. It would be very helpful to have > information such as: > * Is there a problem accessing a specific file on the NFS mount? > * Is there a problem obtaining a listing from the NFS mount? > * Is progress being made at all? > * How long is a listing taking right now? > * How long does a listing typically take? > * Is this problem related to NiFi or to the operating system / > infrastructure? > It would be helpful to track information about each disk access that is > occurring, as well as the overall listing progress and issue warnings if we > see clear problems arise. We can do this by timing how long each disk access > takes, what file was being accessed, and what operating was being performed. > If we capture this data in a rolling window, we can assess the data to > determine if the listing is now taking longer than it did previously and > alert to this fact. Or alert if performing a specific disk operation is > taking a long time. > Gathering this information will likely be fairly heap intensive, so it is > best to make the functionality optional. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5868) Instrument robust timing information for ListFile
[ https://issues.apache.org/jira/browse/NIFI-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710423#comment-16710423 ] ASF subversion and git services commented on NIFI-5868: --- Commit 72ea93a657cd673bfc40ef74e172f5efb950e95d in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=72ea93a ] NIFI-5868: Added instrumentation around ListFile such that all disk accesses are timed and any unusually long listing times or disk access operations can be logged. Additionally, information is logged at a debug level including significant amounts of troubleshooting information when configured to do so This closes #3202. Signed-off-by: Bryan Bende > Instrument robust timing information for ListFile > - > > Key: NIFI-5868 > URL: https://issues.apache.org/jira/browse/NIFI-5868 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > ListFile is used in many different contexts. We often see users with a > specific use case, though, which is to run ListFile on a Primary Node in a > cluster, in order to obtain a file listing of an NFS-mounted share. This > works well in most cases, but whenever problems do arise, it is very > difficult to understand what the problem is. It would be very helpful to have > information such as: > * Is there a problem accessing a specific file on the NFS mount? > * Is there a problem obtaining a listing from the NFS mount? > * Is progress being made at all? > * How long is a listing taking right now? > * How long does a listing typically take? > * Is this problem related to NiFi or to the operating system / > infrastructure? > It would be helpful to track information about each disk access that is > occurring, as well as the overall listing progress and issue warnings if we > see clear problems arise. We can do this by timing how long each disk access > takes, what file was being accessed, and what operating was being performed. > If we capture this data in a rolling window, we can assess the data to > determine if the listing is now taking longer than it did previously and > alert to this fact. Or alert if performing a specific disk operation is > taking a long time. > Gathering this information will likely be fairly heap intensive, so it is > best to make the functionality optional. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5868) Instrument robust timing information for ListFile
[ https://issues.apache.org/jira/browse/NIFI-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710417#comment-16710417 ] ASF GitHub Bot commented on NIFI-5868: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/3202 Code looks good, verified I can see the debug logging when enabled, going to merge > Instrument robust timing information for ListFile > - > > Key: NIFI-5868 > URL: https://issues.apache.org/jira/browse/NIFI-5868 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > ListFile is used in many different contexts. We often see users with a > specific use case, though, which is to run ListFile on a Primary Node in a > cluster, in order to obtain a file listing of an NFS-mounted share. This > works well in most cases, but whenever problems do arise, it is very > difficult to understand what the problem is. It would be very helpful to have > information such as: > * Is there a problem accessing a specific file on the NFS mount? > * Is there a problem obtaining a listing from the NFS mount? > * Is progress being made at all? > * How long is a listing taking right now? > * How long does a listing typically take? > * Is this problem related to NiFi or to the operating system / > infrastructure? > It would be helpful to track information about each disk access that is > occurring, as well as the overall listing progress and issue warnings if we > see clear problems arise. We can do this by timing how long each disk access > takes, what file was being accessed, and what operating was being performed. > If we capture this data in a rolling window, we can assess the data to > determine if the listing is now taking longer than it did previously and > alert to this fact. Or alert if performing a specific disk operation is > taking a long time. > Gathering this information will likely be fairly heap intensive, so it is > best to make the functionality optional. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5868) Instrument robust timing information for ListFile
[ https://issues.apache.org/jira/browse/NIFI-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710183#comment-16710183 ] ASF GitHub Bot commented on NIFI-5868: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/3202 Will review... > Instrument robust timing information for ListFile > - > > Key: NIFI-5868 > URL: https://issues.apache.org/jira/browse/NIFI-5868 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > ListFile is used in many different contexts. We often see users with a > specific use case, though, which is to run ListFile on a Primary Node in a > cluster, in order to obtain a file listing of an NFS-mounted share. This > works well in most cases, but whenever problems do arise, it is very > difficult to understand what the problem is. It would be very helpful to have > information such as: > * Is there a problem accessing a specific file on the NFS mount? > * Is there a problem obtaining a listing from the NFS mount? > * Is progress being made at all? > * How long is a listing taking right now? > * How long does a listing typically take? > * Is this problem related to NiFi or to the operating system / > infrastructure? > It would be helpful to track information about each disk access that is > occurring, as well as the overall listing progress and issue warnings if we > see clear problems arise. We can do this by timing how long each disk access > takes, what file was being accessed, and what operating was being performed. > If we capture this data in a rolling window, we can assess the data to > determine if the listing is now taking longer than it did previously and > alert to this fact. Or alert if performing a specific disk operation is > taking a long time. > Gathering this information will likely be fairly heap intensive, so it is > best to make the functionality optional. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5868) Instrument robust timing information for ListFile
[ https://issues.apache.org/jira/browse/NIFI-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710162#comment-16710162 ] ASF GitHub Bot commented on NIFI-5868: -- GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3202 NIFI-5868: Added instrumentation around ListFile such that all disk a… …ccesses are timed and any unusually long listing times or disk access operations can be logged. Additionally, information is logged at a debug level including significant amounts of troubleshooting information when configured to do so Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi nIFI-5868 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3202 commit 49cc37d807c52701fcce7cae0c1a2265ead0 Author: Mark Payne Date: 2018-12-05T14:37:20Z NIFI-5868: Added instrumentation around ListFile such that all disk accesses are timed and any unusually long listing times or disk access operations can be logged. Additionally, information is logged at a debug level including significant amounts of troubleshooting information when configured to do so > Instrument robust timing information for ListFile > - > > Key: NIFI-5868 > URL: https://issues.apache.org/jira/browse/NIFI-5868 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > ListFile is used in many different contexts. We often see users with a > specific use case, though, which is to run ListFile on a Primary Node in a > cluster, in order to obtain a file listing of an NFS-mounted share. This > works well in most cases, but whenever problems do arise, it is very > difficult to understand what the problem is. It would be very helpful to have > information such as: > * Is there a problem accessing a specific file on the NFS mount? > * Is there a problem obtaining a listing from the NFS mount? > * Is progress being made at all? > * How long is a listing taking right now? > * How long does a listing typically take? > * Is this problem related to NiFi or to the operating system / > infrastructure? > It would be helpful to track information about each disk access that is > occurring, as well as the overall listing progress and issue warnings if we > see clear problems arise. We can do this by timing how long each disk access > takes, what file was being accessed, and what operating was being performed. > If we capture this data in a rolling window, we can assess the data to > determine if the listing is now taking longer than it did previously and > alert to this fact. Or alert if performing a specific disk operation is >
