[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027217#comment-17027217 ] Kevin Doran commented on NIFI-7080: --- Merged to master as well as the support/nifi-1.11.x branch > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.12.0, 1.11.1 > > Time Spent: 50m > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027216#comment-17027216 ] ASF subversion and git services commented on NIFI-7080: --- Commit e62841f6432d618ba9e07d111a9d4a7cdebde9a2 in nifi's branch refs/heads/support/nifi-1.11.x from Aldrin Piri [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e62841f ] NIFI-7080 * Ensure script files in Docker builds are treated as executable. * Updating git permissions to reflect executable for both secure.sh scripts. Signed-off-by: Aldrin Piri Signed-off-by: Kevin Doran This closes #4027. Signed-off-by: Kevin Doran > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.12.0, 1.11.1 > > Time Spent: 50m > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027213#comment-17027213 ] ASF subversion and git services commented on NIFI-7080: --- Commit c8af8eaa766407cb137d0074f824981b5bc07d93 in nifi's branch refs/heads/master from Aldrin Piri [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c8af8ea ] NIFI-7080 * Ensure script files in Docker builds are treated as executable. * Updating git permissions to reflect executable for both secure.sh scripts. Signed-off-by: Aldrin Piri Signed-off-by: Kevin Doran This closes #4027. Signed-off-by: Kevin Doran > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.12.0, 1.11.1 > > Time Spent: 50m > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027094#comment-17027094 ] Joe Witt commented on NIFI-7080: will pull into 1.11.1. but also set fix version 1.12.0 as it will go into both > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.12.0, 1.11.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027048#comment-17027048 ] Aldrin Piri commented on NIFI-7080: --- [~Absolutesantaja] Certainly. By migrating the check to the Dockerfile we ensure a consistent environment to hopefully eradicate those differences and address them in one place. > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.11.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027047#comment-17027047 ] Shawn Weeks commented on NIFI-7080: --- It may depend on what you're building on as well. I'm on a mac and I regularly build the docker release and use it without any of those issues after I fixed the local permissions. Doing the build on Windows might cause all sorts of permission issues. > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.11.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027037#comment-17027037 ] Aldrin Piri commented on NIFI-7080: --- [~Absolutesantaja] Didn't see that one however I don't have confidence that actually solves the problem described by Kevin. I suspect that the plugin(s) used to zip up the source artifact lose permissions of the zip file, and as a result, can leave things in the state where we are unable to run. While changing the permissions _should_ be sufficient, this ticket and approach ensures they will be correct. > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.11.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027033#comment-17027033 ] Shawn Weeks commented on NIFI-7080: --- Isn't this a duplicate of NIFI-7057? I never got around to making the actual changes though so this one can go instead. I fixed the permissions in git instead of changing the docker build though. > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.11.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026986#comment-17026986 ] Aldrin Piri commented on NIFI-7080: --- Hey [~kdoran], Fixed this up. Would be great if we could land it in time for the next RC. > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > Fix For: 1.11.1 > > Time Spent: 10m > Remaining Estimate: 0h > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7080) Building from source release leads to non-functioning docker image
[ https://issues.apache.org/jira/browse/NIFI-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026872#comment-17026872 ] Kevin Doran commented on NIFI-7080: --- Thanks [~aldrin], I can review when you have a patch ready > Building from source release leads to non-functioning docker image > -- > > Key: NIFI-7080 > URL: https://issues.apache.org/jira/browse/NIFI-7080 > Project: Apache NiFi > Issue Type: Bug > Components: Docker, Tools and Build >Affects Versions: 1.11.0 >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Minor > > From the 1.11 release vote [~kdoran] reported an issue with the Docker build > working via Maven. > (https://lists.apache.org/thread.html/r6d7c3298249511d60e386f7aa3107cdf225d48a70ead1251780f0cb1%40%3Cdev.nifi.apache.org%3E). > This is the result of our zip source which does not preserve permissions and > makes it such that the associated script files are not executable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
