[jira] [Commented] (NIFI-8710) StandardProvenanceReporter - receive() incorrectly overiding details parameter
[ https://issues.apache.org/jira/browse/NIFI-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707984#comment-17707984 ] Nissim Shiman commented on NIFI-8710: - Thank you [~mattyb149] for looping back to this to get into 2.0. I appreciate it. > StandardProvenanceReporter - receive() incorrectly overiding details parameter > -- > > Key: NIFI-8710 > URL: https://issues.apache.org/jira/browse/NIFI-8710 > Project: Apache NiFi > Issue Type: Bug >Reporter: Nissim Shiman >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The ProvenanceReporter interface has receive() with details as the third > parameter [1]: > void receive(FlowFile flowFile, String transitUri, String details, long > transmissionMillis); > StandardProvenanceReporter.java implements this with > sourceSystemFlowFileIdentifier as the third parameter [2]: > public void receive(final FlowFile flowFile, final String transitUri, final > String sourceSystemFlowFileIdentifier, final long transmissionMillis) > This implementation in StandardProvenanceReporter should be modified to > reflect the interface. > > [1] > [https://github.com/apache/nifi/blob/main/nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceReporter.java#L100] > [2] > [https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java#L159] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-8710) StandardProvenanceReporter - receive() incorrectly overiding details parameter
[ https://issues.apache.org/jira/browse/NIFI-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707419#comment-17707419 ] ASF subversion and git services commented on NIFI-8710: --- Commit 59eebb99065adc54343f9186896969aabeb45a02 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=59eebb9906 ] NIFI-8710: Pass details instead of source ID for Provenance per the interface doc This closes #5224 Signed-off-by: Nandor Soma Abonyi > StandardProvenanceReporter - receive() incorrectly overiding details parameter > -- > > Key: NIFI-8710 > URL: https://issues.apache.org/jira/browse/NIFI-8710 > Project: Apache NiFi > Issue Type: Bug >Reporter: Nissim Shiman >Assignee: Matt Burgess >Priority: Major > Fix For: 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > The ProvenanceReporter interface has receive() with details as the third > parameter [1]: > void receive(FlowFile flowFile, String transitUri, String details, long > transmissionMillis); > StandardProvenanceReporter.java implements this with > sourceSystemFlowFileIdentifier as the third parameter [2]: > public void receive(final FlowFile flowFile, final String transitUri, final > String sourceSystemFlowFileIdentifier, final long transmissionMillis) > This implementation in StandardProvenanceReporter should be modified to > reflect the interface. > > [1] > [https://github.com/apache/nifi/blob/main/nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceReporter.java#L100] > [2] > [https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java#L159] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-8710) StandardProvenanceReporter - receive() incorrectly overiding details parameter
[ https://issues.apache.org/jira/browse/NIFI-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364399#comment-17364399 ] Nissim Shiman commented on NIFI-8710: - This currently is affect the provenance in HandleHttpRequest's RECEIVE where incorrect information is showing up for Source FlowFile Id > StandardProvenanceReporter - receive() incorrectly overiding details parameter > -- > > Key: NIFI-8710 > URL: https://issues.apache.org/jira/browse/NIFI-8710 > Project: Apache NiFi > Issue Type: Bug >Reporter: Nissim Shiman >Priority: Major > > The ProvenanceReporter interface has receive() with details as the third > parameter [1]: > void receive(FlowFile flowFile, String transitUri, String details, long > transmissionMillis); > StandardProvenanceReporter.java implements this with > sourceSystemFlowFileIdentifier as the third parameter [2]: > public void receive(final FlowFile flowFile, final String transitUri, final > String sourceSystemFlowFileIdentifier, final long transmissionMillis) > This implementation in StandardProvenanceReporter should be modified to > reflect the interface. > > [1] > [https://github.com/apache/nifi/blob/main/nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceReporter.java#L100] > [2] > [https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java#L159] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
