[jira] [Commented] (NIFI-929) Ability to generate a 'true' pid file

2016-07-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384718#comment-15384718
 ] 

ASF GitHub Bot commented on NIFI-929:
-

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/677


> Ability to generate a 'true' pid file
> -
>
> Key: NIFI-929
> URL: https://issues.apache.org/jira/browse/NIFI-929
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Configuration
>Affects Versions: 0.3.0
>Reporter: Ali Bajwa
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.0.0
>
>
> The nifi pid file does not seem to be a true pid file (it has other info as 
> well). 
> For integration with monitoring tools like Ambari it would be nice to have a 
> true pid file (containing only the pid) created as well (in line with other 
> Hadoop components). This is coming from the Ambari service I put together: I 
> had to parse out the pid from Nifi pidfile and maintain another one



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-929) Ability to generate a 'true' pid file

2016-07-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384715#comment-15384715
 ] 

ASF GitHub Bot commented on NIFI-929:
-

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/677
  
+1

Visually verified code, contrib check build and verified that when created, 
the PID file has read access by group and others (and r/w by owner). Thanks 
@bbende, I will merge it in.


> Ability to generate a 'true' pid file
> -
>
> Key: NIFI-929
> URL: https://issues.apache.org/jira/browse/NIFI-929
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Configuration
>Affects Versions: 0.3.0
>Reporter: Ali Bajwa
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.0.0
>
>
> The nifi pid file does not seem to be a true pid file (it has other info as 
> well). 
> For integration with monitoring tools like Ambari it would be nice to have a 
> true pid file (containing only the pid) created as well (in line with other 
> Hadoop components). This is coming from the Ambari service I put together: I 
> had to parse out the pid from Nifi pidfile and maintain another one



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-929) Ability to generate a 'true' pid file

2016-07-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384545#comment-15384545
 ] 

ASF GitHub Bot commented on NIFI-929:
-

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/677

NIFI-929 Changing permissions of nifi.pid to be readable by all, writ…

…able only by user

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-929-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit b884c57d2d139dc083129199e67248bfbf439a6a
Author: Bryan Bende 
Date:   2016-07-19T17:23:55Z

NIFI-929 Changing permissions of nifi.pid to be readable by all, writable 
only by user




> Ability to generate a 'true' pid file
> -
>
> Key: NIFI-929
> URL: https://issues.apache.org/jira/browse/NIFI-929
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Configuration
>Affects Versions: 0.3.0
>Reporter: Ali Bajwa
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.0.0
>
>
> The nifi pid file does not seem to be a true pid file (it has other info as 
> well). 
> For integration with monitoring tools like Ambari it would be nice to have a 
> true pid file (containing only the pid) created as well (in line with other 
> Hadoop components). This is coming from the Ambari service I put together: I 
> had to parse out the pid from Nifi pidfile and maintain another one



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)