[jira] [Created] (NIFI-5086) Many usages of AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch aren't closed properly

[Joseph Percivall (JIRA)]

Joseph Percivall created NIFI-5086:
--------------------------------------

             Summary: Many usages of 
AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch aren't closed 
properly
                 Key: NIFI-5086
                 URL: https://issues.apache.org/jira/browse/NIFI-5086
             Project: Apache NiFi
          Issue Type: Bug
            Reporter: Joseph Percivall


Similar to NIFI-5085, all OkHttp responses must be closed[1]. 
"AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch"  returns the 
actual OkHttp response. All implementing processors should properly close this. 
Processors that need to be updated:
 * FetchElasticsearchHttp[2]
 * PutElasticsearchHttp[3]
 * PutElasticsearchHttpRecord[4]
 * QueryElasticsearchHttp[5]
 * ScrollElasticsearchHtt[6][7]

[1] [https://github.com/square/okhttp/issues/2311] 
[2] 
[https://github.com/apache/nifi/blob/9736cb9d338b611ff3a096d97fd439cf8b8bbac3/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearchHttp.java#L223
][3][https://github.com/apache/nifi/blob/e916594b69601bce58e045ba8ae2acf6af66eb46/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java#L337]
[4] 
[https://github.com/apache/nifi/blob/6b34d3bea9a1fd0923024018d73c3c0b0a807a67/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java#L400]
[5] 
[https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java#L287
][6] 
[https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ScrollElasticsearchHttp.java#L256
][7][https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ScrollElasticsearchHttp.java#L269]




 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)