[GitHub] nifi pull request #1278: NIFI-2886 Fixed the lifecycle delay

[olegz]

Github user olegz closed the pull request at:

https://github.com/apache/nifi/pull/1278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2886) Framework doesn't release thread if processor administratively yields

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088586#comment-16088586
 ] 

ASF GitHub Bot commented on NIFI-2886:
--

Github user olegz closed the pull request at:

https://github.com/apache/nifi/pull/1278


> Framework doesn't release thread if processor administratively yields
> -
>
> Key: NIFI-2886
> URL: https://issues.apache.org/jira/browse/NIFI-2886
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: David A. Wynne
>Assignee: Oleg Zhurakousky
>
> If a processor yields due to a exception from onScheduled it doesn't 
> immediately release the thread back to the pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #1280: NIFI-3109 Initial refactoring of TimerDrivenSchedul...

[olegz]

Github user olegz closed the pull request at:

https://github.com/apache/nifi/pull/1280


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3109) Refactor TimerDrivenSchedulingAgent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088587#comment-16088587
 ] 

ASF GitHub Bot commented on NIFI-3109:
--

Github user olegz closed the pull request at:

https://github.com/apache/nifi/pull/1280


> Refactor TimerDrivenSchedulingAgent
> ---
>
> Key: NIFI-3109
> URL: https://issues.apache.org/jira/browse/NIFI-3109
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core Framework
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>Priority: Minor
>
> While working on determining reasons for bug described in NIFI-2886, I've 
> noticed an opportunity for some refactoring which in a way is significant as 
> it greatly reduces the code base, eliminates unnecessary synchronization as 
> well as provides for better reusability of object instances. (i.e., Currently 
> for each task an instance of ContinuallyRunProcessorTask is created while the 
> same instance could be reused for all tasks, and more)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1888: NIFI-4015 NIFI-3999 Fix DeleteSQS Issues

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1888
  
@brosander I added an update to keep the existing attribute name.  Please 
let me know if/when we need a squash and rebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4015) DeleteSQS Throws Exception Deleting Message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088697#comment-16088697
 ] 

ASF GitHub Bot commented on NIFI-4015:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1888
  
@brosander I added an update to keep the existing attribute name.  Please 
let me know if/when we need a squash and rebase.


> DeleteSQS Throws Exception Deleting Message
> ---
>
> Key: NIFI-4015
> URL: https://issues.apache.org/jira/browse/NIFI-4015
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
>
> While attempting to delete a message from an SQS queue, DeleteSQS throws the 
> following exception:
> {quote}
> DeleteSQS[id=6197f269-015c-1000-9317-818c01162722] Failed to delete 1 objects 
> from SQS due to com.amazonaws.services.sqs.model.AmazonSQSException: The 
> request must contain the parameter DeleteMessageBatchRequestEntry.1.Id. 
> (Service: AmazonSQS; Status Code: 400; Error Code: MissingParameter; Request 
> ID: eea76d96-a07d-5406-9838-3c3f26575223): 
> com.amazonaws.services.sqs.model.AmazonSQSException: The request must contain 
> the parameter DeleteMessageBatchRequestEntry.1.Id. (Service: AmazonSQS; 
> Status Code: 400; Error Code: MissingParameter; Request ID: 
> eea76d96-a07d-5406-9838-3c3f26575223)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1972: NIFI-4147 Class org.apache.nifi.bootstrap.RunNiFi is not d...

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1972
  
@peter-gergely-horvath Thank you for submitting this PR, improving 
testability is always welcome.  I will be happy to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4147) Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088711#comment-16088711
 ] 

ASF GitHub Bot commented on NIFI-4147:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1972
  
@peter-gergely-horvath Thank you for submitting this PR, improving 
testability is always welcome.  I will be happy to review.


> Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in 
> mind
> --
>
> Key: NIFI-4147
> URL: https://issues.apache.org/jira/browse/NIFI-4147
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Peter Horvath
>
> Class org.apache.nifi.bootstrap.RunNiFi was not designed with extensibility 
> in mind. This class is used to bootstrap the runtime; the current 
> implementation does not support extending the class with different behaviour, 
> that would be essential to bootstrap the engine within an integration test. 
> This class should be changed so that it can be easily subclassed, allowing it 
> to be later extended within an integration test runner:
> * The verbose parameter within the RunNiFi constructor is not used: eliminate 
> it
> * getBootstrapConfFile() is static, which means it cannot easily be 
> overridden in a test stub: replace with an instance method, which can be 
> overridden
> * Methods getPidFile, getStatusFile, getLockFile, getStatusFile are package 
> protected, preventing these methods to be stubbed for an integration test: 
> make them protected so that they can be overridden from a subclass (allowing 
> an integration test runner to override default behaviour in a test run)
> *Please note these changes are baby-steps towards the implementation of a 
> NiFi integration test harness.*



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #1972: NIFI-4147 Class org.apache.nifi.bootstrap.RunNiFi i...

[jvwing]

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1972#discussion_r127591766
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -135,8 +135,8 @@
 private volatile Set loggingFutures = new HashSet<>(2);
 private final NotificationServiceManager serviceManager;
 
-public RunNiFi(final File bootstrapConfigFile, final boolean verbose) 
throws IOException {
--- End diff --

I do not recommend changing the signature of a public constructor.  
Although there is no other use of the RunNiFi constructor in the NiFi project, 
someone might be using it in their own code, elsewhere.  Is this essential to 
your testability goal?  It does look like we're not sure about if/how to use 
`verbose`, but that might be a different ticket.  If it is essential, how about 
a second constructor?

With respect to the `File bootstrapConfigFile` argument, I understand there 
is a difference because you make `getBootstrapConfigFile()` an instance method, 
so RunNiFi will not separately call `getBootstrapConfigFile()` first.  What if 
we allowed that as a nullable argument, where it is accepted if given, and 
looked it up if `null` is passed in?  Again, I think this would preserve 
compatibility with possible existing callers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4147) Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088715#comment-16088715
 ] 

ASF GitHub Bot commented on NIFI-4147:
--

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1972#discussion_r127591766
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -135,8 +135,8 @@
 private volatile Set loggingFutures = new HashSet<>(2);
 private final NotificationServiceManager serviceManager;
 
-public RunNiFi(final File bootstrapConfigFile, final boolean verbose) 
throws IOException {
--- End diff --

I do not recommend changing the signature of a public constructor.  
Although there is no other use of the RunNiFi constructor in the NiFi project, 
someone might be using it in their own code, elsewhere.  Is this essential to 
your testability goal?  It does look like we're not sure about if/how to use 
`verbose`, but that might be a different ticket.  If it is essential, how about 
a second constructor?

With respect to the `File bootstrapConfigFile` argument, I understand there 
is a difference because you make `getBootstrapConfigFile()` an instance method, 
so RunNiFi will not separately call `getBootstrapConfigFile()` first.  What if 
we allowed that as a nullable argument, where it is accepted if given, and 
looked it up if `null` is passed in?  Again, I think this would preserve 
compatibility with possible existing callers.


> Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in 
> mind
> --
>
> Key: NIFI-4147
> URL: https://issues.apache.org/jira/browse/NIFI-4147
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Peter Horvath
>
> Class org.apache.nifi.bootstrap.RunNiFi was not designed with extensibility 
> in mind. This class is used to bootstrap the runtime; the current 
> implementation does not support extending the class with different behaviour, 
> that would be essential to bootstrap the engine within an integration test. 
> This class should be changed so that it can be easily subclassed, allowing it 
> to be later extended within an integration test runner:
> * The verbose parameter within the RunNiFi constructor is not used: eliminate 
> it
> * getBootstrapConfFile() is static, which means it cannot easily be 
> overridden in a test stub: replace with an instance method, which can be 
> overridden
> * Methods getPidFile, getStatusFile, getLockFile, getStatusFile are package 
> protected, preventing these methods to be stubbed for an integration test: 
> make them protected so that they can be overridden from a subclass (allowing 
> an integration test runner to override default behaviour in a test run)
> *Please note these changes are baby-steps towards the implementation of a 
> NiFi integration test harness.*



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

[yjhyjhyjh0]

Github user yjhyjhyjh0 commented on the issue:

https://github.com/apache/nifi/pull/1983
  
Thanks for the review and feedback.
I’ve add your enhancement of handing time precision at milliseconds in 
PutSQL.
Also I'm very willing to add a unit test for it.

However after some experiment, I figure out Derby DB has same behavior as 
MySQL in Time type just like what you mentioned.
I’ve tested with derby, MySQL and PostgreSQL. 
Only PostgreSQL will handle millisecond in Time type properly.

About the experiment, it store Time type well with value "00:01:01.111" in 
PutSQL.
But once client fetch via jdbc of Derby. 
It truncate the milliseconds. 
(actually has different long value in client side) (java jdbc client and IJ 
tool of derby)
So even with correct format to parse, the result in client side is 
"00:01:01.000”.

Thus, I only update document to remind this situation instead of providing 
a unit test for this format.
Please let me know if there is any problem.
Thanks for your patient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation

[benqiu2016]

Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/114
  
@phrocker @kevdoran use lock, extract token code, set default port. we need 
to support /nifi-api/controller which is common to 1.x and 0.x. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (NIFI-4188) Create RethinkDB get processor

[Mans Singh (JIRA)]

Mans Singh created NIFI-4188:


 Summary: Create RethinkDB get processor
 Key: NIFI-4188
 URL: https://issues.apache.org/jira/browse/NIFI-4188
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Extensions
Affects Versions: 1.3.0
 Environment: All
Reporter: Mans Singh
Assignee: Mans Singh
Priority: Minor
 Fix For: 1.4.0


Create processor for getting documents by id from RethinkDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4081) GrokReader - add the option to keep raw message in a dedicated field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088802#comment-16088802
 ] 

ASF GitHub Bot commented on NIFI-4081:
--

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1921
  
@pvillard31 I accept it is a bit of bit picking but is there any chance we 
call it _raw? IIRC this is the name we used on ParseCEF. Naming conventions 
make user experience smoother 


> GrokReader - add the option to keep raw message in a dedicated field
> 
>
> Key: NIFI-4081
> URL: https://issues.apache.org/jira/browse/NIFI-4081
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> In some use cases, it can be useful to keep the raw message in the record. I 
> propose to add a parameter to the GrokReader allowing the user to store in 
> the field {{rawMessage}} the raw content of the record (stack trace included 
> if any).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (NIFI-4189) NiFi ignores logback rotation settings

[Andre F de Miranda (JIRA)]

Andre F de Miranda created NIFI-4189:


 Summary: NiFi ignores logback rotation settings
 Key: NIFI-4189
 URL: https://issues.apache.org/jira/browse/NIFI-4189
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Andre F de Miranda






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-2962) Default conf/logback comment for maxHistory is misleading and incorrect

[Andre F de Miranda (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088805#comment-16088805
 ] 

Andre F de Miranda commented on NIFI-2962:
--

Just as a comment on this.

The logback config is quite explicit on this:


bq. The optional maxHistory property controls the maximum number of archive 
files to keep, asynchronously deleting older files. For example, if you specify 
monthly rollover, and set maxHistory to 6, then 6 months worth of archives 
files will be kept with files older than 6 months deleted. Note as old archived 
log files are removed, any folders which were created for the purpose of log 
file archiving will be removed as appropriate.

> Default conf/logback comment for maxHistory is misleading and incorrect
> ---
>
> Key: NIFI-2962
> URL: https://issues.apache.org/jira/browse/NIFI-2962
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Minor
>
> Joe Gresock in dev list note on Oct 27, 2016
> Ahh, that would explain it!  Maybe we can change the comment in logback.xml
> 
> above this element so it's more clear:
> 
> 30



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4189) NiFi ignores logback rotation settings

[Andre F de Miranda (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088811#comment-16088811
 ] 

Andre F de Miranda commented on NIFI-4189:
--

>From what I understand, based on logback settings, NiFi default logback 
>behavior is configured to behave so that once a file reaches the limits set in:

{code}
100MB
{code}

The {{%i}} set in:

{code}
${org.apache.nifi.bootstrap.config.log.dir}/nifi-app_%d{-MM-dd_HH}.%i.log.gz
{code}

Kicks in, creating a new file

This seems to disarm the expected behavior of rotating files for a maximum of X 
files as defined in:

{code}
30
{code}

In my tests, the best workaround seems to be increasing the size of 

{code}
100MB
{code}

To a value that can hold a day worth of data.

Given the workaround above effectively disables rotation based on size - and in 
exchange restores a healthy logfile rotation - I suggest we adjust the default 
NiFi behavior so that:

1. we drop {{ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy}} for 
{{ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy}}
2. Remove both {{%i}} and {{maxFileSize}} from logback.xml


> NiFi ignores logback rotation settings
> --
>
> Key: NIFI-4189
> URL: https://issues.apache.org/jira/browse/NIFI-4189
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Andre F de Miranda
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088778#comment-16088778
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

GitHub user mans2singh opened a pull request:

https://github.com/apache/nifi/pull/2011

NIFI-4118 - Nifi RethinkDB Get processor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mans2singh/nifi NIFI-4188

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2011


commit 0d52c6b62c8acc4053c6f0f6b6c4ea70cd9b85ab
Author: mans2singh 
Date:   2017-07-16T02:18:09Z

NIFI-4118 Nifi RethinkDB Get processor




> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #2011: NIFI-4118 - Nifi RethinkDB Get processor

[mans2singh]

Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/2011
  
The Jira ticket number was not correct.  Will close this one and open a new 
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088779#comment-16088779
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/2011
  
The Jira ticket number was not correct.  Will close this one and open a new 
request.


> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088780#comment-16088780
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

Github user mans2singh closed the pull request at:

https://github.com/apache/nifi/pull/2011


> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #2011: NIFI-4118 - Nifi RethinkDB Get processor

[mans2singh]

Github user mans2singh closed the pull request at:

https://github.com/apache/nifi/pull/2011


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #2011: NIFI-4118 - Nifi RethinkDB Get processor

[mans2singh]

GitHub user mans2singh opened a pull request:

https://github.com/apache/nifi/pull/2011

NIFI-4118 - Nifi RethinkDB Get processor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mans2singh/nifi NIFI-4188

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2011


commit 0d52c6b62c8acc4053c6f0f6b6c4ea70cd9b85ab
Author: mans2singh 
Date:   2017-07-16T02:18:09Z

NIFI-4118 Nifi RethinkDB Get processor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4188) Create RethinkDB get processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088782#comment-16088782
 ] 

ASF GitHub Bot commented on NIFI-4188:
--

GitHub user mans2singh opened a pull request:

https://github.com/apache/nifi/pull/2012

NIFI-4188 - Nifi RethinkDB Get processor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mans2singh/nifi NIFI-4188

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2012


commit 0776617449934d8d961bc7d505defbdf00862220
Author: mans2singh 
Date:   2017-07-16T02:18:09Z

NIFI-4188 Nifi RethinkDB Get processor

modified:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-nar/src/main/resources/META-INF/NOTICE
modified:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/pom.xml
modified:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/main/java/org/apache/nifi/processors/rethinkdb/AbstractRethinkDBProcessor.java
new file:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/main/java/org/apache/nifi/processors/rethinkdb/GetRethinkDB.java
modified:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/main/java/org/apache/nifi/processors/rethinkdb/PutRethinkDB.java
modified:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/main/resources/META-INF/services/org.apache.nifi.processor.Processor
new file:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/test/java/org/apache/nifi/processors/rethinkdb/ITGetRethinkDBTest.java
new file:   
nifi-nar-bundles/nifi-rethinkdb-bundle/nifi-rethinkdb-processors/src/test/java/org/apache/nifi/processors/rethinkdb/TestGetRethinkDB.java




> Create RethinkDB get processor
> --
>
> Key: NIFI-4188
> URL: https://issues.apache.org/jira/browse/NIFI-4188
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, get, rethinkdb
> Fix For: 1.4.0
>
>
> Create processor for getting documents by id from RethinkDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1921
  
@pvillard31 I accept it is a bit of bit picking but is there any chance we 
call it _raw? IIRC this is the name we used on ParseCEF. Naming conventions 
make user experience smoother 😀


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---