date:20171118

[jira] [Updated] (NIFI-4617) TestCSVRecordReader and Status Merging Test Failure

2017-11-18 Thread Matt Gilman (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-4617:
--
Summary: TestCSVRecordReader and Status Merging Test Failure  (was: 
TestCSVRecordReader Test Failure)

> TestCSVRecordReader and Status Merging Test Failure
> ---
>
> Key: NIFI-4617
> URL: https://issues.apache.org/jira/browse/NIFI-4617
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>
> Currently TestCSVRecordReader#testUTF8 fails with the following message:
> Failed tests: 
>   TestCSVRecordReader.testUTF8:81 expected:<[黃凱揚]> but was:<[???]>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Andrew Christianson (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258226#comment-16258226
 ] 

Andrew Christianson commented on MINIFICPP-314:
---

[~drodrigues] Ah, you're right. It wasn't working in my tests with "1 b" or "1 
B" for individual bytes. I think we don't support bytes. We can consider 
opening a ticket to support bytes if necessary.

> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse:
> {code}
> core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
> that will be used", "1 kB");
> {code}
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Andrew Christianson (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Christianson resolved MINIFICPP-314.
---
Resolution: Fixed

> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse:
> {code}
> core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
> that will be used", "1 kB");
> {code}
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Dustin Rodrigues (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258240#comment-16258240
 ] 

Dustin Rodrigues commented on MINIFICPP-314:


Looks to be a general issue of Minifi properties. 
https://issues.apache.org/jira/browse/MINIFICPP-315 fixes it.

> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse:
> {code}
> core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
> that will be used", "1 kB");
> {code}
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (MINIFICPP-313) GenerateFlowFile 'Unique FlowFiles' property inverted

2017-11-18 Thread Andrew Christianson (JIRA)

Andrew Christianson created MINIFICPP-313:
-

 Summary: GenerateFlowFile 'Unique FlowFiles' property inverted
 Key: MINIFICPP-313
 URL: https://issues.apache.org/jira/browse/MINIFICPP-313
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Reporter: Andrew Christianson
Priority: Minor


'Unique FlowFiles' must be set to false in order to get unique flow files, 
which is backward.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-315) Allow Properties to support plain 'b' suffix

2017-11-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258238#comment-16258238
 ] 

ASF GitHub Bot commented on MINIFICPP-315:
--

GitHub user dtrodrigues opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/196

MINIFICPP-315 - allow plain b suffix on properties

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-315

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #196


commit 5e18e4f42112bd65aaecf65cb6c1434182addb87
Author: Dustin Rodrigues 
Date:   2017-11-18T22:04:25Z

MINIFICPP-315 - allow plain b suffix on properties




> Allow Properties to support plain 'b' suffix
> 
>
> Key: MINIFICPP-315
> URL: https://issues.apache.org/jira/browse/MINIFICPP-315
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Dustin Rodrigues
>Priority: Minor
>
> Currently, if a property is 'x kb', the value is multiplied by 1024 but if 
> it's 'x k', it's multiplied by 1000. However, values are of the form 'x b' or 
> 'x B', the value doesn't get parsed at all. Instead, 'x' should be returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Andrew Christianson (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Christianson updated MINIFICPP-314:
--
Description: 
The default value is '1 kb,' which we don't actually parse:

{code}
core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
that will be used", "1 kB");
{code}

We need to either:

1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'

OR

2) Drop the kb from the default value, and note in the description that the 
unit is bytes

Option 2 would be a lot simpler.

  was:
The default value is '1 kb,' which we don't actually parse.

We need to either:

1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'

OR

2) Drop the kb from the default value, and note in the description that the 
unit is bytes

Option 2 would be a lot simpler.


> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse:
> {code}
> core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
> that will be used", "1 kB");
> {code}
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Andrew Christianson (JIRA)

Andrew Christianson created MINIFICPP-314:
-

 Summary: GenerateFlowFiles 'File Size' default value is misleading
 Key: MINIFICPP-314
 URL: https://issues.apache.org/jira/browse/MINIFICPP-314
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Reporter: Andrew Christianson
Priority: Trivial


The default value is '1 kb,' which we don't actually parse.

We need to either:

1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'

-OR-

2) Drop the kb from the default value, and note in the description that the 
unit is bytes

Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Andrew Christianson (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Christianson updated MINIFICPP-314:
--
Description: 
The default value is '1 kb,' which we don't actually parse.

We need to either:

1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'

OR

2) Drop the kb from the default value, and note in the description that the 
unit is bytes

Option 2 would be a lot simpler.

  was:
The default value is '1 kb,' which we don't actually parse.

We need to either:

1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'

-OR-

2) Drop the kb from the default value, and note in the description that the 
unit is bytes

Option 2 would be a lot simpler.


> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse.
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp pull request #196: MINIFICPP-315 - allow plain b suffix on p...

2017-11-18 Thread dtrodrigues

GitHub user dtrodrigues opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/196

MINIFICPP-315 - allow plain b suffix on properties

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-315

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #196


commit 5e18e4f42112bd65aaecf65cb6c1434182addb87
Author: Dustin Rodrigues 
Date:   2017-11-18T22:04:25Z

MINIFICPP-315 - allow plain b suffix on properties




---

[GitHub] nifi-minifi-cpp pull request #195: MINIFICPP-307: Support text mode in Gener...

2017-11-18 Thread dtrodrigues

GitHub user dtrodrigues opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/195

MINIFICPP-307: Support text mode in GenerateFlowFile

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-307

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit 481c4268710fa92db21951a8393025e6e75c6b12
Author: Dustin Rodrigues 
Date:   2017-10-28T06:28:40Z

remove unncessary Boost header dependency from core

commit 431494fe24d29a77e06767af873f3dce0c97c435
Author: Dustin Rodrigues 
Date:   2017-10-29T22:52:33Z

Merge branch 'MINIFICPP-271'

commit f4766c6ee5e92020d847c9c599461fd9ec6f3d77
Author: Dustin Rodrigues 
Date:   2017-11-01T14:51:30Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 3572c044b131a096cfdfc2bbd270975701d80391
Author: Dustin Rodrigues 
Date:   2017-11-02T14:44:24Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 05708ce5681d8bc83d4740b3878ce6893fa43708
Author: Dustin Rodrigues 
Date:   2017-11-04T16:15:02Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 182cb5ce0a62a4d0ac479b40999eb44f45c47ccb
Author: Dustin Rodrigues 
Date:   2017-11-07T00:08:46Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 471b3889cfd0be97e0ca6b12637e4b0a236486d7
Author: Dustin Rodrigues 
Date:   2017-11-08T04:44:03Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit d8cfc9159df53013be2f3818e11ef6b315f9883e
Author: Dustin Rodrigues 
Date:   2017-11-09T00:46:29Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 0358c3a081cfbe7cc74b358d9332221e7435e757
Author: Dustin Rodrigues 
Date:   2017-11-09T17:06:12Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 209ec9f25a78fdf95a5bd0b70c5515ded56a747e
Author: Dustin Rodrigues 
Date:   2017-11-11T23:40:53Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 0a9bad9be0ea4b249cfb123f9f23a3b6af1917f1
Author: Dustin Rodrigues 
Date:   2017-11-14T12:52:41Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 11b2db6bd943e1124c2011515c88e674a317d6cd
Author: Dustin Rodrigues 
Date:   2017-11-15T02:53:08Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 068aa80bd9ea0e5700aabca6428056633e72664c
Author: Dustin Rodrigues 
Date:   2017-11-17T01:49:14Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 345bdf4e3390953876d9c0073aa418ec1ce37975
Author: Dustin Rodrigues 
Date:   2017-11-18T03:05:06Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 76e09c4be88ce5faefa060eb505a2405bebdf7bd
Author: Dustin Rodrigues 
Date:   2017-11-18T19:45:52Z

MINIFICPP-307 - support text mode in GenerateFlowFile




---

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

2017-11-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258168#comment-16258168
 ] 

ASF GitHub Bot commented on MINIFICPP-307:
--

GitHub user dtrodrigues opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/195

MINIFICPP-307: Support text mode in GenerateFlowFile

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-307

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit 481c4268710fa92db21951a8393025e6e75c6b12
Author: Dustin Rodrigues 
Date:   2017-10-28T06:28:40Z

remove unncessary Boost header dependency from core

commit 431494fe24d29a77e06767af873f3dce0c97c435
Author: Dustin Rodrigues 
Date:   2017-10-29T22:52:33Z

Merge branch 'MINIFICPP-271'

commit f4766c6ee5e92020d847c9c599461fd9ec6f3d77
Author: Dustin Rodrigues 
Date:   2017-11-01T14:51:30Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 3572c044b131a096cfdfc2bbd270975701d80391
Author: Dustin Rodrigues 
Date:   2017-11-02T14:44:24Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 05708ce5681d8bc83d4740b3878ce6893fa43708
Author: Dustin Rodrigues 
Date:   2017-11-04T16:15:02Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 182cb5ce0a62a4d0ac479b40999eb44f45c47ccb
Author: Dustin Rodrigues 
Date:   2017-11-07T00:08:46Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 471b3889cfd0be97e0ca6b12637e4b0a236486d7
Author: Dustin Rodrigues 
Date:   2017-11-08T04:44:03Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit d8cfc9159df53013be2f3818e11ef6b315f9883e
Author: Dustin Rodrigues 
Date:   2017-11-09T00:46:29Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 0358c3a081cfbe7cc74b358d9332221e7435e757
Author: Dustin Rodrigues 
Date:   2017-11-09T17:06:12Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 209ec9f25a78fdf95a5bd0b70c5515ded56a747e
Author: Dustin Rodrigues 
Date:   2017-11-11T23:40:53Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 0a9bad9be0ea4b249cfb123f9f23a3b6af1917f1
Author: Dustin Rodrigues 
Date:   2017-11-14T12:52:41Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 11b2db6bd943e1124c2011515c88e674a317d6cd
Author: Dustin Rodrigues 
Date:   2017-11-15T02:53:08Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 068aa80bd9ea0e5700aabca6428056633e72664c
Author: Dustin Rodrigues 
Date:   2017-11-17T01:49:14Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 345bdf4e3390953876d9c0073aa418ec1ce37975
Author: Dustin Rodrigues 
Date:   2017-11-18T03:05:06Z

Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp

commit 76e09c4be88ce5faefa060eb505a2405bebdf7bd
Author: Dustin Rodrigues 
Date:   2017-11-18T19:45:52Z

[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...

2017-11-18 Thread dtrodrigues

Github user dtrodrigues commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/195
  
Linter issues should be fixed now


---

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

2017-11-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258198#comment-16258198
 ] 

ASF GitHub Bot commented on MINIFICPP-307:
--

Github user dtrodrigues commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/195
  
Linter issues should be fixed now


> GenerateFlowFile ignores type property
> --
>
> Key: MINIFICPP-307
> URL: https://issues.apache.org/jira/browse/MINIFICPP-307
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Priority: Minor
>
> It is currently stuck on generating binary data only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...

2017-11-18 Thread achristianson

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/195
  
You have a small linter issue:

```
Done processing 
/home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GetFile.cpp

/home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GenerateFlowFile.cpp:48:
  For a static/global string constant, use a C style string instead: "static 
const char TEXT_CHARS[]".  [runtime/string] [4]
```


---

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

2017-11-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258187#comment-16258187
 ] 

ASF GitHub Bot commented on MINIFICPP-307:
--

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/195
  
You have a small linter issue:

```
Done processing 
/home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GetFile.cpp

/home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GenerateFlowFile.cpp:48:
  For a static/global string constant, use a C style string instead: "static 
const char TEXT_CHARS[]".  [runtime/string] [4]
```


> GenerateFlowFile ignores type property
> --
>
> Key: MINIFICPP-307
> URL: https://issues.apache.org/jira/browse/MINIFICPP-307
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Priority: Minor
>
> It is currently stuck on generating binary data only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

2017-11-18 Thread Dustin Rodrigues (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258220#comment-16258220
 ] 

Dustin Rodrigues commented on MINIFICPP-314:


It looks like it does parse the value: 
https://github.com/apache/nifi-minifi-cpp/blob/master/libminifi/src/processors/GenerateFlowFile.cpp#L69

> GenerateFlowFiles 'File Size' default value is misleading
> -
>
> Key: MINIFICPP-314
> URL: https://issues.apache.org/jira/browse/MINIFICPP-314
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Trivial
>
> The default value is '1 kb,' which we don't actually parse:
> {code}
> core::Property GenerateFlowFile::FileSize("File Size", "The size of the file 
> that will be used", "1 kB");
> {code}
> We need to either:
> 1) Parse size strings e.g. '1 b' '1 kb' '5 MiB'
> OR
> 2) Drop the kb from the default value, and note in the description that the 
> unit is bytes
> Option 2 would be a lot simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4617) TestCSVRecordReader and Status Merging Test Failure

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[jira] [Resolved] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[jira] [Created] (MINIFICPP-313) GenerateFlowFile 'Unique FlowFiles' property inverted

[jira] [Commented] (MINIFICPP-315) Allow Properties to support plain 'b' suffix

[jira] [Updated] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[jira] [Created] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[jira] [Updated] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

[GitHub] nifi-minifi-cpp pull request #196: MINIFICPP-315 - allow plain b suffix on p...

[GitHub] nifi-minifi-cpp pull request #195: MINIFICPP-307: Support text mode in Gener...

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...

[jira] [Commented] (MINIFICPP-307) GenerateFlowFile ignores type property

[jira] [Commented] (MINIFICPP-314) GenerateFlowFiles 'File Size' default value is misleading

17 matches

Site Navigation

Mail list logo

Footer information