[jira] [Commented] (NIFI-12620) Upgrade JLine to 3.25.0
[ https://issues.apache.org/jira/browse/NIFI-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807651#comment-17807651 ] ASF subversion and git services commented on NIFI-12620: Commit eb1b2e31639281dabbd2ea8dd18b316734fde628 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=eb1b2e3163 ] NIFI-12620 Upgraded JLine from 3.24.1 to 3.25.0 Signed-off-by: Pierre Villard This closes #8256. > Upgrade JLine to 3.25.0 > --- > > Key: NIFI-12620 > URL: https://issues.apache.org/jira/browse/NIFI-12620 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > JLine > [3.25.0|https://github.com/jline/jline3/releases/tag/jline-parent-3.25.0] > includes several bug fixes and a resolution for CVE-2023-50572, which impacts > GroovyEngine usage. NiFi Toolkit dependencies on JLine do not use the > GroovyEngine for execution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12620) Upgrade JLine to 3.25.0
[ https://issues.apache.org/jira/browse/NIFI-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807650#comment-17807650 ] ASF subversion and git services commented on NIFI-12620: Commit eb36052bf2567e220520577ef15af2ad6d2d3c5a in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=eb36052bf2 ] NIFI-12620 Upgraded JLine from 3.24.1 to 3.25.0 Signed-off-by: Pierre Villard This closes #8256. > Upgrade JLine to 3.25.0 > --- > > Key: NIFI-12620 > URL: https://issues.apache.org/jira/browse/NIFI-12620 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 10m > Remaining Estimate: 0h > > JLine > [3.25.0|https://github.com/jline/jline3/releases/tag/jline-parent-3.25.0] > includes several bug fixes and a resolution for CVE-2023-50572, which impacts > GroovyEngine usage. NiFi Toolkit dependencies on JLine do not use the > GroovyEngine for execution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12620 Upgrade JLine from 3.24.1 to 3.25.0 [nifi]
asfgit closed pull request #8256: NIFI-12620 Upgrade JLine from 3.24.1 to 3.25.0 URL: https://github.com/apache/nifi/pull/8256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12620) Upgrade JLine to 3.25.0
[ https://issues.apache.org/jira/browse/NIFI-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12620: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade JLine to 3.25.0 > --- > > Key: NIFI-12620 > URL: https://issues.apache.org/jira/browse/NIFI-12620 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > JLine > [3.25.0|https://github.com/jline/jline3/releases/tag/jline-parent-3.25.0] > includes several bug fixes and a resolution for CVE-2023-50572, which impacts > GroovyEngine usage. NiFi Toolkit dependencies on JLine do not use the > GroovyEngine for execution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12621 Upgraded AWS SDK from 2.20.148 to 2.23.3 [nifi]
asfgit closed pull request #8257: NIFI-12621 Upgraded AWS SDK from 2.20.148 to 2.23.3 URL: https://github.com/apache/nifi/pull/8257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2217) Create JoltTransform processor
[ https://issues.apache.org/jira/browse/MINIFICPP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2217. - Resolution: Done > Create JoltTransform processor > -- > > Key: MINIFICPP-2217 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2217 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Adam Debreceni >Assignee: Adam Debreceni >Priority: Minor > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2217) Create JoltTransform processor
[ https://issues.apache.org/jira/browse/MINIFICPP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2217: Fix Version/s: 0.16.0 > Create JoltTransform processor > -- > > Key: MINIFICPP-2217 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2217 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Adam Debreceni >Assignee: Adam Debreceni >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2262) Add processor for pushing logs to Grafana Loki through gRPC
[ https://issues.apache.org/jira/browse/MINIFICPP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2262. - Resolution: Done > Add processor for pushing logs to Grafana Loki through gRPC > --- > > Key: MINIFICPP-2262 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2262 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > MINIFICPP-2261 introduces a Grafana Loki processor that uses REST API. We > should provide a similar functionality using gRPC with protocol buffers for a > more performant option. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2281) StructuredConfiguration should not depend on the Yaml/Json libraries
[ https://issues.apache.org/jira/browse/MINIFICPP-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2281. - Resolution: Done > StructuredConfiguration should not depend on the Yaml/Json libraries > > > Key: MINIFICPP-2281 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2281 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > The serialization of Yaml and Json flow definitions currently happens in > StructuredConfiguration. This should be a generic base and not depend on the > concrete implementations. Refactor the code to remove this dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2281) StructuredConfiguration should not depend on the Yaml/Json libraries
[ https://issues.apache.org/jira/browse/MINIFICPP-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2281: Fix Version/s: 0.16.0 > StructuredConfiguration should not depend on the Yaml/Json libraries > > > Key: MINIFICPP-2281 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2281 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The serialization of Yaml and Json flow definitions currently happens in > StructuredConfiguration. This should be a generic base and not depend on the > concrete implementations. Refactor the code to remove this dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2262) Add processor for pushing logs to Grafana Loki through gRPC
[ https://issues.apache.org/jira/browse/MINIFICPP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2262: Fix Version/s: 0.16.0 > Add processor for pushing logs to Grafana Loki through gRPC > --- > > Key: MINIFICPP-2262 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2262 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > MINIFICPP-2261 introduces a Grafana Loki processor that uses REST API. We > should provide a similar functionality using gRPC with protocol buffers for a > more performant option. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1716:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1716#discussion_r1455236043
##
libminifi/src/core/json/JsonFlowSerializer.cpp:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/json/JsonFlowSerializer.h"
+
+#include "rapidjson/prettywriter.h"
+#include "utils/crypto/property_encryption/PropertyEncryptionUtils.h"
+
+#ifdef WIN32
+#pragma push_macro("GetObject")
+#undef GetObject // windows.h #defines GetObject = GetObjectA or GetObjectW,
which conflicts with rapidjson
+#endif
+
+namespace org::apache::nifi::minifi::core::json {
+
+void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value
_jsons, rapidjson::Document::AllocatorType ,
+const std::map , const
utils::crypto::EncryptionProvider _provider) const {
+ for (auto : property_jsons.GetObject()) {
+std::string name{property.name.GetString()};
Review Comment:
we should also use `property.name.GetSize()` since it could contain a `\0`
character (I see that it appends a trailing `\0` but I don't think we can rely
on that as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1716:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1716#discussion_r1455240246
##
libminifi/src/core/json/JsonFlowSerializer.cpp:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/json/JsonFlowSerializer.h"
+
+#include "rapidjson/prettywriter.h"
+#include "utils/crypto/property_encryption/PropertyEncryptionUtils.h"
+
+#ifdef WIN32
+#pragma push_macro("GetObject")
+#undef GetObject // windows.h #defines GetObject = GetObjectA or GetObjectW,
which conflicts with rapidjson
+#endif
+
+namespace org::apache::nifi::minifi::core::json {
+
+void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value
_jsons, rapidjson::Document::AllocatorType ,
+const std::map , const
utils::crypto::EncryptionProvider _provider) const {
+ for (auto : property_jsons.GetObject()) {
+std::string name{property.name.GetString()};
+if (!properties.contains(name)) {
+ logger_->log_warn("Property {} found in flow definition does not
exist!", name);
+ continue;
+}
+if (properties.at(name).isSensitive()) {
+ auto = property.value;
+ std::string encrypted_value =
utils::crypto::property_encryption::encrypt(value.GetString(),
encryption_provider);
Review Comment:
`GetSize` here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2217 - Implement jolt processor shift operation [nifi-minifi-cpp]
szaszm closed pull request #1692: MINIFICPP-2217 - Implement jolt processor shift operation URL: https://github.com/apache/nifi-minifi-cpp/pull/1692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]
szaszm closed pull request #1698: MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC URL: https://github.com/apache/nifi-minifi-cpp/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
szaszm closed pull request #1716: MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json URL: https://github.com/apache/nifi-minifi-cpp/pull/1716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12506 /nifi-api/flow/metrics endpoint times out if flow is big [nifi]
timeabarna commented on PR #8158: URL: https://github.com/apache/nifi/pull/8158#issuecomment-1895348152 Thanks @exceptionfactory I've updated both pull requests based on your recommendation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12621) Upgrade AWS SDK to 2.23.3 and 1.12.637
[ https://issues.apache.org/jira/browse/NIFI-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807652#comment-17807652 ] ASF subversion and git services commented on NIFI-12621: Commit 1864a370bb9ebf7b62115390179aef992ae0cd1e in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1864a370bb ] NIFI-12621 Upgraded AWS SDK from 2.20.148 to 2.23.3 - Upgraded AWS SDK from 1.12.573 to 1.12.637 - Added dependency check suppression to correct identification of newer ion-java library Signed-off-by: Pierre Villard This closes #8257. > Upgrade AWS SDK to 2.23.3 and 1.12.637 > -- > > Key: NIFI-12621 > URL: https://issues.apache.org/jira/browse/NIFI-12621 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > The AWS SDK libraries should be upgraded to the latest available versions for > SDK 1 and 2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12621) Upgrade AWS SDK to 2.23.3 and 1.12.637
[ https://issues.apache.org/jira/browse/NIFI-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807653#comment-17807653 ] ASF subversion and git services commented on NIFI-12621: Commit 6136a2cebc579bbdd85b073d7a8aba6a71c2a96f in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6136a2cebc ] NIFI-12621 Upgraded AWS SDK from 2.20.148 to 2.23.3 - Upgraded AWS SDK from 1.12.573 to 1.12.637 - Added dependency check suppression to correct identification of newer ion-java library Signed-off-by: Pierre Villard This closes #8257. > Upgrade AWS SDK to 2.23.3 and 1.12.637 > -- > > Key: NIFI-12621 > URL: https://issues.apache.org/jira/browse/NIFI-12621 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 20m > Remaining Estimate: 0h > > The AWS SDK libraries should be upgraded to the latest available versions for > SDK 1 and 2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12621) Upgrade AWS SDK to 2.23.3 and 1.12.637
[ https://issues.apache.org/jira/browse/NIFI-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12621: -- Fix Version/s: 1.25.0 2.0.0-M2 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade AWS SDK to 2.23.3 and 1.12.637 > -- > > Key: NIFI-12621 > URL: https://issues.apache.org/jira/browse/NIFI-12621 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > The AWS SDK libraries should be upgraded to the latest available versions for > SDK 1 and 2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1716:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1716#discussion_r1455147965
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "yaml-cpp/yaml.h"
+#include "core/flow/FlowSerializer.h"
+
+namespace org::apache::nifi::minifi::core::json {
+
+class JsonFlowSerializer : public core::flow::FlowSerializer {
+ public:
+ explicit JsonFlowSerializer(rapidjson::Document&& document) :
flow_definition_json_(std::move(document)) {}
Review Comment:
do we need the rvalue ref here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
fgerlits commented on code in PR #1716:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1716#discussion_r1455414369
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "yaml-cpp/yaml.h"
+#include "core/flow/FlowSerializer.h"
+
+namespace org::apache::nifi::minifi::core::json {
+
+class JsonFlowSerializer : public core::flow::FlowSerializer {
+ public:
+ explicit JsonFlowSerializer(rapidjson::Document&& document) :
flow_definition_json_(std::move(document)) {}
Review Comment:
fixed in 52814c6cc538df8715d22ea213f6f5a355fc0118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2281 StructuredConfiguration should not depend on yaml and json [nifi-minifi-cpp]
fgerlits commented on code in PR #1716:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1716#discussion_r1455414745
##
libminifi/src/core/json/JsonFlowSerializer.cpp:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/json/JsonFlowSerializer.h"
+
+#include "rapidjson/prettywriter.h"
+#include "utils/crypto/property_encryption/PropertyEncryptionUtils.h"
+
+#ifdef WIN32
+#pragma push_macro("GetObject")
+#undef GetObject // windows.h #defines GetObject = GetObjectA or GetObjectW,
which conflicts with rapidjson
+#endif
+
+namespace org::apache::nifi::minifi::core::json {
+
+void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value
_jsons, rapidjson::Document::AllocatorType ,
+const std::map , const
utils::crypto::EncryptionProvider _provider) const {
+ for (auto : property_jsons.GetObject()) {
+std::string name{property.name.GetString()};
Review Comment:
fixed in 52814c6cc538df8715d22ea213f6f5a355fc0118
##
libminifi/src/core/json/JsonFlowSerializer.cpp:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/json/JsonFlowSerializer.h"
+
+#include "rapidjson/prettywriter.h"
+#include "utils/crypto/property_encryption/PropertyEncryptionUtils.h"
+
+#ifdef WIN32
+#pragma push_macro("GetObject")
+#undef GetObject // windows.h #defines GetObject = GetObjectA or GetObjectW,
which conflicts with rapidjson
+#endif
+
+namespace org::apache::nifi::minifi::core::json {
+
+void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value
_jsons, rapidjson::Document::AllocatorType ,
+const std::map , const
utils::crypto::EncryptionProvider _provider) const {
+ for (auto : property_jsons.GetObject()) {
+std::string name{property.name.GetString()};
+if (!properties.contains(name)) {
+ logger_->log_warn("Property {} found in flow definition does not
exist!", name);
+ continue;
+}
+if (properties.at(name).isSensitive()) {
+ auto = property.value;
+ std::string encrypted_value =
utils::crypto::property_encryption::encrypt(value.GetString(),
encryption_provider);
Review Comment:
fixed in 52814c6cc538df8715d22ea213f6f5a355fc0118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]
exceptionfactory closed pull request #8240: NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… URL: https://github.com/apache/nifi/pull/8240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11389 Fixed controller service's link to referencing controller services of lesser scope [nifi]
NissimShiman commented on PR #8099: URL: https://github.com/apache/nifi/pull/8099#issuecomment-1895991048 Thank you very much @mcgilman for looking at this (and the other related PR as well)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12604) Add support to empty queues
[ https://issues.apache.org/jira/browse/NIFI-12604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807770#comment-17807770 ] ASF subversion and git services commented on NIFI-12604: Commit 02df7c13f875f98b0fcac39f2a2a49e6ee8b718f in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=02df7c13f8 ] NIFI-12604: Empty Queue (#8246) * NIFI-12604: - Empty Queue. - Empty All Queues. * NIFI-12611: - Ensuring dialog is closed when an error occurs. - Migrating from withLatestFrom to concatLatestFrom. * NIFI-12611: - Adding header/nav to the controller service listing page. This closes #8246 > Add support to empty queues > --- > > Key: NIFI-12604 > URL: https://issues.apache.org/jira/browse/NIFI-12604 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Introduce actions for emptying a queue or all queues within a Process Group. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12611) View State
[ https://issues.apache.org/jira/browse/NIFI-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807771#comment-17807771 ] ASF subversion and git services commented on NIFI-12611: Commit 02df7c13f875f98b0fcac39f2a2a49e6ee8b718f in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=02df7c13f8 ] NIFI-12604: Empty Queue (#8246) * NIFI-12604: - Empty Queue. - Empty All Queues. * NIFI-12611: - Ensuring dialog is closed when an error occurs. - Migrating from withLatestFrom to concatLatestFrom. * NIFI-12611: - Adding header/nav to the controller service listing page. This closes #8246 > View State > -- > > Key: NIFI-12611 > URL: https://issues.apache.org/jira/browse/NIFI-12611 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > Introduce the ability to view and clear state for extension types that > support state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid [nifi]
mosermw commented on code in PR #8184:
URL: https://github.com/apache/nifi/pull/8184#discussion_r1455849633
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##
@@ -1433,6 +1434,14 @@ private Map populatePropertiesMap(final
ComponentNode componentN
final String serviceVersionedComponentId =
proposedProperties.get(propertyName);
String instanceId =
getServiceInstanceId(serviceVersionedComponentId, group);
value = (instanceId == null) ?
serviceVersionedComponentId : instanceId;
+
+// Find the same property descriptor in the
component's CreatedExtension and replace it with the
+// instance ID of the service
+createdExtensions.stream().filter(ce ->
ce.extension.equals(componentNode)).forEach(createdExtension -> {
+LOG.debug("Replacing CreatedExtension property {}
old value {} with new value {}",
+propertyName,
createdExtension.propertyValues.get(propertyName) , value);
Review Comment:
Good point @exceptionfactory, I have removed the debug log statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12604: Empty Queue [nifi]
rfellows merged PR #8246: URL: https://github.com/apache/nifi/pull/8246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12590) Add an option to add a prefix on Kubernetes resources
[
https://issues.apache.org/jira/browse/NIFI-12590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807830#comment-17807830
]
ASF subversion and git services commented on NIFI-12590:
Commit 787c45dd61f6bec51fb11beef4eb3b71acb2cf71 in nifi's branch
refs/heads/main from Juldrixx
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=787c45dd61 ]
NIFI-12590 Added Prefix Properties for Kubernetes Leases and ConfigMaps
This closes #8240
Signed-off-by: David Handermann
> Add an option to add a prefix on Kubernetes resources
> -
>
> Key: NIFI-12590
> URL: https://issues.apache.org/jira/browse/NIFI-12590
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 2.0.0-M2
>Reporter: Julien G.
>Assignee: Julien G.
>Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> In case of using Kubernetes as a *Cluster Leader Election* and *State
> Mangement*, NiFi will create two types of resources: *ConfigMaps* and
> *Leases*.
> 2 *Leases* for the _Cluster Leader Election_ and multiple *ConfigMaps*
> depending the number of components which their state to be stored.
> Their names are normalized:
> - *Leases*: {{cluster-coordinator}} and {{primary-node}}.
> - *ConfigMap*: {{nifi-component-%s}} with {{%s}} the component identifier.
> But currently, if someone wants to deploy more than one cluster in one
> namespace, conflicts will arise. Because the resources will share their
> names. It has been done this way to prevent security concerns where a cluster
> will manipulate resources of another cluster.
> But as discussed on Slack, these concerns can't prevented with 100% certainty.
> So users should be able to configure a prefix to add to these resources to
> prevent conflict and assume the security concerns.
> It can be done by replicating the logic done with ZooKeeper by adding a
> property in {{nifi.properties}} and a new field in the
> {{state_management.xml}} file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12613 Align type-safe access to allowableValue with it's declaration [nifi]
EndzeitBegins opened a new pull request, #8260: URL: https://github.com/apache/nifi/pull/8260 # Summary [NIFI-12613](https://issues.apache.org/jira/browse/NIFI-12613) Aligns the access site of "allowableValues" in `PropertyValue` with the declaration site in `PropertyDescriptor.Builder`. The method `asDescribedValue` was introduced recently and hasn't been part of a proper release yet. I think its a good time to align the type and naming scheme with the configuration site before the inclusion in a first release, as it would be a breaking change then. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12394) when importing versioned flow with component that migrates properties, controller service reference is invalid
[
https://issues.apache.org/jira/browse/NIFI-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12394:
Fix Version/s: 2.0.0-M2
Resolution: Fixed
Status: Resolved (was: Patch Available)
> when importing versioned flow with component that migrates properties,
> controller service reference is invalid
> --
>
> Key: NIFI-12394
> URL: https://issues.apache.org/jira/browse/NIFI-12394
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Reporter: Michael W Moser
>Assignee: Michael W Moser
>Priority: Major
> Fix For: 2.0.0-M2
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I built a Process Group containing one StandardRestrictedSSLContextService
> that is referenced by one InvokeHTTP processor. I downloaded that Process
> Group as a flow definition {*}with external services{*}. I also versioned
> that Process Group in NiFi Registry.
> Inside the flow definition file, I see the
> StandardRestrictedSSLContextService with
> "identifier":"d7d70b6c-abe4-3564-a219-b289cb7f25d2" and InvokeHTTP references
> that UUID.
> When I create a new Process Group using either the downloaded flow definition
> or the NiFi Registry flow, a new StandardRestrictedSSLContextService is
> created and it has a new UUID as expected. The InvokeHTTP processor is
> invalid because it references the proposed
> StandardRestrictedSSLContextService UUID d7d70b6c-abe4-3564-a219-b289cb7f25d2
> which does not exist.
> The service and processor are created and references are updated, but when
> migrating processor properties and any change occurs, the service reference
> is reverted back to what was in proposedProperties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12554 Placed all Jolt related code under a new nifi-jolt-bundle and refactored to reduce duplicate code. [nifi]
dan-s1 commented on PR #8249: URL: https://github.com/apache/nifi/pull/8249#issuecomment-1896124104 > Thank you for working on this @dan-s1. > > I haven't done a full code review so I might've just overlooked something. But I noticed that the package names of the processors change due to the move from the standard-nar to the new jolt-nar. From my understanding this will result in the processors needing to be replaced manually on the canvas between version updates, or is there a migration in place for this sort of change? If not, and the user needs to replace those processors themself, I don't think we need to migrate properties as there won't be any instance of the processor existing anyway. @EndzeitBegins I am not sure the answer to your question. I was following what @exceptionfactory had told me as seen in [NIFI-12554](https://issues.apache.org/jira/browse/NIFI-12554) in the comment on 1/9/2024. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12506 /nifi-api/flow/metrics endpoint times out if flow is big [nifi]
exceptionfactory commented on code in PR #8158:
URL: https://github.com/apache/nifi/pull/8158#discussion_r1456062429
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -457,6 +462,19 @@ public class StandardNiFiServiceFacade implements
NiFiServiceFacade {
private RuleViolationsManager ruleViolationsManager;
+private boolean analyticsEnabled;
+private Executor parallelProcessingExecutor;
Review Comment:
This should be `ExecutorService` instead of `Executor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2284 Update documentation to reflect user feedback [nifi-minifi-cpp]
szaszm closed pull request #1713: MINIFICPP-2284 Update documentation to reflect user feedback URL: https://github.com/apache/nifi-minifi-cpp/pull/1713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2229) Encrypt sensitive properties in the flow definition
[ https://issues.apache.org/jira/browse/MINIFICPP-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2229. - Resolution: Done > Encrypt sensitive properties in the flow definition > --- > > Key: MINIFICPP-2229 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2229 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 4h > Remaining Estimate: 0h > > The flow definition (config.yml) file can already be encrypted, but this is > optional. Sensitive properties should always be written to the flow > definition file in encrypted form. All processor and controller service > properties should be marked with a flag that shows if they are sensitive. > If full-flow-definition-encryption is enabled, the flow definition file as a > whole can also be encrypted on top of this (as it is now), but the two > encryptions should use separate keys. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2284) Update documentation to reflect user feedback
[ https://issues.apache.org/jira/browse/MINIFICPP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2284. - Resolution: Done > Update documentation to reflect user feedback > - > > Key: MINIFICPP-2284 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2284 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > There have been some feedback regarding the state of the documentation on the > NiFi slack channel that should be incorporated in the MiNiFi C++ markdown > files: > * The CONFIGURE.md file should list the available values for all repositories > * We should note that all components must have a unique id in the flow > config for state to be reloaded after restart. Related examples should be > updated as well > * Add information about the log properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2229 Encrypt sensitive properties (bugfix) [nifi-minifi-cpp]
szaszm closed pull request #1717: MINIFICPP-2229 Encrypt sensitive properties (bugfix) URL: https://github.com/apache/nifi-minifi-cpp/pull/1717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2284) Update documentation to reflect user feedback
[ https://issues.apache.org/jira/browse/MINIFICPP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2284: Fix Version/s: 0.16.0 > Update documentation to reflect user feedback > - > > Key: MINIFICPP-2284 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2284 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > There have been some feedback regarding the state of the documentation on the > NiFi slack channel that should be incorporated in the MiNiFi C++ markdown > files: > * The CONFIGURE.md file should list the available values for all repositories > * We should note that all components must have a unique id in the flow > config for state to be reloaded after restart. Related examples should be > updated as well > * Add information about the log properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid [nifi]
exceptionfactory closed pull request #8184: NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid URL: https://github.com/apache/nifi/pull/8184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12394) when importing versioned flow with component that migrates properties, controller service reference is invalid
[
https://issues.apache.org/jira/browse/NIFI-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807818#comment-17807818
]
ASF subversion and git services commented on NIFI-12394:
Commit 050f81f68611c3eba275be2d8824b4fd572b648b in nifi's branch
refs/heads/main from Michael W Moser
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=050f81f686 ]
NIFI-12394 Fixed Service references for Migrated Configurations
When syncing to a VersionedFlow, make sure processor references to new
controller services are valid after the processor migrates the configuration of
its properties
This closes #8184
Signed-off-by: David Handermann
> when importing versioned flow with component that migrates properties,
> controller service reference is invalid
> --
>
> Key: NIFI-12394
> URL: https://issues.apache.org/jira/browse/NIFI-12394
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Reporter: Michael W Moser
>Assignee: Michael W Moser
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I built a Process Group containing one StandardRestrictedSSLContextService
> that is referenced by one InvokeHTTP processor. I downloaded that Process
> Group as a flow definition {*}with external services{*}. I also versioned
> that Process Group in NiFi Registry.
> Inside the flow definition file, I see the
> StandardRestrictedSSLContextService with
> "identifier":"d7d70b6c-abe4-3564-a219-b289cb7f25d2" and InvokeHTTP references
> that UUID.
> When I create a new Process Group using either the downloaded flow definition
> or the NiFi Registry flow, a new StandardRestrictedSSLContextService is
> created and it has a new UUID as expected. The InvokeHTTP processor is
> invalid because it references the proposed
> StandardRestrictedSSLContextService UUID d7d70b6c-abe4-3564-a219-b289cb7f25d2
> which does not exist.
> The service and processor are created and references are updated, but when
> migrating processor properties and any change occurs, the service reference
> is reverted back to what was in proposedProperties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12616: Added some Use Case docs for Python processors and update… [nifi]
bbende commented on PR #8253: URL: https://github.com/apache/nifi/pull/8253#issuecomment-1896368699 @markap14 it seems like there is a consistent failure in the Windows build for this python related test... ``` == ERROR: TestPythonProcessorAdapter (unittest.loader._FailedTest) -- ImportError: Failed to import test module: TestPythonProcessorAdapter Traceback (most recent call last): File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\unittest\loader.py", line 436, in _find_test_path module = self._get_module_from_name(name) File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\unittest\loader.py", line 377, in _get_module_from_name __import__(name) File "D:\a\nifi\nifi\nifi-nar-bundles\nifi-py4j-bundle\nifi-python-framework\src\test\python\framework\TestPythonProcessorAdapter.py", line 17, in import ProcessorInspection ModuleNotFoundError: No module named 'ProcessorInspection' -- Ran 1 test in 0.009s FAILED (errors=1) Error: Command execution failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:881) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:841) at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:447) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174) at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75) at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162) at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283) at org.apache.maven.cli.MavenCli.main (MavenCli.java:206) at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103) at java.lang.reflect.Method.invoke (Method.java:580) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348) Error: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.1:exec (python-test) on project nifi-python-framework: Command execution failed.: Process exited with an error: 1 (Exit value: 1) -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12625) Documentation: python 3.12 not supported yet
[ https://issues.apache.org/jira/browse/NIFI-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12625: -- Status: Patch Available (was: Open) > Documentation: python 3.12 not supported yet > > > Key: NIFI-12625 > URL: https://issues.apache.org/jira/browse/NIFI-12625 > Project: Apache NiFi > Issue Type: Task > Components: Documentation Website >Affects Versions: 2.0.0-M1 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0-M2 > > > As of today, using Python 3.12 may cause errors with the Python API that has > been added in NiFi 2.0. This JIRA is to reflect this limitation in the > documentation. Further JIRAs will be created to have proper support of Python > 3.12. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12614: Create record reader service for Protobuf messages [nifi]
dan-s1 commented on PR #8250: URL: https://github.com/apache/nifi/pull/8250#issuecomment-1896558818 @mark-bathori With a big addition such as this, I would recommend some more documentation for end users so they are clear on how this works. This would go in your case under `nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/resources/org.apache.nifi.services.protobuf.ProtobufReader/additionalDetails.html` To get ideas on how to format and what to include, take a look at the other readers and the documentation they have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
mattyb149 commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1896626703 Closing this as it isn't a good fit as a NiFi processor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
mattyb149 closed pull request #8071: NIFI-12420: Add Sawmill transformation processors URL: https://github.com/apache/nifi/pull/8071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12420) Add Sawmill transformation processors
[ https://issues.apache.org/jira/browse/NIFI-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-12420: --- Assignee: (was: Matt Burgess) > Add Sawmill transformation processors > - > > Key: NIFI-12420 > URL: https://issues.apache.org/jira/browse/NIFI-12420 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Similarly to > JoltTransformJSON > JoltTransformRecord > JSLTTransformJSON > It would be nice to have SawmillTransformJSON and SawmillTransformRecord > processors that rely on the Sawmill transformation DSL > https://github.com/logzio/sawmill > https://github.com/logzio/sawmill/wiki > to transform input data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12420) Add Sawmill transformation processors
[ https://issues.apache.org/jira/browse/NIFI-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12420: Resolution: Won't Do Status: Resolved (was: Patch Available) > Add Sawmill transformation processors > - > > Key: NIFI-12420 > URL: https://issues.apache.org/jira/browse/NIFI-12420 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Similarly to > JoltTransformJSON > JoltTransformRecord > JSLTTransformJSON > It would be nice to have SawmillTransformJSON and SawmillTransformRecord > processors that rely on the Sawmill transformation DSL > https://github.com/logzio/sawmill > https://github.com/logzio/sawmill/wiki > to transform input data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11627) Add JSON Schema Registry Service for ValidateJson Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807928#comment-17807928
]
Daniel Stieglitz edited comment on NIFI-11627 at 1/17/24 11:21 PM:
---
[~exceptionfactory] Can this also be marked for inclusion in 1.25.0?
was (Author: JIRAUSER294662):
[~exceptionfactory] Can this also be marked for inclusion in 1.25?
> Add JSON Schema Registry Service for ValidateJson Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
> Labels: backport-needed
> Fix For: 2.0.0-M2
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12627) Extract nifi-file-transfer from nifi-standard-processors
endzeit created NIFI-12627:
--
Summary: Extract nifi-file-transfer from nifi-standard-processors
Key: NIFI-12627
URL: https://issues.apache.org/jira/browse/NIFI-12627
Project: Apache NiFi
Issue Type: Sub-task
Reporter: endzeit
Assignee: endzeit
NIFI-11171 plans to move {{SFTP}} processors out of the
{{nifi-standard-processors}} bundle.
These processors are based on the "FileTransfer" processor family.
The same is true for the {{FTP}} processors.
In order for both maven packages {{nifi-standard-processors}} and the new one
for the SFTP processors to access / build upon the "FileTransfer" processors,
these processors need to be moved to a separate package "nifi-file-transfer".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12619 - Fix python dependencies in ParseDocument [nifi]
exceptionfactory closed pull request #8255: NIFI-12619 - Fix python dependencies in ParseDocument URL: https://github.com/apache/nifi/pull/8255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12619) Unable to instantiate ParseDocument processor
[
https://issues.apache.org/jira/browse/NIFI-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12619:
Fix Version/s: 2.0.0-M2
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Unable to instantiate ParseDocument processor
> -
>
> Key: NIFI-12619
> URL: https://issues.apache.org/jira/browse/NIFI-12619
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1
> Environment: Python 3.11.6
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0-M2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Trying to instantiate the Python processor ParseDocument, I get this error:
> {code:java}
> 2024-01-16 18:00:00,573 INFO org.apache.nifi.py4j.ExtensionManager Importing
> dependencies ['langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx'] for
> ParseDocument to
> /Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT
> using command
> ['/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT/bin/python3',
> '-m', 'pip', 'install', '--no-cache-dir', '--target',
> '/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT',
> 'langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx']
> 2024-01-16 18:00:15,752 ERROR py4j.java_gateway There was an exception while
> executing the Python Proxy on the Python Side.
> Traceback (most recent call last):
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/python/framework/py4j/java_gateway.py",
> line 2466, in _call_proxy
> return_value = getattr(self.pool[obj_id], method)(*params)
>^^^
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./python/framework/Controller.py",
> line 72, in downloadDependencies
> self.extensionManager.import_external_dependencies(processor_details,
> work_dir)
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/python/framework/ExtensionManager.py",
> line 511, in import_external_dependencies
> raise RuntimeError(f"Failed to import requirements for {class_name}:
> process exited with status code {result}")
> RuntimeError: Failed to import requirements for ParseDocument: process exited
> with status code
> CompletedProcess(args=['/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT/bin/python3',
> '-m', 'pip', 'install', '--no-cache-dir', '--target',
> '/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT',
> 'langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx'],
> returncode=1) {code}
> If trying to run the pip command manually, I get
> {code:java}
> no matches found: pdfminer.six[image] {code}
> Changing the required dependency to just *pdfminer.six* fixes the issue and I
> can instantiate the processor.
> However when trying to use it against a PDF file, I get:
> {code:java}
> ModuleNotFoundError: No module named 'pikepdf'
> ModuleNotFoundError: No module named 'pypdf'{code}
> After adding the above dependencies, I get:
> {code:java}
> pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is
> poppler installed and in PATH? {code}
> Based on
> [https://pdf2image.readthedocs.io/en/latest/installation.html]
> It sounds like poppler would need to be installed separately. I did it with
> brew for my local instance. -Probably worth adding this in the docs if
> doable.- This is specified in the description of the processor.
> At this point I was able to use the processor to parse a PDF file.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12625) Documentation: python 3.12 not supported yet
[ https://issues.apache.org/jira/browse/NIFI-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807885#comment-17807885 ] ASF subversion and git services commented on NIFI-12625: Commit c719761a51f0bd6af754929d37cbdecc3ca8fb24 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c719761a51 ] NIFI-12625 Listed Supported Python Versions in Docs This closes #8261 Signed-off-by: David Handermann > Documentation: python 3.12 not supported yet > > > Key: NIFI-12625 > URL: https://issues.apache.org/jira/browse/NIFI-12625 > Project: Apache NiFi > Issue Type: Task > Components: Documentation Website >Affects Versions: 2.0.0-M1 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > As of today, using Python 3.12 may cause errors with the Python API that has > been added in NiFi 2.0. This JIRA is to reflect this limitation in the > documentation. Further JIRAs will be created to have proper support of Python > 3.12. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… [nifi]
turcsanyip commented on code in PR #8013:
URL: https://github.com/apache/nifi/pull/8013#discussion_r1456524742
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/checkpoint/CheckpointConstants.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.processors.azure.eventhub.checkpoint;
+
+public final class CheckpointConstants {
Review Comment:
I introduced enums but used a bit different names for them:
`CheckpointStoreKey` and `CheckpointStoreKeyPrefix` because both are related to
keys in the checkpoint store.
I also added a field for the key literal in `CheckpointStoreKey` too because
I preferred to use specific keys in the store instead of the raw enum names.
I hope it will be fine. Let me know if further adjustments are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12619) Unable to instantiate ParseDocument processor
[
https://issues.apache.org/jira/browse/NIFI-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807884#comment-17807884
]
ASF subversion and git services commented on NIFI-12619:
Commit 6e9da11be9bf80ac1c2e85c92355d1ae4d3d117b in nifi's branch
refs/heads/main from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6e9da11be9 ]
NIFI-12619 Fixed Python dependencies in ParseDocument
This closes #8255
Signed-off-by: David Handermann
> Unable to instantiate ParseDocument processor
> -
>
> Key: NIFI-12619
> URL: https://issues.apache.org/jira/browse/NIFI-12619
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1
> Environment: Python 3.11.6
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Trying to instantiate the Python processor ParseDocument, I get this error:
> {code:java}
> 2024-01-16 18:00:00,573 INFO org.apache.nifi.py4j.ExtensionManager Importing
> dependencies ['langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx'] for
> ParseDocument to
> /Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT
> using command
> ['/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT/bin/python3',
> '-m', 'pip', 'install', '--no-cache-dir', '--target',
> '/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT',
> 'langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx']
> 2024-01-16 18:00:15,752 ERROR py4j.java_gateway There was an exception while
> executing the Python Proxy on the Python Side.
> Traceback (most recent call last):
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/python/framework/py4j/java_gateway.py",
> line 2466, in _call_proxy
> return_value = getattr(self.pool[obj_id], method)(*params)
>^^^
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./python/framework/Controller.py",
> line 72, in downloadDependencies
> self.extensionManager.import_external_dependencies(processor_details,
> work_dir)
> File
> "/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/python/framework/ExtensionManager.py",
> line 511, in import_external_dependencies
> raise RuntimeError(f"Failed to import requirements for {class_name}:
> process exited with status code {result}")
> RuntimeError: Failed to import requirements for ParseDocument: process exited
> with status code
> CompletedProcess(args=['/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT/bin/python3',
> '-m', 'pip', 'install', '--no-cache-dir', '--target',
> '/Users/pierre/dev/github/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/./work/python/extensions/ParseDocument/2.0.0-SNAPSHOT',
> 'langchain', 'unstructured', 'unstructured-inference',
> 'unstructured_pytesseract', 'numpy', 'opencv-python', 'pdf2image',
> 'pdfminer.six[image]', 'python-docx', 'openpyxl', 'python-pptx'],
> returncode=1) {code}
> If trying to run the pip command manually, I get
> {code:java}
> no matches found: pdfminer.six[image] {code}
> Changing the required dependency to just *pdfminer.six* fixes the issue and I
> can instantiate the processor.
> However when trying to use it against a PDF file, I get:
> {code:java}
> ModuleNotFoundError: No module named 'pikepdf'
> ModuleNotFoundError: No module named 'pypdf'{code}
> After adding the above dependencies, I get:
> {code:java}
> pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is
> poppler installed and in PATH? {code}
> Based on
> [https://pdf2image.readthedocs.io/en/latest/installation.html]
> It sounds like poppler would need to be installed separately. I did it with
> brew for my local instance. -Probably worth adding this in the docs if
> doable.- This is specified in the description of the processor.
> At this point I was able to use the processor to parse a PDF file.
>
--
This message was sent by Atlassian
Re: [PR] NIFI-12625 - Python version support in docs [nifi]
exceptionfactory closed pull request #8261: NIFI-12625 - Python version support in docs URL: https://github.com/apache/nifi/pull/8261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12625) Documentation: python 3.12 not supported yet
Pierre Villard created NIFI-12625: - Summary: Documentation: python 3.12 not supported yet Key: NIFI-12625 URL: https://issues.apache.org/jira/browse/NIFI-12625 Project: Apache NiFi Issue Type: Task Components: Documentation Website Affects Versions: 2.0.0-M1 Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 2.0.0-M2 As of today, using Python 3.12 may cause errors with the Python API that has been added in NiFi 2.0. This JIRA is to reflect this limitation in the documentation. Further JIRAs will be created to have proper support of Python 3.12. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… [nifi]
exceptionfactory commented on code in PR #8013:
URL: https://github.com/apache/nifi/pull/8013#discussion_r1456551848
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/checkpoint/CheckpointConstants.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.processors.azure.eventhub.checkpoint;
+
+public final class CheckpointConstants {
Review Comment:
Thanks @turcsanyip, the names you selected look good. Will review once more
pending automated build completion, but this looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12625 - Python version support in docs [nifi]
pvillard31 opened a new pull request, #8261: URL: https://github.com/apache/nifi/pull/8261 # Summary [NIFI-12625](https://issues.apache.org/jira/browse/NIFI-12625) - Python version support in docs to specify that using Python 3.12 may cause error at the moment # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11627) Add JSON Schema Registry Service for ValidateJson Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807928#comment-17807928
]
Daniel Stieglitz commented on NIFI-11627:
-
[~exceptionfactory] Can this also be marked for inclusion in 1.25?
> Add JSON Schema Registry Service for ValidateJson Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
> Labels: backport-needed
> Fix For: 2.0.0-M2
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12626) Nifi Registry - Git integration
Philipp Korniets created NIFI-12626: --- Summary: Nifi Registry - Git integration Key: NIFI-12626 URL: https://issues.apache.org/jira/browse/NIFI-12626 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: Philipp Korniets NiFi Registry +Git integration. If we have some pre-commit/merge rules enabled on Git side (like check commit message to include Jira number) - it is completely ignored by NiFi Registry. This means that if rule didnt pass and no changes was committed to GIT - Registry - dont show error message - save data to Registry Possibly will be helpful to have following - setting - [Save on GIT fail]- if TRUE and GIT commit fails - do not save to registry, if FALSE - current behaviour - pass back GIT error message to NiFi UI -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12627 Extract nifi-file-transfer from nifi-standard-processors [nifi]
EndzeitBegins opened a new pull request, #8262: URL: https://github.com/apache/nifi/pull/8262 # Summary [NIFI-12627](https://issues.apache.org/jira/browse/NIFI-12627) Extracts *FileTransfer base processors to a separate module in preparation for the extraction of the *SFTP processors planned in [NIFI-11171](https://issues.apache.org/jira/browse/NIFI-11171). I haven't done any refactoring. In order to decouple *FileTransfer from `ListFile` of the `nifi-standard-processors` bundle I needed to point to `GetFileTransfer` instead and copy a missing attribute value. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12625) Documentation: python 3.12 not supported yet
[ https://issues.apache.org/jira/browse/NIFI-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12625: Resolution: Fixed Status: Resolved (was: Patch Available) > Documentation: python 3.12 not supported yet > > > Key: NIFI-12625 > URL: https://issues.apache.org/jira/browse/NIFI-12625 > Project: Apache NiFi > Issue Type: Task > Components: Documentation Website >Affects Versions: 2.0.0-M1 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > As of today, using Python 3.12 may cause errors with the Python API that has > been added in NiFi 2.0. This JIRA is to reflect this limitation in the > documentation. Further JIRAs will be created to have proper support of Python > 3.12. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12627 Extract nifi-file-transfer from nifi-standard-processors [nifi]
exceptionfactory closed pull request #8262: NIFI-12627 Extract nifi-file-transfer from nifi-standard-processors URL: https://github.com/apache/nifi/pull/8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12628) Upgrade Netty to 4.1.105
[ https://issues.apache.org/jira/browse/NIFI-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808061#comment-17808061 ] ASF subversion and git services commented on NIFI-12628: Commit 4c3705d91ee0d240632d57db2dfe017a3244a7b2 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4c3705d91e ] NIFI-12628 Upgraded Netty from 4.1.104 to 4.1.105 Signed-off-by: Pierre Villard This closes #8263. > Upgrade Netty to 4.1.105 > > > Key: NIFI-12628 > URL: https://issues.apache.org/jira/browse/NIFI-12628 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 20m > Remaining Estimate: 0h > > Netty [4.1.105|https://netty.io/news/2024/01/16/4-1-105-Final.html] includes > several minor bug fixes related to HTTP/2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12628) Upgrade Netty to 4.1.105
[ https://issues.apache.org/jira/browse/NIFI-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12628: -- Fix Version/s: 1.25.0 2.0.0-M2 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Netty to 4.1.105 > > > Key: NIFI-12628 > URL: https://issues.apache.org/jira/browse/NIFI-12628 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Netty [4.1.105|https://netty.io/news/2024/01/16/4-1-105-Final.html] includes > several minor bug fixes related to HTTP/2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… [nifi]
exceptionfactory closed pull request #8013: NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… URL: https://github.com/apache/nifi/pull/8013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11294) ConsumeAzureEventHub should default to processor state for checkpointing
[ https://issues.apache.org/jira/browse/NIFI-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807964#comment-17807964 ] ASF subversion and git services commented on NIFI-11294: Commit 2a3a7d93795d0c7a7efbf91e195fc2a9a7c4633a in nifi's branch refs/heads/main from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2a3a7d9379 ] NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub This closes #8013 Signed-off-by: David Handermann Co-authored-by: Peter Turcsanyi Co-authored-by: Malthe Borch > ConsumeAzureEventHub should default to processor state for checkpointing > > > Key: NIFI-11294 > URL: https://issues.apache.org/jira/browse/NIFI-11294 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > The current implementation requires an Azure Blob Storage account to persist > offsets (checkpointing) between restarts. > In NiFi, we have a readily available state store which is the processor state. > We should default to using this storage such that "Storage Account Name" > becomes a non-required field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11294) ConsumeAzureEventHub should support Component State for Checkpointing
[ https://issues.apache.org/jira/browse/NIFI-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11294. - Fix Version/s: 2.0.0-M2 Resolution: Fixed > ConsumeAzureEventHub should support Component State for Checkpointing > - > > Key: NIFI-11294 > URL: https://issues.apache.org/jira/browse/NIFI-11294 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 2.0.0-M2 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > The current implementation requires an Azure Blob Storage account to persist > offsets (checkpointing) between restarts. > In NiFi, we have a readily available state store which is the processor state. > We should default to using this storage such that "Storage Account Name" > becomes a non-required field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11294) ConsumeAzureEventHub should support Component State for Checkpointing
[ https://issues.apache.org/jira/browse/NIFI-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11294: Summary: ConsumeAzureEventHub should support Component State for Checkpointing (was: ConsumeAzureEventHub should default to processor state for checkpointing) > ConsumeAzureEventHub should support Component State for Checkpointing > - > > Key: NIFI-11294 > URL: https://issues.apache.org/jira/browse/NIFI-11294 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > The current implementation requires an Azure Blob Storage account to persist > offsets (checkpointing) between restarts. > In NiFi, we have a readily available state store which is the processor state. > We should default to using this storage such that "Storage Account Name" > becomes a non-required field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12613) Align PropertyDescriptor asAllowableValue with Builder Declaration
[
https://issues.apache.org/jira/browse/NIFI-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12613.
-
Fix Version/s: 2.0.0-M2
Resolution: Fixed
> Align PropertyDescriptor asAllowableValue with Builder Declaration
> --
>
> Key: NIFI-12613
> URL: https://issues.apache.org/jira/browse/NIFI-12613
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NIFI-12452 introduced a new method on {{PropertyValue}} to type-safely access
> a property with allowableValues constrained by an Enum.
> {code:java}
> & DescribedValue> E asDescribedValue(Class enumType)
> throws IllegalArgumentException {code}
> I think it makes sense to align the access site in {{PropertyValue}} with the
> declaration site in {{PropertyDescriptor.Builder}}.
> This would involve renaming the method to {{asAllowableValue}} for improved
> symmetry.
> This is a breaking change, however the method was never part of an stable
> release.
> Additionally, NIFI-12573 unified the behaviour of specifying Enums (not)
> implementing {{DescribedValue}} as allowableValues. With this change in
> place, I think it's reasonable to open the method to accepts any Enum as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12613 Align type-safe access to allowableValue with its declaration [nifi]
exceptionfactory closed pull request #8260: NIFI-12613 Align type-safe access to allowableValue with its declaration URL: https://github.com/apache/nifi/pull/8260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12613) Align type-safe access to allowableValue with it's declaration
[
https://issues.apache.org/jira/browse/NIFI-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807999#comment-17807999
]
ASF subversion and git services commented on NIFI-12613:
Commit 53bb995e4edb00235ac212317a6baba7f7bcaafb in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=53bb995e4e ]
NIFI-12613 Renamed asDescribedValue() to asAllowableValue()
This closes #8260
Signed-off-by: David Handermann
> Align type-safe access to allowableValue with it's declaration
> ---
>
> Key: NIFI-12613
> URL: https://issues.apache.org/jira/browse/NIFI-12613
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NIFI-12452 introduced a new method on {{PropertyValue}} to type-safely access
> a property with allowableValues constrained by an Enum.
> {code:java}
> & DescribedValue> E asDescribedValue(Class enumType)
> throws IllegalArgumentException {code}
> I think it makes sense to align the access site in {{PropertyValue}} with the
> declaration site in {{PropertyDescriptor.Builder}}.
> This would involve renaming the method to {{asAllowableValue}} for improved
> symmetry.
> This is a breaking change, however the method was never part of an stable
> release.
> Additionally, NIFI-12573 unified the behaviour of specifying Enums (not)
> implementing {{DescribedValue}} as allowableValues. With this change in
> place, I think it's reasonable to open the method to accepts any Enum as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12613) Align PropertyDescriptor asAllowableValue with Builder Declaration
[
https://issues.apache.org/jira/browse/NIFI-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12613:
Summary: Align PropertyDescriptor asAllowableValue with Builder Declaration
(was: Align type-safe access to allowableValue with it's declaration )
> Align PropertyDescriptor asAllowableValue with Builder Declaration
> --
>
> Key: NIFI-12613
> URL: https://issues.apache.org/jira/browse/NIFI-12613
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NIFI-12452 introduced a new method on {{PropertyValue}} to type-safely access
> a property with allowableValues constrained by an Enum.
> {code:java}
> & DescribedValue> E asDescribedValue(Class enumType)
> throws IllegalArgumentException {code}
> I think it makes sense to align the access site in {{PropertyValue}} with the
> declaration site in {{PropertyDescriptor.Builder}}.
> This would involve renaming the method to {{asAllowableValue}} for improved
> symmetry.
> This is a breaking change, however the method was never part of an stable
> release.
> Additionally, NIFI-12573 unified the behaviour of specifying Enums (not)
> implementing {{DescribedValue}} as allowableValues. With this change in
> place, I think it's reasonable to open the method to accepts any Enum as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-4491) Add a CaptureChangeMySQLRecord processor
[ https://issues.apache.org/jira/browse/NIFI-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807967#comment-17807967 ] Dongwook Chang edited comment on NIFI-4491 at 1/18/24 3:18 AM: --- [~mattyb149] Could you please assign this issue to me? was (Author: JIRAUSER303703): Could you please assign this issue to me? > Add a CaptureChangeMySQLRecord processor > > > Key: NIFI-4491 > URL: https://issues.apache.org/jira/browse/NIFI-4491 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Priority: Major > > The main reason CaptureChangeMySQL doesn't leverage the RecordSetWriter API > is that those capabilities were being developed in parallel with that > processor. Whether a new record-aware processor is better than an improvement > to the original is up for discussion; however, it would be a good idea to > support the RecordSetWriter API for any CDC (CaptureChangeXYZ) processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-9770) Upgrade Cassandra Components to Datastax 4 Driver
[
https://issues.apache.org/jira/browse/NIFI-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-9770:
--
Assignee: (was: Mike Thomsen)
> Upgrade Cassandra Components to Datastax 4 Driver
> -
>
> Key: NIFI-9770
> URL: https://issues.apache.org/jira/browse/NIFI-9770
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Priority: Major
>
> The Processors and Controller Services in the {{nifi-cassandra-bundle}}
> leverage the Datastax Driver version 3.10.2, which includes a transitive
> dependency on Google Guava 19.0. Older versions of Google Guava have several
> associated vulnerabilities, which do not appear to impact the Datastax Driver
> directly. In order to upgrade to a more recent version of Google Guava,
> however, it is necessary to upgrade to a recent version 4 release of the
> Datastax Driver. Datastax Driver 4.14.0 depends on Google Guava 25.0.
> The Datastax Driver version 4 supports access to Cassandra 2.1 and above, but
> upgrading the driver from version 3 to version 4 requires a number of
> changes. Several of the client configuration properties, accessible through
> NiFi component properties, must be provided through a different approach than
> the current driver configuration strategy. The Datastax Driver Upgrade Guide
> provides a summary of the relevant driver changes:
> https://docs.datastax.com/en/developer/java-driver/4.13/upgrade_guide/#4-0-0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12627) Extract nifi-file-transfer from nifi-standard-processors
[
https://issues.apache.org/jira/browse/NIFI-12627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808000#comment-17808000
]
ASF subversion and git services commented on NIFI-12627:
Commit 359ffa5b4f39efac15bd47232a581bb0b8b24cb3 in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=359ffa5b4f ]
NIFI-12627 Extract nifi-file-transfer from nifi-standard-processors
This closes #8262
Signed-off-by: David Handermann
> Extract nifi-file-transfer from nifi-standard-processors
>
>
> Key: NIFI-12627
> URL: https://issues.apache.org/jira/browse/NIFI-12627
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NIFI-11171 plans to move {{SFTP}} processors out of the
> {{nifi-standard-processors}} bundle.
> These processors are based on the "FileTransfer" processor family.
> The same is true for the {{FTP}} processors.
> In order for both maven packages {{nifi-standard-processors}} and the new one
> for the SFTP processors to access / build upon the "FileTransfer" processors,
> these processors need to be moved to a separate package "nifi-file-transfer".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12627) Extract nifi-file-transfer from nifi-standard-processors
[
https://issues.apache.org/jira/browse/NIFI-12627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12627.
-
Fix Version/s: 2.0.0-M2
Resolution: Fixed
> Extract nifi-file-transfer from nifi-standard-processors
>
>
> Key: NIFI-12627
> URL: https://issues.apache.org/jira/browse/NIFI-12627
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NIFI-11171 plans to move {{SFTP}} processors out of the
> {{nifi-standard-processors}} bundle.
> These processors are based on the "FileTransfer" processor family.
> The same is true for the {{FTP}} processors.
> In order for both maven packages {{nifi-standard-processors}} and the new one
> for the SFTP processors to access / build upon the "FileTransfer" processors,
> these processors need to be moved to a separate package "nifi-file-transfer".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12628 Upgrade Netty from 4.1.104 to 4.1.105 [nifi]
exceptionfactory opened a new pull request, #8263: URL: https://github.com/apache/nifi/pull/8263 # Summary [NIFI-12628](https://issues.apache.org/jira/browse/NIFI-12628) Upgrades Netty from 4.1.104 to [4.1.105](https://netty.io/news/2024/01/16/4-1-105-Final.html) incorporating several minor bug fixes for HTTP/2 handling. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12628) Upgrade Netty to 4.1.105
[ https://issues.apache.org/jira/browse/NIFI-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12628: Status: Patch Available (was: Open) > Upgrade Netty to 4.1.105 > > > Key: NIFI-12628 > URL: https://issues.apache.org/jira/browse/NIFI-12628 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Netty [4.1.105|https://netty.io/news/2024/01/16/4-1-105-Final.html] includes > several minor bug fixes related to HTTP/2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-4491) Add a CaptureChangeMySQLRecord processor
[ https://issues.apache.org/jira/browse/NIFI-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807967#comment-17807967 ] Dongwook Chang commented on NIFI-4491: -- Could you please assign this issue to me? > Add a CaptureChangeMySQLRecord processor > > > Key: NIFI-4491 > URL: https://issues.apache.org/jira/browse/NIFI-4491 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Priority: Major > > The main reason CaptureChangeMySQL doesn't leverage the RecordSetWriter API > is that those capabilities were being developed in parallel with that > processor. Whether a new record-aware processor is better than an improvement > to the original is up for discussion; however, it would be a good idea to > support the RecordSetWriter API for any CDC (CaptureChangeXYZ) processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12628 Upgrade Netty from 4.1.104 to 4.1.105 [nifi]
asfgit closed pull request #8263: NIFI-12628 Upgrade Netty from 4.1.104 to 4.1.105 URL: https://github.com/apache/nifi/pull/8263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]
exceptionfactory commented on code in PR #7940:
URL: https://github.com/apache/nifi/pull/7940#discussion_r1456861650
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractPutElasticsearch.java:
##
@@ -55,10 +55,41 @@
import java.util.stream.Collectors;
public abstract class AbstractPutElasticsearch extends AbstractProcessor
implements ElasticsearchRestProcessor {
+static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("All flowfiles that are sent to Elasticsearch without
request failures go to this relationship.")
+.build();
+
+static final Relationship REL_SUCCESSFUL = new Relationship.Builder()
+.name("successful")
Review Comment:
Is there a particular reason for calling this `successful` as opposed to the
much more common `success`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12628) Upgrade Netty to 4.1.105
David Handermann created NIFI-12628: --- Summary: Upgrade Netty to 4.1.105 Key: NIFI-12628 URL: https://issues.apache.org/jira/browse/NIFI-12628 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Netty [4.1.105|https://netty.io/news/2024/01/16/4-1-105-Final.html] includes several minor bug fixes related to HTTP/2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12613 Align type-safe access to allowableValue with its declaration [nifi]
EndzeitBegins commented on PR #8260: URL: https://github.com/apache/nifi/pull/8260#issuecomment-1897848576 Thank you for the quick review & merge @exceptionfactory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12628) Upgrade Netty to 4.1.105
[ https://issues.apache.org/jira/browse/NIFI-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808059#comment-17808059 ] ASF subversion and git services commented on NIFI-12628: Commit 0e6fb9a2787de0a7df4835a718f5e4d059c3 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e6fb9a278 ] NIFI-12628 Upgraded Netty from 4.1.104 to 4.1.105 Signed-off-by: Pierre Villard This closes #8263. > Upgrade Netty to 4.1.105 > > > Key: NIFI-12628 > URL: https://issues.apache.org/jira/browse/NIFI-12628 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Netty [4.1.105|https://netty.io/news/2024/01/16/4-1-105-Final.html] includes > several minor bug fixes related to HTTP/2. -- This message was sent by Atlassian Jira (v8.20.10#820010)
