[GitHub] nifi issue #719: NIFI-2389 Refactoring identity mapping and applying it to F...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/719
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #719: NIFI-2389 Refactoring identity mapping and applying it to F...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/719
  
Thanks @bbende... looks good. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/724
  
Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/724
  
@bbende This is a great start. I've verified that we can no longer add new 
users or groups with the same name as existing users or groups. However, I 
think we need to additionally ensure uniqueness between user identities and 
group names. Also, the unique constraint appears to only be checked when 
creating the user or group. Updating still allows the identities to become the 
same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #627: [NIFI-2205] [NIFI-2217] [NIFI-2219] [NIFI-2180] [NIFI-2140]...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/627
  
@scottyaslan Looks good... Ran into a couple minor issues...

1) Progress bar flickers and seems to default to 100%.
2) Label color preview does not update automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #563: NIFI-2078: External state management.

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/563
  
@ijokarumawak Awesome, thank you. There was just some confusion about 
whether we could resolve the PR for NIFI-2078 and just wanted to verify with 
you first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #651: UI - Cluster Awareness

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/651

UI - Cluster Awareness

NIFI-1947 NIFI-2082:
- Making it more obviously when a nodes cluster state changes.
- Showing which node is the cluster coordinator.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-1947

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #651


commit 6acd55fd3584a6182af3c8c8a7145737459f8ae3
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-14T15:00:14Z

NIFI-1947 NIFI-2082:
- Making it more obviously when a nodes cluster state changes.
- Showing which node is the cluster coordinator.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #654: Addressing issue with enabling/disabling Controller ...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/654

Addressing issue with enabling/disabling Controller Services

NIFI-2261:
- Addressed issue enabling/disabling controller services where the wrong 
URI was referenced.
- Addressed with the update revisions in the controller service references.
- Addressed issue with showing the disconnected from cluster dialog on page 
load.
- Addressed issue with URI when adding a dynamic property.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #654


commit e380aa6e503c2b7d910b53ad62ba1429c71b3007
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-14T16:43:18Z

NIFI-2261
- Addressed issue enabling/disabling controller services where the wrong 
URI was referenced.
- Addressed with the update revisions in the controller service references.
- Addressed issue with showing the disconnected from cluster dialog on page 
load.
- Addressed issue with URI when adding a dynamic property.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/698
  
Good catch. Will update PR shortly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIFI-2134]...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/703
  
Thanks @scottyaslan! Looks good.. this has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #730: Ensuring component specific policies are retained wh...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/730

Ensuring component specific policies are retained when copying/pasting

NIFI-2347:
- Ensuring component specific policies are retained when using copy/paste.
- This includes the policies for the component, data of the component, data 
transfers of the component, and policies of the component.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2347

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 834a0666ef2dfba49040f26d9fa0c3efa951e4a4
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-27T16:27:48Z

NIFI-2347:
- Ensuring component specific policies are retained when using copy/paste.
- This includes the policies for the component, data of the component, data 
transfers of the component, and policies of the component.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #732: [NIFI-2396] Update Bulletin Board shell header and filter c...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/732
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/724
  
Thanks @bbende! While testing I found a condition where the UI wasn't 
displaying the error returned from the server. I included that minor addition 
into your commit. This has been merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/725
  
Good catch and great suggestion. I've updated the PR accordingly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #736: Cleanup endpoints/UI when not running with a configu...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/736

Cleanup endpoints/UI when not running with a configurable authorizer

NIFI-2122:
- Merging responses for the current user and the flow configuration.
- Returning whether NiFi is configured with a policy based authorizer in 
the flow configuration.
- Only showing the users and policy icons when configured with a policy 
based authorizer.
- Failing faster when invoking the users or policies endpoint when not 
configured with a configurable authorizer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2122

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #736


commit 47a842bf9a481916449f31d4cb1c5191122a75a1
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-28T14:37:00Z

NIFI-2122:
- Merging responses for the current user and the flow configuration.
- Returning whether NiFi is configured with a policy based authorizer in 
the flow configuration.
- Only showing the users and policy icons when configured with a policy 
based authorizer.
- Failing faster when invoking the users or policies endpoint when not 
configured with a configurable authorizer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIFI-2027]...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/715
  
Looks great @scottyaslan! This has been merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #698: Updating the UI to reflect the access policies being...

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/698#discussion_r71818711
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
@@ -2147,9 +2147,15 @@ public ProcessGroupStatus getGroupStatus(final 
ProcessGroup group, final Reposit
 return null;
 }
 
+// if the user is null, this is not a web request so we need to 
treat as authorized - this is the case when
+// gather status for history in a background thread... we then 
will check the access of the user when pulling
+// back history...
+final NiFiUser user = NiFiUserUtils.getNiFiUser();
+final boolean isAuthorized = user == null ? true : 
group.isAuthorized(authorizer, RequestAction.READ, user);
--- End diff --

When handling a web request, the user will always be available. When this 
method is running outside the scope of a web request, there is nothing to 
attempt to authorize (nor should we). This conditional authorization seems 
appropriate to me. However, I think we can clean up the code to make the 
distinction a little more clear and deliberate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #735: NIFI-2390 Separating of users and groups from authorization...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/735
  
Looks good @bbende! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #740: Message on history page when clustered

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/740
  
Each node processed each action regardless if your browser was pointed to 
it. That's how the flows are kept in sync. The potential confusion here is with 
actions that happened to a node when it was not part of the cluster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #740: Message on history page when clustered

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/740
  
Do you have another suggestion for the message? What if we create another 
JIRA for further explanation in the user guide? Tough to explain the scenario 
in a short sentence or two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #740: Message on history page when clustered

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/740
  
The message is only shown when the node is part of a cluster. I think we 
shouldn't overcomplicate things. Inform the user that they are viewing the 
history of the current node and suggest they can browse to another node to view 
it's history. I believe this is a clear, simple, and accurate description of 
what is being display and what other options the user has.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #740: Message on history page when clustered

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/740
  
Your first impression of that message is accurate. We are only showing 
actions from the node the browser is pointing to. Meaning, if that node has 
other history before it was clustered it would be available. Each node is only 
showing the history it knows about. If every node was only part of its current 
cluster then all nodes would report the same history.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #745: Enabling Play/Stop buttons in palette more liberally

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/745

Enabling Play/Stop buttons in palette more liberally

NIFI-2401:
- Returning the enabled state of play and stop buttons in the palette. 
Allowing the user to always press if they have permissions to modify the 
selection or if no selection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2401

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #745


commit b6807751945744749a6c8336dc6b67a74cff28cd
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-29T14:36:25Z

NIFI-2401:
- Returning the enabled state of play and stop buttons in the palette. 
Allowing the user to always press if they have permissions to modify the 
selection.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #726: NIFI-2339 Removed some outputs which could cause errors to ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/726
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #750: Removing client side check for component move eligib...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/750

Removing client side check for component move eligibility

NIFI-2402:
- Removing client side check component move eligibility and instead 
relaying on verification server side. Cannot check client side as the current 
user may not have permissions to inspect required fields.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi PR-2402

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #750


commit 48d29a38f128bbcafac0dcb742681efacedf1309
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-29T21:45:41Z

NIFI-2402:
- Removing client side check component move eligibility and instead 
relaying on verification server side. Cannot check client side as the current 
user may not have permissions to inspect required fields.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #756: Fixing issue when searching for a component in a dif...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/756

Fixing issue when searching for a component in a different Group

NIFI-2443:
- Addressing issue where reload group deferred was being resolved 
prematurely.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2443

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #756


commit 565fd11cb8f2e520d060be5e8eca5f3012676b08
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-01T12:31:58Z

NIFI-2443:
- Addressing issue where reload group deferred was being resolved 
prematurely.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #755: Update REST endpoint documentation

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/755

Update REST endpoint documentation

NIFI-2237:
- Updating Rest Endpoint documentation specifically regarding access 
policies.
- Ensuring the resource listing is accurate.
- Removing unnecessary code.

This PR is part 1 of the overall effort required for NIFI-2237.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/755.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #755


commit 2a3aa6d1fab95adf9f2016d2282e04186238dc57
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-01T12:06:30Z

NIFI-2237:
- Updating Rest Endpoint documentation specifically regarding access 
policies.
- Ensuring the resource listing is accurate.
- Removing unnecessary code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #757: Ensuring all component specific policies are removed...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/757

Ensuring all component specific policies are removed when the component is 
deleted

NIFI-2301:
- Ensure all component specific policies are removed when the component is 
removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2301

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #757


commit 286550b801ea4e869f94dc91c6f404759f4b4cb7
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-01T14:18:21Z

NIFI-2301:
- Ensure all component specific policies are removed when the component is 
removed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #759: [NIFI-2426] Update visibility of New service/task button in...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/759
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #760: Reporting appropriate error message when not authori...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/760

Reporting appropriate error message when not authorized to empty queue in a 
cluster

NIFI-2438:
- If a node reports forbidden, using an appropriate response failure 
exception.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2438

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #760


commit 120c3b881cbdc5f5f1c0905a74514412c038eaf1
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-01T15:32:43Z

NIFI-2438:
- If a node reports forbidden, using an appropriate response failure 
exception.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/720
  
@markap14 Good catch. We also need to do this for site to site data 
transfers. Will update the seeding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #720: Introduce data resource for authorizing Provenance a...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/720

Introduce data resource for authorizing Provenance and Queue interactions

NIFI-2346:
- Introducing data resource for authorizing provenance events and queue 
listing.
- Authorizing entire proxy chain for data resource and data transfer 
resource.

NIFI-2338:
- Ensuring that replay authorization only happens once.

- Allowing users with access to policies for a component to be able to 
access all policies for that component.
-- Includes the component, data, data transfers, and policies.
- Fixing drop request completion to update the correct queued field.
- Fixing access control check for listing and emptying queues.
- Reseting selected policy when re-opening the policy management page.
- Fixing button/link visibility for available actions in policy management 
page.
- Fixing policy issues with policy removal when the underlying component is 
deleted.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2346

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #720


commit fe7213f7264cd5a97dc78ca1cbbb947f0ed3506f
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-25T20:47:22Z

NIFI-2346:
- Introducing data resource for authorizing provenance events and queue 
listing.
- Authorizing entire proxy chain for data resource and data transfer 
resource.
NIFI-2338:
- Ensuring that replay authorization only happens once.

- Allowing users with access to policies for a component to be able to 
access all policies for that component.
-- Includes the component, data, data transfers, and policies.
- Fixing drop request completion to update the correct queued field.
- Fixing access control check for listing and emptying queues.
- Reseting selected policy when re-opening the policy management page.
- Fixing button/link visibility for available actions in policy management 
page.
- Fixing policy issues with policy removal when the underlying component is 
deleted.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/720
  
@markap14 PR has been updated to address the comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #725: Addressing issues surrounding Template uploading

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/725

Addressing issues surrounding Template uploading

NIFI-2224:
- Ensuring the template form is reset when the upload template dialog is 
closed.

NIFI-2175:
- Not submitting the template form is a template isn't choosen.

NIFI-2176:
- Ensuring a template is specified during creation.

NIFI-2223:
- Ensuring templates with the same name cannot be added.

NIFI-2296:
- Updating the tooltip for the upload template browse button.

- Cleaning up un-used parameters to REST endpoints.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2175

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #725


commit 32a6482662add3d41307661d93de06261054e5ff
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-26T15:02:04Z

NIFI-2224:
- Ensuring the template form is reset when the upload template dialog is 
closed.
NIFI-2175:
- Not submitting the template form is a template isn't choosen.
NIFI-2176:
- Ensuring a template is specified during creation.
NIFI-2223:
- Ensuring templates with the same name cannot be added.
NIFI-2296:
- Updating the tooltip for the upload template browse button.

- Cleaning up un-used parameters to REST endpoints.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/770
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/770
  
@olegz I just ran through some of these scenario's and everything looks 
good so far. However, with the new UUID generation strategy I think there is 
some dead code in SnippetUtils that should be cleaned up.

Specifically, in SnippetUtils#copyContentsForGroup there is a serviceIdMap 
that was being used to update service identifiers in other component 
properties. Can we remove this code to help clean that up? Specifically, I 
think we can get rid of the serviceIdMap in SnippetUtils#copyContentsForGroup 
as well as both of the overloaded 
SnippetUtils#updateControllerServiceIdentifiers methods.

Please can a peek to make sure we're on the same page. Leaving this code in 
place could lead to confusion down the road.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #759: [NIFI-2426] Update visibility of New service/task button in...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/759
  
All merged. Thanks @scottyaslan!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #764: NIFI-2339 made exception statements more vague and limited ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/764
  
Thanks @joewitt! Looks good, this has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #835: Ensuring users can access the Controller Service and...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/835

Ensuring users can access the Controller Service and Reporting Tasks lists

NIFI-2501:
- Ensuring users can access the controller service list regardless of 
permissions on the corresponding process group or controller.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2501

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #835


commit 8e99c338c17d08ee465f9fac9f178cc8127f20ee
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-10T18:52:59Z

NIFI-2501:
- Ensuring users can access the controller service list regardless of 
permissions on the corresponding process group or controller.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #837: Controller Services - Addressing issues with transit...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/837

Controller Services - Addressing issues with transitive referencing 
components

NIFI-2542: - Ensuring transitive referencing components are able to be 
returned. 

NIFI-2543: - Ensuring we have permissions before attempting to reload a 
controller service.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2542

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #837


commit 17fbf55972fa81e7f5cccfd01fe833dbdc6326f7
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-11T14:52:04Z

NIFI-2542: - Ensuring transitive referencing components are able to be 
returned. NIFI-2543: - Ensuring we have permissions before attempting to reload 
a controller service.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #839: Allowing selection of User/Cluster node when searchi...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/839

Allowing selection of User/Cluster node when searching and encountering an 
exact match

NIFI-2548:
- Allowing selection of User/Cluster node when searching and encountering 
an exact match.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/839.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #839


commit 2f479d18f6a8ba2724ac45d141bc73d79dda1e13
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-11T18:50:57Z

NIFI-2548:
- Allowing selection of User/Cluster node when searching and encountering 
an exact match.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #822: Ensuring bulletins bubble up to ancestor Process Gro...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/822

Ensuring bulletins bubble up to ancestor Process Groups

NIFI-2511:
- Ensuring Process Group bulletins are bubbling up as expected.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2511

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/822.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #822


commit 56508592d45cb969c8bdf1fc1e2ff143db39d0a4
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-09T16:55:18Z

NIFI-2511:
- Ensuring Process Group bulletins are bubbling up as expected.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/757
  
Another good catch. I've updated the PR accordingly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #750: Removing client side check for component move eligibility

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/750
  
Good catch. I've update the PR accordingly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #755: Update REST endpoint documentation

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/755#discussion_r73401024
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessPolicyResource.java
 ---
@@ -102,14 +102,18 @@ public AccessPolicyEntity 
populateRemainingAccessPolicyEntityContent(AccessPolic
 @Consumes(MediaType.WILDCARD)
 @Produces(MediaType.APPLICATION_JSON)
 @Path("{action}/{resource: .+}")
-// TODO - @PreAuthorize("hasAnyRole('ROLE_MONITOR', 'ROLE_DFM', 
'ROLE_ADMIN')")
 @ApiOperation(
-value = "Gets an access policy",
+value = "Gets an access policy for the specified action and 
resource",
+notes = "Will return the effective policy if no component 
specific policy exists for the specified action and resource. "
++ "Must have Read permissions to the policy with the 
desired action and resource. Permissions for the policy that is "
++ "returned will be indicated in the response. This 
means the client could be authorized to get the policy for a "
++ "given component but the effective policy may be 
inherited from an ancestor Process Group. If the client does not "
++ "have permissions to that policy, the response will 
not include the policy and the permissions in the response "
++ "will be marked accordingly. If the client does not 
have permissions to the policy of the desired action and resource "
++ "a 403 response will be returned.",
 response = AccessPolicyEntity.class,
 authorizations = {
-@Authorization(value = "Read Only", type = 
"ROLE_MONITOR"),
-@Authorization(value = "Data Flow Manager", type = 
"ROLE_DFM"),
-@Authorization(value = "Administrator", type = 
"ROLE_ADMIN")
+@Authorization(value = "Read - 
/policies/{action}/{resource}", type = "")
--- End diff --

Yep, good call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #755: Update REST endpoint documentation

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/755#discussion_r73401076
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java
 ---
@@ -111,7 +111,7 @@
  * Authorizes access to the flow.
  */
 private boolean hasFlowAccess(final NiFiUser user) {
-final Map<String,String> userContext;
+final Map<String, String> userContext;
--- End diff --

Yep, removing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #755: Update REST endpoint documentation

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/755#discussion_r73401344
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
 ---
@@ -1470,42 +1437,41 @@ public Response getRemoteProcessGroups(
  * Creates a new connection.
  *
  * @param httpServletRequest request
- * @param groupId The group id
- * @param connectionEntity A connectionEntity.
+ * @param groupIdThe group id
+ * @param connectionEntity   A connectionEntity.
  * @return A connectionEntity.
  */
 @POST
 @Consumes(MediaType.APPLICATION_JSON)
 @Produces(MediaType.APPLICATION_JSON)
 @Path("{id}/connections")
-// TODO - @PreAuthorize("hasRole('ROLE_DFM')")
 @ApiOperation(
-value = "Creates a connection",
-response = ConnectionEntity.class,
-authorizations = {
-@Authorization(value = "Data Flow Manager", type = "ROLE_DFM")
-}
+value = "Creates a connection",
+response = ConnectionEntity.class,
+authorizations = {
+@Authorization(value = "Write - 
/process-groups/{uuid}", type = "")
--- End diff --

Yep, good call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #755: Update REST endpoint documentation

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/755#discussion_r73408766
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProvenanceResource.java
 ---
@@ -181,15 +179,15 @@ public Response getSearchOptions() {
 + "should be deleted by the client who originally 
submitted it.",
 response = ProvenanceEntity.class,
 authorizations = {
-@Authorization(value = "Provenance", type = 
"ROLE_PROVENANCE")
+@Authorization(value = "Read - /provenance", type = "")
--- End diff --

Yes it should. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #775: [NIFI-2053] update open/close palettes

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/775
  
Thanks @scottyaslan! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #784: Fixing issue with auto complete after closing/openin...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/784

Fixing issue with auto complete after closing/opening the containing dialog

NIFI-2467:
- Resetting cached search term when closing the dialog to ensure the same 
search time works upon re-opening.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2467

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #784


commit 6b5a1354c463914ba2ba513f56eb28df700609bb
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-04T13:04:33Z

NIFI-2467:
- Resetting cached search term when closing the dialog to ensure the same 
search time works upon re-opening.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #788: Updating the REST docs to account for the refactored...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/788

Updating the REST docs to account for the refactored endpoints

NIFI-2237:
- Reorganizing the refactored REST endpoints.
- Tweaking message text.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit 0f476d96f8b363cc776dc2c17655cc6033ef1f31
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-04T14:37:42Z

NIFI-2237:
- Reorganizing the refactored REST endpoints.
- Tweaking message text.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #781: [NIFI-2468] addressing some inconsistencies

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/781
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #842: [NIFI-2557] Enhance Modal Plugin

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/842
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #846: Addressing potential NullPointerException in AccessD...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/846

Addressing potential NullPointerException in AccessDeniedExceptionMapper

NIFI-2555:
- Addressing potential NullPointerException when an AccessDeniedException 
is thrown from an endpoint that isn't subject to the security filter chain.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2555

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #846


commit 9112f2942609094fc5b8d91efab26cb23a7d37aa
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-12T12:48:10Z

NIFI-2555:
- Addressing potential NullPointerException when an AccessDeniedException 
is thrown from an endpoint that isn't subject to the security filter chain.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #842: [NIFI-2557] Enhance Modal Plugin

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/842
  
Thanks @scottyaslan. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #841: [NIFI-2558] adjust content viewer combo alignment

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/841
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #694: NIFI-1876 Implements merging of responses to successful req...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/694
  
@jtstorck I think we also need a CounterEndpointMerger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #641: NIFI-2252: Fixed issue where POST to Controller Resource cr...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/641
  
Looks good @markap14! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #627: [NIFI-2205] [NIFI-2217] [NIFI-2219] [NIFI-2180] [NIFI-2140]...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/627
  
Thanks @scottyaslan. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #634: [NIFI-2182] [NIFI-2019] [NIFI-2183]

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/634

[NIFI-2182] [NIFI-2019] [NIFI-2183]

NIFI-2182:
- Ensuring the active thread count is shown.

NIFI-2019:
- Ensuring correct color of the run status in the From connection label.

NIFI-2183:
- Removing the DownloadSvg servlet and hidding the download icon until 
we're able to support saving the svg entirely from the client side.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2182

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #634


commit d21ea4cd5b5aafd4972bd17f9778477016cb75ea
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-12T23:24:11Z

NIFI-2182:
- Ensuring the active thread count is shown.
NIFI-2019:
- Ensuring correct color of the run status in the From connection label.
NIFI-2183:
- Removing the DownloadSvg servlet and hidding the download icon until 
we're able to support save the svg entirely from the client side.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #644: NIFI-2254: Fixing URI when reloading/updating compon...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/644

NIFI-2254: Fixing URI when reloading/updating component

- Addressing accessing URI on the wrong object.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2254

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #644


commit dd2770c7316d0348dd9d064752ab1245bb3a155f
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-13T18:13:42Z

NIFI-2254:
- Addressing accessing URI on the wrong object.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #628: NIFI-2003 Creating abstract authentication provider ...

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/628#discussion_r70423287
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-authorization/src/main/java/org/apache/nifi/authorization/user/StandardNiFiUser.java
 ---
@@ -23,18 +23,20 @@
  */
 public class StandardNiFiUser implements NiFiUser {
 
-public static final StandardNiFiUser ANONYMOUS = new 
StandardNiFiUser("anonymous");
+public static final StandardNiFiUser ANONYMOUS = new 
StandardNiFiUser("anonymous", null);
 
 private final String identity;
 private final NiFiUser chain;
+private final String clientAddress;
 
-public StandardNiFiUser(String identity) {
-this(identity, null);
+public StandardNiFiUser(String identity, String clientAddress) {
--- End diff --

Should we offer another constructor for when we don't have a client address?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #635: NIFI-2232: Dynamically updating the global menu acco...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/635

NIFI-2232: Dynamically updating the global menu according to the current 
users permissions

- Dynamically updating the global menu according to the current users 
permissions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2232

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #635


commit b56f6dcd5661843e4849f50f1e2479b956fbc99c
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-13T00:26:27Z

NIFI-2232:
- Dynamically updating the global menu according to the current users 
permissions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #636: NIFI-2249: Move URI out of component so it is access...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/636

NIFI-2249: Move URI out of component so it is accessible without read 
permissions

- Making the URI accessible outside of the component.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #636


commit b20518e18088d14b7e17022dfaa1d42ca8dc4dca
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-13T02:10:21Z

NIFI-2249:
- Making the URI accessibility outside of the component.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #698: Updating the UI to reflect the access policies being...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/698

Updating the UI to reflect the access policies being enforced

NIFI-2244:
- Separating the access control check and the supports modification check 
for the selected component.
- Using separated access control check to support editing when possible 
without write permission.

NIFI-2307:
- Adding support for opening Connection configuration and Connection 
details dialog when source/destination permissions are not allowed.
- Enforcing connection permissions based on the source and destination 
comonent.
- Removing connection specific access policies.

NIFI-2265:
- Filtering out sensitive details in component status and status history 
when appropriate.

NIFI-1800:
- Adding parent process group id to the Controller Services table.

NIFI-2077:
- Removing some old un-used icons following the UI refresh.

NIFI-2242:
- Requiring write permissions for all components in a selection.

NIFI-2080:
- Updating style of the name in the selection context to handle scroll bars 
and use available width.

NIFI-2331:
- Addressing issue when removing a user/group which was causing the tenant 
policy to be removed.

NIFI-2335:
- Ensuring the flow is saved after starting/stopping a process group.

NIFI-2235:
- Ensuring we use consistent conditions between the context menu and the 
operate palette.

- Allowing users with read only access to the tenants page.
- Fixing current user integration test.
- Ensuring schedule methods are locked appropriately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2244

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #698


commit f62f48efe5f0e68f6c6f439565a31c9ae4e708b7
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-21T01:41:06Z

NIFI-2244:
- Separating the access control check and the supports modification check 
for the selected component.
- Using separated access control check to support editing when possible 
without write permission.
NIFI-2307:
- Adding support for opening Connection configuration and Connection 
details dialog when source/destination permissions are not allowed.
- Enforcing connection permissions based on the source and destination 
comonent.
- Removing connection specific access policies.
NIFI-2265:
- Filtering out sensitive details in component status and status history 
when appropriate.
NIFI-1800:
- Adding parent process group id to the Controller Services table.
NIFI-2077:
- Removing some old un-used icons following the UI refresh.
NIFI-2242:
- Requiring write permissions for all components in a selection.
NIFI-2080:
- Updating style of the name in the selection context to handle scroll bars 
and use available width.
NIFI-2331:
- Addressing issue when removing a user/group which was causing the tenant 
policy to be removed.
NIFI-2335:
- Ensuring the flow is saved after starting/stopping a process group.
NIFI-2235:
- Ensuring we use consistent conditions between the context menu and the 
operate palette.

- Allowing users with read only access to the tenants page.
- Fixing current user integration test.
- Ensuring schedule methods are locked appropriately.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/698
  
NIFI-2242 was when there are multiple components selected with mixed 
permissions so I think this may be a slightly different case but I'd be happy 
to address as part of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/698
  
Yeah, I'm unable to replicate. The first message you mentioned sounds like 
the request was attempted like it was prior to the fix. Maybe your browser had 
some old JS cached. The "Must be authorized..." message is a client side check 
that I added to address NIFI-2242. Let me know if you still seeing any 
weirdness.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #666: Fixing issues loading the Policy Management UI

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/666

Fixing issues loading the Policy Management UI

NIFI-2272:
- Ensuring the appropriate visibility of the action in the policy 
management page.

NIFI-2273:
- Ensuring we load the policy or inform the user of the appropriate 
permissions of the effective policy.

NIFI-2239:
- Providing help tooltips for the policies in the management page.

NIFI-2283:
- Adding auditing for access policies, users, and groups.

NIFI-2263:
- Not replicating history requests throughout the cluster.

NIFI-2096:
- Fixing upload template file input in Firefox.

NIFI-2301:
- Removing relevant policies after component deletion.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2272

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #666


commit a0ab95a8478ec98e50f18b857c5fd8ae09c55867
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-18T12:35:00Z

NIFI-2272:
- Ensuring the appropriate visibilty of the action in the policy management 
page.
NIFI-2273:
- Ensuring we load the policy or inform the user of the appropriate 
permissions of the effective policy.
NIFI-2239:
- Providing help tooltips for the policies in the management page.
NIFI-2283:
- Adding auditing for access policies, users, and groups.
NIFI-2263:
- Not replicating history requests throughout the cluster.
NIFI-2096:
- Fixing upload template file input in Firefox.
NIFI-2301:
- Removing relevant policies after component deletion.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #673: [NIFI-2105] [NIFI-2106] fix status history dialog issues

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/673
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #684: [NIFI-2107] [NIFI-2143] Update content-viewer, error, and l...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/684
  
@scottyaslan After merging #646 this PR doesn't rebase cleanly. Can you 
update for the current state of master? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #666: Fixing issues loading the Policy Management UI

[mcgilman]

Github user mcgilman closed the pull request at:

https://github.com/apache/nifi/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #646: [NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refresh upd...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/646
  
Looks great @scottyaslan! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #646: [NIFI-2257] refresh updateattribute processor advanced shel...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/646
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #660: Addressing issue prevent access to login page

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/660

Addressing issue prevent access to login page

NIFI-2271:

- Fixing issue that was preventing an anonymous user from accessing the log 
in page.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2271

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #660


commit 7ff997ef370d9510bf782ef3d714fbfa5f631562
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-15T17:14:50Z

NIFI-2271:
- Fixing issue that was preventing an anonymous user from accessing the log 
in page.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #658: Addressing issue searching Provenance while clustere...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/658

Addressing issue searching Provenance while clustered and Replaying Events

NIFI-2260:

- Addressing issue searching provenance on a specific node.
- Fixing issues viewing content and replaying events.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2260

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #658


commit cd30370d68081695fe0aa0216ab963ca45091c1f
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-07-15T14:32:02Z

NIFI-2260:
- Addressing issue searching provenance on a specific node.
- Fixing issues viewing content and replaying events.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #646: [NIFI-2257] refresh updateattribute processor advanc...

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/646#discussion_r71017973
  
--- Diff: 
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js
 ---
@@ -1598,9 +1635,9 @@ var ua = {
 // create the editor
 editor = 
$('').addClass(editorClass).appendTo(wrapper).nfeditor({
 languageId: languageId,
-width: (cellNode.width() - 5) + 'px',
+width: '250px',
--- End diff --

I think we want to retain the previous behavior where the editor is the 
width of the entire cell when it's opened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #660: Addressing issue prevent access to login page

[mcgilman]

Github user mcgilman closed the pull request at:

https://github.com/apache/nifi/pull/660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #530: NIFI-1992: Updated site-to-site client and server to suppor...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/530
  
Looks good @markap14! I've merged this into master. Also found and 
addressed in your PR a minor issue that was already reported in NIFI-2274 [1]

[1] https://issues.apache.org/jira/browse/NIFI-2274


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #617: NIFI-826 Added deterministic template support

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/617#discussion_r71035162
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/TemplateResource.java
 ---
@@ -168,7 +172,13 @@ public Response exportTemplate(
 }
 
 // generate the response
-return generateOkResponse(template).header("Content-Disposition", 
String.format("attachment; filename=\"%s.xml\"", attachmentName)).build();
+/*
+ * Here instead of relying on default JAXB marshalling we are 
simply
+ * serializing template to String (formatted, indented etc) and 
sending
+ * it as part of the response.
+ */
+String serializedTemplate = new 
String(TemplateSerializer.serialize(template), StandardCharsets.UTF_8);
--- End diff --

This is fine here but we could have stream the template instead of 
converting to a String in memory using an approach like [1]

[1] 
https://github.com/apache/nifi/blob/5cd5a4ce788bec39e0dc5c7db93356610a9fa84e/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProvenanceEventResource.java#L146


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #636: NIFI-2249: Move URI out of component so it is access...

[mcgilman]

Github user mcgilman closed the pull request at:

https://github.com/apache/nifi/pull/636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #620: [NIFI-2147] Fix Warning/Invalid roll-over text

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/620
  
Looks good @scottyaslan! Thanks, this has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/604
  
Looks good @scottyaslan! This has been merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #621: NIFI-2185: Proxy requests through the cluster coordinator r...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/621
  
Looks good @markap14. This has been merged to master. I ran into a couple 
of unrelated issues while testing and will open additional JIRAs as necessary. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #620: [NIFI-2147] Fix Warning/Invalid roll-over text

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/620#discussion_r70240401
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
 ---
@@ -1328,9 +1328,9 @@
 var tooltip = 
nf.Common.formatPropertyTooltip(propertyDescriptor, propertyHistory);
 
 if (nf.Common.isDefinedAndNotNull(tooltip)) {
-infoIcon.qtip($.extend({
-content: tooltip,
-}, nf.Common.config.tooltipConfig));
+infoIcon.qtip($.extend(nf.Common.config.tooltipConfig, 
{
--- End diff --

@scottyaslan - If you checkout the description of $.extend [1] it shows the 
first argument is the target meaning that is what object that is being 
modified/updated. I don't we want to be modifying the tooltip configuration 
template like we are here as it will affect all subsequent $.extend calls. 

This applies to all of modified $.extend lines in this PR.

[1] https://api.jquery.com/jquery.extend/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #619: [NIFI-2198] [NIFI-1879] [NIFI-2197]

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/619
  
Looks good @scottyaslan! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #794: UI inconsistencies

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/794
  
Thanks @moranr. Will update shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/793
  
@jskora Thanks for the PR. I just tried it out and was able to replicate 
the issue. However, with your proposed change, the heading text on the 
Controller Settings dialog is missing. This is accessed through the global menu 
and selecting 'Controller Settings'.

I think the underlying issue is that the default visibility is not being 
set on the settings dialog [1]. By adding `class="hidden"` to the settings div, 
I believe the issue is resolved. Would you mind trying that locally and if you 
agree update the PR?

Thanks again!

[1] 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/settings-content.jsp#L18
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #800: Addressing issue preventing the display of the user ...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/800

Addressing issue preventing the display of the user in the history table

NIFI-2505:
- Updating the user identity field in the ActionDTO.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2505

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #800


commit 323e1dd24c6495f71f66f761612995a9ccdcc2b4
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-05T20:35:13Z

NIFI-2505:
- Updating the user identity field in the ActionDTO.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #781: [NIFI-2468] addressing some inconsistencies

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/781
  
@scottyaslan There were a few items that we're not implemented from the 
original JIRA. I am going to take your commit from this PR and include it in a 
subsequent PR that I'll post later. It will incorporate the remainder of 
NIFI-2468. Can we please close this one? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #792: Authorizing each bulletin returned through the bulle...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/792

Authorizing each bulletin returned through the bulletin board

NIFI-2486:
- Authorizing individual bulletins being returned through the bulletin 
board.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #792


commit 31457a2afecb44e593f25a9bd03a4142aa7861e8
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-04T18:53:02Z

NIFI-2486:
- Authorizing individual bulletins being returned through the bulletin 
board.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #813: Updating UI to reflect administrator policies do not...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/813

Updating UI to reflect administrator policies do not override

NIFI-2475:
- Updating UI to better suggest that component specific administrators do 
not override higher level administrators.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2475

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #813


commit e79a6a3aa89ff44a0cc1820e414786dea46ee7bd
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-08T20:52:53Z

NIFI-2475:
- Updating UI to better suggest that component specific administrators do 
not override higher level administrators.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #806: Extend REST API docs template to handle read only propertie...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/806
  
Looks good @jskora. This has been merged to master!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #806: Extend REST API docs template to handle read only propertie...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/806
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/770
  
Thanks @olegz. This has been merged to master. All changes looked good. I 
verified using a template from a 0.x release and templates generated with 
current version of 1.0.0-SNAPSHOT. All looks good.

I was mistaken about the dead code I mentioned earlier. Let's hold off on 
revisiting until later [1].

[1] https://issues.apache.org/jira/browse/NIFI-2461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #767: NIFI-1869 Cloning controller services when referenced by re...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/767
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #767: NIFI-1869 Cloning controller services when referenced by re...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/767
  
Looks great @bbende! Thanks for knocking this out. I've merged it to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #765: NIFI-2455 Removing 'Queue Buffering Max Time' as a required...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/765
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #773: Addressing issue when initial Provenance query is ca...

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/773

Addressing issue when initial Provenance query is cancelled

NIFI-2458:
- Fixing issue with timezone when the initial provenance result was 
cancelled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2458

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #773


commit 82659e5c3d0d81cf86c552c148d431348d88d543
Author: Matt Gilman <matt.c.gil...@gmail.com>
Date:   2016-08-02T15:26:05Z

NIFI-2458:
- Fixing issue with timezone when the initial provenance result was 
cancelled.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/745
  
Invalid processors are only ignored when your starting a group (there is no 
selection). This is how it works in 0.x and 1.x. When there is something 
selected this is not the case. I believe the behavior is consistent with only 
the addition in 1.x to ensure you have permissions to modify the entire 
selection. In 0.x the play and stop buttons are always enabled. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #735: NIFI-2390 Separating of users and groups from authorization...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/735
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---