[jira] [Resolved] (OPENNLP-1397) Build should fail fast if an unsupported JDK is used
[ https://issues.apache.org/jira/browse/OPENNLP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suneel Marthi resolved OPENNLP-1397. Fix Version/s: 2.1.0 Resolution: Fixed Enforce Maven-enforcer-plugin to kick in JDK version validation during the 'validate' phase > Build should fail fast if an unsupported JDK is used > > > Key: OPENNLP-1397 > URL: https://issues.apache.org/jira/browse/OPENNLP-1397 > Project: OpenNLP > Issue Type: Task > Components: Build, Packaging and Test >Affects Versions: 2.0.0, 2.1.0 >Reporter: Jeff Zemerick >Assignee: Suneel Marthi >Priority: Minor > Fix For: 2.1.0 > > > The build should fail fast if an unsupported JDK is used. Check to see if the > Maven Enforcer plugin is configured correctly or if something else is needed. > This issue came about from [~smarthi] testing the OpenNLP 2.1.0 RC1 using > Amazon Corretto 8. The build did not fail until a failed unit test. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1397) Build should fail fast if an unsupported JDK is used
[ https://issues.apache.org/jira/browse/OPENNLP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637517#comment-17637517 ] ASF GitHub Bot commented on OPENNLP-1397: - smarthi merged PR #437: URL: https://github.com/apache/opennlp/pull/437 > Build should fail fast if an unsupported JDK is used > > > Key: OPENNLP-1397 > URL: https://issues.apache.org/jira/browse/OPENNLP-1397 > Project: OpenNLP > Issue Type: Task > Components: Build, Packaging and Test >Affects Versions: 2.0.0, 2.1.0 >Reporter: Jeff Zemerick >Assignee: Suneel Marthi >Priority: Minor > > The build should fail fast if an unsupported JDK is used. Check to see if the > Maven Enforcer plugin is configured correctly or if something else is needed. > This issue came about from [~smarthi] testing the OpenNLP 2.1.0 RC1 using > Amazon Corretto 8. The build did not fail until a failed unit test. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1397) Build should fail fast if an unsupported JDK is used
[ https://issues.apache.org/jira/browse/OPENNLP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637513#comment-17637513 ] ASF GitHub Bot commented on OPENNLP-1397: - smarthi opened a new pull request, #437: URL: https://github.com/apache/opennlp/pull/437 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with OPENNLP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > Build should fail fast if an unsupported JDK is used > > > Key: OPENNLP-1397 > URL: https://issues.apache.org/jira/browse/OPENNLP-1397 > Project: OpenNLP > Issue Type: Task > Components: Build, Packaging and Test >Affects Versions: 2.0.0, 2.1.0 >Reporter: Jeff Zemerick >Assignee: Suneel Marthi >Priority: Minor > > The build should fail fast if an unsupported JDK is used. Check to see if the > Maven Enforcer plugin is configured correctly or if something else is needed. > This issue came about from [~smarthi] testing the OpenNLP 2.1.0 RC1 using > Amazon Corretto 8. The build did not fail until a failed unit test. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OPENNLP-1397) Build should fail fast if an unsupported JDK is used
[ https://issues.apache.org/jira/browse/OPENNLP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zemerick updated OPENNLP-1397: --- Description: The build should fail fast if an unsupported JDK is used. Check to see if the Maven Enforcer plugin is configured correctly or if something else is needed. This issue came about from [~smarthi] testing the OpenNLP 2.1.0 RC1 using Amazon Corretto 8. The build did not fail until a failed unit test. was:The build should fail fast if an unsupported JDK is used. Check to see if the Maven Enforcer plugin is configured correctly or if something else is needed. > Build should fail fast if an unsupported JDK is used > > > Key: OPENNLP-1397 > URL: https://issues.apache.org/jira/browse/OPENNLP-1397 > Project: OpenNLP > Issue Type: Task > Components: Build, Packaging and Test >Affects Versions: 2.0.0, 2.1.0 >Reporter: Jeff Zemerick >Assignee: Suneel Marthi >Priority: Minor > > The build should fail fast if an unsupported JDK is used. Check to see if the > Maven Enforcer plugin is configured correctly or if something else is needed. > This issue came about from [~smarthi] testing the OpenNLP 2.1.0 RC1 using > Amazon Corretto 8. The build did not fail until a failed unit test. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1397) Build should fail fast if an unsupported JDK is used
Jeff Zemerick created OPENNLP-1397: -- Summary: Build should fail fast if an unsupported JDK is used Key: OPENNLP-1397 URL: https://issues.apache.org/jira/browse/OPENNLP-1397 Project: OpenNLP Issue Type: Task Components: Build, Packaging and Test Affects Versions: 2.0.0, 2.1.0 Reporter: Jeff Zemerick Assignee: Suneel Marthi The build should fail fast if an unsupported JDK is used. Check to see if the Maven Enforcer plugin is configured correctly or if something else is needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
