[jira] [Updated] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated OPENNLP-1399: Affects Version/s: 2.1.0 > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Affects Versions: 2.1.0 >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > Fix For: 2.1.1 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642572#comment-17642572 ] ASF GitHub Bot commented on OPENNLP-1399: - kinow merged PR #73: URL: https://github.com/apache/opennlp-site/pull/73 > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642571#comment-17642571 ] ASF GitHub Bot commented on OPENNLP-1399: - kinow commented on PR #73: URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335392946 True, LGTM. I think I saw an email from... INFRA? Telling projects to migrate away from Travis. Merging and updating JIRA. Thanks! > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved OPENNLP-1399. - Fix Version/s: 2.1.1 Resolution: Fixed > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > Fix For: 2.1.1 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642560#comment-17642560 ] ASF GitHub Bot commented on OPENNLP-1399: - rzo1 commented on PR #73: URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335340181 > Just waiting for Travis (man_shrugging even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer). Guess we need to migrate away from Travis CI any time soon. I read, that ASF discontinous to use it, so we obviously need to change that in the future. > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642554#comment-17642554 ] ASF GitHub Bot commented on OPENNLP-1399: - kinow commented on PR #73: URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335324888 Just waiting for Travis (:man_shrugging: even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer). > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-936) Add thread safe versions of some tools (ME sentence detection, tokenization, pos tagging)
[ https://issues.apache.org/jira/browse/OPENNLP-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642541#comment-17642541 ] ASF GitHub Bot commented on OPENNLP-936: rzo1 commented on code in PR #69: URL: https://github.com/apache/opennlp/pull/69#discussion_r1038188389 ## opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerME_TS.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package opennlp.tools.postag; + +import opennlp.tools.util.Sequence; + +/** + * A thread-safe version of the POSTaggerME. Using it is completely transparent. You can use it in + * a single-threaded context as well, it only incurs a minimal overhead. + */ +public class POSTaggerME_TS implements POSTagger { Review Comment: > `ThreadSafePOSTaggerME` Would be fine for me. > Add thread safe versions of some tools (ME sentence detection, tokenization, > pos tagging) > - > > Key: OPENNLP-936 > URL: https://issues.apache.org/jira/browse/OPENNLP-936 > Project: OpenNLP > Issue Type: Improvement > Components: POS Tagger >Affects Versions: 1.7.1 >Reporter: Thilo Goetz >Priority: Minor > > As discussed on the mailing list, add thread safe versions of maximum entropy > sentence detection, tokenization and pos tagging. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642537#comment-17642537 ] ASF GitHub Bot commented on OPENNLP-1399: - rzo1 commented on code in PR #73: URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038180787 ## src/main/jbake/templates/footer.ftl: ## @@ -40,5 +40,24 @@ link.parents('li,ul').addClass('active'); + + Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642534#comment-17642534 ] ASF GitHub Bot commented on OPENNLP-1399: - kinow commented on code in PR #73: URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038178860 ## src/main/jbake/templates/footer.ftl: ## @@ -40,5 +40,24 @@ link.parents('li,ul').addClass('active'); + + Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642532#comment-17642532 ] ASF GitHub Bot commented on OPENNLP-1400: - kinow commented on PR #443: URL: https://github.com/apache/opennlp/pull/443#issuecomment-1335279523 Merged, and JIRA updated. Thanks! > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Affects Versions: 2.1.0 >Reporter: Martin Wiesner >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated OPENNLP-1400: Affects Version/s: 2.1.0 > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Affects Versions: 2.1.0 >Reporter: Martin Wiesner >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642530#comment-17642530 ] ASF GitHub Bot commented on OPENNLP-1400: - kinow merged PR #443: URL: https://github.com/apache/opennlp/pull/443 > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Reporter: Martin Wiesner >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved OPENNLP-1400. - Resolution: Fixed Thanks for the PR and for setting the fix version! > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Reporter: Martin Wiesner >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita reassigned OPENNLP-1400: --- Assignee: Bruno P. Kinoshita > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Reporter: Martin Wiesner >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642529#comment-17642529 ] ASF GitHub Bot commented on OPENNLP-1399: - rzo1 commented on code in PR #73: URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038175207 ## src/main/jbake/templates/footer.ftl: ## @@ -40,5 +40,24 @@ link.parents('li,ul').addClass('active'); + + Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642527#comment-17642527 ] ASF GitHub Bot commented on OPENNLP-1399: - kinow commented on code in PR #73: URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038173686 ## src/main/jbake/templates/footer.ftl: ## @@ -40,5 +40,24 @@ link.parents('li,ul').addClass('active'); + + Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
[ https://issues.apache.org/jira/browse/OPENNLP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642525#comment-17642525 ] ASF GitHub Bot commented on OPENNLP-1400: - mawiesne opened a new pull request, #443: URL: https://github.com/apache/opennlp/pull/443 Change - - adds missing JavaDoc - improves existing documentation for clarity - removes superfluous text - fixes typos in several interfaces, classes and package-info files - adjusts SentenceSample to implement Sample interface to be consistent with other cases (see changes in: OPENNLP-1394) - adds 'final' modifier where useful and applicable - removes deprecated constructors in SDCrossValidator Tasks - Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > Enhance JavaDoc in opennlp.tools.sentdetect package > --- > > Key: OPENNLP-1400 > URL: https://issues.apache.org/jira/browse/OPENNLP-1400 > Project: OpenNLP > Issue Type: Improvement > Components: Documentation >Reporter: Martin Wiesner >Priority: Minor > Fix For: 2.1.1 > > > The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several > inconsistencies and missing descriptions. Moreover, several typos are present > that need sanitizing. > It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1399) Integrate ASF Matomo into OpenNLP website
[ https://issues.apache.org/jira/browse/OPENNLP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642523#comment-17642523 ] ASF GitHub Bot commented on OPENNLP-1399: - rzo1 opened a new pull request, #73: URL: https://github.com/apache/opennlp-site/pull/73 as the title says. https://matomo.privacy.apache.org > Integrate ASF Matomo into OpenNLP website > - > > Key: OPENNLP-1399 > URL: https://issues.apache.org/jira/browse/OPENNLP-1399 > Project: OpenNLP > Issue Type: Task > Components: Website >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Minor > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1400) Enhance JavaDoc in opennlp.tools.sentdetect package
Martin Wiesner created OPENNLP-1400: --- Summary: Enhance JavaDoc in opennlp.tools.sentdetect package Key: OPENNLP-1400 URL: https://issues.apache.org/jira/browse/OPENNLP-1400 Project: OpenNLP Issue Type: Improvement Components: Documentation Reporter: Martin Wiesner Fix For: 2.1.1 The JavaDoc the _opennlp.tools.sentdetect_ package suffers from several inconsistencies and missing descriptions. Moreover, several typos are present that need sanitizing. It needs enhancements and/or additions to provide more clarity. -- This message was sent by Atlassian Jira (v8.20.10#820010)