[jira] [Commented] (OPENNLP-1124) Optimize XML Parser configuration
[ https://issues.apache.org/jira/browse/OPENNLP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148660#comment-16148660 ] ASF GitHub Bot commented on OPENNLP-1124: - kottmann closed pull request #258: OPENNLP-1124: Optimize XML parser configuration URL: https://github.com/apache/opennlp/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize XML Parser configuration > - > > Key: OPENNLP-1124 > URL: https://issues.apache.org/jira/browse/OPENNLP-1124 > Project: OpenNLP > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: William Colen >Assignee: William Colen > Fix For: 1.8.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENNLP-1124) Optimize XML Parser configuration
[
https://issues.apache.org/jira/browse/OPENNLP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146422#comment-16146422
]
ASF GitHub Bot commented on OPENNLP-1124:
-
smarthi commented on a change in pull request #258: OPENNLP-1124: Optimize XML
parser configuration
URL: https://github.com/apache/opennlp/pull/258#discussion_r135948080
##
File path: opennlp-tools/src/main/java/opennlp/tools/util/XmlUtil.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools.util;
+
+import javax.xml.XMLConstants;
+import javax.xml.parsers.DocumentBuilder;
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.parsers.SAXParser;
+import javax.xml.parsers.SAXParserFactory;
+
+import org.xml.sax.SAXException;
+
+public class XmlUtil {
+
+ /**
+ * Create a new DocumentBuilder which processes XML securely.
+ *
+ * @return a DocumentBuilder
+ */
+ public static DocumentBuilder createDocumentBuilder() {
+try {
+ DocumentBuilderFactory documentBuilderFacoty =
DocumentBuilderFactory.newInstance();
Review comment:
spelling typo
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize XML Parser configuration
> -
>
> Key: OPENNLP-1124
> URL: https://issues.apache.org/jira/browse/OPENNLP-1124
> Project: OpenNLP
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: William Colen
>Assignee: William Colen
> Fix For: 1.8.2
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1124) Optimize XML Parser configuration
[ https://issues.apache.org/jira/browse/OPENNLP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146360#comment-16146360 ] ASF GitHub Bot commented on OPENNLP-1124: - wcolen commented on issue #257: OPENNLP-1124: Optimize XML Parser configuration URL: https://github.com/apache/opennlp/pull/257#issuecomment-325837021 PR duplicated. Closing this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize XML Parser configuration > - > > Key: OPENNLP-1124 > URL: https://issues.apache.org/jira/browse/OPENNLP-1124 > Project: OpenNLP > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: William Colen >Assignee: William Colen > Fix For: 1.8.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENNLP-1124) Optimize XML Parser configuration
[ https://issues.apache.org/jira/browse/OPENNLP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146361#comment-16146361 ] ASF GitHub Bot commented on OPENNLP-1124: - wcolen closed pull request #257: OPENNLP-1124: Optimize XML Parser configuration URL: https://github.com/apache/opennlp/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize XML Parser configuration > - > > Key: OPENNLP-1124 > URL: https://issues.apache.org/jira/browse/OPENNLP-1124 > Project: OpenNLP > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: William Colen >Assignee: William Colen > Fix For: 1.8.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENNLP-1124) Optimize XML Parser configuration
[ https://issues.apache.org/jira/browse/OPENNLP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145329#comment-16145329 ] ASF GitHub Bot commented on OPENNLP-1124: - kottmann opened a new pull request #258: OPENNLP-1124: Optimize XML parser configuration URL: https://github.com/apache/opennlp/pull/258 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with OPENNLP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize XML Parser configuration > - > > Key: OPENNLP-1124 > URL: https://issues.apache.org/jira/browse/OPENNLP-1124 > Project: OpenNLP > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: William Colen >Assignee: William Colen > Fix For: 1.8.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
