[GitHub] [openwhisk-apigateway] mhamann opened a new pull request #357: Fix App ID bug, add unit tests
mhamann opened a new pull request #357: Fix App ID bug, add unit tests URL: https://github.com/apache/openwhisk-apigateway/pull/357 A bug with the App ID OAuth flow was introduced as part of #353 and wasn't caught due to a missing unit test. The unit test wasn't written because it was fairly involved. Given that bug, this PR fixes the defect and adds test coverage to the function, which should ensure this doesn't occur again. Due to the need to generate JWTs and JWKs to fully test this, the [step](https://github.com/smallstep/cli) CLI is used in the test build. It appears to be [Apache 2.0 licensed](https://github.com/smallstep/cli/blob/master/LICENSE), so I assume it is safe to use? Please let me know if there are any concerns. There are a couple of minor perf improvements to the unit test Dockerfile so that build caching can occur for local testing. Thus, the `install-deps.sh` script is no longer needed (and it was only used by the tests). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] Humbedooh commented on issue #4608: fix indent on labels in .asf.yaml
Humbedooh commented on issue #4608: fix indent on labels in .asf.yaml URL: https://github.com/apache/openwhisk/pull/4608#issuecomment-528676737 FaaS is invalid as it contains uppercase characters. faas would work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] dgrove-oss merged pull request #4608: fix indent on labels in .asf.yaml
dgrove-oss merged pull request #4608: fix indent on labels in .asf.yaml URL: https://github.com/apache/openwhisk/pull/4608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1054: Honor WSK_CONFIG_FILE if variable is set
mrutkows commented on a change in pull request #1054: Honor WSK_CONFIG_FILE if
variable is set
URL:
https://github.com/apache/openwhisk-wskdeploy/pull/1054#discussion_r321441197
##
File path: cmd/root.go
##
@@ -102,21 +102,32 @@ func init() {
func initConfig() {
userHome := utils.GetHomeDirectory()
defaultPath := path.Join(userHome, whisk.DEFAULT_LOCAL_CONFIG)
- if utils.Flags.CfgFile != "" {
- // Read the file as a wskprops file, to check if it is valid.
- _, err := whisk.ReadProps(utils.Flags.CfgFile)
- if err != nil {
- utils.Flags.CfgFile = defaultPath
- warn :=
wski18n.T(wski18n.ID_WARN_CONFIG_INVALID_X_path_X,
- map[string]interface{}{
- wski18n.KEY_PATH: utils.Flags.CfgFile})
- wskprint.PrintOpenWhiskWarning(warn)
+// Precedence order for reading the configuration file should be:
+// 1. --config
+// 2. ENV variable WSK_CONFIG_FILE
+// 3. Default $HOME/.wskprops
+ cfgFiles := []string{
+ utils.Flags.CfgFile,
+ os.Getenv("WSK_CONFIG_FILE"),
+defaultPath,
+}
+
+ for _, cfgFile := range cfgFiles {
Review comment:
Can you please clarify "not a gopher" for me?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows commented on issue #1054: Honor WSK_CONFIG_FILE if variable is set
mrutkows commented on issue #1054: Honor WSK_CONFIG_FILE if variable is set URL: https://github.com/apache/openwhisk-wskdeploy/pull/1054#issuecomment-528542355 @alvarolopez The build is failing as the linter does not like your go formatting (indentation); could you please fix that so we can review and work towards merge? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4606: Update k8s client to 4.4.0 from 4.0.3
chetanmeh commented on a change in pull request #4606: Update k8s client to
4.4.0 from 4.0.3
URL: https://github.com/apache/openwhisk/pull/4606#discussion_r321387886
##
File path: common/scala/build.gradle
##
@@ -59,7 +59,7 @@ dependencies {
compile ('com.fasterxml.uuid:java-uuid-generator:3.1.3')
compile 'com.github.ben-manes.caffeine:caffeine:2.6.2'
compile 'com.google.code.findbugs:jsr305:3.0.2'
-compile 'io.fabric8:kubernetes-client:4.0.3'
+compile 'io.fabric8:kubernetes-client:4.4.0'
Review comment:
Missed that there were new point releases. Done now
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah merged pull request #4607: Add asf.yaml to configure github metadata
rabbah merged pull request #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4607: Add asf.yaml to configure github metadata
rabbah commented on issue #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607#issuecomment-528450275 You beat me to it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4607: Add asf.yaml to configure github metadata
codecov-io commented on issue #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607#issuecomment-528378824 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=h1) Report > Merging [#4607](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8d2aeabf56667a9dec49690da1cd63f64eb217ee?src=pr=desc) will **decrease** coverage by `5.69%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4607 +/- ## = - Coverage 84.45% 78.75% -5.7% = Files 183 183 Lines8305 8305 Branches 581 581 = - Hits 7014 6541-473 - Misses 1291 1764+473 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.89%)` | :arrow_down: | | [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-94.74%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...e/database/cosmosdb/cache/ChangeFeedListener.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRMaXN0ZW5lci5zY2FsYQ==) | `0% <0%> (-86.67%)` | :arrow_down: | | [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-76.48%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: | | [...a/org/apache/openwhisk/common/ExecutorCloser.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9FeGVjdXRvckNsb3Nlci5zY2FsYQ==) | `0% <0%> (-66.67%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4% <0%> (-52%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/openwhisk/pull/4607/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=footer). Last
[GitHub] [openwhisk] dgrove-oss merged pull request #4605: add full license headers to vagrant scripts
dgrove-oss merged pull request #4605: add full license headers to vagrant scripts URL: https://github.com/apache/openwhisk/pull/4605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4605: add full license headers to vagrant scripts
codecov-io commented on issue #4605: add full license headers to vagrant scripts URL: https://github.com/apache/openwhisk/pull/4605#issuecomment-528358151 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=h1) Report > Merging [#4605](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8d2aeabf56667a9dec49690da1cd63f64eb217ee?src=pr=desc) will **decrease** coverage by `5.69%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4605 +/- ## = - Coverage 84.45% 78.75% -5.7% = Files 183 183 Lines8305 8305 Branches 581 581 = - Hits 7014 6541-473 - Misses 1291 1764+473 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.89%)` | :arrow_down: | | [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-94.74%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...e/database/cosmosdb/cache/ChangeFeedListener.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRMaXN0ZW5lci5zY2FsYQ==) | `0% <0%> (-86.67%)` | :arrow_down: | | [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-76.48%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: | | [...a/org/apache/openwhisk/common/ExecutorCloser.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9FeGVjdXRvckNsb3Nlci5zY2FsYQ==) | `0% <0%> (-66.67%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4% <0%> (-52%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/openwhisk/pull/4605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=footer).
[GitHub] [openwhisk] dgrove-oss opened a new pull request #4607: Add asf.yaml to configure github metadata
dgrove-oss opened a new pull request #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607 Experiment with new ASF feature of using a per-repo yaml file to configure github metadata for a project. See https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories for what is supported. I suggest we experiment in the main repo to verify it works and get to a core set of tags. Then we can replicate across all the repos & add additional per-repo tags as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] duynguyen commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images
duynguyen commented on a change in pull request #4503: Add optional config for
appending custom registry to user provided images
URL: https://github.com/apache/openwhisk/pull/4503#discussion_r321240007
##
File path: tests/src/test/resources/application.conf.j2
##
@@ -86,6 +86,7 @@ whisk {
container-factory.runtimes-registry {
url = "{{ runtimes_registry | default('') }}"
+include-user-images = "{{ runtimes_registry_user_images |
default('false') }}"
Review comment:
thanks for pointing out, removed the outdated boolean flag and added the
string config.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh opened a new pull request #4606: Update k8s client to 4.4.0 from 4.0.3
chetanmeh opened a new pull request #4606: Update k8s client to 4.4.0 from 4.0.3 URL: https://github.com/apache/openwhisk/pull/4606 Updates `io.fabric8:kubernetes-client` to 4.4.0 from 4.0.3. ## Description Current fabric8 k8s client version is 4.0.3 which does not support newer version of k8s (see [compatability matrix](https://github.com/fabric8io/kubernetes-client#compatibility-matrix). Updating it to 4.4.0 would enable support for newer version. Note that with this change old version <= 1.7.0 would not work and min supported k8s version per matrix would be 1.9.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images
rabbah commented on a change in pull request #4503: Add optional config for
appending custom registry to user provided images
URL: https://github.com/apache/openwhisk/pull/4503#discussion_r321196314
##
File path: core/invoker/src/main/resources/application.conf
##
@@ -98,6 +98,7 @@ whisk {
}
runtimes-registry {
url: ""
+ include-user-images: false # if true, registry hostname is automatically
appended to user images which do not contain hostname
Review comment:
is this still needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-deploy-kube] rabbah merged pull request #525: add missing license header
rabbah merged pull request #525: add missing license header URL: https://github.com/apache/openwhisk-deploy-kube/pull/525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] duynguyen commented on issue #4503: Add option for appending runtimes registry to user provided images
duynguyen commented on issue #4503: Add option for appending runtimes registry to user provided images URL: https://github.com/apache/openwhisk/pull/4503#issuecomment-528279282 @rabbah , @chetanmeh : I have updated the PR according to the comments. Could you please review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-wskdeploy] alvarolopez commented on issue #1057: Support Description field in corresponding entities
alvarolopez commented on issue #1057: Support Description field in corresponding entities URL: https://github.com/apache/openwhisk-wskdeploy/pull/1057#issuecomment-528266287 @mrutkows I believe that adding the description field worked for me, I need to check and keep you posted, as I remember some fields not working as you say. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
