[GitHub] [openwhisk-wskdeploy] TPei closed pull request #1043: allow limits on sequences
TPei closed pull request #1043: allow limits on sequences URL: https://github.com/apache/openwhisk-wskdeploy/pull/1043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-deploy-kube] belfhi closed issue #553: Install Packages Fails with External CouchDB cluster
belfhi closed issue #553: Install Packages Fails with External CouchDB cluster URL: https://github.com/apache/openwhisk-deploy-kube/issues/553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-deploy-kube] belfhi commented on issue #553: Install Packages Fails with External CouchDB cluster
belfhi commented on issue #553: Install Packages Fails with External CouchDB cluster URL: https://github.com/apache/openwhisk-deploy-kube/issues/553#issuecomment-563189643 So I found the error, the annotation nginx.ingress.kubernetes.io/proxy-body-size: 50m was missing in my CouchDB Nginx Ingress Controller, so not an issue with Openwhisk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] mhenke1 merged pull request #4736: Update pureconfig to version 0.11.1.
mhenke1 merged pull request #4736: Update pureconfig to version 0.11.1. URL: https://github.com/apache/openwhisk/pull/4736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4736: Update pureconfig to version 0.11.1.
codecov-io edited a comment on issue #4736: Update pureconfig to version 0.11.1. URL: https://github.com/apache/openwhisk/pull/4736#issuecomment-559129805 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=h1) Report > Merging [#4736](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/58c89764ccb8588045157605dac9a34a4a4ddfdc?src=pr=desc) will **decrease** coverage by `6.59%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4736 +/- ## = - Coverage 84.92% 78.32% -6.6% = Files 198 198 Lines8837 8837 Branches 606 604 -2 = - Hits 7505 6922-583 - Misses 1332 1915+583 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree) | Coverage Δ | | |---|---|---| | [...che/openwhisk/core/yarn/YARNContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUveWFybi9ZQVJOQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `87.5% <ø> (ø)` | :arrow_up: | | [...pache/openwhisk/core/entity/ConcurrencyLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0NvbmN1cnJlbmN5TGltaXQuc2NhbGE=) | `94.11% <ø> (ø)` | :arrow_up: | | [...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh) | `93.75% <ø> (ø)` | :arrow_up: | | [...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=) | `21.15% <ø> (ø)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `59.15% <ø> (ø)` | :arrow_up: | | [...abase/ArtifactWithFileStorageActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RXaXRoRmlsZVN0b3JhZ2VBY3RpdmF0aW9uU3RvcmUuc2NhbGE=) | `91.66% <ø> (ø)` | :arrow_up: | | [...a/org/apache/openwhisk/core/entity/TimeLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1RpbWVMaW1pdC5zY2FsYQ==) | `95.65% <ø> (ø)` | :arrow_up: | | [...sk/core/containerpool/logging/SplunkLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL1NwbHVua0xvZ1N0b3JlLnNjYWxh) | `84.61% <ø> (ø)` | :arrow_up: | | [.../containerpool/logging/ElasticSearchLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hMb2dTdG9yZS5zY2FsYQ==) | `96.15% <ø> (ø)` | :arrow_up: | | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `88.7% <ø> (ø)` | :arrow_up: | | ... and [59 more](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=footer). Last update [58c8976...c9d885e](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] [openwhisk-client-go] mrutkows opened a new issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool)
mrutkows opened a new issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool) URL: https://github.com/apache/openwhisk-client-go/issues/134 Please switch and document for developers how to use/build with "dep"; see https://github.com/golang/dep Please note that client-go chose to use govendor which has numerous problems: for reference: https://github.com/apache/openwhisk-client-go/pull/113/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-client-go] markusthoemmes commented on issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool)
markusthoemmes commented on issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool) URL: https://github.com/apache/openwhisk-client-go/issues/134#issuecomment-563382545 Why not go modules? All other golang dependency management tools are afaik deprecated in favor of it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] tysonnorris commented on a change in pull request #4593: Change ContainerPool buffer processing
tysonnorris commented on a change in pull request #4593: Change ContainerPool
buffer processing
URL: https://github.com/apache/openwhisk/pull/4593#discussion_r355713115
##
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##
@@ -173,7 +173,8 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
// from the buffer
val (_, newBuffer) = runBuffer.dequeue
runBuffer = newBuffer
- runBuffer.dequeueOption.foreach { case (run, _) => self ! run }
Review comment:
github is not showing this update 路♂
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-client-go] style95 commented on issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool)
style95 commented on issue #134: Deprecate godep in favor of "dep" (new official dep. mgmt. tool) URL: https://github.com/apache/openwhisk-client-go/issues/134#issuecomment-563672030 I also have felt the project structure of OpenWhisk cli families(client-go, cli, wskdeploy) is somewhat different from the other Go projects and I have wondered the reasons. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4698: Add healthcheck for Invoker -> Action Container
codecov-io edited a comment on issue #4698: Add healthcheck for Invoker -> Action Container URL: https://github.com/apache/openwhisk/pull/4698#issuecomment-550457551 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=h1) Report > Merging [#4698](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/bae8fb6e5b12e38b06c28a067567df6b0701b453?src=pr=desc) will **decrease** coverage by `6.52%`. > The diff coverage is `80.32%`. [](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4698 +/- ## == - Coverage 84.88% 78.35% -6.53% == Files 198 198 Lines8837 8931 +94 Branches 604 609 +5 == - Hits 7501 6998 -503 - Misses 1336 1933 +597 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cala/org/apache/openwhisk/core/yarn/YARNTask.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUveWFybi9ZQVJOVGFzay5zY2FsYQ==) | `70% <ø> (ø)` | :arrow_up: | | [...sk/core/containerpool/docker/DockerContainer.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyLnNjYWxh) | `96.47% <ø> (ø)` | :arrow_up: | | [...la/org/apache/openwhisk/core/mesos/MesosTask.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbWVzb3MvTWVzb3NUYXNrLnNjYWxh) | `73.8% <ø> (ø)` | :arrow_up: | | [...pache/openwhisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `87.65% <100%> (+0.15%)` | :arrow_up: | | [...la/org/apache/openwhisk/common/TransactionId.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9UcmFuc2FjdGlvbklkLnNjYWxh) | `93.65% <100%> (+0.1%)` | :arrow_up: | | [...whisk/core/containerpool/AkkaContainerClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Ba2thQ29udGFpbmVyQ2xpZW50LnNjYWxh) | `79.16% <100%> (+0.9%)` | :arrow_up: | | [...in/scala/org/apache/openwhisk/common/Logging.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `71.12% <100%> (-8.55%)` | :arrow_down: | | [.../containerpool/ApacheBlockingContainerClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9BcGFjaGVCbG9ja2luZ0NvbnRhaW5lckNsaWVudC5zY2FsYQ==) | `71.18% <100%> (+0.49%)` | :arrow_up: | | [.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.81% <100%> (+0.03%)` | :arrow_up: | | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `89.88% <76.13%> (-3.19%)` | :arrow_down: | | ... and [20 more](https://codecov.io/gh/apache/openwhisk/pull/4698/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=footer). Last update [bae8fb6...4f16165](https://codecov.io/gh/apache/openwhisk/pull/4698?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an
[GitHub] [openwhisk] style95 commented on issue #4724: Implement an ElasticSearchActivationStore
style95 commented on issue #4724: Implement an ElasticSearchActivationStore URL: https://github.com/apache/openwhisk/pull/4724#issuecomment-563700063 @chetanmeh Any other opinion on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
