[GitHub] dgrove-oss opened a new pull request #129: include running install-routemgmt Job in deployment steps
dgrove-oss opened a new pull request #129: include running install-routemgmt Job in deployment steps URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #109: Failed to create api for a java web action
dgrove-oss commented on issue #109: Failed to create api for a java web action URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/109#issuecomment-352132729 Made a little progress on this today with https://github.com/apache/incubator-openwhisk-deploy-kube/pull/123 Now failing with a different error: ``` daves-mbp-2:routemgmt dgrove$ wsk api create /api-demo/v1 /hello get hello --response-type json error: Unable to create API: API creation failure: API swagger generation error: TypeError: Cannot read property '2' of null ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet opened a new pull request #119: Add update lifecycle support
jasonpet opened a new pull request #119: Add update lifecycle support URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/119 Adds UPDATE lifecycle event to support updating parameters for alarms, interval and once feeds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on a change in pull request #2996: Rewrite WskBasicUsageTests
houshengbo commented on a change in pull request #2996: Rewrite
WskBasicUsageTests
URL:
https://github.com/apache/incubator-openwhisk/pull/2996#discussion_r157312663
##
File path: tests/src/test/scala/common/rest/WskRest.scala
##
@@ -1294,21 +1313,35 @@ class RunWskRestCmd() extends FlatSpec with RunWskCmd
with Matchers with ScalaFu
def convertMapIntoKeyValue(params: Map[String, JsValue],
feed: Option[String] = None,
- web: Option[String] = None): JsArray = {
+ web: Option[String] = None,
+ oldParams: Vector[JsObject] =
Vector[JsObject]()): JsArray = {
var paramsList = Vector[JsObject]()
params foreach { case (key, value) => paramsList :+= JsObject("key" ->
key.toJson, "value" -> value.toJson) }
paramsList = feed map { f =>
paramsList :+ JsObject("key" -> "feed".toJson, "value" -> f.toJson)
} getOrElse paramsList
+
+if (paramsList.size == 0) {
+ paramsList = oldParams
+}
Review comment:
The paramsList is not Vector[JsObject](), which is unable to convert to
JsArray.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss opened a new issue #128: db config via secrets/configmap
dgrove-oss opened a new issue #128: db config via secrets/configmap URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/128 Avoid hardwiring db credentials and configuration in various .yml files. Instead setup proper secrets and configmap during cluster-setup stage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new issue #127: Run OpenWhisk test suite against kube-based deployment
dgrove-oss opened a new issue #127: Run OpenWhisk test suite against kube-based deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/127 At first glance, I think we need to run the test suite as a Job within the cluster because some of the tests attempt to reach internal endpoints that intentionally aren't exposed outside the cluster. So, it might look something like a Job that does the following: 1. clone the openwhisk repo 2. generate a whisk.properties describing the deployment (use service names for hosts) 3. compile and run the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #118: synchronize nginx.conf with upstream file
dgrove-oss commented on issue #118: synchronize nginx.conf with upstream file URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/118#issuecomment-352124395 rebased & added cli redirects following PR https://github.com/apache/incubator-openwhisk/pull/3100 Closes #24 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3112: optional bypass of whisk.properties when setting GW_ values
dgrove-oss commented on issue #3112: optional bypass of whisk.properties when setting GW_ values URL: https://github.com/apache/incubator-openwhisk/pull/3112#issuecomment-352117043 PG2 2357 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #69: Do we want to support package deployment using kubectl ?
dgrove-oss commented on issue #69: Do we want to support package deployment using kubectl ? URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/69#issuecomment-352116612 I've put together #126 that installs the basic catalog using an official image published to dockerhub under the openwhisk id. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #126: define Job to install openwhisk-catalog
dgrove-oss opened a new pull request #126: define Job to install openwhisk-catalog URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/126 Define Job and associated Docker image to install the packages from incubator-openwhisk-catalog. Not referenced yet in top-level README.md and build.sh because we need to wait for Travis to publish the new image to Dockerhub first. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #125: build fix: Travis deploy step must be a single script
csantanapr closed pull request #125: build fix: Travis deploy step must be a single script URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index f47846a..62d05e4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,8 +22,6 @@ script: deploy: - provider: script - script: -- ./tools/travis/publish.sh openwhisk kube-couchdb latest docker/couchdb -- ./tools/travis/publish.sh openwhisk kube-routemgmt latest docker/routemgmt + script: ./tools/travis/deploy.sh on: branch: master diff --git a/tools/travis/deploy.sh b/tools/travis/deploy.sh new file mode 100755 index 000..8d27014 --- /dev/null +++ b/tools/travis/deploy.sh @@ -0,0 +1,14 @@ +#!/bin/bash + +set -x + +SCRIPTDIR=$(cd $(dirname "$0") && pwd) +ROOTDIR="$SCRIPTDIR/../../" + +cd $ROOTDIR + +echo "Publishing kube-couchdb image" +./tools/travis/publish.sh openwhisk kube-couchdb latest docker/couchdb + +echo "Publishing kube-routemgmt image" +./tools/travis/publish.sh openwhisk kube-routemgmt latest docker/routemgmt This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData
dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData URL: https://github.com/apache/incubator-openwhisk/pull/3109#discussion_r157277534 ## File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala ## @@ -190,7 +190,7 @@ trait WebActionsApiBaseTests extends ControllerTestCommon with BeforeAndAfterEac WhiskActionMetaData( actionName.path, actionName.name, - js6MetaData(), + js6MetaData(binary = false), Review comment: The binary field could be optional and default to a value of `false`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData
dubeejw commented on a change in pull request #3109: Add binary, image, and
main properties to WhiskActionMetaData
URL:
https://github.com/apache/incubator-openwhisk/pull/3109#discussion_r157281385
##
File path: tests/src/test/scala/whisk/core/entity/test/ExecHelpers.scala
##
@@ -80,6 +82,12 @@ trait ExecHelpers extends Matchers with WskActorSystem with
StreamLogging {
CodeExecAsAttachment(manifest, attachment, main.map(_.trim))
}
+ protected def javaMetaData(main: Option[String] = None, binary: Boolean) = {
Review comment:
`binary` can be optional and default to `true`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData
dubeejw commented on a change in pull request #3109: Add binary, image, and
main properties to WhiskActionMetaData
URL:
https://github.com/apache/incubator-openwhisk/pull/3109#discussion_r157281385
##
File path: tests/src/test/scala/whisk/core/entity/test/ExecHelpers.scala
##
@@ -80,6 +82,12 @@ trait ExecHelpers extends Matchers with WskActorSystem with
StreamLogging {
CodeExecAsAttachment(manifest, attachment, main.map(_.trim))
}
+ protected def javaMetaData(main: Option[String] = None, binary: Boolean) = {
Review comment:
`binary` can be optional and default to `true`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData
dubeejw commented on a change in pull request #3109: Add binary, image, and main properties to WhiskActionMetaData URL: https://github.com/apache/incubator-openwhisk/pull/3109#discussion_r157277534 ## File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala ## @@ -190,7 +190,7 @@ trait WebActionsApiBaseTests extends ControllerTestCommon with BeforeAndAfterEac WhiskActionMetaData( actionName.path, actionName.name, - js6MetaData(), + js6MetaData(binary = false), Review comment: The binary field could be optional and default to a value of `false`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #267: Add s390x provisions to Dockerfile
jonpspri commented on issue #267: Add s390x provisions to Dockerfile URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/267#issuecomment-352086143 Yep. Doing the merge and re-commit now. Hopefully that gives us a clean build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #234: requeue messages to kafka if subject is throttled
rabbah opened a new issue #234: requeue messages to kafka if subject is throttled URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/234 the provider today will retry post requests when the subject is throttled. this is limited however (6 retries, and on the order of a few minutes), after which the message is dropped if it's not posted successfully. the retry period is too short. more over it is generally better to requeue the messages rather than dropping them entirely. there already is no ordering guarantee so it requeue is no worse in that regard. it would also naturally extend the retry to longer periods. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #3113: extend namespaces api response to include current limits/quota
rabbah opened a new issue #3113: extend namespaces api response to include current limits/quota URL: https://github.com/apache/incubator-openwhisk/issues/3113 there isn't a way for a subject to check how much of their quota they've already consumed - we can potentially provide this information by extending the GET /namespaces api to include the current counts and limits for the subject. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #3109: Add binary, image, and main properties to WhiskActionMetaData
dubeejw commented on issue #3109: Add binary, image, and main properties to WhiskActionMetaData URL: https://github.com/apache/incubator-openwhisk/pull/3109#issuecomment-352075426 PG3 1548 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #125: build fix: Travis deploy step must be a single script
dgrove-oss opened a new pull request #125: build fix: Travis deploy step must be a single script URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/125 Fix bug introduced in 9f8e75d7 -- didn't read the Travis CI docs closely enough. The deploy step with the script provider must be a single script. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3112: optional bypass of whisk.properties when setting GW_ values
dgrove-oss commented on issue #3112: optional bypass of whisk.properties when setting GW_ values URL: https://github.com/apache/incubator-openwhisk/pull/3112#issuecomment-352071216 PG2 2537 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #3112: optional bypass of whisk.properties when setting GW_ values
dgrove-oss opened a new pull request #3112: optional bypass of whisk.properties when setting GW_ values URL: https://github.com/apache/incubator-openwhisk/pull/3112 If GW_USER, GW_PWD, or GW_HOST_V2 are already set in the environment when running installRouteMgmt.sh then use the value from the environment bypassing the values in whisk.properties. This is useful for downstream deployments such as kube to avoid the need to generate a whisk.properties just to run this script. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3104: Add TID stride configuration
rabbah commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352054768 Invokers don't generate tids, they receive them from the activation messages. They should only have system ids. The tid generation happens fairly early in the server - we could parse the nginx header at that point and stuff into the tid. https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/http/BasicHttpService.scala#L103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3104: Add TID stride configuration
rabbah commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352054768 Invokers don't generate tids, they receive them from the activation messages. They should only have system ids. The tid generation happens fairly early in the server - we could parse the nginx header at that point and stuff into the tid. https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/http/BasicHttpService.scala#L87 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new issue #124: version bump openwhisk/kube-couchdb to 2.1
dgrove-oss opened a new issue #124: version bump openwhisk/kube-couchdb to 2.1 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/124 Upstream changed to pulling apache/couchdb:2.1. Update kube accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3104: Add TID stride configuration
rabbah commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352054768 Invokers don't generate tids, they receive them from the activation messages. They should only have system ids. The tid generation happens fairly early in the server - we could parse the nginx header at that point and stuff into the tid. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3104: Add TID stride configuration
rabbah commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352054768 Invokers don't generate tids, they receive them from the activation messages. They should only have system ids. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3104: Add TID stride configuration
dgrove-oss commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352054688 If the default is in application.conf (instead of in ansible), then the downstream projects don't need to be changed. They'll get the new defaults automatically. That's why we're going to migrate as much as possible to using pureconfig. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #108: WHISK_API_HOST_NAME not set correctly in invoker.yml
rabbah commented on issue #108: WHISK_API_HOST_NAME not set correctly in invoker.yml URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/108#issuecomment-352054263 Closed by https://github.com/apache/incubator-openwhisk-deploy-kube/commit/9f8e75d7ac221c6314ad9bc2d2547baa9306ddf8. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #45: Install Route Management from the script
rabbah commented on issue #45: Install Route Management from the script URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/45#issuecomment-352054204 Closed by https://github.com/apache/incubator-openwhisk-deploy-kube/commit/9f8e75d7ac221c6314ad9bc2d2547baa9306ddf8. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #3104: Add TID stride configuration
dubeejw commented on issue #3104: Add TID stride configuration URL: https://github.com/apache/incubator-openwhisk/pull/3104#issuecomment-352051448 PG3 1542 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #673: Document command line flag strict
pritidesai opened a new issue #673: Document command line flag strict URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/673 Strict flag was added to adhere to run times specified in manifest YAML without going through any runtime validation on client. We need to document it?s usage and various use cases when this flag is useful. Also show the difference between deployments with and without this flag. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #123: add cluster-setup step to deployment workflow and Job to install routemgmt actions
dgrove-oss commented on issue #123: add cluster-setup step to deployment workflow and Job to install routemgmt actions URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/123#issuecomment-352049304 Closes #45 Closes #79 Closes #108 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #123: add cluster-setup step to deployment workflow and Job to install routemgmt actions
dgrove-oss commented on issue #123: add cluster-setup step to deployment workflow and Job to install routemgmt actions URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/123#issuecomment-351529281 WIP - not ready to merge yet. Created pull request early to validate travis changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #224: Provide a consistent set of descriptive errors.
mrutkows commented on issue #224: Provide a consistent set of descriptive errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/224#issuecomment-352024372 Fixed primarily in PR https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649/files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #672: Read Runtime JSON Payload from incubator-openwhisk
mrutkows commented on issue #672: Read Runtime JSON Payload from incubator-openwhisk URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/672#issuecomment-352023279 As we see there are issues that this endpoint was "broken" at some point > 3 weeks ago in ICF. See comments on issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/671 as well since they apply here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #671: Move Runtimes JSON Payload in Separate JSON file
mrutkows commented on issue #671: Move Runtimes JSON Payload in Separate JSON file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/671#issuecomment-352022999 Would be great if we could dynamically retrieve the (default) list (perhaps during build time) from https://github.com/apache/incubator-openwhisk/blob/master/ansible/group_vars/all In any event, we should at least sync with the list on a release-by-release basis. HOWEVER, we should be aware that not all deployments may use an ansible config. file for declaring supported runtimes (assuring an endpoint would be the best of course), but should still allow if -strict is not set a path to deploy actions that have runtimes/exts. we do not know. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3100: add remote_redirect mode for openwhisk_cli installation
dgrove-oss commented on issue #3100: add remote_redirect mode for openwhisk_cli installation URL: https://github.com/apache/incubator-openwhisk/pull/3100#issuecomment-352021726 @csantanapr @houshengbo -- reminder to review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #608: Invalid Runtime not detected / no error generated
mrutkows closed issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #669: wskdeploy runtime overhaul
mrutkows closed pull request #669: wskdeploy runtime overhaul
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/669
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cmd/root.go b/cmd/root.go
index fd0642d..eab75d2 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -146,9 +146,9 @@ func initConfig() {
func setSupportedRuntimes(apiHost string) {
op, error := utils.ParseOpenWhisk(apiHost)
if error == nil {
- utils.Rts = utils.ConvertToMap(op)
- } else {
- utils.Rts = utils.DefaultRts
+ utils.SupportedRunTimes = utils.ConvertToMap(op)
+ utils.DefaultRunTimes = utils.DefaultRuntimes(op)
+ utils.FileExtensionRuntimeKindMap =
utils.FileExtensionRuntimes(op)
}
}
diff --git a/parsers/manifest_parser.go b/parsers/manifest_parser.go
index 4a651c5..a7497b0 100644
--- a/parsers/manifest_parser.go
+++ b/parsers/manifest_parser.go
@@ -398,12 +398,13 @@ func (dm *YAMLParser)
ComposeActionsFromAllPackages(manifest *YAML, filePath str
func (dm *YAMLParser) ComposeActions(filePath string, actions
map[string]Action, packageName string, ma whisk.KeyValue)
([]utils.ActionRecord, error) {
+ const RUNTIME_ERR_MESSAGE = "Please specify any of the supported
runtime for zip actions in manifest YAML."
var errorParser error
+ var ext string
var s1 []utils.ActionRecord = make([]utils.ActionRecord, 0)
for key, action := range actions {
splitFilePath := strings.Split(filePath,
string(os.PathSeparator))
-
// set the name of the action (which is the key)
action.Name = key
@@ -422,6 +423,7 @@ func (dm *YAMLParser) ComposeActions(filePath string,
actions map[string]Action,
//bind action, and exposed URL
if action.Function != "" {
+
filePath := strings.TrimRight(filePath,
splitFilePath[len(splitFilePath)-1]) + action.Function
if utils.IsDirectory(filePath) {
@@ -433,28 +435,27 @@ func (dm *YAMLParser) ComposeActions(filePath string,
actions map[string]Action,
defer os.Remove(zipName)
// To do: support docker and main entry as did
by go cli?
wskaction.Exec, err = utils.GetExec(zipName,
action.Runtime, false, "")
+ if err != nil {
+ return nil, err
+ }
} else {
- ext := path.Ext(filePath)
- var kind string
+ ext = path.Ext(filePath)
+ // drop the "." from file extension
+ if len(ext) > 0 && ext[0] == '.' {
+ ext = ext[1:]
+ }
- switch ext {
- case ".swift":
- kind = "swift:3.1.1"
- case ".js":
- kind = "nodejs:6"
- case ".py":
- kind = "python"
- case ".java":
- kind = "java"
- case ".php":
- kind = "php:7.1"
- case ".jar":
- kind = "java"
- default:
- kind = "nodejs:6"
- errStr := wski18n.T("Unsupported
runtime type, set to nodejs")
- whisk.Debug(whisk.DbgWarn, errStr)
- // TODO() add the user input kind here if
interactive
+ // determine default runtime for the given file
extension
+ var kind string
+ r := utils.FileExtensionRuntimeKindMap[ext]
+ kind = utils.DefaultRunTimes[r]
+
+ // produce an error when a runtime could not be
derived from the action file extension
+ // and its not explicitly specified in the
manifest YAML file
+ // and action source is not a zip file
+ if len(kind) == 0 && len(action.Runtime) == 0
&& ext != utils.ZIP_FILE_EXTENSION {
+ errMessage := "ERROR: Failed to
discover
[GitHub] mrutkows closed issue #636: Updates needed to support Swift 3.1.1 and deprecate 3.0
mrutkows closed issue #636: Updates needed to support Swift 3.1.1 and deprecate 3.0 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/636 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #647: Update runtimes (kinds) to match latest versions
mrutkows closed issue #647: Update runtimes (kinds) to match latest versions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/647 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3111: Replace our own clients with akka-streams-kafka.
markusthoemmes opened a new pull request #3111: Replace our own clients with akka-streams-kafka. URL: https://github.com/apache/incubator-openwhisk/pull/3111 Inspired by @devbv's awesome contributions (thanks ? ) with regards to Kafka clustering, we tried to replace our self-written Kafka abstractions with akka-streams based kafka clients from Lightbend. This is the outcome of that experiment, it still contains a couple of todos but opening the PR early to gather feedback. **Important:** As @devbv correctly noted, not all cases are handled by these clients either. They are rather passed to the user to handle. We're in discussions with Lightbend to contribute a more resilient version of their flows if those play out to be production-ready. In general we found the interface to be much much nicer and it gets rid of a lot of code and tests that we'd need to do ourselves. **TODO:** - [ ] Backoff strategies for retries - [ ] Handle `offer` error cases This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
