[GitHub] style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy
style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-389749094 Could anyone trigger the build again please? It seems failing test is not related to my changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r188840143 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ## @@ -204,26 +204,25 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, * @param kind the kind you want to invoke * @return the container iff found */ - def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = -prewarmConfig.flatMap { config => - val kind = action.exec.kind - val memory = action.limits.memory.megabytes.MB - prewarmedPool -.find { - case (_, PreWarmedData(_, `kind`, `memory`)) => true - case _ => false -} -.map { - case (ref, data) => -// Move the container to the usual pool -freePool = freePool + (ref -> data) -prewarmedPool = prewarmedPool - ref -// Create a new prewarm container -prewarmContainer(config.exec, config.memoryLimit) + def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = { +val kind = action.exec.kind +val memory = action.limits.memory.megabytes.MB +prewarmedPool + .find { +case (_, PreWarmedData(_, `kind`, `memory`)) => true +case _ => false + } + .map { +case (ref, data) => + // Move the container to the usual pool + freePool = freePool + (ref -> data) + prewarmedPool = prewarmedPool - ref + // Create a new prewarm container + prewarmContainer(action.exec, memory) Review comment: i don't like the use of action.exec here - it leaves the door open to leaking init code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3668: Fixes asymmetry between reading and writing of ByteSize.
codecov-io commented on issue #3668: Fixes asymmetry between reading and writing of ByteSize. URL: https://github.com/apache/incubator-openwhisk/pull/3668#issuecomment-389741389 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=h1) Report > Merging [#3668](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3668 +/- ## == + Coverage 74.49% 74.49% +<.01% == Files 126 126 Lines5990 5994 +4 Branches 390 392 +2 == + Hits 4462 4465 +3 - Misses 1528 1529 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `97.82% <100%> (+0.2%)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=footer). Last update [ed71ee0...041b2c6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3668: Fixes asymmetry between reading and writing of ByteSize.
rabbah opened a new pull request #3668: Fixes asymmetry between reading and writing of ByteSize. URL: https://github.com/apache/incubator-openwhisk/pull/3668 Constructing a ByteSize form String will accept MB or M, KB or K (and is case insenstive). This is to match the toString method which writes out the units as MB or KB (so that a serialized value can be parsed back to the identity). ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [x] Controller - ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r188826249 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ## @@ -204,26 +204,25 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, * @param kind the kind you want to invoke * @return the container iff found */ - def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = -prewarmConfig.flatMap { config => - val kind = action.exec.kind - val memory = action.limits.memory.megabytes.MB - prewarmedPool -.find { - case (_, PreWarmedData(_, `kind`, `memory`)) => true - case _ => false -} -.map { - case (ref, data) => -// Move the container to the usual pool -freePool = freePool + (ref -> data) -prewarmedPool = prewarmedPool - ref -// Create a new prewarm container -prewarmContainer(config.exec, config.memoryLimit) + def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = { +val kind = action.exec.kind +val memory = action.limits.memory.megabytes.MB +prewarmedPool + .find { +case (_, PreWarmedData(_, `kind`, `memory`)) => true Review comment: @tysonnorris this is semantic preserving - the stem cell today is only used if the memory slot matches exactly. I suggest opening a separate issue to configure a memory slop factor for the stem cell matching. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #298: Allow CLI build to write results to any specified directory
rabbah opened a new pull request #298: Allow CLI build to write results to any specified directory URL: https://github.com/apache/incubator-openwhisk-cli/pull/298 A small change to allow the CLI build directory to be overridden from the command line. Default to current value if none specified. @jonpspri would you mind taking a look please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3667: post.lua fails in wrk tests
tysonnorris commented on issue #3667: post.lua fails in wrk tests URL: https://github.com/apache/incubator-openwhisk/issues/3667#issuecomment-389713678 This does not seem to happen with travis, but happens consistently locally (macos) and reverting this extra linebreak fixes it locally: https://github.com/apache/incubator-openwhisk/commit/3c12c2f3b8a36d3f9800251ec35aae687916f3f6#diff-96ee228ccd3e09e5e9519e18480b7719L1 Is anyone able to confirm proper running of wrk tests on macos? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #200: add ingress configuration for IBM Cloud Standard Clusters to Helm deploy
csantanapr closed pull request #200: add ingress configuration for IBM Cloud Standard Clusters to Helm deploy URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/200 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/helm/README.md b/helm/README.md index c774a2e..83383aa 100644 --- a/helm/README.md +++ b/helm/README.md @@ -77,26 +77,26 @@ you want to be an invoker, execute $ kubectl label nodes openwhisk-role=invoker ``` -### Step 4. Deploy Charts -You will need to create a mycluster.yaml file that specifies the host -and port information that will be used to access your cluster. See -the [ingress discussion](../kubernetes/ingress/README.md) for -details. Below is a sample file appropriate for a minikube cluster -where `minikube ip` returns `192.168.99.100`. +### Step 4. Define `mycluster.yaml` + +You will need to create a mycluster.yaml file that records how the +OpenWhisk deployment on your cluster will be accessed by clients. See +the [ingress discussion](./ingress.md) for details. Below is a sample +file appropriate for a minikube cluster where `minikube ip` returns +`192.168.99.100` and port 31001 is available to be used. ```yaml whisk: ingress: +type: NodePort api_host: 192.168.99.100:31001 -apigw_url: http://192.168.99.100:31004 nginx: httpsNodePort: 31001 - -apigw: - apiNodePort: 31004 ``` +### Step 5. Deploy Charts + Deployment can be done by using the following single command: ```shell helm install . --namespace=openwhisk --name=your_release_name -f mycluster.yaml @@ -107,18 +107,19 @@ After a while, if you can see all the pods listed by the following command are i kubectl get pods -n openwhisk ``` -### Test Deployment +### Step 6. Configure the `wsk` CLI -Install an [OpenWhisk client](https://github.com/apache/incubator-openwhisk/tree/master/docs) to test the deployed OpenWhisk environment. - -For now, we are using nginx to provide web access for OpenWhisk client. By default, the nginx service is configured to run at port 31000 for HTTP connection and 31001 for HTTPS connection. - -As a result, please run the following command to config your OpenWhisk client: +Configure the OpenWhisk CLI, wsk, by setting the auth and apihost +properties (if you don't already have the wsk cli, follow the +instructions [here](https://github.com/apache/incubator-openwhisk-cli) +to get it). ```shell -wsk property set --apihost http://:31000 +wsk property set --apihost wsk property set --auth 23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP ``` +### Step 7. Test your Deployment + Prepare a small js function like the following and save it to `greeting.js`: ```js /** diff --git a/helm/ingress.md b/helm/ingress.md new file mode 100644 index 000..ce3459a --- /dev/null +++ b/helm/ingress.md @@ -0,0 +1,131 @@ + + +Ingress +--- + +Defining a Kubernetes Ingress is what makes the OpenWhisk system you +are going to deploy available outside of your Kubernetes cluster. When +you select an ingress method, you are determining what values to use +for the `whisk.ingress` stanza of your `mycluster.yaml` file that you +will use in the `helm install` command. You will need to define +values for at least `whisk.ingress.type` and `whisk.ingress.api_host`. + +Unfortunately, the exact details of configuring an Ingress vary across +cloud providers. The detailed instructions +[below](#possible-ingress-types) describe multiple possible Ingress +configurations. We welcome contributions from the community to +describe how to configure Ingress for additional cloud providers. + +If you are deploying on minikube, use the NodePort instructions below. + +# Possible Ingress Types + +## NodePort + +NodePort is the simplest type of Ingress and is suitable for use with +minikube and single node clusters that do not support more advanced +ingress options. Deploying a NodePort ingress will expose a port on +each Kubernetes worker node for OpenWhisk's nginx service. +In this Ingress, TLS termination will be handled by OpenWhisk's +`nginx` service and will use self-signed certificates. You will need +to invoke `wsk` with the `-i` command line argument to bypass +certificate checking. + +First, obtain the IP address of the Kubernetes nodes. If you are +using minikube, use the command +```shell +minikube ip +``` +otherwise use +``` +kubectl get nodes +``` + +Next pick an unassigned port (eg 31001) and define mycluster.yaml as +```yaml +whisk: + ingress: +type: NodePort +api_host: 192.168.99.100:31001 + +nginx: + httpsNodePort: 31001 +``` + +## IBM Cloud + +### IBM Cloud Lite cluster + +The only available ingress method for a Lite cluster is to use a +NodePort (see above).
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/84e906bfcb73514fc8ff87f088ec2b917f20b397?src=pr=desc) will **increase** coverage by `0.13%`. > The diff coverage is `84.74%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2795 +/- ## == + Coverage 74.49% 74.63% +0.13% == Files 126 126 Lines5990 6019 +29 Branches 390 399 +9 == + Hits 4462 4492 +30 + Misses 1528 1527 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `93.33% <100%> (+0.83%)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `92.67% <100%> (+0.85%)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <100%> (ø)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.61% <80%> (-1.27%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [84e906b...d694f93](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #200: add ingress configuration for IBM Cloud Standard Clusters to Helm deploy
dgrove-oss commented on issue #200: add ingress configuration for IBM Cloud Standard Clusters to Helm deploy URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/200#issuecomment-389695868 with some guidance from @mdeuser I reworked the ibm ingress rules and apigateway is now working for me. May need some adjustments to nginx.conf to get apigateway to work on minikube with NodePort; will tackle that in separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #125: Use configured protocol for API requests
dgrove-oss commented on issue #125: Use configured protocol for API requests URL: https://github.com/apache/incubator-openwhisk-cli/issues/125#issuecomment-389695021 I just got bit by this today when trying to use `wsk api create` with a .wskprops that was "misconfigured" to have `APIHOST=https://MY_HOST` instead of `APIHOST=MY_HOST`. The symptom was that invoking the resulting APIs gave a 502 (bad gateway) because the created actions were given the url `https://https://MY_HOST/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/84e906bfcb73514fc8ff87f088ec2b917f20b397?src=pr=desc) will **increase** coverage by `0.15%`. > The diff coverage is `84.74%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/graphs/tree.svg?width=650=pr=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2795 +/- ## == + Coverage 74.49% 74.64% +0.15% == Files 126 126 Lines5990 6019 +29 Branches 390 399 +9 == + Hits 4462 4493 +31 + Misses 1528 1526 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `92.67% <100%> (+0.85%)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <100%> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `93.33% <100%> (+0.83%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.61% <80%> (-1.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [84e906b...d694f93](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris opened a new issue #3667: post.lua fails in wrk tests
tysonnorris opened a new issue #3667: post.lua fails in wrk tests URL: https://github.com/apache/incubator-openwhisk/issues/3667 ## Environment details: * local deployment (trying to verify in travis by enabling log collection for perf tests) ## Steps to reproduce the issue: 1. run wrk perf tests: `./performance/wrk_tests/throughput.sh "https://192.168.99.100:10001; "$(cat ansible/files/auth.guest)" ./performance/preparation/actions/async.js 100 5 10s` 2. notice errors from wrk: `post.lua: post.lua:1: unexpected symbol` 3. (note: the error is output to stderr) I think this is due to: https://github.com/apache/incubator-openwhisk/commit/3c12c2f3b8a36d3f9800251ec35aae687916f3f6#diff-96ee228ccd3e09e5e9519e18480b7719L1 locally, it works fine if I remove the extra linebreak ## Provide the expected results and outputs: no errors I will verify in an updated PR with log collection enabled, and create a separate PR for this fix, it is is seen there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3665: Allow for init to specify if artifact should be treated as binary
csantanapr closed pull request #3665: Allow for init to specify if artifact should be treated as binary URL: https://github.com/apache/incubator-openwhisk/pull/3665 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/actionRuntimes/actionProxy/invoke.py b/actionRuntimes/actionProxy/invoke.py index 1b3b47142a..80f64a6e53 100755 --- a/actionRuntimes/actionProxy/invoke.py +++ b/actionRuntimes/actionProxy/invoke.py @@ -76,6 +76,7 @@ def parseArgs(): subparsers = parser.add_subparsers(title='available commands', dest='cmd') initmenu = subparsers.add_parser('init', help='initialize container with src or zip/tgz file') +initmenu.add_argument('-b', '--binary', help='treat artifact as binary', action='store_true') initmenu.add_argument('main', nargs='?', default='main', help='name of the "main" entry method for the action') initmenu.add_argument('artifact', help='a source file or zip/tgz archive') @@ -90,7 +91,7 @@ def init(args): main = args.main artifact = args.artifact -if artifact and (artifact.endswith('.zip') or artifact.endswith('tgz') or artifact.endswith('jar')): +if artifact and (args.binary or artifact.endswith('.zip') or artifact.endswith('tgz') or artifact.endswith('jar')): with open(artifact, 'rb') as fp: contents = fp.read() contents = base64.b64encode(contents) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #10: Can't run tests in OSX
csantanapr commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-389685837 Running a second time after failure above ^^ now it works ``` $ gradle test --info Initialized native services in: /Users/csantana23/.gradle/native The client will now receive all logging from the daemon (pid: 81040). The daemon log file: /Users/csantana23/.gradle/daemon/4.7/daemon-81040.out.log Starting 12th build in daemon [uptime: 1 hrs 29 mins 49.093 secs, performance: 99%, no major garbage collections] Using 8 worker leases. Starting Build Settings evaluated using settings file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/settings.gradle'. Projects loaded. Root project using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Included projects: [root project 'runtime-golang', project ':actionProxyLoop', project ':golang1.10'] > Configure project : Evaluating root project 'runtime-golang' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Found go 1.10.2 in /Users/csantana23/.gimme/versions/go1.10.2.darwin.amd64/bin/go, use it. > Configure project :actionProxyLoop Evaluating project ':actionProxyLoop' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/actionProxyLoop/build.gradle'. > Configure project :golang1.10 Evaluating project ':golang1.10' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/golang1.10/build.gradle'. All projects evaluated. Selected primary task 'test' from project : Tasks to be executed: [task ':prepare', task ':resolveBuildDependencies', task ':resolveTestDependencies', task ':installDependencies', task ':vendor', task ':test'] :prepare (Thread[Task worker for ':',5,main]) started. > Task :prepare Task ':prepare' is not up-to-date because: Task has not declared any outputs despite executing actions. Use project GOPATH: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath :prepare (Thread[Task worker for ':',5,main]) completed. Took 0.0 secs. :resolveBuildDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveBuildDependencies UP-TO-DATE Skipping task ':resolveBuildDependencies' as it is up-to-date. :resolveBuildDependencies (Thread[Task worker for ':',5,main]) completed. Took 0.005 secs. :resolveTestDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveTestDependencies UP-TO-DATE Skipping task ':resolveTestDependencies' as it is up-to-date. :resolveTestDependencies (Thread[Task worker for ':',5,main]) completed. Took 0.004 secs. :installDependencies (Thread[Task worker for ':',5,main]) started. > Task :installDependencies Task ':installDependencies' is not up-to-date because: Task has not declared any outputs despite executing actions. /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/BurntSushi/toml is up-to-date, skip installing github.com/BurntSushi/toml#a368813c5e648fee92e5f6c30e3944ff9d5e8895 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/apache/incubator-openwhisk-client-go is up-to-date, skip installing github.com/apache/incubator-openwhisk-client-go#e452b524cd745f71c913c5acccf72a8daba6dc71 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/cloudfoundry/jibber_jabber is up-to-date, skip installing github.com/cloudfoundry/jibber_jabber#bcc4c8345a21301bf47c032ff42dd1aae2fe3027 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/davecgh/go-spew is up-to-date, skip installing github.com/davecgh/go-spew:github.com/stretchr/testify#12b6f73e6084dad08a7c6e575284b177ecafbc71/vendor/github.com/davecgh/go-spew /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/fatih/color is up-to-date, skip installing github.com/fatih/color#2d684516a8861da43017284349b7e303e809ac21 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/google/go-querystring is up-to-date, skip installing github.com/google/go-querystring#53e6ce116135b80d037921a7fdd5138cf32d7a8a /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/h2non/filetype is up-to-date, skip installing github.com/h2non/filetype#cc14fdc9ca0e4c2bafad7458f6ff79fd3947cfbb /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/hokaccha/go-prettyjson is up-to-date, skip installing
[GitHub] csantanapr commented on issue #10: Can't run tests in OSX
csantanapr commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-389685520 With latest from master 1 test is failing. I deleted the directory and did a new git clone. It looks like is random which test fails ``` $ gradle test --info Initialized native services in: /Users/csantana23/.gradle/native The client will now receive all logging from the daemon (pid: 81040). The daemon log file: /Users/csantana23/.gradle/daemon/4.7/daemon-81040.out.log Starting 11th build in daemon [uptime: 1 hrs 26 mins 21.684 secs, performance: 99%, no major garbage collections] Using 8 worker leases. Starting Build Settings evaluated using settings file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/settings.gradle'. Projects loaded. Root project using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Included projects: [root project 'runtime-golang', project ':actionProxyLoop', project ':golang1.10'] > Configure project : Evaluating root project 'runtime-golang' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Found go 1.10.2 in /Users/csantana23/.gimme/versions/go1.10.2.darwin.amd64/bin/go, use it. > Configure project :actionProxyLoop Evaluating project ':actionProxyLoop' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/actionProxyLoop/build.gradle'. > Configure project :golang1.10 Evaluating project ':golang1.10' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/golang1.10/build.gradle'. All projects evaluated. Selected primary task 'test' from project : Tasks to be executed: [task ':prepare', task ':resolveBuildDependencies', task ':resolveTestDependencies', task ':installDependencies', task ':vendor', task ':test'] :prepare (Thread[Task worker for ':',5,main]) started. > Task :prepare Task ':prepare' is not up-to-date because: Task has not declared any outputs despite executing actions. Use project GOPATH: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath :prepare (Thread[Task worker for ':',5,main]) completed. Took 0.0 secs. :resolveBuildDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveBuildDependencies UP-TO-DATE Skipping task ':resolveBuildDependencies' as it is up-to-date. :resolveBuildDependencies (Thread[Task worker for ':',5,main]) completed. Took 0.004 secs. :resolveTestDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveTestDependencies UP-TO-DATE Skipping task ':resolveTestDependencies' as it is up-to-date. :resolveTestDependencies (Thread[Task worker for ':',5,main]) completed. Took 0.004 secs. :installDependencies (Thread[Task worker for ':',5,main]) started. > Task :installDependencies Task ':installDependencies' is not up-to-date because: Task has not declared any outputs despite executing actions. /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/BurntSushi/toml is up-to-date, skip installing github.com/BurntSushi/toml#a368813c5e648fee92e5f6c30e3944ff9d5e8895 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/apache/incubator-openwhisk-client-go is up-to-date, skip installing github.com/apache/incubator-openwhisk-client-go#e452b524cd745f71c913c5acccf72a8daba6dc71 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/cloudfoundry/jibber_jabber is up-to-date, skip installing github.com/cloudfoundry/jibber_jabber#bcc4c8345a21301bf47c032ff42dd1aae2fe3027 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/davecgh/go-spew is up-to-date, skip installing github.com/davecgh/go-spew:github.com/stretchr/testify#12b6f73e6084dad08a7c6e575284b177ecafbc71/vendor/github.com/davecgh/go-spew /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/fatih/color is up-to-date, skip installing github.com/fatih/color#2d684516a8861da43017284349b7e303e809ac21 /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/google/go-querystring is up-to-date, skip installing github.com/google/go-querystring#53e6ce116135b80d037921a7fdd5138cf32d7a8a /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/vendor/github.com/h2non/filetype is up-to-date, skip installing github.com/h2non/filetype#cc14fdc9ca0e4c2bafad7458f6ff79fd3947cfbb
[GitHub] houshengbo commented on issue #288: Apache release does not allow to have private license as the header
houshengbo commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-389668739 This issue can be closed, since all the headers have been changed to comply Apache policies. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #288: Apache release does not allow to have private license as the header
houshengbo closed issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #294: Fix the copyryright IBM issue in the headers
houshengbo commented on issue #294: Fix the copyryright IBM issue in the headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/294#issuecomment-389668534 This issue has been closed, since all the headers have been changed to the Apache header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #294: Fix the copyryright IBM issue in the headers
houshengbo closed issue #294: Fix the copyryright IBM issue in the headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/294 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389667020 @csantanapr here are two more explicit use cases. 1) The OW system currently supports nodejs kinds in the system manifest. However, as a platform provider there is a need to periodically add support for additional kinds without allowing use across the entire system. Initially we want to restrict these kinds to certain namespaces which are owned and controlled by approved maintainers of the system. 2) We need to restrict the use of `blackbox` kinds to a namespace containing provider-owned actions which are usable by others within the system. Only actions in these namespaces should be allowed to be created as `blackbox` kinds. Eventually, this could be handled at an IAM/ACL/oauth level. However, there is no such construct available today. Also, the use cases do not explicitly require a per-subject set of ACLs. I see two separate tasks here: 1) Support system-level configuration of how new functionality can be rolled out. 2) Support per-subject IAM and oauth for more granular permissions and entitlement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389667020 @csantanapr here's are two more explicit use cases. 1) The OW system currently supports nodejs kinds in the system manifest. However, as a platform provider there is a need to periodically add support for additional kinds without allowing use across the entire system. Initially we want to restrict these kinds to certain namespaces which are owned and controlled by maintainers of the system. 2) We need to restrict the use of `blackbox` kinds to a namespace containing provider-owned actions which are usable by others within the system. Only actions in these namespaces should be allowed to be created as blackbox kinds. Eventually, this could be handled at an IAM/ACL/oauth level. However, there is no such construct available today. The use cases do not require a per-subject set of ACLs for this particular PR. I see two separate tasks here: 1) Support system-level configuration of how new functionality can be rolled out. 2) Support per-subject IAM and oauth for more granular permissions and entitlement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #86: Remove the disclaimer and the reference as experimental
houshengbo opened a new pull request #86: Remove the disclaimer and the reference as experimental URL: https://github.com/apache/incubator-openwhisk-client-go/pull/86 Closes: #82 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/22c0807b9eae20af9acc70b91a1943dd35a95092?src=pr=desc) will **increase** coverage by `0.1%`. > The diff coverage is `82.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/graphs/tree.svg?height=150=pr=650=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff@@ ## master#2795 +/- ## = + Coverage 74.49% 74.59% +0.1% = Files 126 126 Lines5990 6019 +29 Branches 390 395 +5 = + Hits 4462 4490 +28 - Misses 1528 1529 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `93.33% <100%> (+0.83%)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <100%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `92.67% <100%> (+0.85%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `81.31% <70.58%> (-4.57%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [22c0807...7df5e10](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #24: Pin go dependencies
csantanapr commented on issue #24: Pin go dependencies URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/24#issuecomment-389655999 Close by #30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #24: Pin go dependencies
csantanapr closed issue #24: Pin go dependencies URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/24 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #25: Update Apache license with third party content
csantanapr commented on issue #25: Update Apache license with third party content URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/25#issuecomment-389655950 Close by #30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #25: Update Apache license with third party content
csantanapr closed issue #25: Update Apache license with third party content URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/25 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #30: Fixes for #10, #24 and #25
csantanapr closed pull request #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index a35ea03..cacf376 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ vendor/ actionProxyLoop/proxy golang1.10/proxy openwhisk/_test/exec +openwhisk/_test/exec.go openwhisk/_test/hi openwhisk/_test/hello_greeting openwhisk/_test/hello_message diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c29a74e..0f7f858 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,19 +1,19 @@ -[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0) @@ -36,18 +36,18 @@ Instructions on how to do this can be found here: [http://www.apache.org/licenses/#clas](http://www.apache.org/licenses/#clas) Once submitted, you will receive a confirmation email from the Apache Software Foundation (ASF) and be added to -the following list: http://people.apache.org/unlistedclas.html. +the following list: http://people.apache.org/unlistedclas.html. Project committers will use this list to verify pull requests (PRs) come from contributors that have signed a CLA. -We look forward to your contributions! +We look forward to your contributions! ## Raising issues -Please raise any bug reports or enhancement requests on the respective project repository's GitHub issue tracker. Be sure to search the +Please raise any bug reports or enhancement requests on the respective project repository's GitHub issue tracker. Be sure to search the list to see if your issue has already been raised. -A good bug report is one that make it easy for us to understand what you were trying to do and what went wrong. +A good bug report is one that make it easy for us to understand what you were trying to do and what went wrong. Provide as much context as possible so we can try to recreate the issue. A good enhancement request comes with an explanation of what you are trying to do and how that enhancement would help you. diff --git a/LICENSE-filetype.txt b/LICENSE-filetype.txt new file mode 100644 index 000..c03a05c --- /dev/null +++ b/LICENSE-filetype.txt @@ -0,0 +1,25 @@ +The MIT License + +Copyright (c) Tomas Aparicio + +Permission is hereby granted, free of charge, to any person +obtaining a copy of this software and associated documentation +files (the "Software"), to deal in the Software without +restriction, including without limitation the rights to use, +copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the +Software is furnished to do so, subject to the following +conditions: + +The above copyright notice and this permission notice shall be +included in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES +OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND +NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT +HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, +WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +OTHER DEALINGS IN THE SOFTWARE. + diff --git a/LICENSE-testify.txt b/LICENSE-testify.txt new file mode 100644 index 000..8b79c3f --- /dev/null +++ b/LICENSE-testify.txt @@ -0,0 +1,22 @@ +Copyright (c) 2012 - 2013 Mat Ryer and Tyler Bunnell + +Please consider promoting this project if you find it useful. + +Permission is hereby granted, free of charge, to any person +obtaining a copy of this software and associated documentation +files (the "Software"), to deal in the Software without restriction, +including without limitation the rights to use, copy, modify, merge, +publish, distribute, sublicense, and/or sell copies of the Software, +and to permit persons to whom the Software is furnished to do so, +subject to the following conditions: + +The above copyright notice and this permission notice shall be included +in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES +OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. +IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT +OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE +OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. \ No newline at end of file diff --git a/LICENSE.txt b/LICENSE.txt
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389655786 going to merge but leave the #10 still open This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389655659 Even with latest changes is still fails on OSX $ ./gradlew test --info Initialized native services in: /Users/csantana23/.gradle/native The client will now receive all logging from the daemon (pid: 82077). The daemon log file: /Users/csantana23/.gradle/daemon/4.1/daemon-82077.out.log Starting 13th build in daemon [uptime: 13 mins 43.636 secs, performance: 100%, no major garbage collections] Using 8 worker leases. Creating new cache for fileHashes, path /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gradle/4.1/fileHashes/fileHashes.bin, access org.gradle.cache.internal.DefaultCacheAccess@130b807d Creating new cache for plugin-use-metadata, path /Users/csantana23/.gradle/caches/4.1/plugin-resolution/plugin-use-metadata.bin, access org.gradle.cache.internal.DefaultCacheAccess@205c34b8 Creating new cache for client-status, path /Users/csantana23/.gradle/caches/4.1/plugin-resolution/client-status.bin, access org.gradle.cache.internal.DefaultCacheAccess@205c34b8 Starting Build Settings evaluated using settings file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/settings.gradle'. Projects loaded. Root project using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Included projects: [root project 'runtime-golang', project ':actionProxyLoop', project ':golang1.10'] > Configure project : Evaluating root project 'runtime-golang' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/build.gradle'. Creating new cache for metadata-1.1/results, path /Users/csantana23/.gradle/caches/transforms-1/metadata-1.1/results.bin, access org.gradle.cache.internal.DefaultCacheAccess@665c66ed Creating new cache for metadata-2.23/module-metadata, path /Users/csantana23/.gradle/caches/modules-2/metadata-2.23/module-metadata.bin, access org.gradle.cache.internal.DefaultCacheAccess@1d852969 Creating new cache for metadata-2.23/artifact-at-repository, path /Users/csantana23/.gradle/caches/modules-2/metadata-2.23/artifact-at-repository.bin, access org.gradle.cache.internal.DefaultCacheAccess@1d852969 Found go 1.10.2 in /Users/csantana23/.gimme/versions/go1.10.2.darwin.amd64/bin/go, use it. > Configure project :actionProxyLoop Evaluating project ':actionProxyLoop' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/actionProxyLoop/build.gradle'. > Configure project :golang1.10 Evaluating project ':golang1.10' using build file '/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/golang1.10/build.gradle'. All projects evaluated. Selected primary task 'test' from project : Tasks to be executed: [task ':prepare', task ':resolveBuildDependencies', task ':resolveTestDependencies', task ':installDependencies', task ':vendor', task ':test'] Creating new cache for resourceHashesCache, path /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gradle/4.1/fileHashes/resourceHashesCache.bin, access org.gradle.cache.internal.DefaultCacheAccess@130b807d Creating new cache for fileSnapshots, path /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gradle/4.1/taskHistory/fileSnapshots.bin, access org.gradle.cache.internal.DefaultCacheAccess@602a49c8 Creating new cache for taskHistory, path /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gradle/4.1/taskHistory/taskHistory.bin, access org.gradle.cache.internal.DefaultCacheAccess@602a49c8 :prepare (Thread[Task worker for ':',5,main]) started. > Task :prepare Putting task artifact state for task ':prepare' into context took 0.0 secs. Executing task ':prepare' (up-to-date check took 0.0 secs) due to: Task has not declared any outputs. Use project GOPATH: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath :prepare (Thread[Task worker for ':',5,main]) completed. Took 0.0 secs. :resolveBuildDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveBuildDependencies Putting task artifact state for task ':resolveBuildDependencies' into context took 0.0 secs. Skipping task ':resolveBuildDependencies' as it is up-to-date (took 0.013 secs). :resolveBuildDependencies (Thread[Task worker for ':',5,main]) completed. Took 0.026 secs. :resolveTestDependencies (Thread[Task worker for ':',5,main]) started. > Task :resolveTestDependencies Putting task artifact state for task ':resolveTestDependencies' into context took 0.0 secs. Skipping task
[GitHub] matthewpflueger commented on issue #124: Docker Compose limiting action size to 512KB?
matthewpflueger commented on issue #124: Docker Compose limiting action size to 512KB? URL: https://github.com/apache/incubator-openwhisk-devtools/issues/124#issuecomment-389646279 Any workaround for this? This issue prevents me from using openwhisk locally... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389644665 @sciabarra 2 tests are failing in Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389643874 I'm not using VSCode to run the tests, just using terminal windows and executing `./gradlew test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #198: Add minified Apache license header to all yaml and yml files
mrutkows closed pull request #198: Add minified Apache license header to all yaml and yml files URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/198 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/helm/Chart.yaml b/helm/Chart.yaml index 4a3f712..889345c 100644 --- a/helm/Chart.yaml +++ b/helm/Chart.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + apiVersion: v1 description: A Helm chart to deploy Apache OpenWhisk for Kubernetes name: openwhisk diff --git a/helm/templates/_affinity.tpl b/helm/templates/_affinity.tpl index efa0d73..237bdc5 100644 --- a/helm/templates/_affinity.tpl +++ b/helm/templates/_affinity.tpl @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # This file defines template snippets for scheduler affinity and anti-affinity {{/* Generic core affinity */}} diff --git a/helm/templates/_helpers.tpl b/helm/templates/_helpers.tpl index 917d311..ddffc1a 100644 --- a/helm/templates/_helpers.tpl +++ b/helm/templates/_helpers.tpl @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + {{/* hostname for apigateway */}} {{- define "apigw_host" -}} {{ .Values.apigw.name }}.{{ .Release.Namespace }}.svc.cluster.local diff --git a/helm/templates/_readiness.tpl b/helm/templates/_readiness.tpl index f9e4174..8e53ec0 100644 --- a/helm/templates/_readiness.tpl +++ b/helm/templates/_readiness.tpl @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + {{/* Init container that waits for couchdb to be ready */}} {{- define "readiness.waitForCouchDB" -}} - name: "wait-for-couchdb" diff --git a/helm/templates/apigateway.yaml b/helm/templates/apigateway.yaml index 6878eaf..15a698c 100644 --- a/helm/templates/apigateway.yaml +++ b/helm/templates/apigateway.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + --- apiVersion: v1 kind: Service diff --git a/helm/templates/cluster_config.yaml b/helm/templates/cluster_config.yaml index 7c71c7a..c2c4220 100644 --- a/helm/templates/cluster_config.yaml +++ b/helm/templates/cluster_config.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + --- apiVersion: v1 kind: ConfigMap diff --git a/helm/templates/controller.yaml b/helm/templates/controller.yaml index 2c1e657..1eb208a 100644 --- a/helm/templates/controller.yaml +++ b/helm/templates/controller.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + --- apiVersion: v1 kind: Service diff --git a/helm/templates/couchdb.yaml b/helm/templates/couchdb.yaml index 268f9f6..e87c46c 100644 --- a/helm/templates/couchdb.yaml +++ b/helm/templates/couchdb.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + apiVersion: v1 kind: Service metadata: diff --git a/helm/templates/install_catalog_job.yaml b/helm/templates/install_catalog_job.yaml index d845f4f..fab30d0 100644 --- a/helm/templates/install_catalog_job.yaml +++ b/helm/templates/install_catalog_job.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + apiVersion: batch/v1 kind: Job metadata: diff --git a/helm/templates/install_routemgmt_job.yaml b/helm/templates/install_routemgmt_job.yaml index b90d13f..2ef1768 100644 --- a/helm/templates/install_routemgmt_job.yaml +++ b/helm/templates/install_routemgmt_job.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + apiVersion: batch/v1 kind: Job metadata: diff --git a/helm/templates/invoker.yaml b/helm/templates/invoker.yaml index ed3e97a..d5ac64e 100644 --- a/helm/templates/invoker.yaml +++ b/helm/templates/invoker.yaml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +#
[GitHub] dgrove-oss commented on issue #198: Add minified Apache license header to all yaml and yml files
dgrove-oss commented on issue #198: Add minified Apache license header to all yaml and yml files URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/198#issuecomment-389608024 @mrutkows -- ping This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom commented on issue #30: Fixes for #10, #24 and #25
sciabarracom commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389602684 Apparently the problem in OSX is simply a timeout problem. I "optimized" tests with a fixture, in order to build only once hence speeding test up. Now I do not have the problem of failing tests in VSCode. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #154: Provide per-repo., file-level ASF license header exclusion listing.
mrutkows opened a new pull request #154: Provide per-repo., file-level ASF license header exclusion listing. URL: https://github.com/apache/incubator-openwhisk-release/pull/154 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #3666: Use Minified ASF License header in Ansible YAML files.
houshengbo closed pull request #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/actionRuntimes/actionProxy/invoke.py b/actionRuntimes/actionProxy/invoke.py index 1b3b47142a..fb5b72e80c 100755 --- a/actionRuntimes/actionProxy/invoke.py +++ b/actionRuntimes/actionProxy/invoke.py @@ -1,16 +1,5 @@ #!/usr/bin/env python """Executable Python script for testing the action proxy. - - This script is useful for testing the action proxy (or its derivatives) - by simulating invoker interactions. Use it in combination with - docker run which starts up the action proxy. - Example: - docker run -i -t -p 8080:8080 dockerskeleton # locally built images may be referenced without a tag - ./invoke.py init - ./invoke.py run '{"some":"json object as a string"}' - - For additional help, try ./invoke.py -h - /* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with @@ -27,6 +16,16 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + + This script is useful for testing the action proxy (or its derivatives) + by simulating invoker interactions. Use it in combination with + docker run which starts up the action proxy. + Example: + docker run -i -t -p 8080:8080 dockerskeleton # locally built images may be referenced without a tag + ./invoke.py init + ./invoke.py run '{"some":"json object as a string"}' + + For additional help, try ./invoke.py -h """ import os diff --git a/ansible/apigateway.yml b/ansible/apigateway.yml index 8a79747717..96f32e6591 100644 --- a/ansible/apigateway.yml +++ b/ansible/apigateway.yml @@ -1,18 +1,5 @@ -# # Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements. See the NOTICE file distributed with this work for additional -# information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this -# file except in compliance with the License. You may obtain a copy of the License -# at: -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR -# CONDITIONS OF ANY KIND, either express or implied. See the License for the -# specific language governing permissions and limitations under the License. -# +# license agreements; and to You under the Apache License, Version 2.0. - hosts: redis roles: diff --git a/ansible/boot_instances_dist.yml b/ansible/boot_instances_dist.yml index 96062cb5a2..c8cb643bc0 100644 --- a/ansible/boot_instances_dist.yml +++ b/ansible/boot_instances_dist.yml @@ -1,18 +1,5 @@ -# # Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements. See the NOTICE file distributed with this work for additional -# information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this -# file except in compliance with the License. You may obtain a copy of the License -# at: -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR -# CONDITIONS OF ANY KIND, either express or implied. See the License for the -# specific language governing permissions and limitations under the License. -# +# license agreements; and to You under the Apache License, Version 2.0. --- # boot_instances.yml # TODO, in "with_instance" loops, the "instance" variable that is passed in gets unset, look up the proper way to do nested loops diff --git a/ansible/controller.yml b/ansible/controller.yml index e603823f25..6987fb5bc8 100644 --- a/ansible/controller.yml +++ b/ansible/controller.yml @@ -1,18 +1,5 @@ -# # Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements. See the NOTICE file distributed with this work for additional -# information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this -# file except in compliance with the License. You may obtain a copy of the License -# at: -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License
[GitHub] codecov-io commented on issue #3666: Use Minified ASF License header in Ansible YAML files.
codecov-io commented on issue #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666#issuecomment-389588207 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=h1) Report > Merging [#3666](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/22c0807b9eae20af9acc70b91a1943dd35a95092?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3666 +/- ## === Coverage 74.49% 74.49% === Files 126 126 Lines5990 5990 Branches 390 390 === Hits 4462 4462 Misses 1528 1528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=footer). Last update [22c0807...545d64f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3666?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom commented on issue #30: Fixes for #10, #24 and #25
sciabarracom commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389575123 Tests pass when I use ./gradlew test and go test. I have seen an occasionally failing a test when I run the "package test" from VSCode in your case. Yes, test are run in parallel and I did a lot of work to make them running in parallel. Not sure exactly why with VSCode the package test is different. I will try figure out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files.
mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666#issuecomment-389572964 Note this also fixes a typo that was in the old ASF headers; therefore, I closed https://github.com/apache/incubator-openwhisk/pull/3664 since this negates the need for the typo fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files.
mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666#issuecomment-389572964 Note this also fixes a type that was in the old ASF headers; therefore I closed https://github.com/apache/incubator-openwhisk/pull/3664 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #3664: fix typo error in headers
mrutkows closed pull request #3664: fix typo error in headers URL: https://github.com/apache/incubator-openwhisk/pull/3664 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/ansible/apigateway.yml b/ansible/apigateway.yml index 8a79747717..3392a57988 100644 --- a/ansible/apigateway.yml +++ b/ansible/apigateway.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/boot_instances_dist.yml b/ansible/boot_instances_dist.yml index 96062cb5a2..9dfd0f0f4a 100644 --- a/ansible/boot_instances_dist.yml +++ b/ansible/boot_instances_dist.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/controller.yml b/ansible/controller.yml index e603823f25..62df60f5fd 100644 --- a/ansible/controller.yml +++ b/ansible/controller.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/couchdb.yml b/ansible/couchdb.yml index 0d21600efd..d4baf4f985 100644 --- a/ansible/couchdb.yml +++ b/ansible/couchdb.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/edge.yml b/ansible/edge.yml index a5523fa9de..dc57a65c46 100644 --- a/ansible/edge.yml +++ b/ansible/edge.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/initdb.yml b/ansible/initdb.yml index f6eca76677..c80d010943 100644 --- a/ansible/initdb.yml +++ b/ansible/initdb.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the "License"); you may not use this # file except in compliance with the License. You may obtain a copy of the License # at: # diff --git a/ansible/invoker.yml b/ansible/invoker.yml index 05e39979a2..2713228459 100644 --- a/ansible/invoker.yml +++ b/ansible/invoker.yml @@ -2,7 +2,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements. See the NOTICE file distributed with this work for additional # information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this +# under the Apache License, Version 2.0 (the
[GitHub] mrutkows commented on issue #3664: fix typo error in headers
mrutkows commented on issue #3664: fix typo error in headers URL: https://github.com/apache/incubator-openwhisk/pull/3664#issuecomment-389572698 Closing this PR in favor of PR https://github.com/apache/incubator-openwhisk/pull/3666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #3666: Use Minified ASF License header in Ansible YAML files.
mrutkows opened a new pull request #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666 The ASF approved mini license header should be used in all YAML playbooks. ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [X] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389566763 trying with gradle 4.7 and more memory now. ``` > Task :vendor Skipping task ':vendor' as it has no actions. :vendor (Thread[Task worker for ':' Thread 7,5,main]) completed. Took 0.0 secs. :test (Thread[Task worker for ':' Thread 7,5,main]) started. === RUN ExampleHello 2018/05/16 11:40:36 Hello, Mike --- PASS: ExampleHello (0.00s) === RUN ExampleHello_noName --- PASS: ExampleHello_noName (0.00s) === RUN ExampleHello_badJson --- PASS: ExampleHello_badJson (0.00s) PASS coverage: 100.0% of statements ok github.com/apache/incubator-openwhisk-runtime-go/test/src/hello 0.009s coverage: 100.0% of statements > Task :test Task ':test' is not up-to-date because: Task has failed previously. Result of package github.com/apache/incubator-openwhisk-runtime-go/test/src/hello: Test for github.com/apache/incubator-openwhisk-runtime-go/test/src/hello finished, 3 completed, 0 failed Result of package github.com/apache/incubator-openwhisk-runtime-go/openwhisk: === RUN TestExtractActionTest_exec --- PASS: TestExtractActionTest_exec (0.37s) === RUN TestExtractActionTest_exe --- PASS: TestExtractActionTest_exe (0.38s) === RUN TestExtractActionTest_zip 2018/05/16 11:40:38 Extract Action, assuming a zip --- PASS: TestExtractActionTest_zip (0.39s) === RUN TestExtractAction_script --- PASS: TestExtractAction_script (0.00s) === RUN TestHighestDir --- PASS: TestHighestDir (0.00s) === RUN Example_startTestServer 2018/05/16 11:40:38 /var/folders/q6/4ry_mh5s3cxbcb1r0jwh06x8gn/T/action912616795 2018/05/16 11:40:38 http://127.0.0.1:54498 --- PASS: Example_startTestServer (1.00s) === RUN Example_isCompiled 2018/05/16 11:40:40 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runt ime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 11:40:40 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 11:40:40 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec out= 2018/05/16 11:40:41 2018/05/16 11:40:41 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runt ime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} elf} 2018/05/16 11:40:41 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} elf} 2018/05/16 11:40:41 open /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/main: no such file or directory 2018/05/16 11:40:41 stat /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec1: no such file or directory --- PASS: Example_isCompiled (1.53s) === RUN Example_compileAction_singlefile_main 2018/05/16 11:40:41 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src /github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1/exec out= 2018/05/16 11:40:42 --- PASS: Example_compileAction_singlefile_main (1.41s) === RUN Example_compileAction_singlefile_main_out 2018/05/16 11:40:43 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src /github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1a/exec out=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project _gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/output/1a 2018/05/16 11:40:44 --- PASS: Example_compileAction_singlefile_main_out (1.38s) === RUN Example_compileAction_singlefile_hello 2018/05/16 11:40:44 compiling: compiler=../common/gobuild.sh main=hello src=_test/compile/2/exec out= 2018/05/16 11:40:45 --- PASS:
[GitHub] codecov-io commented on issue #3665: Allow for init to specify if artifact should be treated as binary
codecov-io commented on issue #3665: Allow for init to specify if artifact should be treated as binary URL: https://github.com/apache/incubator-openwhisk/pull/3665#issuecomment-389566501 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=h1) Report > Merging [#3665](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/22c0807b9eae20af9acc70b91a1943dd35a95092?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3665 +/- ## === Coverage 74.49% 74.49% === Files 126 126 Lines5990 5990 Branches 390 390 === Hits 4462 4462 Misses 1528 1528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=footer). Last update [22c0807...5e8be72](https://codecov.io/gh/apache/incubator-openwhisk/pull/3665?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3665: Allow for init to specify if artifact should be treated as binary
rabbah opened a new pull request #3665: Allow for init to specify if artifact should be treated as binary URL: https://github.com/apache/incubator-openwhisk/pull/3665 ## Description The invoke.py script infers a binary init artifact based on the file extension but sometimes the binary has no extension or one that is not recognized by the script. Rather than make changes to the set of extensions, add a binary option to the init commands. example use: `invoke.py init -b main.exe` The presence of the flag overrides any extension that might be set otherwise. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [x] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389548816 Hum second run fails differently. Are all these tests running in parallel ? ``` :test (Thread[Task worker for ':',5,main]) started. === RUN ExampleHello 2018/05/16 10:51:08 Hello, Mike --- PASS: ExampleHello (0.00s) === RUN ExampleHello_noName --- PASS: ExampleHello_noName (0.00s) === RUN ExampleHello_badJson --- PASS: ExampleHello_badJson (0.00s) PASS coverage: 100.0% of statements ok github.com/apache/incubator-openwhisk-runtime-go/test/src/hello 0.032s coverage: 100.0% of statements === RUN TestExtractActionTest_exec --- PASS: TestExtractActionTest_exec (0.36s) === RUN TestExtractActionTest_exe --- PASS: TestExtractActionTest_exe (0.35s) === RUN TestExtractActionTest_zip 2018/05/16 10:51:10 Extract Action, assuming a zip --- PASS: TestExtractActionTest_zip (0.37s) === RUN TestExtractAction_script --- PASS: TestExtractAction_script (0.00s) === RUN TestHighestDir --- PASS: TestHighestDir (0.00s) === RUN Example_startTestServer 2018/05/16 10:51:10 /var/folders/q6/4ry_mh5s3cxbcb1r0jwh06x8gn/T/action845818479 2018/05/16 10:51:10 http://127.0.0.1:64372 > Task :test Putting task artifact state for task ':test' into context took 0.001 secs. Executing task ':test' (up-to-date check took 0.533 secs) due to: Task has failed previously. Result of package github.com/apache/incubator-openwhisk-runtime-go/test/src/hello: Test for github.com/apache/incubator-openwhisk-runtime-go/test/src/hello finished, 3 completed, 0 failed Result of package github.com/apache/incubator-openwhisk-runtime-go/openwhisk: --- PASS: Example_startTestServer (1.01s) === RUN Example_isCompiled 2018/05/16 10:51:11 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 10:51:11 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 10:51:11 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec out= 2018/05/16 10:51:12 2018/05/16 10:51:12 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} mach} 2018/05/16 10:51:12 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} elf} 2018/05/16 10:51:12 open /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/main: no such file or directory 2018/05/16 10:51:12 stat /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec1: no such file or directory --- PASS: Example_isCompiled (1.40s) === RUN Example_compileAction_singlefile_main 2018/05/16 10:51:13 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1/exec out= 2018/05/16 10:51:14 --- PASS: Example_compileAction_singlefile_main (1.29s) === RUN Example_compileAction_singlefile_main_out 2018/05/16 10:51:14 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1a/exec out=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/output/1a 2018/05/16 10:51:15 --- PASS: Example_compileAction_singlefile_main_out (1.26s) === RUN Example_compileAction_singlefile_hello 2018/05/16 10:51:15 compiling: compiler=../common/gobuild.sh main=hello src=_test/compile/2/exec out= 2018/05/16 10:51:16 --- PASS: Example_compileAction_singlefile_hello (1.26s)
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389546682 @sciabarra tests not passing for me on OSX ``` :test (Thread[Task worker for ':',5,main]) started. === RUN ExampleHello 2018/05/16 10:25:56 Hello, Mike --- PASS: ExampleHello (0.00s) === RUN ExampleHello_noName --- PASS: ExampleHello_noName (0.00s) === RUN ExampleHello_badJson --- PASS: ExampleHello_badJson (0.00s) PASS coverage: 100.0% of statements ok github.com/apache/incubator-openwhisk-runtime-go/test/src/hello 0.006s coverage: 100.0% of statements === RUN TestExtractActionTest_exec --- PASS: TestExtractActionTest_exec (0.43s) === RUN TestExtractActionTest_exe --- PASS: TestExtractActionTest_exe (0.34s) === RUN TestExtractActionTest_zip 2018/05/16 10:25:58 Extract Action, assuming a zip --- PASS: TestExtractActionTest_zip (0.37s) === RUN TestExtractAction_script --- PASS: TestExtractAction_script (0.03s) === RUN TestHighestDir --- PASS: TestHighestDir (0.00s) === RUN Example_startTestServer 2018/05/16 10:25:58 /var/folders/q6/4ry_mh5s3cxbcb1r0jwh06x8gn/T/action937541528 2018/05/16 10:25:58 http://127.0.0.1:60857 --- PASS: Example_startTestServer (1.01s) === RUN Example_isCompiled > Task :test Putting task artifact state for task ':test' into context took 0.001 secs. Executing task ':test' (up-to-date check took 0.362 secs) due to: Task has failed previously. Result of package github.com/apache/incubator-openwhisk-runtime-go/test/src/hello: Test for github.com/apache/incubator-openwhisk-runtime-go/test/src/hello finished, 3 completed, 0 failed Result of package github.com/apache/incubator-openwhisk-runtime-go/openwhisk: 2018/05/16 10:26:01 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 10:26:01 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{ } unknown} 2018/05/16 10:26:01 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec out= 2018/05/16 10:26:02 2018/05/16 10:26:02 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} elf} 2018/05/16 10:26:02 isCompiled: /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec kind={{darwin mach darwin/mach} mach} 2018/05/16 10:26:02 open /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/main: no such file or directory 2018/05/16 10:26:02 stat /Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/c/exec1: no such file or directory --- PASS: Example_isCompiled (2.06s) === RUN Example_compileAction_singlefile_main 2018/05/16 10:26:02 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1/exec out= 2018/05/16 10:26:03 --- PASS: Example_compileAction_singlefile_main (1.37s) === RUN Example_compileAction_singlefile_main_out 2018/05/16 10:26:03 compiling: compiler=../common/gobuild.sh main=main src=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/compile/1a/exec out=/Users/csantana23/Documents/dev/whisk/git/apache/incubator-openwhisk-runtime-go/.gogradle/project_gopath/src/github.com/apache/incubator-openwhisk-runtime-go/openwhisk/_test/output/1a 2018/05/16 10:26:04 --- PASS: Example_compileAction_singlefile_main_out (1.40s) === RUN Example_compileAction_singlefile_hello 2018/05/16 10:26:05 compiling: compiler=../common/gobuild.sh main=hello src=_test/compile/2/exec out= 2018/05/16 10:26:07 --- PASS: Example_compileAction_singlefile_hello (2.80s) === RUN
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389527837 I will try on OSX to see if works, and later we can OSX in the travis matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #30: Fixes for #10, #24 and #25
csantanapr commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389527705 FYI: It's better if you create a branch when you submit a PR other than using `master` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarra commented on issue #30: Fixes for #10, #24 and #25
sciabarra commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389520652 Now builds? Great! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarra commented on issue #30: Fixes for #10, #24 and #25
sciabarra commented on issue #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389520426 Sorry I closed the PR by error. I did not mean to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarra opened a new pull request #30: Fixes for #10, #24 and #25
sciabarra opened a new pull request #30: Fixes for #10, #24 and #25 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30 - refactored tests to run (mostly) on OSX - those that cannot has been isolated - go dependencies are now explicit in the build.gradle - fixed licenses and headers This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #51: Bump nodejs 8 to latest LTS 8.11.2
csantanapr opened a new issue #51: Bump nodejs 8 to latest LTS 8.11.2 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/51 Nodejs8 LTS got released last night https://nodejs.org/en/blog/release/v8.11.2/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #19: need to bump npm openwhisk version
csantanapr closed issue #19: need to bump npm openwhisk version URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #19: need to bump npm openwhisk version
csantanapr commented on issue #19: need to bump npm openwhisk version URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/19#issuecomment-389503193 Done long time ago This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel closed pull request #3658: Assure nginx verifies upstream ssl certs
cbickel closed pull request #3658: Assure nginx verifies upstream ssl certs URL: https://github.com/apache/incubator-openwhisk/pull/3658 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/ansible/roles/nginx/templates/nginx.conf.j2 b/ansible/roles/nginx/templates/nginx.conf.j2 index 61ea6fbf64..a86593f26e 100644 --- a/ansible/roles/nginx/templates/nginx.conf.j2 +++ b/ansible/roles/nginx/templates/nginx.conf.j2 @@ -26,6 +26,8 @@ http { {% if controller.protocol == 'https' %} proxy_ssl_session_reuse on; proxy_ssl_name {{ controller.ssl.cn }}; +proxy_ssl_verify on; +proxy_ssl_trusted_certificate /etc/nginx/{{ controller.ssl.cert }}; proxy_ssl_protocols TLSv1.1 TLSv1.2; proxy_ssl_certificate /etc/nginx/{{ controller.ssl.cert }}; proxy_ssl_certificate_key /etc/nginx/{{ controller.ssl.key }}; @@ -90,7 +92,6 @@ http { ssl_protocolsTLSv1.2; ssl_ciphers ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256; ssl_prefer_server_ciphers on; -proxy_ssl_verify off; proxy_ssl_session_reuse on; # proxy to the web action path This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3664: fix typo error in headers
codecov-io commented on issue #3664: fix typo error in headers URL: https://github.com/apache/incubator-openwhisk/pull/3664#issuecomment-389474443 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=h1) Report > Merging [#3664](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6397912386537056b295300a7c262218047d60ae?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664/graphs/tree.svg?token=l0YmsiSAso=650=pr=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3664 +/- ## === Coverage 74.49% 74.49% === Files 126 126 Lines5990 5990 Branches 390 390 === Hits 4462 4462 Misses 1528 1528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=footer). Last update [6397912...29f21e9](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3664: fix typo error in headers
codecov-io commented on issue #3664: fix typo error in headers URL: https://github.com/apache/incubator-openwhisk/pull/3664#issuecomment-389474443 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=h1) Report > Merging [#3664](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6397912386537056b295300a7c262218047d60ae?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664/graphs/tree.svg?height=150=pr=l0YmsiSAso=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3664 +/- ## === Coverage 74.49% 74.49% === Files 126 126 Lines5990 5990 Branches 390 390 === Hits 4462 4462 Misses 1528 1528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=footer). Last update [6397912...29f21e9](https://codecov.io/gh/apache/incubator-openwhisk/pull/3664?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #3664: fix typo error in headers
daisy-ycguo opened a new pull request #3664: fix typo error in headers URL: https://github.com/apache/incubator-openwhisk/pull/3664 Partially-closed issue #3660 Two py files are not included. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389460522 @mrutkows `incubator-openwhisk/actionRuntimes/actionProxy/invoke.py` and `incubator-openwhisk/tools/db/moveCodeToAttachment.py` already has a full Apache license, although the license is not on the top. I don't know why `scancode` cannot recognize them. Will you check if `scancode` can recognize such license not on the top ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389460522 @mrutkows `incubator-openwhisk/actionRuntimes/actionProxy/invoke.py` and `incubator-openwhisk/tools/db/moveCodeToAttachment.py` already has a full Apache license, although the license is not on the top. Will you check if `scancode` can recognize such license not on the top ? Must we move the license header on the top ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389460522 @mrutkows `incubator-openwhisk/actionRuntimes/actionProxy/invoke.py` and `incubator-openwhisk/tools/db/moveCodeToAttachment.py` already has a full Apache license, although the license is not on the top. Will you check if `scancode` can be improved to recognize such license ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
daisy-ycguo commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389460522 @mrutkows `incubator-openwhisk/actionRuntimes/actionProxy/invoke.py` already has a full Apache license, although the license is not on the top. Will you check if `scancode` can be improved to recognize such license ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism
codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism URL: https://github.com/apache/incubator-openwhisk/pull/3656#issuecomment-389115907 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=h1) Report > Merging [#3656](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6397912386537056b295300a7c262218047d60ae?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.9%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3656 +/- ## == + Coverage 74.49% 74.51% +0.02% == Files 126 126 Lines5990 5999 +9 Branches 390 400 +10 == + Hits 4462 4470 +8 - Misses 1528 1529 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.57% <90%> (+0.1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=footer). Last update [6397912...0205168](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism
codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism URL: https://github.com/apache/incubator-openwhisk/pull/3656#issuecomment-389115907 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=h1) Report > Merging [#3656](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6397912386537056b295300a7c262218047d60ae?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.9%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3656 +/- ## == + Coverage 74.49% 74.51% +0.02% == Files 126 126 Lines5990 5999 +9 Branches 390 400 +10 == + Hits 4462 4470 +8 - Misses 1528 1529 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.57% <90%> (+0.1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=footer). Last update [6397912...0205168](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #3656: Adjust the ForcableSemaphore mechanism
ningyougang commented on issue #3656: Adjust the ForcableSemaphore mechanism URL: https://github.com/apache/incubator-openwhisk/pull/3656#issuecomment-389407942 It seems good @markusthoemmes , can you have a look at this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism
codecov-io commented on issue #3656: Adjust the ForcableSemaphore mechanism URL: https://github.com/apache/incubator-openwhisk/pull/3656#issuecomment-389115907 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=h1) Report > Merging [#3656](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6397912386537056b295300a7c262218047d60ae?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `81.81%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/graphs/tree.svg?src=pr=650=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3656 +/- ## == + Coverage 74.49% 74.49% +<.01% == Files 126 126 Lines5990 5999 +9 Branches 390 400 +10 == + Hits 4462 4469 +7 - Misses 1528 1530 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `85.71% <80%> (-2.75%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=footer). Last update [6397912...3e972a6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services