[GitHub] pritidesai opened a new pull request #910: Fix for 909
pritidesai opened a new pull request #910: Fix for 909 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/910 Closes #909 Fixing License in all .yaml and action source files under `tests/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #24: Fix travis yaml file asf header, change to mini.
mrutkows opened a new pull request #24: Fix travis yaml file asf header, change to mini. URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #61: Fix travis yaml file asf header, change to mini.
mrutkows opened a new pull request #61: Fix travis yaml file asf header, change to mini. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #22: Fix travis yaml file asf header, change to mini.
mrutkows opened a new pull request #22: Fix travis yaml file asf header, change to mini. URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #53: Fix travis yaml file asf header, change to mini.
mrutkows opened a new pull request #53: Fix travis yaml file asf header, change to mini. URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #38: Fix travis yaml file asf header, change to mini.
mrutkows opened a new pull request #38: Fix travis yaml file asf header, change to mini. URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #76: Review NOTICE file for incubator-openwhisk-cli
mrutkows closed issue #76: Review NOTICE file for incubator-openwhisk-cli URL: https://github.com/apache/incubator-openwhisk-release/issues/76 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #76: Review NOTICE file for incubator-openwhisk-cli
mrutkows commented on issue #76: Review NOTICE file for incubator-openwhisk-cli URL: https://github.com/apache/incubator-openwhisk-release/issues/76#issuecomment-390027401 Closing in favor of tracking with LICENSE issues here: https://github.com/apache/incubator-openwhisk-release/issues/97 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #84: Review NOTICE file for incubator-openwhisk-runtime-python
mrutkows commented on issue #84: Review NOTICE file for incubator-openwhisk-runtime-python URL: https://github.com/apache/incubator-openwhisk-release/issues/84#issuecomment-390024931 Closing in favor of tracking along with LICENSE in issue here: https://github.com/apache/incubator-openwhisk-release/issues/104 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #84: Review NOTICE file for incubator-openwhisk-runtime-python
mrutkows closed issue #84: Review NOTICE file for incubator-openwhisk-runtime-python URL: https://github.com/apache/incubator-openwhisk-release/issues/84 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #25: Some source files miss Apache license headers
mrutkows closed issue #25: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/25 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #81: Review NOTICE file for incubator-openwhisk-runtime-java
mrutkows closed issue #81: Review NOTICE file for incubator-openwhisk-runtime-java URL: https://github.com/apache/incubator-openwhisk-release/issues/81 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #81: Review NOTICE file for incubator-openwhisk-runtime-java
mrutkows commented on issue #81: Review NOTICE file for incubator-openwhisk-runtime-java URL: https://github.com/apache/incubator-openwhisk-release/issues/81#issuecomment-390023591 Closing in favor of tracking issues with the LICENSE file here:https://github.com/apache/incubator-openwhisk-release/issues/102 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #80: Review NOTICE file for incubator-openwhisk-runtime-docker
mrutkows closed issue #80: Review NOTICE file for incubator-openwhisk-runtime-docker URL: https://github.com/apache/incubator-openwhisk-release/issues/80 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #80: Review NOTICE file for incubator-openwhisk-runtime-docker
mrutkows commented on issue #80: Review NOTICE file for incubator-openwhisk-runtime-docker URL: https://github.com/apache/incubator-openwhisk-release/issues/80#issuecomment-390022844 Closing in favor of tracking with LICENSE issues here: https://github.com/apache/incubator-openwhisk-release/issues/101 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #85: Review NOTICE file for incubator-openwhisk-runtime-swift
mrutkows closed issue #85: Review NOTICE file for incubator-openwhisk-runtime-swift URL: https://github.com/apache/incubator-openwhisk-release/issues/85 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #85: Review NOTICE file for incubator-openwhisk-runtime-swift
mrutkows commented on issue #85: Review NOTICE file for incubator-openwhisk-runtime-swift URL: https://github.com/apache/incubator-openwhisk-release/issues/85#issuecomment-390022290 Closing in favor of tracking with LICENSE issues here: https://github.com/apache/incubator-openwhisk-release/issues/100 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #83: Review NOTICE file for incubator-openwhisk-runtime-php
mrutkows commented on issue #83: Review NOTICE file for incubator-openwhisk-runtime-php URL: https://github.com/apache/incubator-openwhisk-release/issues/83#issuecomment-390021149 Close in favor of tracking with LICENSE file here: https://github.com/apache/incubator-openwhisk-release/issues/103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #83: Review NOTICE file for incubator-openwhisk-runtime-php
mrutkows closed issue #83: Review NOTICE file for incubator-openwhisk-runtime-php URL: https://github.com/apache/incubator-openwhisk-release/issues/83 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #82: Review NOTICE file for incubator-openwhisk-runtime-nodejs
mrutkows commented on issue #82: Review NOTICE file for incubator-openwhisk-runtime-nodejs URL: https://github.com/apache/incubator-openwhisk-release/issues/82#issuecomment-390018933 Close in favor of tracking with LICENSE issues here: https://github.com/apache/incubator-openwhisk-release/issues/99 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #82: Review NOTICE file for incubator-openwhisk-runtime-nodejs
mrutkows closed issue #82: Review NOTICE file for incubator-openwhisk-runtime-nodejs URL: https://github.com/apache/incubator-openwhisk-release/issues/82 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #48: Update doc to remove experimental references
mrutkows commented on issue #48: Update doc to remove experimental references URL: https://github.com/apache/incubator-openwhisk-client-go/issues/48#issuecomment-390017789 PR: https://github.com/apache/incubator-openwhisk-client-go/pull/86 fixed issue Issue: https://github.com/apache/incubator-openwhisk-client-go/issues/82 and this issue (dups.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #48: Update doc to remove experimental references
mrutkows commented on issue #48: Update doc to remove experimental references URL: https://github.com/apache/incubator-openwhisk-client-go/issues/48#issuecomment-390017789 Fixed: https://github.com/apache/incubator-openwhisk-client-go/issues/82 PR: https://github.com/apache/incubator-openwhisk-client-go/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #48: Update doc to remove experimental references
mrutkows closed issue #48: Update doc to remove experimental references URL: https://github.com/apache/incubator-openwhisk-client-go/issues/48 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #77: Review NOTICE file for incubator-openwhisk-client-go
mrutkows commented on issue #77: Review NOTICE file for incubator-openwhisk-client-go URL: https://github.com/apache/incubator-openwhisk-release/issues/77#issuecomment-390016576 Closing issue to instead track with LICENSE here: https://github.com/apache/incubator-openwhisk-release/issues/98 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #77: Review NOTICE file for incubator-openwhisk-client-go
mrutkows closed issue #77: Review NOTICE file for incubator-openwhisk-client-go URL: https://github.com/apache/incubator-openwhisk-release/issues/77 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #78: Review NOTICE file for incubator-openwhisk-apigateway
mrutkows commented on issue #78: Review NOTICE file for incubator-openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-release/issues/78#issuecomment-390015350 Closing as this granularity of tracking is not needed, see https://github.com/apache/incubator-openwhisk-release/issues/95 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #273: A list of source files missing Apache license headers
mrutkows commented on issue #273: A list of source files missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/273#issuecomment-390012725 Closing this issue and will open more granular issues for any remaining files that need to have ASF headers added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #273: A list of source files missing Apache license headers
mrutkows closed issue #273: A list of source files missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/273 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #87: Review all (12) NOTICE files for contents
mrutkows closed issue #87: Review all (12) NOTICE files for contents URL: https://github.com/apache/incubator-openwhisk-release/issues/87 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #87: Review all (12) NOTICE files for contents
mrutkows opened a new issue #87: Review all (12) NOTICE files for contents URL: https://github.com/apache/incubator-openwhisk-release/issues/87 Track the review of notice files in these individual issues: openwhisk: https://github.com/apache/incubator-openwhisk-release/issues/75 cli: https://github.com/apache/incubator-openwhisk-release/issues/76 client-go: https://github.com/apache/incubator-openwhisk-release/issues/77 apigateway: https://github.com/apache/incubator-openwhisk-release/issues/78 catalog: https://github.com/apache/incubator-openwhisk-release/issues/79 runtime-docker: https://github.com/apache/incubator-openwhisk-release/issues/80 java: https://github.com/apache/incubator-openwhisk-release/issues/81 nodejs: https://github.com/apache/incubator-openwhisk-release/issues/82 php: https://github.com/apache/incubator-openwhisk-release/issues/83 python: https://github.com/apache/incubator-openwhisk-release/issues/84 swift: https://github.com/apache/incubator-openwhisk-release/issues/85 wskdeploy: https://github.com/apache/incubator-openwhisk-release/issues/86 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #75: Review NOTICE file for main openwhisk repo.
mrutkows closed issue #75: Review NOTICE file for main openwhisk repo. URL: https://github.com/apache/incubator-openwhisk-release/issues/75 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #157: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog`
mrutkows closed issue #157: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog` URL: https://github.com/apache/incubator-openwhisk-release/issues/157 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #96: Document LICENSE file Exclusions for incubator-openwhisk-catalog
mrutkows opened a new issue #96: Document LICENSE file Exclusions for incubator-openwhisk-catalog URL: https://github.com/apache/incubator-openwhisk-release/issues/96 Please use this issue to document directories/files (by extension) or individual files we have decided will not require a LICENSE header because it falls under an allowed Apache category (see https://www.apache.org/legal/src-headers.html) Open Issues/PRs: _None_ **Merged PRs**: - PR [#260 - Add the LICENSE and NOTICE files](https://github.com/apache/incubator-openwhisk-catalog/pull/260) - PR [#262 - Add the license headers](https://github.com/apache/incubator-openwhisk-catalog/pull/262) - PR [#265 - Use the strict ASF release specific configuration for scancode.py](https://github.com/apache/incubator-openwhisk-catalog/pull/265) - PR [#270 - Add the licenses of dependencies into LICENSE file](https://github.com/apache/incubator-openwhisk-catalog/pull/270) - PR [#271 - Fix .md files to pass scanCode.py and comply with policy](https://github.com/apache/incubator-openwhisk-catalog/pull/271) - PR [#272 - Remove the unnecessary dependencies](https://github.com/apache/incubator-openwhisk-catalog/pull/272) - Issue [#256 - A list of source files missing Apache license headers](https://github.com/apache/incubator-openwhisk-catalog/issues/256) **Closed PRs/Issues**: - PR [#257 - Add the support to package source code](https://github.com/apache/incubator-openwhisk-catalog/pull/257/files) - old/no longer valid **Other Issues**: - Issue [#177 - create Invoke.py](https://github.com/apache/incubator-openwhisk-catalog/pull/177) - (pdesai) - Old open issue; Rodric requested changes on 2017-02-13). It indicates "Adding a sample in python showing how to invoke another action "whisk.system/utils/date", closing issue #171" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #86: Remove the disclaimer and the reference as experimental
mrutkows closed pull request #86: Remove the disclaimer and the reference as experimental URL: https://github.com/apache/incubator-openwhisk-client-go/pull/86 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 64c62bae..37aefb44 100644 --- a/README.md +++ b/README.md @@ -24,14 +24,6 @@ This project `openwhisk-client-go` is a Go client library to access Openwhisk API. -# Disclaimer - -This project is currently on an experimental stage. We periodically synchronize the source code of this repository with -the [Go whisk folder](https://github.com/apache/incubator-openwhisk/tree/master/tools/cli/go-whisk) in OpenWhisk. The framework of test cases is under construction -for this repository. Please contribute to the [Go whisk folder](https://github.com/apache/incubator-openwhisk/tree/master/tools/cli/go-whisk) in OpenWhisk for any Go whisk changes, before we officially announce the separation -of OpenWhisk CLI from OpenWhisk. - - ### Usage ```go This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #82: Change README to remove Disclaimer and "experimental" descriptions
mrutkows closed issue #82: Change README to remove Disclaimer and "experimental" descriptions URL: https://github.com/apache/incubator-openwhisk-client-go/issues/82 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #155: Add the tests directory back to the source code release
mrutkows closed pull request #155: Add the tests directory back to the source code release URL: https://github.com/apache/incubator-openwhisk-release/pull/155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/package_source_code.sh b/tools/package_source_code.sh index 2bf2984..6e8effd 100755 --- a/tools/package_source_code.sh +++ b/tools/package_source_code.sh @@ -30,7 +30,7 @@ mkdir -p $CURRENT_VERSION_DIR # Remove bin and build folders mkdir -p $OPENWHISK_CLEANED_SOURCE_DIR rm -rf $OPENWHISK_CLEANED_SOURCE_DIR/* -rsync -rtp --exclude .*\* --exclude bin\* --exclude build\* --exclude tests\* $OPENWHISK_SOURCE_DIR/. $OPENWHISK_CLEANED_SOURCE_DIR +rsync -rtp --exclude .*\* --exclude bin\* --exclude build\* $OPENWHISK_SOURCE_DIR/. $OPENWHISK_CLEANED_SOURCE_DIR for repo in $(echo $repos | sed "s/,/ /g") do This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann commented on issue #302: Add option to encrypt redis password
mhamann commented on issue #302: Add option to encrypt redis password URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/302#issuecomment-389996458 @alexsong93 can you update the readme to document how the redis password should be encrypted and what needs to be passed into the container to take advantage of the config? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #201: apigateway working with helm+minikube (NodePort)
dgrove-oss opened a new pull request #201: apigateway working with helm+minikube (NodePort) URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/201 1. rework nginx.conf for NodePort ingress to direct apigw traffic to the appropriate service. 2. Add also invoking hello as a web action to the travis sniff test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexsong93 opened a new pull request #302: Add option to encrypt redis password
alexsong93 opened a new pull request #302: Add option to encrypt redis password URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/302 @mhamann This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #157: Track LICENSE and NOTICE issues for incubator-openwhisk-catalog
mrutkows opened a new issue #157: Track LICENSE and NOTICE issues for incubator-openwhisk-catalog URL: https://github.com/apache/incubator-openwhisk-release/issues/157 Please use this issue to document directories/files (by extension) or individual files we have decided will not require a LICENSE header because it falls under an allowed Apache category (see [https://www.apache.org/legal/src-headers.html](https://www.apache.org/legal/src-headers.html)) **Open Issues/PRs**: - TBD **Closed Issues/Merged PRs**: - TBD This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom opened a new pull request #31: Ignore this PR
sciabarracom opened a new pull request #31: Ignore this PR URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/31 Only to trigger a build and cause errors (if any). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
mrutkows closed issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files.
mrutkows commented on issue #3666: Use Minified ASF License header in Ansible YAML files. URL: https://github.com/apache/incubator-openwhisk/pull/3666#issuecomment-389956352 Closes #3660 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers
mrutkows commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers URL: https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-38999 Closed by PR https://github.com/apache/incubator-openwhisk/pull/3666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #277: Add ASF license header to travis yaml file.
houshengbo closed pull request #277: Add ASF license header to travis yaml file. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index b3c6415..ca8397f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # Gradle .gradle build/ @@ -14,4 +17,4 @@ node_modules/ # IntelliJ .idea -out/ \ No newline at end of file +out/ diff --git a/.travis.yml b/.travis.yml index e690d65..69931a7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # A Travis CI configuration file. sudo: required This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #301: Add ASF license header to travis yaml file.
houshengbo closed pull request #301: Add ASF license header to travis yaml file. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 4b9d47a..ee628f4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # A Travis CI configuration file. sudo: required This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI
codecov-io commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1) Report > Merging [#3619](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `0.12%`. > The diff coverage is `80.76%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3619 +/- ## == + Coverage 74.49% 74.61% +0.12% == Files 126 127 +1 Lines5990 5992 +2 Branches 390 372 -18 == + Hits 4462 4471 +9 + Misses 1528 1521 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../src/main/scala/whisk/core/entity/WhiskStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrU3RvcmUuc2NhbGE=) | `96.87% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ActivationId.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25JZC5zY2FsYQ==) | `89.47% <ø> (ø)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `91.28% <ø> (ø)` | :arrow_up: | | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `31.13% <0%> (+0.85%)` | :arrow_up: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.5% <100%> (+0.47%)` | :arrow_up: | | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `81.02% <100%> (+0.3%)` | :arrow_up: | | [...la/whisk/core/entity/ArtifactActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FydGlmYWN0QWN0aXZhdGlvblN0b3JlLnNjYWxh) | `92.85% <92.85%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=footer). Last update [ed71ee0...527c770](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message
[GitHub] pritidesai commented on issue #909: Fix LICENSE headers in all YAML/.js under "tests" folder
pritidesai commented on issue #909: Fix LICENSE headers in all YAML/.js under "tests" folder URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/909#issuecomment-389947247 Assigning to me as I am working on it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #277: Add ASF license header to travis yaml file.
mrutkows opened a new pull request #277: Add ASF license header to travis yaml file. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/277 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #3670: Add ASF Headers to .groovy source files.
houshengbo closed pull request #3670: Add ASF Headers to .groovy source files.
URL: https://github.com/apache/incubator-openwhisk/pull/3670
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/dev/src/main/groovy/couchdbViews.groovy
b/tools/dev/src/main/groovy/couchdbViews.groovy
index 2de008a06d..4db872bb85 100644
--- a/tools/dev/src/main/groovy/couchdbViews.groovy
+++ b/tools/dev/src/main/groovy/couchdbViews.groovy
@@ -1,20 +1,18 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
import groovy.json.JsonSlurper
@@ -58,4 +56,4 @@ private static File createFreshBuildDir() {
private static String parseViewJs(String jsonText) {
jsonText.replace("\\n", "")
.replace('\"','"')
-}
\ No newline at end of file
+}
diff --git a/tools/jenkins/apache/dockerhub.groovy
b/tools/jenkins/apache/dockerhub.groovy
index c804b23d34..fb8c73644b 100644
--- a/tools/jenkins/apache/dockerhub.groovy
+++ b/tools/jenkins/apache/dockerhub.groovy
@@ -1,4 +1,21 @@
#!groovy
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
node('xenial&&!H21&&!H22&&!H11&&!ubuntu-eu3') {
sh "env"
sh "docker version"
@@ -30,6 +47,6 @@ node('xenial&&!H21&&!H22&&!H11&&!ubuntu-eu3') {
withCredentials([string(credentialsId: 'openwhisk_slack_token', variable:
'OPENWHISK_SLACK_TOKEN')]) {
sh "curl -X POST --data-urlencode 'payload={\"channel\": \"#dev\",
\"username\": \"whiskbot\", \"text\": \"OpenWhisk Docker Images build and
posted to https://hub.docker.com/u/openwhisk by Jenkins job ${BUILD_URL}\",
\"icon_emoji\": \":openwhisk:\"}'
https://hooks.slack.com/services/${OPENWHISK_SLACK_TOKEN};
}
-
+
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3670: Add ASF Headers to .groovy source files.
codecov-io commented on issue #3670: Add ASF Headers to .groovy source files. URL: https://github.com/apache/incubator-openwhisk/pull/3670#issuecomment-389938394 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=h1) Report > Merging [#3670](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3670 +/- ## === Coverage 74.49% 74.49% === Files 126 126 Lines5990 5990 Branches 390 390 === Hits 4462 4462 Misses 1528 1528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=footer). Last update [ed71ee0...8c08914](https://codecov.io/gh/apache/incubator-openwhisk/pull/3670?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3652: Disable Slf4jLogger startup log in test runs
dubee closed pull request #3652: Disable Slf4jLogger startup log in test runs
URL: https://github.com/apache/incubator-openwhisk/pull/3652
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/resources/logback-test.xml
b/tests/src/test/resources/logback-test.xml
new file mode 100644
index 00..ae31af6f3e
--- /dev/null
+++ b/tests/src/test/resources/logback-test.xml
@@ -0,0 +1,21 @@
+
+
+
+
+
+[%d{-MM-dd'T'HH:mm:ss.SSS'Z'}] [%p] %msg%n
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment
codecov-io commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=h1) Report > Merging [#3669](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `0.09%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3669 +/- ## == + Coverage 74.49% 74.58% +0.09% == Files 126 126 Lines5990 6004 +14 Branches 390 393 +3 == + Hits 4462 4478 +16 + Misses 1528 1526 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.62% <100%> (+0.52%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `97.82% <100%> (+0.2%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `85.88% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=footer). Last update [ed71ee0...d78d599](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment
codecov-io commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=h1) Report > Merging [#3669](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `0.09%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3669 +/- ## == + Coverage 74.49% 74.58% +0.09% == Files 126 126 Lines5990 6004 +14 Branches 390 393 +3 == + Hits 4462 4478 +16 + Misses 1528 1526 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.62% <100%> (+0.52%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `97.82% <100%> (+0.2%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `85.88% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=footer). Last update [ed71ee0...d78d599](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #301: Add ASF license header to travis yaml file.
mrutkows opened a new pull request #301: Add ASF license header to travis yaml file. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3232: Making prewarm kind (and count) configurable
rabbah closed pull request #3232: Making prewarm kind (and count) configurable
URL: https://github.com/apache/incubator-openwhisk/pull/3232
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
index 668ef609f6..3acb49022a 100644
--- a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
@@ -122,6 +122,7 @@ protected[core] object ExecManifest {
* @param requireMain true iff main entry point is not optional
* @param sentinelledLogs true iff the runtime generates stdout/stderr log
sentinels after an activation
* @param image optional image name, otherwise inferred via fixed mapping
(remove colons and append 'action')
+ * @param stemCells optional list of stemCells to be initialized by invoker
per kind
*/
protected[core] case class RuntimeManifest(kind: String,
image: ImageName,
@@ -129,7 +130,8 @@ protected[core] object ExecManifest {
default: Option[Boolean] = None,
attached: Option[Attached] = None,
requireMain: Option[Boolean] =
None,
- sentinelledLogs: Option[Boolean]
= None) {
+ sentinelledLogs: Option[Boolean]
= None,
+ stemCells: Option[List[StemCell]]
= None) {
protected[entity] def toJsonSummary = {
JsObject(
@@ -138,10 +140,16 @@ protected[core] object ExecManifest {
"deprecated" -> deprecated.getOrElse(false).toJson,
"default" -> default.getOrElse(false).toJson,
"attached" -> attached.isDefined.toJson,
-"requireMain" -> requireMain.getOrElse(false).toJson)
+"requireMain" -> requireMain.getOrElse(false).toJson,
+"stemCells" -> stemCells.getOrElse(List()).toJson)
}
}
+ /**
+ * A stemcell for a container image to be initialized by Invoker
+ */
+ protected[core] case class StemCell(count: Int, memory: String)
+
/**
* An image name for an action refers to the container image canonically as
* "prefix/name[:tag]" e.g., "openwhisk/python3action:latest".
@@ -285,6 +293,7 @@ protected[core] object ExecManifest {
private val defaultSplitter = "([a-z0-9]+):default".r
}
+ protected[entity] implicit val stemCellSerdes = jsonFormat2(StemCell.apply)
protected[entity] implicit val imageNameSerdes = jsonFormat3(ImageName.apply)
- protected[entity] implicit val runtimeManifestSerdes =
jsonFormat7(RuntimeManifest)
+ protected[entity] implicit val runtimeManifestSerdes =
jsonFormat8(RuntimeManifest)
}
diff --git
a/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
b/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
index 183556942e..d39e78a49d 100644
--- a/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
+++ b/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
@@ -60,7 +60,7 @@ case class WorkerData(data: ContainerData, state: WorkerState)
*/
class ContainerPool(childFactory: ActorRefFactory => ActorRef,
feed: ActorRef,
-prewarmConfig: Option[PrewarmingConfig] = None,
+prewarmConfigs: Option[List[PrewarmingConfig]] = None,
poolConfig: ContainerPoolConfig)
extends Actor {
implicit val logging = new AkkaLogging(context.system.log)
@@ -70,7 +70,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
var prewarmedPool = immutable.Map.empty[ActorRef, ContainerData]
val logMessageInterval = 10.seconds
- prewarmConfig.foreach { config =>
+ prewarmConfigs.getOrElse(List()).foreach { config =>
logging.info(this, s"pre-warming ${config.count} ${config.exec.kind}
containers")(TransactionId.invokerWarmup)
(1 to config.count).foreach { _ =>
prewarmContainer(config.exec, config.memoryLimit)
@@ -204,26 +204,25 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
* @param kind the kind you want to invoke
* @return the container iff found
*/
- def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef,
ContainerData)] =
-prewarmConfig.flatMap { config =>
- val kind = action.exec.kind
- val memory = action.limits.memory.megabytes.MB
- prewarmedPool
-.find {
- case (_, PreWarmedData(_, `kind`, `memory`)) => true
- case _
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389926238 @Himavanth thanks for the thumbs up - will close in favor of new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #3670: Add ASF Headers to .groovy source files.
mrutkows opened a new pull request #3670: Add ASF Headers to .groovy source files. URL: https://github.com/apache/incubator-openwhisk/pull/3670 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #301: Display appropriate message when an activation ID is not returned from a trigger fire.
mdeuser commented on issue #301: Display appropriate message when an activation ID is not returned from a trigger fire. URL: https://github.com/apache/incubator-openwhisk-cli/issues/301#issuecomment-389920959 and should probably pass along a message that indicates the trigger was not really fired.. - no rule associate with trigger - no action associated with trigger's rule (need to confirm this one) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution
csantanapr closed issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution URL: https://github.com/apache/incubator-openwhisk-release/issues/156 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution
csantanapr commented on issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution URL: https://github.com/apache/incubator-openwhisk-release/issues/156#issuecomment-389918646 spm-build not related at all to spmjs spm stands for swift package manager spm-build is just a directory name we picked as the location where the code will get compiled This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new issue #301: Display appropriate message when an activation ID is not returned from a trigger fire.
dubee opened a new issue #301: Display appropriate message when an activation ID is not returned from a trigger fire. URL: https://github.com/apache/incubator-openwhisk-cli/issues/301 Executing a trigger returns an activation ID only when there is rule linked to the trigger. As a result, the CLI should not display `with id` when an activation ID is not returned from a fired trigger. ``` $ wsk trigger create a ok: created trigger a $ wsk trigger fire a ok: triggered /_/a with id ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #151: increase wait time for maxTriggers test
dubee closed pull request #151: increase wait time for maxTriggers test URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/151 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala index b5bf6d3..131d52a 100644 --- a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala +++ b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala @@ -78,7 +78,7 @@ class AlarmsFeedTests } // get activation list of the trigger -val activations = wsk.activation.pollFor(N = 4, Some(triggerName)).length +val activations = wsk.activation.pollFor(N = 4, Some(triggerName), retries = 30).length println(s"Found activation size: $activations") activations should be(3) } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution
mrutkows opened a new issue #156: Swift runtime has "SPM" builds (binaries) using ext. code with no license attribution URL: https://github.com/apache/incubator-openwhisk-release/issues/156 Both Swift 3.1 and Swift 4 runtimes produce "spm-build" directories indicative of use of 3rd party tools but we have no license attribution. See: https://github.com/spmjs/spm-build This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #2795: enable concurrent activation processing
tysonnorris commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-389904732 @markusthoemmes @rabbah @csantanapr this is ready for a PG and another review glance This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Himavanth commented on issue #3232: Making prewarm kind (and count) configurable
Himavanth commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389904344 Sounds good. Thanks @rabbah This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet opened a new pull request #151: increase wait time for maxTriggers test
jasonpet opened a new pull request #151: increase wait time for maxTriggers test URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #155: Add the tests directory back to the source code release
houshengbo opened a new pull request #155: Add the tests directory back to the source code release URL: https://github.com/apache/incubator-openwhisk-release/pull/155 Since we have already added the valid license header to all the test cases, we restore to add them back to the source code release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3669: Make stemcells configurable by deployment
rabbah commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389895111 Should get a fresh PG @csantanapr @dubee This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and
count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r188986673
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##
@@ -204,26 +204,25 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
* @param kind the kind you want to invoke
* @return the container iff found
*/
- def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef,
ContainerData)] =
-prewarmConfig.flatMap { config =>
- val kind = action.exec.kind
- val memory = action.limits.memory.megabytes.MB
- prewarmedPool
-.find {
- case (_, PreWarmedData(_, `kind`, `memory`)) => true
- case _ => false
-}
-.map {
- case (ref, data) =>
-// Move the container to the usual pool
-freePool = freePool + (ref -> data)
-prewarmedPool = prewarmedPool - ref
-// Create a new prewarm container
-prewarmContainer(config.exec, config.memoryLimit)
+ def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef,
ContainerData)] = {
+val kind = action.exec.kind
+val memory = action.limits.memory.megabytes.MB
+prewarmedPool
+ .find {
+case (_, PreWarmedData(_, `kind`, `memory`)) => true
Review comment:
@tysonnorris with the changes in
https://github.com/apache/incubator-openwhisk/pull/3669 we can add an
additional property to the stem cell configuration, _the slop factor_ to allow
for more sizes to match a particular cell.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3669: Make stemcells configurable by deployment
rabbah commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389893508 Note to committer: please preserve co-author credits, I preserved much of @Himavanth patches from #3232 and improved on them where appropriate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3669: Make stemcells configurable by deployment
rabbah commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389893066 @dgrove-oss @tysonnorris I don't think this will break downstream in terms of a deployment but it will affect performance. A heads up - when this is reviewed, I can open a PR downstream. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3669: Make stemcells configurable by deployment
rabbah commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389893066 @dgrove-oss @tysonnorris I don't think this will break downstream in terms of a deployment but it will affect performance. A heads up - when this is reviewed, I can open PRs downstream. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3669: Make stemcells configurable by deployment
rabbah commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389893066 @dgrove-oss I don't think this will break downstream in terms of a deployment but it will affect performance. A heads up - when this is reviewed, I can open a PR downstream. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3669: Make stemcells configurable by deployment
rabbah commented on a change in pull request #3669: Make stemcells configurable
by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r188985305
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##
@@ -204,26 +199,25 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
* @param kind the kind you want to invoke
* @return the container iff found
*/
- def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef,
ContainerData)] =
-prewarmConfig.flatMap { config =>
- val kind = action.exec.kind
- val memory = action.limits.memory.megabytes.MB
- prewarmedPool
-.find {
- case (_, PreWarmedData(_, `kind`, `memory`)) => true
- case _ => false
-}
-.map {
- case (ref, data) =>
-// Move the container to the usual pool
-freePool = freePool + (ref -> data)
-prewarmedPool = prewarmedPool - ref
-// Create a new prewarm container
-prewarmContainer(config.exec, config.memoryLimit)
-
-(ref, data)
-}
-}
+ def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef,
ContainerData)] = {
+val kind = action.exec.kind
+val memory = action.limits.memory.megabytes.MB
+prewarmedPool
+ .find {
+case (_, PreWarmedData(_, `kind`, `memory`)) => true
+case _ => false
+ }
+ .map {
+case (ref, data) =>
+ // Move the container to the usual pool
+ freePool = freePool + (ref -> data)
+ prewarmedPool = prewarmedPool - ref
+ // Create a new prewarm container
+ // NOTE: prewarming ignores the action code, but this is dangerous
as the code is accessible to the factory
Review comment:
@markusthoemmes we should fix this separately - I don't like this but it is
safe here. Please sanity check me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah opened a new pull request #3669: Stemcells
rabbah opened a new pull request #3669: Stemcells
URL: https://github.com/apache/incubator-openwhisk/pull/3669
## Description
This PR replaces #3232 and makes stem cell containers configurable from the
runtime manifest. See the changes to runtimes.json for an example (or the new
tests). It is possible to have multiple stem cells per runtime kind. For
example:
```
{ "runtimes": {
"node": [
{
"kind": "nodejs:6",
"image": {
"name": "nodejsaction"
},
"stemCells": [{
"count": 1,
"memory": "128 MB"
}]
}, {
"kind": "nodejs:8",
"default": true,
"image": {
"name": "nodejsaction"
},
"stemCells": [{
"count": 1,
"memory": "128 MB"
}, {
"count": 1,
"memory": "256 MB"
}]
}
]...
```
This PR improves #3232 with stricter types on the `StemCell` configuration,
filters configrations for runtimes for the ones that exists to make it easier
to work with stem cells in the invoker.
Closes #2401.
## Related issue and scope
- [x] There is an open an issue to propose and discuss this change (#2401)
## My changes affect the following components
- [ ] API
- [x] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [x] Tests
- [x] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [x] Breaking change (a bug fix or enhancement which changes existing
behavior).
Labelled breaking change because it will require downstream changes to
enable stem cells.
It's plausible we should warn or fail startup if no stemcells are defined.
## Checklist:
- [x] I signed an [Apache
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [x] I updated the documentation where necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #299: Wait for 2 minutes for logs.
dubee commented on a change in pull request #299: Wait for 2 minutes for logs.
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/299#discussion_r188983257
##
File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
##
@@ -400,7 +400,7 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
be("this is stdout\nthis is stderr\n") or
be("this is stderr\nthis is stdout\n")
}
-}, 10, Some(1.second))
Review comment:
@rabbah, super yikes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI
dubee commented on a change in pull request #3619: Provide an activation store
SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r188982201
##
File path: common/scala/src/main/scala/whisk/core/entity/ActivationStore.scala
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import java.time.Instant
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import spray.json.JsObject
+import whisk.common.{Logging, TransactionId}
+import whisk.core.database.CacheChangeNotification
+import whisk.spi.Spi
+
+import scala.concurrent.Future
+
+trait ActivationStore {
+
+ def store(activation: WhiskActivation)(implicit transid: TransactionId,
+ notifier:
Option[CacheChangeNotification]): Future[DocInfo]
+
+ def get(activationId: ActivationId)(implicit transid: TransactionId):
Future[WhiskActivation]
+
+ def delete(activationId: ActivationId)(implicit transid: TransactionId,
+ notifier:
Option[CacheChangeNotification]): Future[Boolean]
+
+ def response(activationId: ActivationId)(implicit transid: TransactionId):
Future[WhiskActivation]
Review comment:
Looks like `response()` can be deleted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #299: Wait for 2 minutes for logs.
dubee closed pull request #299: Wait for 2 minutes for logs.
URL: https://github.com/apache/incubator-openwhisk-cli/pull/299
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
b/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
index 245e9551..94a6ce55 100644
--- a/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
+++ b/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
@@ -400,7 +400,7 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
be("this is stdout\nthis is stderr\n") or
be("this is stderr\nthis is stdout\n")
}
-}, 10, Some(1.second))
+}, 120, Some(1.second))
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #299: Wait for 2 minutes for logs.
rabbah commented on a change in pull request #299: Wait for 2 minutes for logs.
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/299#discussion_r188979941
##
File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
##
@@ -400,7 +400,7 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
be("this is stdout\nthis is stderr\n") or
be("this is stderr\nthis is stdout\n")
}
-}, 10, Some(1.second))
Review comment:
2 minutes - yikes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss opened a new pull request #300: Bug fix: Use configured prototcol for API requests
dgrove-oss opened a new pull request #300: Bug fix: Use configured prototcol for API requests URL: https://github.com/apache/incubator-openwhisk-cli/pull/300 Add check to see if Client.Config.Host already specifies the protocol to use before prepending https:// in URL construction. Fixes a bug where if .wskprops specifies a APIHOST with a protocol, `wsk api create` generates an invalid backend URL (https://https://APIHOST/...). Fixes #125. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel opened a new pull request #299: Wait for 2 minutes for logs.
cbickel opened a new pull request #299: Wait for 2 minutes for logs. URL: https://github.com/apache/incubator-openwhisk-cli/pull/299 Increase time to wait for logs, to handle potential delays, that could occure, depending on the store, that is used to store logs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy
style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-389860736 @csantanapr thank you for the good tip. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy
style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-389860736 @csantanpr thank you for the good tip. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-389851869 Rebased to current master. @rabbah and @dubee would be helpful if you can review the proposed changes now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3502: Immutable attachments via putAndAttach
codecov-io commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-389761107 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=h1) Report > Merging [#3502](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `0.5%`. > The diff coverage is `96.96%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3502 +/- ## = + Coverage 74.49% 74.99% +0.5% = Files 126 126 Lines5990 6019 +29 Branches 390 387 -3 = + Hits 4462 4514 +52 + Misses 1528 1505 -23 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=tree) | Coverage Δ | | |---|---|---| | [...a/whisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==) | `82.11% <ø> (ø)` | :arrow_up: | | [...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=) | `94.82% <100%> (+0.09%)` | :arrow_up: | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `71.51% <100%> (+1.75%)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `78.37% <100%> (+0.75%)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/ApiUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BcGlVdGlscy5zY2FsYQ==) | `66.66% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `83.76% <100%> (-0.11%)` | :arrow_down: | | [...in/scala/whisk/core/database/DocumentFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvRG9jdW1lbnRGYWN0b3J5LnNjYWxh) | `89.47% <100%> (ø)` | :arrow_up: | | [...main/scala/whisk/core/entity/WhiskActivation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aXZhdGlvbi5zY2FsYQ==) | `91.37% <100%> (+0.15%)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `83.33% <100%> (ø)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.26% <80%> (ø)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=footer). Last update [ed71ee0...d1958cd](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] csantanapr closed pull request #3654: Issues/3653 - Ansible playbook openwhisk.yml fails to find whisk/cont…
csantanapr closed pull request #3654: Issues/3653 - Ansible playbook
openwhisk.yml fails to find whisk/cont…
URL: https://github.com/apache/incubator-openwhisk/pull/3654
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/group_vars/all b/ansible/group_vars/all
index d4258b8eb6..777ed3ad93 100644
--- a/ansible/group_vars/all
+++ b/ansible/group_vars/all
@@ -233,7 +233,7 @@ docker:
# docker commands on a machine setup with prereq_build.yml
#user:
image:
-prefix: "{{ docker_image_prefix | default('whisk') }}"
+prefix: "{{ docker_image_prefix | default('openwhisk') }}"
tag: "{{ docker_image_tag | default('latest') }}"
version: 1.12.0-0~trusty
storagedriver: overlay
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #10: Can't run tests in OSX
csantanapr commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-389839011 @sciabarra I went ahead and enabled Travis to run on master branch daily to see how often it fails and which tests fail This way we can help collect data on where is the code or tests having trouble. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3502: Immutable attachments via putAndAttach
csantanapr commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-389835826 What’s the latest status on this PR? @dubee Does this affect or related to your ArtifactStore work? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3663: Support SPI for ContainerPool and ContainerProxy
csantanapr commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-389834596 @style95 Closing the PR and then re-opening the PR will trigger the build again in Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #10: Can't run tests in OSX
csantanapr commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-389832783 Tests sometimes fail on Travis also And also fail in OSX also Maybe there is a race condition on the tests with concurrent procs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junoyoon commented on issue #3570: ArtifactStore implementation for MongoDB
junoyoon commented on issue #3570: ArtifactStore implementation for MongoDB URL: https://github.com/apache/incubator-openwhisk/pull/3570#issuecomment-389820765 rebase please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3502: Immutable attachments via putAndAttach
codecov-io commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-389761107 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=h1) Report > Merging [#3502](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr=desc) will **increase** coverage by `0.49%`. > The diff coverage is `96.82%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3502 +/- ## == + Coverage 74.49% 74.98% +0.49% == Files 126 126 Lines5990 6017 +27 Branches 390 388 -2 == + Hits 4462 4512 +50 + Misses 1528 1505 -23 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=tree) | Coverage Δ | | |---|---|---| | [...a/whisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==) | `82.11% <ø> (ø)` | :arrow_up: | | [...in/scala/whisk/core/database/DocumentFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvRG9jdW1lbnRGYWN0b3J5LnNjYWxh) | `89.28% <100%> (-0.19%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `83.33% <100%> (ø)` | :arrow_up: | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `71.51% <100%> (+1.75%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `83.76% <100%> (-0.11%)` | :arrow_down: | | [...main/scala/whisk/core/entity/WhiskActivation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aXZhdGlvbi5zY2FsYQ==) | `91.37% <100%> (+0.15%)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `78.37% <100%> (+0.75%)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/ApiUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BcGlVdGlscy5zY2FsYQ==) | `66.66% <100%> (ø)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.26% <80%> (ø)` | :arrow_up: | | [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `96.55% <96%> (+17.76%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=footer). Last update [ed71ee0...ff70c9f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3502?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an
[GitHub] chetanmeh commented on a change in pull request #3619: Provide an activation store SPI
chetanmeh commented on a change in pull request #3619: Provide an activation
store SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r188849747
##
File path: common/scala/src/main/scala/whisk/core/entity/ActivationStore.scala
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import java.time.Instant
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import spray.json.JsObject
+import whisk.common.{Logging, TransactionId}
+import whisk.core.database.CacheChangeNotification
+import whisk.spi.Spi
+
+import scala.concurrent.Future
+
+trait ActivationStore {
+
+ def store(activation: WhiskActivation)(implicit transid: TransactionId,
+ notifier:
Option[CacheChangeNotification]): Future[DocInfo]
+
+ def get(activationId: ActivationId)(implicit transid: TransactionId):
Future[WhiskActivation]
+
+ def delete(activationId: ActivationId)(implicit transid: TransactionId,
+ notifier:
Option[CacheChangeNotification]): Future[Boolean]
+
+ def response(activationId: ActivationId)(implicit transid: TransactionId):
Future[WhiskActivation]
Review comment:
Whats the difference between `get` and `response`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3663: Support SPI for ContainerPool and ContainerProxy
codecov-io commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-389757306 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=h1) Report > Merging [#3663](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/22c0807b9eae20af9acc70b91a1943dd35a95092?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `87.45%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3663 +/- ## == - Coverage 74.49% 74.41% -0.08% == Files 126 126 Lines5990 5996 +6 Branches 390 393 +3 == Hits 4462 4462 - Misses 1528 1534 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [...hisk/core/containerpool/DefaultContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9EZWZhdWx0Q29udGFpbmVyUG9vbC5zY2FsYQ==) | `84.88% <84.88%> (ø)` | | | [...isk/core/containerpool/DefaultContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9EZWZhdWx0Q29udGFpbmVyUHJveHkuc2NhbGE=) | `91.27% <91.27%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=footer). Last update [22c0807...a3c21b2](https://codecov.io/gh/apache/incubator-openwhisk/pull/3663?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389755413 @Himavanth take a look at this branch: https://github.com/apache/incubator-openwhisk/compare/master...rabbah:stemcells?expand=1 I rebased this PR to master, resolved conflicts, and made a few changes, organized as separate commits. If you're agreeable, I can open a PR to supersede this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarra commented on issue #10: Can't run tests in OSX
sciabarra commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-389755164 Tests now runs for me in all the case after I added the "fixture" (TestMain) to compile only once. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
