[GitHub] codecov-io commented on issue #2941: Add api gateway test that uses custom package for action
codecov-io commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-396118743 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=h1) Report > Merging [#2941](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr=desc) will **increase** coverage by `1%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2941 +/- ## === + Coverage 73.94% 74.94% +1% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4500 4561 +61 + Misses 1586 1525 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+31.24%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=footer). Last update [8f58103...99ec8f0](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2941: Add api gateway test that uses custom package for action
codecov-io commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-396118743 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=h1) Report > Merging [#2941](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr=desc) will **increase** coverage by `1%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2941 +/- ## === + Coverage 73.94% 74.94% +1% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4500 4561 +61 + Misses 1586 1525 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+31.24%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=footer). Last update [8f58103...99ec8f0](https://codecov.io/gh/apache/incubator-openwhisk/pull/2941?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3751: Allow invoker pools to overlap for small N.
codecov-io commented on issue #3751: Allow invoker pools to overlap for small N. URL: https://github.com/apache/incubator-openwhisk/pull/3751#issuecomment-396465146 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=h1) Report > Merging [#3751](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr=desc) will **increase** coverage by `1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3751 +/- ## === + Coverage 73.94% 74.94% +1% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4500 4561 +61 + Misses 1586 1525 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+31.24%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=footer). Last update [8f58103...d2fb7d8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3751?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3693: new invokers cause load balancer to reallocate black box invokers
rabbah commented on issue #3693: new invokers cause load balancer to reallocate black box invokers URL: https://github.com/apache/incubator-openwhisk/issues/3693#issuecomment-396461426 @Ahmed-elsayed-mahmoud this is the issue I mentioned on slack and the accompanying PR #3751. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3751: Allow invoker pools to overlap for small N.
rabbah opened a new pull request #3751: Allow invoker pools to overlap for small N. URL: https://github.com/apache/incubator-openwhisk/pull/3751 ## Description For small N, allow the managed invokers to overlap with blackbox invokers. As an example, for a blackbox fraction of 10%, and two invokers, the blackbox pool will have size 1, but the managed pool will utilize both invokers. ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3693) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3750: Fix arithmetic bug calculating blackbox and managed invokers.
codecov-io commented on issue #3750: Fix arithmetic bug calculating blackbox and managed invokers. URL: https://github.com/apache/incubator-openwhisk/pull/3750#issuecomment-396453489 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=h1) Report > Merging [#3750](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr=desc) will **increase** coverage by `1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3750 +/- ## === + Coverage 73.94% 74.94% +1% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4500 4561 +61 + Misses 1586 1525 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <100%> (ø)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+31.24%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=footer). Last update [8f58103...8f58103](https://codecov.io/gh/apache/incubator-openwhisk/pull/3750?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3749: managed and blackbox invoker counts are wrong when adding new invokers
rabbah closed issue #3749: managed and blackbox invoker counts are wrong when adding new invokers URL: https://github.com/apache/incubator-openwhisk/issues/3749 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified.
codecov-io commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1) Report > Merging [#3680](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f581036f1419590b659510a6474044901bcb0f5?src=pr=desc) will **increase** coverage by `1.05%`. > The diff coverage is `76.92%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3680 +/- ## == + Coverage 73.94% 74.99% +1.05% == Files 128 128 Lines6086 6075 -11 Branches 388 388 == + Hits 4500 4556 +56 + Misses 1586 1519 -67 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92% <100%> (-0.25%)` | :arrow_down: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.29% <100%> (+14.58%)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <100%> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <100%> (ø)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `56.52% <0%> (+5.54%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=footer). Last update [8f58103...3996c6d](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] rabbah closed pull request #3750: Fix arithmetic bug calculating blackbox and managed invokers.
rabbah closed pull request #3750: Fix arithmetic bug calculating blackbox and managed invokers. URL: https://github.com/apache/incubator-openwhisk/pull/3750 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3750: Fix arithmetic bug calculating blackbox and managed invokers.
rabbah opened a new pull request #3750: Fix arithmetic bug calculating blackbox and managed invokers. URL: https://github.com/apache/incubator-openwhisk/pull/3750 This patch fixes a bug computing the number of blackbox and managed invokers. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#3749) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #3749: managed and blackbox invoker counts are wrong when adding new invokers
rabbah opened a new issue #3749: managed and blackbox invoker counts are wrong when adding new invokers URL: https://github.com/apache/incubator-openwhisk/issues/3749 If you deploy additional invokers, they will register with the load balancer but will not get assigned additional load. https://github.com/apache/incubator-openwhisk/blob/6a5ef98d80c5b1f857ef8baaef93b522662a88ef/core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala#L427-L428 Need to `floor` and `ceil` these expressions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #216: Stop testing non-Helm based deployments
daisy-ycguo closed pull request #216: Stop testing non-Helm based deployments
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/216
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 888237c..da8d137 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,10 +7,9 @@ env:
- secure:
d7CuMXbhT83W2x78qiLwgogX1+3aPicd1PlTwwNNDN6QSkImbxareyKThnsqlHIiNj3o5l5DBuiYjy7wrF/xD1g8BQMmTwm99DRx5q3CI3Im3VCi/ZK8SaNjuOy24d7cf5k2tB/87Gk7zmKsMDYm+fpCl+GpgUmIEeIwthiAxuXSDWZ8eQPIptmxj56DeFRNouvXG+dEUtBfWiwN27UPxNKExCixFnegmdtffLbz6hhst7BHr5Ry9acbycre98PCwWZcu9lxFs+SJ1kvnzX2iue4otmDkF1WkJjxaOFPJVs/D3YItg+neLCSxjwBskPed+Fct8bOjcM/uVROJPNIq5icBmaPX2isH0lvtxOeVw/dmioWYXYPN9ygBOe4eO/vtPllN0bcAUo5xl9jXev8ciAozYrYpHVh9Fplfd81rcYTeYzALmRJBdoiWoc3KQGzwGc9sB1ffmy+KWgG9T0zbnS4fALSR4PSzyNlKSLXw9vuvdNP0OBYtO+6yTJXavIxqmDoj64Lb93n+uGPatnaIGPTKEEBMJTSjsgYVEfxzzZuxUT9Ldkf2lzqvN2PCllGoMqxkgsdb8i4v4QgRaMWBDbKa5Va4k0O4dnhRmtdbJavOSKN6fECJbyfoJlV1VvJGxk5znVLRznBmUPBKbNccyPZJULugKD3QIh4q8Q5jBU=
- secure:
CJtnU94HTDqd4A6uvhFl8IpnmU+wTdlzb8bPBFUl/lI/VKXiRrYpgJdKUro5xEoxFKuqMprLhbyf66niyWLTIeogjUAEu/h/o2dBVeGgSGKoqC0hQgqvnxKFeGlzFJ0XuEs3vbStJGRnQszGsfnnDrscJtR0x9X+1w4aBKI7iPyyuFtVkDD1UsmBbSi+M8FTeq7G7A0reMDaey7uog3CFCpIMl4geshcohQEcKEGbnXQZoLPFpb7cBOE83VXBJ7Y7Dgf/U4keiLovvnuJThGKZm/SVV2KlELmBmtmbx3rMT6Vb5k9ChSdRWapromNnnzmJBIQ5Scc2mwV3A93/SMha1F3IlYpDKs5djfTw8jZfVnuiou7HhTaRjHkmmcwP12/k30gLe2kw0Vezg1TCY4zgtOpcmCxc8RHEy0ceA74rKvRi8LbexTCwX+iAMQFn/pSrh/OqAq/50JbLyczcoO1zXWS38txUQNLW8i+XllhCg9pjkjyfBeGjOOcWiVIz9rWJd2XufjSXDcj6xoZHtkh1XDt1CnVkpsYKtyyZucQnhUM9ebmaWqbSW2+bpqC/2hI+G+kOyyCesGdB1q+VmN1augMMs6RgWjk4yw5dyLAshATSoUlE8KH2cDcJL19r4ECaQ99PSLwxoB89yfPoJiNc42vwxRdsLmB1BMNyPa81Y=
matrix:
-- TRAVIS_USE_HELM=true OW_CONTAINER_FACTORY=docker
TRAVIS_KUBE_VERSION=v1.8.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
-- TRAVIS_USE_HELM=true OW_CONTAINER_FACTORY=docker
TRAVIS_KUBE_VERSION=v1.9.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
-- TRAVIS_USE_HELM=false OW_CONTAINER_FACTORY=docker
TRAVIS_KUBE_VERSION=v1.9.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
-- TRAVIS_USE_HELM=true OW_CONTAINER_FACTORY=kubernetes
TRAVIS_KUBE_VERSION=v1.9.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
+- TRAVIS_KUBE_VERSION=v1.8.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
OW_CONTAINER_FACTORY=docker
+- TRAVIS_KUBE_VERSION=v1.9.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
OW_CONTAINER_FACTORY=docker
+- TRAVIS_KUBE_VERSION=v1.9.0 TRAVIS_MINIKUBE_VERSION=v0.25.2
OW_CONTAINER_FACTORY=kubernetes
services:
- docker
@@ -29,7 +28,6 @@ before_install:
script:
- ./tools/travis/scancode.sh
- ./tools/travis/build-helm.sh
- - ./tools/travis/build.sh
- ./tools/travis/collect-logs.sh
- ./tools/travis/box-upload.py "logs"
"deploy-kube-$TRAVIS_BUILD_ID-$TRAVIS_BRANCH-$TRAVIS_JOB_NUMBER.tar.gz"
diff --git a/tools/travis/build-helm.sh b/tools/travis/build-helm.sh
index b4b4857..f73740a 100755
--- a/tools/travis/build-helm.sh
+++ b/tools/travis/build-helm.sh
@@ -115,11 +115,6 @@ set -x
SCRIPTDIR=$(cd $(dirname "$0") && pwd)
ROOTDIR="$SCRIPTDIR/../../"
-# If TRAVIS and !TRAVIS_USE_HELM, just exit (don't test HELM deploy)
-if [[ "$TRAVIS" = "true" ]] && [[ "$TRAVIS_USE_HELM" = "false" ]]; then
-exit 0
-fi
-
# Default to docker container factory if not specified
OW_CONTAINER_FACTORY=${OW_CONTAINER_FACTORY:="docker"}
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
deleted file mode 100755
index 48f1348..000
--- a/tools/travis/build.sh
+++ /dev/null
@@ -1,331 +0,0 @@
-#!/bin/bash
-# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
-# license agreements; and to You under the Apache License, Version 2.0.
-
-#
-# Helper functions for verifying pod creation
-#
-
-couchdbHealthCheck () {
- # wait for the pod to be created before getting the job name
- sleep 5
- POD_NAME=$(kubectl -n openwhisk get pods -l name=couchdb -o wide --show-all
| grep "couchdb" | awk '{print $1}')
-
- PASSED=false
- TIMEOUT=0
- until [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
-if [ -n "$(kubectl -n openwhisk logs $POD_NAME | grep "successfully setup
and configured CouchDB")" ]; then
- PASSED=true
- break
-fi
-
-let TIMEOUT=TIMEOUT+1
-sleep 10
- done
-
- if [ "$PASSED" = false ]; then
-echo "Failed to finish deploying CouchDB"
-
-kubectl -n openwhisk logs $POD_NAME
-exit 1
- fi
-
- echo "CouchDB is up and running"
-}
-
-deploymentHealthCheck () {
- if [ -z "$1" ]; then
-echo "Error, component health check called without a component parameter"
-exit 1
- fi
-
- PASSED=false
- TIMEOUT=0
- until $PASSED || [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
-KUBE_DEPLOY_STATUS=$(kubectl -n openwhisk get
[GitHub] dgrove-oss opened a new pull request #217: add license header
dgrove-oss opened a new pull request #217: add license header
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217
license header is inside Go template comment markers ( {{/* ... */}}) to
keep it from appearing in end-user visible text (the usage message generated
from NOTES.txt).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss opened a new issue #46: scan code is not checking .txt files for license
dgrove-oss opened a new issue #46: scan code is not checking .txt files for license URL: https://github.com/apache/incubator-openwhisk-utilities/issues/46 In the openwhisk-kube-deploy project, the file home/templates/Notes.txt does not have a license header. However, scancode with the ASF-Release.cfg is not detecting this because it appears to not be scanning any file with a .txt extension for a license. Appended is the relevant snippet from the verbose output of the tool. ``` [/Users/dgrove/code/openwhisk/incubator-openwhisk-deploy-kube/tools/travis/../../NOTICE.txt]... [36mRunning Line Check [regex_check][0m [/Users/dgrove/code/openwhisk/incubator-openwhisk-deploy-kube/tools/travis/../../LICENSE.txt]... [36mRunning Line Check [regex_check][0m [/Users/dgrove/code/openwhisk/incubator-openwhisk-deploy-kube/tools/travis/../../helm/templates/NOTES.txt]... [36mRunning Line Check [regex_check][0m [/Users/dgrove/code/openwhisk/incubator-openwhisk-deploy-kube/tools/travis/../../.travis.yml]... [36mRunning File Check [has_block_license][0m [36mRunning Line Check [no_trailing_spaces][0m [36mRunning Line Check [eol_at_eof][0m [36mRunning Line Check [regex_check][0m ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r194578413 ## File path: tests/src/test/scala/actionContainers/Ruby25ActionContainerTests.scala ## @@ -0,0 +1,408 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: I have removed this with 3cc287c1f67181c1d6c66ff59bbda01b913bcfa1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r194578413 ## File path: tests/src/test/scala/actionContainers/Ruby25ActionContainerTests.scala ## @@ -0,0 +1,408 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: I have removed this at 3cc287c1f67181c1d6c66ff59bbda01b913bcfa1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396400309 If we add Kube, do we add Mesos? At this point, if adding Kube is that important for first release (cannot wait 2 weeks) then we can add it. BUT, we will need to delay at least 2 days to add to scripts and do some dry runs and go through EVERY file as we have done for the existing 12 repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396405440 @rabbah thanks Rodric, we will try.. will look at all the files tomorrow in detail... and if we hit a snag will inform here... LUCKY 13! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
rabbah commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396403119 Thanks for the explanation Matt. I think it’s worth trying quickly. If you find it’s too much work and will delay the release then we should defer. IMO if we can include kube it’s a win but getting the first release out i think we all agree is a very meanginful milestone. As for Mesos I’m not sure and will need to defer to others as I have not followed that very closely myself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #181: Add openwhisk-kube-deploy to list of release repos.
houshengbo closed pull request #181: Add openwhisk-kube-deploy to list of
release repos.
URL: https://github.com/apache/incubator-openwhisk-release/pull/181
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 61e747d..9a934de 100644
--- a/README.md
+++ b/README.md
@@ -117,6 +117,14 @@ The following table can be used by Release Managers to get
quickly check the sta
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/tools/travis/scancode.sh;>scancode.sh
+https://github.com/apache/incubator-openwhisk-deploy-kube;>incubator-openwhisk-deploy-kube
+https://travis-ci.org/apache/incubator-openwhisk-deploy-kube/branches;>https://travis-ci.org/apache/incubator-openwhisk-deploy-kube.svg?branch=master;
alt="" />
+https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/LICENSE.txt;>https://img.shields.io/badge/license-Apache--2.0-blue.svg; alt=""
/>
+https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/NOTICE.txt;>NOTICE
+https://openwhisk-team.slack.com/messages/C4J3R7JFL/;>https://img.shields.io/badge/channel-Slack-800080.svg; alt="" />
+https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/tools/travis/scancode.sh;>scancode.sh
+
+
https://github.com/apache/incubator-openwhisk-runtime-nodejs;>incubator-openwhisk-runtime-nodejs
https://travis-ci.org/apache/incubator-openwhisk-runtime-nodejs/branches;>https://travis-ci.org/apache/incubator-openwhisk-runtime-nodejs.svg?branch=master;
alt="" />
https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/LICENSE.txt;>https://camo.githubusercontent.com/3a4d3bc039085cffdfecbe3077ffe49c5fe23286/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f6c6963656e73652d4170616368652d2d322e302d626c75652e737667;
alt="" />
diff --git a/docs/general_spec.md b/docs/general_spec.md
index c04c089..dd9e711 100644
--- a/docs/general_spec.md
+++ b/docs/general_spec.md
@@ -63,6 +63,8 @@ We plan to release the following OpenWhisk repositories:
-
[incubator-openwhisk-runtime-docker](https://github.com/apache/incubator-openwhisk-runtime-docker)
- OpenWhisk catalog:
[incubator-openwhisk-catalog](https://github.com/apache/incubator-openwhisk-catalog)
- OpenWhisk API gateway:
[incubator-openwhisk-apigateway](https://github.com/apache/incubator-openwhisk-apigateway)
+- OpenWhisk deployment support:
+-
[incubator-openwhisk-deploy-kube](https://github.com/apache/incubator-openwhisk-deploy-kube)
- OpenWhisk clients:
-
[incubator-openwhisk-client-go](https://github.com/apache/incubator-openwhisk-client-go)
-
[incubator-openwhisk-cli](https://github.com/apache/incubator-openwhisk-cli)
diff --git a/tools/config.json b/tools/config.json
index 97fdfff..ade5ea2 100644
--- a/tools/config.json
+++ b/tools/config.json
@@ -12,6 +12,7 @@
"openwhisk-cli",
"openwhisk-client-go",
"openwhisk-catalog",
+"openwhisk-deploy-kube",
"openwhisk-apigateway",
"openwhisk-runtime-nodejs",
"openwhisk-runtime-swift",
@@ -47,6 +48,11 @@
"repository": "https://github.com/apache/incubator-openwhisk-catalog.git;,
"branch": "master"
},
+ "openwhisk_deploy_kube": {
+"hash": "7340cc9",
+"repository":
"https://github.com/apache/incubator-openwhisk-deploy-kube.git;,
+"branch": "master"
+ },
"openwhisk_apigateway": {
"hash": "8907ab9",
"repository":
"https://github.com/apache/incubator-openwhisk-apigateway.git;,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396401713 @houshengbo @rabbah @dgrove-oss Vincent and I spoke and he will start adding Kube to release automation. It should be ready I agree, but we will have to dry-run and look at all the files as indicated. Vincent will engage the dev list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #140: Key words like IBM, Adobe, etc should be removed from the source code
houshengbo closed issue #140: Key words like IBM, Adobe, etc should be removed from the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/140 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396400309 If we add Kube, do we add Mesos? At this point, if adding Kube is that important for first release (cannot wait 2 weeks) then we can add it. BUT, we will need to delay at least 2 days to add to scripts and do some dry runs and go through VERY file as we have done for the existing 12 repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #141: Some license files copied from client-go are not exactly same as original one.
houshengbo commented on issue #141: Some license files copied from client-go are not exactly same as original one. URL: https://github.com/apache/incubator-openwhisk-release/issues/141#issuecomment-396399956 We have changed to Copyright 2015-2018 The Apache Software Foundation for all LICENSE and NOTICE files, so this issue can be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #141: Some license files copied from client-go are not exactly same as original one.
houshengbo closed issue #141: Some license files copied from client-go are not exactly same as original one. URL: https://github.com/apache/incubator-openwhisk-release/issues/141 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
mrutkows commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396399275 @rabbah we had planned to submit the vote by EOD Wed. (or sooner) to the "dev" list. I have no doubt that the Kube repo. may be ready as my team has been assuming we will add Kube ASAP (and Go runtime), but would rather get the first source release behind us and then add Kube in the next 2 weeks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #132: Document treatment of .conf files as part of LICENSE header exclusions/inclusion
houshengbo closed issue #132: Document treatment of .conf files as part of LICENSE header exclusions/inclusion URL: https://github.com/apache/incubator-openwhisk-release/issues/132 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #130: Revisit LICENSE.txt vs. LICENSE or document decision
houshengbo closed issue #130: Revisit LICENSE.txt vs. LICENSE or document decision URL: https://github.com/apache/incubator-openwhisk-release/issues/130 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #132: Document treatment of .conf files as part of LICENSE header exclusions/inclusion
houshengbo commented on issue #132: Document treatment of .conf files as part of LICENSE header exclusions/inclusion URL: https://github.com/apache/incubator-openwhisk-release/issues/132#issuecomment-396397474 We have added the headers to all the .conf files in api gateway repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #107: Do we need to add LICENSE header to binary files?
houshengbo commented on issue #107: Do we need to add LICENSE header to binary files? URL: https://github.com/apache/incubator-openwhisk-release/issues/107#issuecomment-396396031 We will revisit this issue for further binary releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #93: Track LICENSE and NOTICE issues for `incubator-openwhisk`
houshengbo closed issue #93: Track LICENSE and NOTICE issues for `incubator-openwhisk` URL: https://github.com/apache/incubator-openwhisk-release/issues/93 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #99: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-nodejs`
houshengbo closed issue #99: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-nodejs` URL: https://github.com/apache/incubator-openwhisk-release/issues/99 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #100: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-swift`
houshengbo closed issue #100: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-swift` URL: https://github.com/apache/incubator-openwhisk-release/issues/100 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #659: Add flag to suppress Warnings -warning false
mrutkows closed issue #659: Add flag to suppress Warnings -warning false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/659 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #940: API section doesn't support path parameters
mrutkows closed issue #940: API section doesn't support path parameters URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/940 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #724: API Gateway - Add support to specify response type in manifest file
mrutkows closed issue #724: API Gateway - Add support to specify response type in manifest file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #916: deploying manifest containing APIs with same backend action fails
mrutkows closed issue #916: deploying manifest containing APIs with same backend action fails URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/916 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #944: API section doesn't support response-type
mrutkows closed issue #944: API section doesn't support response-type URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/944 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker`
mrutkows opened a new issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker` URL: https://github.com/apache/incubator-openwhisk-release/issues/101 Please use this issue to track any issues surrounding either the [LICENSE.txt](https://github.com/apache/incubator-openwhisk-runtime-docker/blob/master/LICENSE.txt) or [NOTICE.txt](https://github.com/apache/incubator-openwhisk-runtime-doscker/blob/master/NOTICE.txt) file for the associated repository listed in the title. **Open Issues/PRs**: - _None_ **Closed Issues/Merged PRs**: - PR [#18 - Add the NOTICE file](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/18) - PR [#25 - update notice file](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/25) - Issue [#80 - Review NOTICE file for incubator-openwhisk-runtime-docker](https://github.com/apache/incubator-openwhisk-release/issues/80) - PR [#27 - Add license headers](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/27) - Issue [#19 - Add the license headers](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/19) - Issue [#20 - Some source files miss Apache license headers](https://github.com/apache/incubator-openwhisk-runtime-docker/issues/20) - PR [#28 - Add the licenses of the dependencies into LICENSE](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/28) - PR [#29 - Add scancode using ASF config. to Travis build](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/29) - PR [#32 - Update .md and .sh files to pass scancode with latest .cfg](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/32) - PR [#33 - Add ASF license headers to all Scala .conf files](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/33) - PR [#36 - Fix markdown files with a typo. in the Hash license header](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/36) - PR [#37 - Restore the LICENSE and NOTICE to fit the source code release](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/37) - PR [#38 - Fix travis yaml file asf header, change to mini.](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/38) - PR [#39 - Last files to need ASF License headers.](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/39) - PI [#40 - Fix example.c to have correct ASF license header](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/40) - PR [#41 - Fix bad Dockerfile license and use ASF release config](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/41) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker`
houshengbo closed issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker` URL: https://github.com/apache/incubator-openwhisk-release/issues/101 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker`
houshengbo closed issue #101: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-docker` URL: https://github.com/apache/incubator-openwhisk-release/issues/101 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #102: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-java`
houshengbo closed issue #102: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-java` URL: https://github.com/apache/incubator-openwhisk-release/issues/102 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #103: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-php`
houshengbo closed issue #103: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-php` URL: https://github.com/apache/incubator-openwhisk-release/issues/103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #104: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-python`
houshengbo closed issue #104: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-python` URL: https://github.com/apache/incubator-openwhisk-release/issues/104 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #104: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-python`
houshengbo commented on issue #104: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-python` URL: https://github.com/apache/incubator-openwhisk-release/issues/104#issuecomment-396392798 All PRs have been merged, so this issue can be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #120: Define format of LICENSE file
houshengbo closed issue #120: Define format of LICENSE file URL: https://github.com/apache/incubator-openwhisk-release/issues/120 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #120: Define format of LICENSE file
houshengbo commented on issue #120: Define format of LICENSE file URL: https://github.com/apache/incubator-openwhisk-release/issues/120#issuecomment-396391239 @daisy-ycguo @mrutkows We can refer to what are under https://github.com/apache/incubator-openwhisk-release/tree/master/archive/convenience-binaries for the format of the LICENSE and NOTICE. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #137: JDK license issue for the runtime Java
houshengbo commented on issue #137: JDK license issue for the runtime Java URL: https://github.com/apache/incubator-openwhisk-release/issues/137#issuecomment-396390975 Revisit this issue for further binary releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #122: Documentation requirements for LogBack (default logger)
houshengbo commented on issue #122: Documentation requirements for LogBack (default logger) URL: https://github.com/apache/incubator-openwhisk-release/issues/122#issuecomment-396390854 Revisit this issue for further binary releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #87: Review all (12) NOTICE files for contents
houshengbo closed issue #87: Review all (12) NOTICE files for contents URL: https://github.com/apache/incubator-openwhisk-release/issues/87 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #87: Review all (12) NOTICE files for contents
houshengbo commented on issue #87: Review all (12) NOTICE files for contents URL: https://github.com/apache/incubator-openwhisk-release/issues/87#issuecomment-396390468 @mrutkows We are fine with the LICENSE and NOTICE files so far, since we expect source code release only as the first time release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs.
houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs. URL: https://github.com/apache/incubator-openwhisk-release/issues/63#issuecomment-396390140 @mrutkows This issue has been resolved, since Adobe contributors have changed the headers. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs.
houshengbo closed issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs. URL: https://github.com/apache/incubator-openwhisk-release/issues/63 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed
houshengbo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed URL: https://github.com/apache/incubator-openwhisk-release/issues/34#issuecomment-396389844 For source code release, we do not list them. We will revisit this issue for further binary releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #13: Step 5: Add NOTICE, LICENSE, and CHANGELOG to each OpenWhisk project
houshengbo commented on issue #13: Step 5: Add NOTICE, LICENSE, and CHANGELOG to each OpenWhisk project URL: https://github.com/apache/incubator-openwhisk-release/issues/13#issuecomment-396389506 The LICENSE and NOTICE files have been added to the 12 repos we are about to release for the first time in Apache. We will resolve the issue regarding CHANGELOG during next source code release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #158: Add ASF license to ISSUE_TEMPLATE.md under .github
houshengbo commented on issue #158: Add ASF license to ISSUE_TEMPLATE.md under .github URL: https://github.com/apache/incubator-openwhisk-release/issues/158#issuecomment-396388860 .github is excluded in the source code release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #159: Verify source code release TARs do not contain "ignore" and project tooling files.
houshengbo closed issue #159: Verify source code release TARs do not contain "ignore" and project tooling files. URL: https://github.com/apache/incubator-openwhisk-release/issues/159 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #159: Verify source code release TARs do not contain "ignore" and project tooling files.
houshengbo commented on issue #159: Verify source code release TARs do not contain "ignore" and project tooling files. URL: https://github.com/apache/incubator-openwhisk-release/issues/159#issuecomment-396388684 duplicate of the issue https://github.com/apache/incubator-openwhisk-release/issues/161 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #161: Verify we do not include any tooling dot `.` configuration files in source release
houshengbo commented on issue #161: Verify we do not include any tooling dot `.` configuration files in source release URL: https://github.com/apache/incubator-openwhisk-release/issues/161#issuecomment-396388343 @mrutkows .dockerignore has to stay, because we need to build the docker images locally based on it to determine what are copied into the images. PR to fix this issue: https://github.com/apache/incubator-openwhisk-release/pull/182 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #161: Verify we do not include any tooling dot `.` configuration files in source release
houshengbo commented on issue #161: Verify we do not include any tooling dot `.` configuration files in source release URL: https://github.com/apache/incubator-openwhisk-release/issues/161#issuecomment-396388343 @mrutkows .dockerignore has to stay, because we need to build the docker images locally based on it to determine what are copied into the images. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #165: Do we need to list Lua modules (luarocks) installed as part of build?
houshengbo commented on issue #165: Do we need to list Lua modules (luarocks) installed as part of build? URL: https://github.com/apache/incubator-openwhisk-release/issues/165#issuecomment-396386635 @mrutkows tests are excluded in source code release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #165: Do we need to list Lua modules (luarocks) installed as part of build?
houshengbo closed issue #165: Do we need to list Lua modules (luarocks) installed as part of build? URL: https://github.com/apache/incubator-openwhisk-release/issues/165 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #166: Assure `lua_modules` directory tree (test deps.) is not part of source or binary release.
houshengbo commented on issue #166: Assure `lua_modules` directory tree (test deps.) is not part of source or binary release. URL: https://github.com/apache/incubator-openwhisk-release/issues/166#issuecomment-396386461 @mrutkows Tests folder is excluded, since there will not be any lua_modules module to be released. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #166: Assure `lua_modules` directory tree (test deps.) is not part of source or binary release.
houshengbo closed issue #166: Assure `lua_modules` directory tree (test deps.) is not part of source or binary release. URL: https://github.com/apache/incubator-openwhisk-release/issues/166 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #170: Change directory from 'license' to 'licenses' for runtime-swift
houshengbo closed issue #170: Change directory from 'license' to 'licenses' for runtime-swift URL: https://github.com/apache/incubator-openwhisk-release/issues/170 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #170: Change directory from 'license' to 'licenses' for runtime-swift
houshengbo commented on issue #170: Change directory from 'license' to 'licenses' for runtime-swift URL: https://github.com/apache/incubator-openwhisk-release/issues/170#issuecomment-396386059 @mrutkows This issue is fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files
houshengbo commented on issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files URL: https://github.com/apache/incubator-openwhisk-release/issues/171#issuecomment-396385957 @mrutkows I confirm this issue is resolved. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files
houshengbo closed issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files URL: https://github.com/apache/incubator-openwhisk-release/issues/171 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #182: Exclude specification/archive and specification/diagrams for wskdeploy
houshengbo opened a new pull request #182: Exclude specification/archive and specification/diagrams for wskdeploy URL: https://github.com/apache/incubator-openwhisk-release/pull/182 Closes: #175 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)
houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release) URL: https://github.com/apache/incubator-openwhisk-release/issues/153#issuecomment-396383412 @mrutkows We have already resolved this issue, since both openwhisk and openwhisk runtime java have adopted Open JDK from adoptopenjdk. https://github.com/apache/incubator-openwhisk/commit/71e25c201aa3ba71137dfb434a6e4fb595741956 JDK becomes configurable for users to build their openwhisk environment. https://github.com/apache/incubator-openwhisk/commit/5aa8fc7fa6a09f219f704d301541b213b9aa07c8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)
houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release) URL: https://github.com/apache/incubator-openwhisk-release/issues/153#issuecomment-396383412 @mrutkows We have already resolved this issue, since both openwhisk and openwhisk runtime java have adopted Open JDK from adoptopenjdk. JDK becomes configurable for users to build their openwhisk environment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)
houshengbo closed issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release) URL: https://github.com/apache/incubator-openwhisk-release/issues/153 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)
houshengbo commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release) URL: https://github.com/apache/incubator-openwhisk-release/issues/153#issuecomment-396383412 @mrutkows We have already resolved this issue, since both openwhisk and openwhisk runtime java have adopted Open JDK from adoptopenjdk. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #177: Can we remove gradle-wrapper.jar from TAR files?
houshengbo commented on issue #177: Can we remove gradle-wrapper.jar from TAR files? URL: https://github.com/apache/incubator-openwhisk-release/issues/177#issuecomment-396382954 @mrutkows As we discussed, we can keep the gradle wrapper in the source code release. Apache Beam can be our reference for the wrapper solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #177: Can we remove gradle-wrapper.jar from TAR files?
houshengbo closed issue #177: Can we remove gradle-wrapper.jar from TAR files? URL: https://github.com/apache/incubator-openwhisk-release/issues/177 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
rabbah commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396382802 Vincent what’s the rationale for notn ncluding this in the first release with the increasing prevalence of kube? We should discuss this on the dev list. In any case we’ll need a vote in the RC. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #179: Do we need to add JIRA automation (changes.md gen) and track Fix Versions
houshengbo commented on issue #179: Do we need to add JIRA automation (changes.md gen) and track Fix Versions URL: https://github.com/apache/incubator-openwhisk-release/issues/179#issuecomment-396382555 @mrutkows So far, we can stay with our process as documented in the instruction of openwhisk release. Our instruction for the release manager is informative enough for us to follow in order to release. We can opened an issue in JIRA called "Calling for release of OpenWhisk", listing all the artifacts we release and make the community aware of that we are in the process of the release, and ask them to read the email, test and vote. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #178: Verify each TAR has changes(.md or .txt) included
houshengbo commented on issue #178: Verify each TAR has changes(.md or .txt) included URL: https://github.com/apache/incubator-openwhisk-release/issues/178#issuecomment-396381447 @mrutkows Since the very first release contains the initial code, we do not need it by far. This function will definitely be added for the further releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #181: Add openwhisk-kube-deploy to list of release repos.
houshengbo commented on issue #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181#issuecomment-396380105 For the first source code release, we have decided to pick up the existing 12 openwhisk repositories. At this moment, we do not add new repository. Sorry about that, but this PR will be added for the second source code release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3685: Enable test code coverage collection for containers
csantanapr commented on issue #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685#issuecomment-396353952 PG3 2361 looks good This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3619: Provide an activation store SPI
dubee commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-396353658 @markusthoemmes, anything else on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3453: Introduce a AttachmentStore SPI
csantanapr commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-396353552 PG1 3010 looks good This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #58: can't override npm packages that are embedded when extending runtime image.
csantanapr opened a new issue #58: can't override npm packages that are
embedded when extending runtime image.
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/58
Given that I have a `package.json` that I want to use to extend the nodejs
runtime
Let's say I want to use a different version of npm package `openwhisk` and
some of my own.
package.json:
```json
{
"dependencies": {
"cowsay": "^1.3.0",
"openwhisk": "2.0.0"
}
}
```
I have the following `Dockerfile`
```dockerfile
FROM openwhisk/action-nodejs-v8
COPY package.json .
RUN npm i --production
```
Running this will not work. This is how I want it to work.
This will wipe the already present `/nodejsAction/node_modules` directory
and install my new npm packages `openwhisk` and `cowsay`
A 1/2 workaround is to install my dependcies in the parent directory of
`/nodejsAction/` which `/`
This way nodejs ref [1] will not find it in `/nodejsAction/tmpXX` or
`/nodejsAction/` and fall back to `/`
```dockerfile
FROM openwhisk/action-nodejs-v8
COPY package.json /
RUN cd / && npm i --production
```
This will only to find `cowsay` in the `/node_modules` but will find the
`1.x` `openwhisk` in `/nodejsAction/node_modules` and never use the version
`2.0.0` where I installed it `/node_modules/openwhisk`
My proposed solution is that we installed embedded npm packages in in the
root `/` this way they act as fallback global modules in the search path, and
user is always able to declare the npm packages he wants to use in the action.
cc @rabbah
[1]:
https://nodejs.org/api/modules.html#modules_loading_from_node_modules_folders
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3568: Add activation result integration test
rabbah commented on a change in pull request #3568: Add activation result
integration test
URL:
https://github.com/apache/incubator-openwhisk/pull/3568#discussion_r194485364
##
File path: tests/src/test/scala/system/basic/WskActivationTests.scala
##
@@ -54,4 +57,24 @@ abstract class WskActivationTests extends TestHelpers with
WskTestHelpers with J
}, 10, Some(1.second))
}
}
+
+ it should "fetch result using activation result API" in
withAssetCleaner(wskprops) { (wp, assetHelper) =>
+val name = "hello"
+val expectedResult = JsObject("payload" -> "hello, undefined!".toJson)
+
+assetHelper.withCleaner(wsk.action, name) { (action, _) =>
+ action.create(name, Some(TestUtils.getTestActionFilename("hello.js")))
+}
+
+val run = wsk.action.invoke(name, blocking = true)
+
+// Use withActivation() to reduce intermittent failures that may result
from eventually consistent DBs
+withActivation(wsk.activation, run) { activation =>
+ retry({
+val result =
wsk.activation.result(Some(activation.activationId)).stdout
+
+result should include(expectedResult.compactPrint)
Review comment:
As to making the CLI and REST responses appear the same, this is related to
the HTTP status code when the action errors which we've not closed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on issue #3568: Add activation result integration test
dubee commented on issue #3568: Add activation result integration test URL: https://github.com/apache/incubator-openwhisk/pull/3568#issuecomment-396321661 @rabbah, removed the retry loop as it will not be needed with the future ActivationStore changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3568: Add activation result integration test
dubee commented on issue #3568: Add activation result integration test URL: https://github.com/apache/incubator-openwhisk/pull/3568#issuecomment-396321661 @rabbah, removed the retry loop as it will not be need with the future ActivationStore changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] apercova commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained
apercova commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained URL: https://github.com/apache/incubator-openwhisk-devtools/pull/132#issuecomment-396318882 Hi @ddragosd thank you for reviewing the fix. I wonder if you could give me an insight on what SO's are you testing openwhisk's quick start? Regards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #51: Bump nodejs 8 to latest LTS 8.11.2
csantanapr closed issue #51: Bump nodejs 8 to latest LTS 8.11.2 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/51 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #51: Bump nodejs 8 to latest LTS 8.11.2
csantanapr commented on issue #51: Bump nodejs 8 to latest LTS 8.11.2 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/51#issuecomment-396318121 this is done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #57: CWD is not the root of the zip action
csantanapr opened a new issue #57: CWD is not the root of the zip action
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/57
Problem when your action wants to reference another file in your zip,
locally this is easy because the node process usually get's started from the
root of the project where the `package.json` is located.
For example the following code works fine in my local computer.
Since I'm running the node process locally
```javascript
const fs = require('fs')
exports.main = () => {
const cwd = process.cwd()
const dirname = __dirname
//in openwhisk need to find the root of the zip
console.log(`dirname= ${dirname}`)
console.log(`cwd= ${cwd}`)
const file = fs.readFileSync('secondfile.txt',{encoding:'utf8'})
console.log(file)
return {file, cwd, dirname}
}
```
I run this code in openwhisk I get an error about not found
In openwhisk currently the current working directory (cwd) is set to where
the nodejs process started `/nodejsAction`
This is different from using for example dockerskeleton or python action,
where the cwd is changed to the tmp directory where the the zip action get's
unzip.
For now the workaround is to use `__dirname` like
`${dirname}/secondfile.txt` instead of `secondfile.txt`
```javascript
const fs = require('fs')
exports.main = () => {
const cwd = process.cwd()
const dirname = __dirname
//in openwhisk need to find the root of the zip
console.log(`dirname= ${dirname}`)
console.log(`cwd= ${cwd}`)
const file =
fs.readFileSync(`${dirname}/secondfile.txt`,{encoding:'utf8'})
console.log(file)
return {file, cwd, dirname}
}
```
The fix is in runner.js to change the process directory `process.chdir()` to
the directory where the zip get's extracted
cc @rabbah
https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/core/nodejsActionBase/runner.js#L59
```
process.chdir(moduleDir)
thisRunner.userScriptMain = eval('require("' + moduleDir + '").' +
message.main);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh closed pull request #3748: Mention Slack and mailing list links in issue template
chetanmeh closed pull request #3748: Mention Slack and mailing list links in issue template URL: https://github.com/apache/incubator-openwhisk/pull/3748 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 8ff14324fd..b737cd54a8 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,6 @@
[GitHub] csantanapr closed pull request #3740: Exclude logback-test.xml from test sources jar
csantanapr closed pull request #3740: Exclude logback-test.xml from test
sources jar
URL: https://github.com/apache/incubator-openwhisk/pull/3740
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index ed9f2f51e5..ee49762403 100644
--- a/build.gradle
+++ b/build.gradle
@@ -61,6 +61,7 @@ subprojects {
task testSourcesJar(type: Jar, dependsOn: testClasses) {
classifier = 'test-sources'
from sourceSets.test.allSource
+exclude("logback-test.xml")
}
task testClassesJar(type: Jar, dependsOn: testClasses) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3568: Add activation result integration test
codecov-io commented on issue #3568: Add activation result integration test URL: https://github.com/apache/incubator-openwhisk/pull/3568#issuecomment-396305057 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=h1) Report > Merging [#3568](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/f55af05535c36bed04c798b1ff62e81442517acd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3568 +/- ## === Coverage 74.94% 74.94% === Files 128 128 Lines6086 6086 Branches 388 388 === Hits 4561 4561 Misses 1525 1525 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=footer). Last update [f55af05...d016b88](https://codecov.io/gh/apache/incubator-openwhisk/pull/3568?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3748: Mention Slack and mailing list links in issue template
codecov-io commented on issue #3748: Mention Slack and mailing list links in issue template URL: https://github.com/apache/incubator-openwhisk/pull/3748#issuecomment-396302337 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=h1) Report > Merging [#3748](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/f55af05535c36bed04c798b1ff62e81442517acd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3748 +/- ## === Coverage 74.94% 74.94% === Files 128 128 Lines6086 6086 Branches 388 388 === Hits 4561 4561 Misses 1525 1525 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=footer). Last update [f55af05...7c19f65](https://codecov.io/gh/apache/incubator-openwhisk/pull/3748?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3685: Enable test code coverage collection for containers
codecov-io commented on issue #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685#issuecomment-390943297 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=h1) Report > Merging [#3685](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9445d6100f6e3aa4a00e489ca98f99a3f4a207f5?src=pr=desc) will **increase** coverage by `10.53%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3685 +/- ## === + Coverage 74.92% 85.45% +10.53% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4560 5201 +641 + Misses 1526 885 -641 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `83.76% <0%> (+0.64%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.93% <0%> (+0.67%)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `90.9% <0%> (+1.13%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `88.54% <0%> (+1.52%)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.56% <0%> (+1.75%)` | :arrow_up: | | [...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=) | `97.91% <0%> (+2.08%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `89.65% <0%> (+2.29%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.57% <0%> (+2.32%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `93.84% <0%> (+2.56%)` | :arrow_up: | | [...ala/src/main/scala/whisk/core/entity/DocInfo.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0RvY0luZm8uc2NhbGE=) | `87.09% <0%> (+3.22%)` | :arrow_up: | | ... and [31 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=footer). Last update [9445d61...ad7eec5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] codecov-io commented on issue #3685: Enable test code coverage collection for containers
codecov-io commented on issue #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685#issuecomment-390943297 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=h1) Report > Merging [#3685](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9445d6100f6e3aa4a00e489ca98f99a3f4a207f5?src=pr=desc) will **increase** coverage by `10.53%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3685 +/- ## === + Coverage 74.92% 85.45% +10.53% === Files 128 128 Lines6086 6086 Branches 388 388 === + Hits 4560 5201 +641 + Misses 1526 885 -641 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `83.76% <0%> (+0.64%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.93% <0%> (+0.67%)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `90.9% <0%> (+1.13%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `88.54% <0%> (+1.52%)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.56% <0%> (+1.75%)` | :arrow_up: | | [...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=) | `97.91% <0%> (+2.08%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `89.65% <0%> (+2.29%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.57% <0%> (+2.32%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `93.84% <0%> (+2.56%)` | :arrow_up: | | [...ala/src/main/scala/whisk/core/entity/DocInfo.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0RvY0luZm8uc2NhbGE=) | `87.09% <0%> (+3.22%)` | :arrow_up: | | ... and [31 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=footer). Last update [9445d61...ad7eec5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI
codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging [#3453](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/37ce9b86048dafb0f369a5a5b05caa0136a26ef4?src=pr=desc) will **increase** coverage by `0.28%`. > The diff coverage is `94.28%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3453 +/- ## == + Coverage 74.94% 75.23% +0.28% == Files 128 130 +2 Lines6086 6161 +75 Branches 388 405 +17 == + Hits 4561 4635 +74 - Misses 1525 1526 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `83.33% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/database/StoreUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvU3RvcmVVdGlscy5zY2FsYQ==) | `100% <100%> (ø)` | :arrow_up: | | [...ala/whisk/core/database/CouchDbStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlN0b3JlUHJvdmlkZXIuc2NhbGE=) | `81.81% <100%> (+1.81%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.64% <100%> (+0.28%)` | :arrow_up: | | [.../scala/whisk/core/database/AttachmentInliner.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudElubGluZXIuc2NhbGE=) | `100% <100%> (ø)` | :arrow_up: | | [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `99.29% <100%> (+1.93%)` | :arrow_up: | | [...la/whisk/core/database/ArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RTdG9yZVByb3ZpZGVyLnNjYWxh) | `66.66% <66.66%> (ø)` | | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `77.03% <90.74%> (+3%)` | :arrow_up: | | [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `94.73% <94.73%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=footer). Last update [37ce9b8...4d523b3](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns
rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-396292359 @vooolll did you try `./gradlew :tests:test --tests "your.package.name.TestClass.evenMethodName"` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #270: Fix binary encoding
dubee commented on issue #270: Fix binary encoding URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/270#issuecomment-396288463 @abaruni, FYI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned
rabbah commented on a change in pull request #311: Display appropriate message
for trigger fire when 204 is returned
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/311#discussion_r194450149
##
File path: commands/trigger.go
##
@@ -92,13 +93,24 @@ var triggerFireCmd = {
return werr
}
+ if resp.StatusCode == http.StatusNoContent {
Review comment:
I suggest starting to add go unit tests as well for such changes as it will
vector toward better factoring of the code. For example a unit test that mocks
an HTTP response and confirms returning the expected message and CLI code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
