[GitHub] chetanmeh commented on issue #4140: ContainerProxyTests Heisenbug
chetanmeh commented on issue #4140: ContainerProxyTests Heisenbug URL: https://github.com/apache/incubator-openwhisk/issues/4140#issuecomment-446473708 Another one at https://scans.gradle.com/s/st23hp56clclk/tests/xaqugzlgs2zxa-4fdg7fshdyxgs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446422425 @markusthoemmes , yes, you are right, just a debug level log, `this log is saved to controllerN_logs.log` have some benefits, for example. when openwhisk admin received the log alering, he may do some system tuning`(e.g. increase the namespace's concurrrentInvocation)` or check which action leads to that according to `the log alering info` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446422425 @markusthoemmes , yes, you are right, just a debug level log, `this log is saved to controllerN_logs.log` have some benefits, for example. when openwhisk admin received the log alering, he may do some system tuning`(e.g. increase the namespace's concurrrentInvocation) or check which action leads to that according to `the log alering info` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446422425 @markusthoemmes , yes, you are right, just a debug level log, `this log is saved to controllerN_logs.log` have some benefits, for example. when openwhisk admin received the log alering, he may do some system tuning or check which action leads to that according to `the log alering info`(e.g. increase the namespace's concurrrentInvocation) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3: Fix missing RUNTIME name.
rabbah opened a new pull request #3: Fix missing RUNTIME name. URL: https://github.com/apache/incubator-openwhisk-runtime-dotnet/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris opened a new pull request #4171: mesos - expose config for setting heartbeatMaxFailures to reconnect after master failover
tysonnorris opened a new pull request #4171: mesos - expose config for setting heartbeatMaxFailures to reconnect after master failover URL: https://github.com/apache/incubator-openwhisk/pull/4171 In case of mesos master failover, we need to reconnect to master by re-subscribing. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446422425 @markusthoemmes , yes, you are right, just a debug level log, `this log is saved to controllerN_logs.log` have some benefits, for example. when openwhisk admin received the log alering, he will do some system tuning according to `the log alering info`(e.g. increase the namespace's concurrrentInvocation) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #4164: Add warn log when too many requests happened
ningyougang commented on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446422425 @markusthoemmes , yes, you are right, just a debug level log, `this log is saved to controllerN_logs.log` have some benefits, for example. when openwhisk admin received the log alering, he will do some configuration tuning according to `the log alering info` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #2: Add travis hooks to test and publish docker images.
csantanapr closed pull request #2: Add travis hooks to test and publish docker
images.
URL: https://github.com/apache/incubator-openwhisk-runtime-dotnet/pull/2
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..6a25af9
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,12 @@
+.vscode
+.idea
+*.iml
+*~
+
+.gradle/
+tests/build
+tests/out/
+.settings
+tests/bin/
+.project
+.classpath
diff --git a/.scalafmt.conf b/.scalafmt.conf
new file mode 100644
index 000..7084efe
--- /dev/null
+++ b/.scalafmt.conf
@@ -0,0 +1,9 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+style = intellij
+danglingParentheses = false
+maxColumn = 120
+docstrings = JavaDoc
+rewrite.rules = [SortImports]
+project.git = true
diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 000..f19648f
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+sudo: required
+group: deprecated-2017Q3
+language: csharp
+dotnet: 2.1.300
+services:
+- docker
+notifications:
+ email: false
+ webhooks:
+urls:
+ # travis2slack webhook to enable DMs on openwhisk-team.slack.com to PR
authors with TravisCI results
+ secure:
y6caEKjRnby723P1W8Rup+yioJRBV1YmqwGEEgPxNu9YGdef0m7TO8fp1BZaa/hHErYzYrfvOo3gwXBB7lkmZ9p1NfF/Cb5bjy5UwSx+EFaEjugFIoCCg+xPPTS4SM24+bXljiFZd7ZZGXu4beGdcgxmYsufRQoWJBF4Itcr424wEw+fSrPPknAotgAXjUyOOmr/xHng50mFqyfal1miR9vOiX1y/cdeAmaCmuagv20ry0ZpnOyMYCdH0LtWIDAxSDn/GTXBAwLBy2Wn05uE+Yqh6EI7xRvYBtT0PfaBFwb28pmkArYG9ZpXB8cwUhuLQZ51zFt0uHMetzlThbw6pO0X9FzGcT/BBlUaZbUaY6zar8FkRzija72HLKOY/yAN8VkhGlDOz2RSI3Tw05vep4Y7ZVRF9/wW0KnKB68VMJuwCbzgtCvWpgRXbxxLcKvKYsBVnkcWY/fwMxG5q8gQ2ZELf65975MVMn/oejwAcJkP2EOBBFpHGsWvEwNV4ymTD00XX1qeebfYQYTsxUOEUFrvu3p4GgqI2MQksgWusGaHaOTG0XHZ7afbZ+4EdPA098rPFaIcnq5E8PVZ+IRzn+5aupAqXy/tY0i4V1U7H4rtF+6u3PJpAIcgVo03wmzNcnsw0rVcAqKbIxn/oyMaIaGtb1VaKYQZJ4t4CCo0cEo=
+before_install:
+- "./tools/travis/setup.sh"
+install: true
+script:
+- "./tools/travis/build.sh && ./tools/travis/test.sh"
+deploy:
+- provider: script
+ script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*}
${TRAVIS_TAG##*@}"
+ on:
+tags: true
+all_branches: true
+repo: apache/incubator-openwhisk-runtime-dotnet
+- provider: script
+ script: "./tools/travis/publish.sh openwhisk 2.1 latest"
+ on:
+branch: master
+repo: apache/incubator-openwhisk-runtime-dotnet
+env:
+ global:
+ - secure:
Y1ldwIQ6bc3/3Pc0E+qQ6K2M830B9BObYDlsNilPwF/kak3YSfF7SuXuRbJGjTdhH2KOotZD2CwONgP2yvOSPBToC/HpnXYfAGtgblrxQORvgdik88CFWa3Lli1pwlpdzKQNWhBvglzq+IIS98wqzmwqGr8zKA+Iau2ByHdb1j3M9rrIY9V6oU9Gwim1apcRyfI/as3+QfPtt8BUAl2U7+PprxwJigyF/mcZnBJbd7IjrilE2gldZLxKlBiffoKVBinrEg3IQGJPt6k8riw264pBQEpcA0ZBsPUvMaISSxLb+d1ymp3WsiTJUjv+URR/HcdDa7P9jY+ouc8PQz4Yt+Ii38lM2tQU480APfVTyfj6drkjL/+54mYuxm8TzkBWcM2j6/FYT+8HvK/pF35wDJ3El+jGq7BARXg8HVxFsZgynJnhqhWDQb3xX9fK+N4K8+ct+HlsOSa5mP5i5Yo6WRTrWrFpyxVnv9crKePCiYqA2Y8ta8Wnh0sM06nLRtDbfbDjvXPQbaZqSnL4B2Cto08YoT/W/lu8QgJ3EEFlUdDOke4kv9yoXtuE0h7+8dwOvBNMVrBis3G2EYObgR4WmWjk4loYhqT9h3jrH0/5bGLzSKc++qYW0rOZ/RB21cRSe1ILQvSzWkImUoPI8b0i5baGSDq3EjTXYr3pIXSYpQk=
+ - secure:
DOg+FgllLbyv7nEK3JJZfO/cvXy5K0L6QI/S9EJ/ivm4XBDCw1ayhrSQXvp1tMTPbWBEIv2gomPsHghJ+hVvX3dgwYdoNz9WZaNBB6lOO9U8OQW0LBsO5Eai6grzqOP35OuKtthuyR3dGJHAZo/XjhZM/jL0z6q1kNDzdS7ASwRwHJG0rHPGVlGeolH4nAity4KNJvyAspS1FYaIj9FEC/M7UT6nJVACbr9iMt/83teF/Oo2uoFI6Pa4K3nE2NViVFibToNOM3CV8kArDPDoNJviXxQ07ZM6fNijwehZ80waiPSaxFY8PLSntQNxGyB3DbomSTCcdVvtuHHQVmZgpVdvOJE8wk3R09+nq9U9FuUWLiRYSRbF1eF48YFnssPW1jEeVSenFRADcQ37e4B21ssLvXRHpQHpPVrYBZ8ffDamS7pKtEqocX/3Syc6irxHGCpxEdhvQ0Of5AWHhzB714VCijJJQiH9J4hEKXhMeAZ5SSt4eUavEHJKMhUcJ/aaku5w1+KtiYeOso1fTRbTYkEYb1A0bSNdXlGrYRRT+N683W7+ENiQIT+hTp617L/m5WQLIHfKe3gy5qt46kHFiUL3R3YlBI5OKjnLkDnUiA+0d4SFtJC/TBuPmH1fG4isAuvggTjzCb3kUG3ysin8AW0AKaXW0eqjKa/nsHWDKmc=
+ - secure:
[GitHub] pritidesai closed pull request #353: Clarify GitHub nightly-interim releases tags from Apache releases.
pritidesai closed pull request #353: Clarify GitHub nightly-interim releases tags from Apache releases. URL: https://github.com/apache/incubator-openwhisk-website/pull/353 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_layouts/downloads.html b/_layouts/downloads.html index df157c0..8cd8c93 100644 --- a/_layouts/downloads.html +++ b/_layouts/downloads.html @@ -16,12 +16,16 @@ Versioning -Releases +Official Releases Verifying Keys Versions + + +Developer Builds + @@ -40,7 +44,9 @@ Downloads Versioning -Apache OpenWhisk uses semantic versioning. Version numbers use the form major.minor.incremental-build and are incremented as follows: +Apache OpenWhisk uses semantic versioning. Version numbers + use the form major.minor.incremental-build and + are incremented as follows: major version: for incompatible API changes. minor version: for new functionality added in a backward-compatible manner. @@ -52,13 +58,21 @@ Versioning - -Releases -The Apache OpenWhisk project provides releases of source code, by component groupings, as TAR compressed archives files denoted by the .tar.gz extension.) + +Official Releases +The Apache OpenWhisk project provides official releases of + source code, by component groupings, as TAR compressed + archives files denoted by the .tar.gz extension.) + +Developers who wish to use nightly builds or interim builds + should read about them below under + Developer Builds. Verifying -As an Apache project, all downloaded files are signed by a project Release Manager and can be verified following these instructions: +As an Apache project, all downloaded files are signed by a + project Release Manager and can be verified following these + instructions: https://www.apache.org/info/verification;>How to verify downloaded files @@ -380,5 +394,35 @@ OpenWhisk Apigateway + + + + Developer Builds + Most of the Apache OpenWhisk project component repositories +are configured within GitHub to automatically generate interim +builds (not +official release builds) +for each merged Pull Request (PR) and/or on +a nightly basis. These builds, by default, are tagged +'latest' and appear under their respective GitHub +component's release tab and are intended for developer +evaluation and testing only. + + In some special cases, +Committers on the project may choose to use GitHub to tag +certain builds as they become closer to being Release Candidate +(RC) builds. However, any build tagged within GitHub with +either 'latest' or any other tag do NOT have +official Apache project release status. +All official Apache OpenWhisk builds +undergo a rigorous process to be approved and are linked +above. + + To be clear, GitHub "releases" are not official Apache project +releases. + + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss edited a comment on issue #4169: tests:testSwaggerCodegen failing
dgrove-oss edited a comment on issue #4169: tests:testSwaggerCodegen failing URL: https://github.com/apache/incubator-openwhisk/issues/4169#issuecomment-446380630 #4170 disabled the failing test. As people have time, we should do a real fix and re-enable the test. @bbrowning This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4169: tests:testSwaggerCodegen failing
dgrove-oss commented on issue #4169: tests:testSwaggerCodegen failing URL: https://github.com/apache/incubator-openwhisk/issues/4169#issuecomment-446380630 #4170 disables the failing test. As people have time, we should do a real fix and re-enable the test. @bbrowning This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #4170: disable broken swaggerCodegen tests
dgrove-oss closed pull request #4170: disable broken swaggerCodegen tests
URL: https://github.com/apache/incubator-openwhisk/pull/4170
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/travis/runTests.sh b/tools/travis/runTests.sh
index 5d5b6d7f35..82b9db63b6 100755
--- a/tools/travis/runTests.sh
+++ b/tools/travis/runTests.sh
@@ -26,7 +26,9 @@ ROOTDIR="$SCRIPTDIR/../.."
cd $ROOTDIR
cat whisk.properties
-TERM=dumb ./gradlew :tests:testCoverageLean :tests:reportCoverage
:tests:testSwaggerCodegen
+TERM=dumb ./gradlew :tests:testCoverageLean :tests:reportCoverage
+# disabled test until
https://github.com/apache/incubator-openwhisk/issues/4169 is resolved
+TERM=dumb ./gradlew :tests:testCoverageLean :tests:reportCoverage #
:tests:testSwaggerCodegen
bash <(curl -s https://codecov.io/bash)
echo "Time taken for ${0##*/} is $SECONDS secs"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4170: disable broken swaggerCodegen tests
codecov-io commented on issue #4170: disable broken swaggerCodegen tests URL: https://github.com/apache/incubator-openwhisk/pull/4170#issuecomment-446378656 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4170?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@42831e7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4170?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4170 +/- ## = Coverage ? 81.18% = Files ? 152 Lines ? 7291 Branches ? 470 = Hits ? 5919 Misses? 1372 Partials ?0 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4170?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4170?src=pr=footer). Last update [42831e7...7f31e97](https://codecov.io/gh/apache/incubator-openwhisk/pull/4170?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macdonst commented on issue #143: Updating package parameters doesn't seem to take affect
macdonst commented on issue #143: Updating package parameters doesn't seem to take affect URL: https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446356536 Okay, well I'm going to close this a user error :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macdonst closed issue #143: Updating package parameters doesn't seem to take affect
macdonst closed issue #143: Updating package parameters doesn't seem to take affect URL: https://github.com/apache/incubator-openwhisk-client-js/issues/143 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] starpit commented on issue #143: Updating package parameters doesn't seem to take affect
starpit commented on issue #143: Updating package parameters doesn't seem to take affect URL: https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446355312 yes, i agree that this API could be refined; it is not a reflexive API. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macdonst commented on issue #143: Updating package parameters doesn't seem to take affect
macdonst commented on issue #143: Updating package parameters doesn't seem to
take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446354425
Yeah, using `ow.packages.update({ name, package})` has resolved the issue
but I'm not sure why that would be different than `ow.packages.update(pack)`
where pack is an object that has a name and parameters properties.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new pull request #394: Integrating wskdeploy into wsk CLI
pritidesai opened a new pull request #394: Integrating wskdeploy into wsk CLI URL: https://github.com/apache/incubator-openwhisk-cli/pull/394 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macdonst removed a comment on issue #143: Updating package parameters doesn't seem to take affect
macdonst removed a comment on issue #143: Updating package parameters doesn't
seem to take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446335481
@starpit here is a smaller example that still doesn't work that is based off
the sample code from the README.
```
const openwhisk = require('openwhisk');
function extractPackageName(action) {
return action.split('/')[2];
}
function main(params) {
const ow = openwhisk();
const packageName = extractPackageName(process.env['__OW_ACTION_NAME']);
const package1 = {
parameters: [
{key: "colour", value: "green"},
{key: "name", value: "Freya"}
]
}
return ow.packages.update({packageName, package1}).then(newPackage => {
console.log('updated package:');
console.log(newPackage);
return { ...params };
}).catch(err => {
console.error('failed to update package', err);
return err;
});
}
exports.main = main;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] macdonst commented on issue #143: Updating package parameters doesn't seem to take affect
macdonst commented on issue #143: Updating package parameters doesn't seem to
take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446335481
@starpit here is a smaller example that still doesn't work that is based off
the sample code from the README.
```
const openwhisk = require('openwhisk');
function extractPackageName(action) {
return action.split('/')[2];
}
function main(params) {
const ow = openwhisk();
const packageName = extractPackageName(process.env['__OW_ACTION_NAME']);
const package1 = {
parameters: [
{key: "colour", value: "green"},
{key: "name", value: "Freya"}
]
}
return ow.packages.update({packageName, package1}).then(newPackage => {
console.log('updated package:');
console.log(newPackage);
return { ...params };
}).catch(err => {
console.error('failed to update package', err);
return err;
});
}
exports.main = main;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] starpit commented on issue #143: Updating package parameters doesn't seem to take affect
starpit commented on issue #143: Updating package parameters doesn't seem to
take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446335143
you have tried `ow.packages.update({ name, package})`? your example has
`ow.packages.update(pack)` which i think won't work.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] macdonst commented on issue #143: Updating package parameters doesn't seem to take affect
macdonst commented on issue #143: Updating package parameters doesn't seem to take affect URL: https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446333922 @starpit Yeah, I updated the code above as that was a copy and paste from my trashing trying to figure out what I was doing wrong. I have the same issue if I push new object into the parameters array. As well, if I run the example code directly from here: https://github.com/apache/incubator-openwhisk-client-js#update-package-parameters I still get the same issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #1005: Action has no kind set - Error decoding runtimes with Local Values
pritidesai closed issue #1005: Action has no kind set - Error decoding runtimes with Local Values URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1005 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #1017: Deleting static runtimes data file, instead, adding data to go file
pritidesai commented on a change in pull request #1017: Deleting static runtimes data file, instead, adding data to go file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1017#discussion_r240758461 ## File path: runtimes/runtimes.go ## @@ -56,7 +54,6 @@ const ( HTTP_CONTENT_TYPE_VALUE = "application/json; charset=UTF-8" RUNTIME_NOT_SPECIFIED = "NOT SPECIFIED" BLACKBOX= "blackbox" - RUNTIMES_FILE_NAME = "runtimes.json" Review comment: will try to address #1018 soon if possible ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #1017: Deleting static runtimes data file, instead, adding data to go file
pritidesai closed pull request #1017: Deleting static runtimes data file,
instead, adding data to go file
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1017
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runtimes/runtimes.go b/runtimes/runtimes.go
index 190e114f..73779e42 100644
--- a/runtimes/runtimes.go
+++ b/runtimes/runtimes.go
@@ -23,8 +23,6 @@ import (
"io/ioutil"
"net/http"
"net/url"
- "path/filepath"
- "runtime"
"strings"
"time"
@@ -56,7 +54,6 @@ const (
HTTP_CONTENT_TYPE_VALUE = "application/json; charset=UTF-8"
RUNTIME_NOT_SPECIFIED = "NOT SPECIFIED"
BLACKBOX= "blackbox"
- RUNTIMES_FILE_NAME = "runtimes.json"
HTTPS = "https://;
)
@@ -137,14 +134,11 @@ func ParseOpenWhisk(apiHost string) (op OpenWhiskInfo,
err error) {
if err != nil || !strings.Contains(HTTP_CONTENT_TYPE_VALUE,
res.Header.Get(HTTP_CONTENT_TYPE_KEY)) {
stdout := wski18n.T(wski18n.ID_MSG_UNMARSHAL_LOCAL)
wskprint.PrintOpenWhiskInfo(stdout)
- runtimeDetails := readRuntimes()
- if runtimeDetails != nil {
- err = json.Unmarshal(runtimeDetails, )
- if err != nil {
- errMessage :=
wski18n.T(wski18n.ID_ERR_RUNTIME_PARSER_ERROR,
- map[string]interface{}{wski18n.KEY_ERR:
err.Error()})
- err =
wskderrors.NewRuntimeParserError(errMessage)
- }
+ err = json.Unmarshal(RUNTIME_DETAILS, )
+ if err != nil {
+ errMessage :=
wski18n.T(wski18n.ID_ERR_RUNTIME_PARSER_ERROR,
+ map[string]interface{}{wski18n.KEY_ERR:
err.Error()})
+ err = wskderrors.NewRuntimeParserError(errMessage)
}
} else {
b, _ := ioutil.ReadAll(res.Body)
@@ -270,14 +264,259 @@ func ListOfSupportedRuntimes(runtimes
map[string][]string) (rt []string) {
return
}
-func readRuntimes() []byte {
- _, b, _, _ := runtime.Caller(0)
- basepath := filepath.Dir(b)
- runtimesFileWithPath := filepath.Join(basepath, RUNTIMES_FILE_NAME)
- file, readErr := ioutil.ReadFile(runtimesFileWithPath)
- if readErr != nil {
- wskprint.PrintlnOpenWhiskWarning(readErr.Error())
- return nil
- }
- return file
-}
+var RUNTIME_DETAILS = []byte(`{
+"support": {
+"github": "https://github.com/apache/incubator-openwhisk/issues;,
+"slack": "http://slack.openwhisk.org;
+},
+"description": "OpenWhisk",
+"api_paths": [
+"/api/v1"
+],
+"runtimes": {
+"nodejs": [
+{
+"kind": "nodejs",
+"image": {
+"prefix": "openwhisk",
+"name": "nodejsaction",
+"tag": "latest"
+},
+"deprecated": true,
+"attached": {
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
+}
+},
+{
+"kind": "nodejs:6",
+"default": true,
+"image": {
+"prefix": "openwhisk",
+"name": "nodejs6action",
+"tag": "latest"
+},
+"deprecated": false,
+"attached": {
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
+},
+"stemCells": [{
+"count": 2,
+"memory": "256 MB"
+}]
+},
+{
+"kind": "nodejs:8",
+"default": false,
+"image": {
+"prefix": "openwhisk",
+"name": "action-nodejs-v8",
+"tag": "latest"
+},
+"deprecated": false,
+"attached": {
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
+}
+},
+{
+"kind": "nodejs:10",
+"default": false,
+"image": {
+"prefix": "openwhisk",
+"name": "action-nodejs-v10",
+"tag": "latest"
+},
+"deprecated": false,
+"attached": {
+"attachmentName": "codefile",
+
[GitHub] starpit edited a comment on issue #143: Updating package parameters doesn't seem to take affect
starpit edited a comment on issue #143: Updating package parameters doesn't
seem to take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446329927
hi, i think the issue is that the `parameters` field is an array i.e.
`[{key, value}, ...]` of key-value pairs, not a map from key to value?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] starpit commented on issue #143: Updating package parameters doesn't seem to take affect
starpit commented on issue #143: Updating package parameters doesn't seem to
take affect
URL:
https://github.com/apache/incubator-openwhisk-client-js/issues/143#issuecomment-446329927
hi, i think the issue is that the `parameters` array is an array i.e.
`[{key, value}, ...]` of key-value pairs, not a map from key to value?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] macdonst opened a new issue #143: Updating package parameters doesn't seem to take affect
macdonst opened a new issue #143: Updating package parameters doesn't seem to
take affect
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/143
I'm attempting to update my package parameters while executing an action.
Unfortunately, no matter what I try the parameters don't seem to be updated.
Here is some sample action code that illustrates the problem:
```
const openwhisk = require('openwhisk');
function extractPackageName(action) {
return action.split('/')[2];
}
function main(params) {
const ow = openwhisk();
const packageName = extractPackageName(process.env['__OW_ACTION_NAME']);
return ow.packages
.get(packageName)
.then(pack => {
// a and b not in package
console.log(pack);
pack.parameters.a = 'a';
pack.parameters.b = 'b';
// a and b included in the package
console.log(pack);
return ow.packages
.update(pack)
.then(updatedPackage => {
// a and b not in package
console.log(updatedPackage);
return {
...params
};
})
.catch(err => {
return err;
});
})
.catch(function(err) {
return err;
});
}
```
As well subsequent calls to this action do not show the updated `a` and `b`
parameters I've attempted to add.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on a change in pull request #1017: Deleting static runtimes data file, instead, adding data to go file
mrutkows commented on a change in pull request #1017: Deleting static runtimes data file, instead, adding data to go file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1017#discussion_r240750610 ## File path: runtimes/runtimes.go ## @@ -56,7 +54,6 @@ const ( HTTP_CONTENT_TYPE_VALUE = "application/json; charset=UTF-8" RUNTIME_NOT_SPECIFIED = "NOT SPECIFIED" BLACKBOX= "blackbox" - RUNTIMES_FILE_NAME = "runtimes.json" Review comment: I hate getting rid of this... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #4170: disable broken swaggerCodegen tests
dgrove-oss opened a new pull request #4170: disable broken swaggerCodegen tests URL: https://github.com/apache/incubator-openwhisk/pull/4170 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new issue #4169: tests:testSwaggerCodegen failing
dgrove-oss opened a new issue #4169: tests:testSwaggerCodegen failing URL: https://github.com/apache/incubator-openwhisk/issues/4169 Test currently failing. Appears to be breakage in upstream dependency. $ ./gradlew :tests:testSwaggerCodegen > Task :tests:testSwaggerCodegen FAILED > FAILURE: Build failed with an exception. > > * What went wrong: > A problem occurred configuring project ':swagger-java-client'. > > Could not resolve all artifacts for configuration ':swagger-java-client:classpath'. >> Could not find any matches for com.android.tools.build:gradle:2.3.+ as no versions of com.android.tools.build:gradle are available. > Searched in the following locations: >- https://jcenter.bintray.com/com/android/tools/build/gradle/maven-metadata.xml >- https://jcenter.bintray.com/com/android/tools/build/gradle/ > Required by: > project :swagger-java-client Proposing to disable test case until we have time to find a real fix. See https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1544514441533000 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #353: Clarify GitHub nightly-interim releases tags from Apache releases.
mrutkows opened a new pull request #353: Clarify GitHub nightly-interim releases tags from Apache releases. URL: https://github.com/apache/incubator-openwhisk-website/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3: add encoded URL for travis2slack webhook
dgrove-oss commented on issue #3: add encoded URL for travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-composer-python/pull/3#issuecomment-446232792 Success.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #3: add encoded URL for travis2slack webhook
dgrove-oss opened a new pull request #3: add encoded URL for travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-composer-python/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #4137: Remove busy loop in case the invoker is overloaded.
cbickel commented on issue #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#issuecomment-446188127 @sven-lange-last and me decided to not merge this yet, as it is too risky currently (before everyone leaves during christmas). I'll close the PR for now and I'll reopen after addressing it again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel closed pull request #4137: Remove busy loop in case the invoker is overloaded.
cbickel closed pull request #4137: Remove busy loop in case the invoker is
overloaded.
URL: https://github.com/apache/incubator-openwhisk/pull/4137
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
b/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
index 81c542714f..4edbae59d9 100644
---
a/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
+++
b/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
@@ -18,7 +18,7 @@
package org.apache.openwhisk.core.containerpool
import akka.actor.{Actor, ActorRef, ActorRefFactory, Props}
-import org.apache.openwhisk.common.{AkkaLogging, LoggingMarkers, TransactionId}
+import org.apache.openwhisk.common.{AkkaLogging, Logging, LoggingMarkers,
TransactionId}
import org.apache.openwhisk.core.connector.MessageFeed
import org.apache.openwhisk.core.entity._
import org.apache.openwhisk.core.entity.size._
@@ -60,7 +60,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
extends Actor {
import ContainerPool.memoryConsumptionOf
- implicit val logging = new AkkaLogging(context.system.log)
+ implicit val logging: Logging = new AkkaLogging(context.system.log)
var freePool = immutable.Map.empty[ActorRef, ContainerData]
var busyPool = immutable.Map.empty[ActorRef, ContainerData]
@@ -68,8 +68,8 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
// If all memory slots are occupied and if there is currently no container
to be removed, than the actions will be
// buffered here to keep order of computation.
// Otherwise actions with small memory-limits could block actions with large
memory limits.
- var runBuffer = immutable.Queue.empty[Run]
- val logMessageInterval = 10.seconds
+ var runBuffer: immutable.Queue[Run] = immutable.Queue.empty[Run]
+ val logMessageInterval: FiniteDuration = 10.seconds
prewarmConfig.foreach { config =>
logging.info(this, s"pre-warming ${config.count} ${config.exec.kind}
${config.memoryLimit.toString}")(
@@ -99,13 +99,23 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
// their requests and send them back to the pool for rescheduling (this
may happen if "docker" operations
// fail for example, or a container has aged and was destroying itself
when a new request was assigned)
case r: Run =>
- // Check if the message is resent from the buffer. Only the first
message on the buffer can be resent.
- val isResentFromBuffer = runBuffer.nonEmpty &&
runBuffer.dequeueOption.exists(_._1.msg == r.msg)
+ // Checks if the current message is the first in the queue
+ val isFirstInQueue = runBuffer.dequeueOption.exists(_._1.msg == r.msg)
- // Only process request, if there are no other requests waiting for free
slots, or if the current request is the
- // next request to process
- // It is guaranteed, that only the first message on the buffer is resent.
- if (runBuffer.isEmpty || isResentFromBuffer) {
+ if (!r.isFromQueue) {
+// If the request is not from the queue, it will be added to the queue
always.
+runBuffer = runBuffer.enqueue(r)
+runFirstMessageOfQueue()
+ } else if (r.isFromQueue && !isFirstInQueue) {
+// The current message was already in buffer and it is not a resned
form the container. But it is not the top most one of the buffer.
+// This could happen because of a race condition of arriving messages
in the actor.
+// If there are two messages, that trigger the first message of the
buffer to run, at the same time, the same
+// Run-message will be sent twice. The first arriving Run-message will
be handled correctly and removed from
+// the buffer. The second one will end up here as it is not the first
one in the buffer anymore. Instead we try
+// to trigger the next Run-message.
+runFirstMessageOfQueue()
+ } else {
+// The current message is from the buffer and it is the top most one.
So we will process it.
val createdContainer =
// Is there enough space on the invoker for this action to be
executed.
if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
@@ -151,45 +161,28 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
freePool = freePool - actor
}
// Remove the action that get's executed now from the buffer and
execute the next one afterwards.
-if (isResentFromBuffer) {
- // It is guaranteed that the currently executed messages is
[GitHub] markusthoemmes commented on issue #4164: Add warn log when too many requests happened
markusthoemmes commented on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446160253 @ningyougang that feels like a Debug level log then, certainly not a warning since nothing is wrong with the system in that case? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel opened a new pull request #4168: Remove unused ansible parameters in group_vars/all file.
cbickel opened a new pull request #4168: Remove unused ansible parameters in group_vars/all file. URL: https://github.com/apache/incubator-openwhisk/pull/4168 ## Description This PR cleans up some config parameters in `group_vars/all`-file of ansible, taht are not used anymore. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh commented on issue #4165: Update to Kamon 1.1.3 from 0.6 series URL: https://github.com/apache/incubator-openwhisk/pull/4165#issuecomment-446154308 Discussed this with @ivantopo on [gitter](https://gitter.im/kamon-io/Kamon?at=5c0f880a80986419d572ba8f) and it seems we would need to take care of the naming part in our side as there is a conceptual change in way Kamon modes metrics. Would modify `MetricEmitter` to include metric type This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh edited a comment on issue #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh edited a comment on issue #4165: Update to Kamon 1.1.3 from 0.6 series URL: https://github.com/apache/incubator-openwhisk/pull/4165#issuecomment-446138192 Seems like Kamon has changed the [metric naming convention](https://github.com/kamon-io/kamon-datadog/pull/20#issuecomment-391419144). Earlier it used to include the metric type/category as part of name like `openwhisk-statsd.invoker0.counter.database_cacheMiss_count` and now its dropping that which lead to error in our case like ``` [2018-12-11T15:05:44.284Z] [ERROR] Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] java.lang.RuntimeException: Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] at scala.sys.package$.error(package.scala:26) at kamon.metric.MetricRegistry.lookupMetric(MetricRegistry.scala:83) at kamon.metric.MetricRegistry.counter(MetricRegistry.scala:48) at kamon.Kamon$.counter(Kamon.scala:82) at kamon.metric.MetricLookup.counter(MetricLookup.scala:41) at kamon.metric.MetricLookup.counter$(MetricLookup.scala:40) at kamon.Kamon$.counter(Kamon.scala:32) at org.apache.openwhisk.common.MetricEmitter$.emitCounterMetric(Logging.scala:222) ``` So we would probably need to do that on our side This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh commented on issue #4165: Update to Kamon 1.1.3 from 0.6 series URL: https://github.com/apache/incubator-openwhisk/pull/4165#issuecomment-446138192 Seems like Kamon has changed the metric naming convention. Earlier it used to include the metric type/category as part of name like `openwhisk-statsd.invoker0.counter.database_cacheMiss_count` and now its dropping that which lead to error in our case like ``` [2018-12-11T15:05:44.284Z] [ERROR] Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] java.lang.RuntimeException: Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] at scala.sys.package$.error(package.scala:26) at kamon.metric.MetricRegistry.lookupMetric(MetricRegistry.scala:83) at kamon.metric.MetricRegistry.counter(MetricRegistry.scala:48) at kamon.Kamon$.counter(Kamon.scala:82) at kamon.metric.MetricLookup.counter(MetricLookup.scala:41) at kamon.metric.MetricLookup.counter$(MetricLookup.scala:40) at kamon.Kamon$.counter(Kamon.scala:32) at org.apache.openwhisk.common.MetricEmitter$.emitCounterMetric(Logging.scala:222) ``` So we would probably need to do that on our side This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3
from 0.6 series
URL:
https://github.com/apache/incubator-openwhisk/pull/4165#discussion_r240514286
##
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala
##
@@ -59,10 +59,8 @@ object Invoker {
def initKamon(instance: Int): Unit = {
// Replace the hostname of the invoker to the assigned id of the invoker.
val newKamonConfig = Kamon.config
- .withValue(
-"kamon.statsd.simple-metric-key-generator.hostname-override",
-ConfigValueFactory.fromAnyRef(s"invoker$instance"))
-Kamon.start(newKamonConfig)
+ .withValue("kamon.environment.host",
ConfigValueFactory.fromAnyRef(s"invoker$instance"))
Review comment:
With Kamon 1.0 a new [environment][1] config section is added and individual
reporters now rely on that for hostname and service name. See
kamon-io/kamon-statsd#2 for relevant change.
[1]:
https://github.com/kamon-io/Kamon/blob/master/kamon-core/src/main/resources/reference.conf#L3
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3
from 0.6 series
URL:
https://github.com/apache/incubator-openwhisk/pull/4165#discussion_r240537006
##
File path: common/scala/src/main/resources/application.conf
##
@@ -19,7 +19,11 @@ akka.http {
#kamon related configuration
kamon {
-
+environment {
+ # Identifier for this service. For keeping it backward compatible
setting to natch previous
+ # statsd name
+ service = "openwhisk-statsd"
Review comment:
Setting this to `openwhisk-statsd` for ensuring that new metric names are
backward compatible with previous names as now reporters use this tag to
determine the service name and do not expose reporter specific setting
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cbickel commented on a change in pull request #4167: Add tid from header to RestResult in tests.
cbickel commented on a change in pull request #4167: Add tid from header to RestResult in tests. URL: https://github.com/apache/incubator-openwhisk/pull/4167#discussion_r240534351 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -299,20 +285,17 @@ class RestActionOperations(implicit val actorSystem: ActorSystem) val actionName = entityName(artifact.get) val actionPath = Path(s"$basePath/namespaces/$namespace/$noun/$actionName") val resp = requestEntity(GET, actionPath) -if (resp == None) return new RestResult(NotFound) // NOTE return, aborts the method Review comment: This can never be `None` as `resp` is no `Option` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel opened a new pull request #4167: Add tid from header to RestResult in tests.
cbickel opened a new pull request #4167: Add tid from header to RestResult in tests. URL: https://github.com/apache/incubator-openwhisk/pull/4167 ## Description This PR adds the tid from the tid-header to the rest result. This will enhance debugging failed test cases. In addition this PR cleans up the Warnings in `WskRestOperations`. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446128276 Regarding `Can you elaborate on the lack of information you have with the current logs?` it is better to output below warning log when too many request happened ``` [ActionsApi] Unable to invoke action guest/hello, because namespace:guest has exceeded its throttle limit, detail info: RejectRequest(429 Too Many Requests) Too many concurrent requests in flight (count: 100, allowed: 60) ``` Through above warning log, we can see the action info, and the detail throttle info. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446128276 Regarding `Can you elaborate on the lack of information you have with the current logs?` it is better to output below warning log when too many request happened ``` [ActionsApi] Unable to invoke action guest/hello, because namespace:guest has exceeded its throttle limit, detail info: RejectRequest(429 Too Many Requests) Too many concurrent requests in flight (count: 0, allowed: 2) ``` Through above warning log, we can see the action info, and the detail throttle info. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446128276 Regarding `Can you elaborate on the lack of information you have with the current logs?` it is better to output below warning log when too many request happened ``` [ActionsApi] Unable to invoke action guest/hello, because namespace:guest has exceeded its throttle limit, detail info: RejectRequest(429 Too Many Requests) Too many concurrent requests in flight (count: 0, allowed: 2) ``` Through above warning log, we can see the action info, and the detail throttleCheck info. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang edited a comment on issue #4164: Add warn log when too many requests happened
ningyougang edited a comment on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446128276 Regarding `Can you elaborate on the lack of information you have with the current logs?` it is better to output below warning log ``` [ActionsApi] Unable to invoke action guest/hello, because namespace:guest has exceeded its throttle limit, detail info: RejectRequest(429 Too Many Requests) Too many concurrent requests in flight (count: 0, allowed: 2) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #4164: Add warn log when too many requests happened
ningyougang commented on issue #4164: Add warn log when too many requests happened URL: https://github.com/apache/incubator-openwhisk/pull/4164#issuecomment-446128276 Regarding `Can you elaborate on the lack of information you have with the current logs?` it is better to output below warning log ``` [2018-12-11T17:13:31.486Z] [WARN] [#tid_qlbXZYpWuI9uH5UjR5FzXi9AGge2TyPU] [ActionsApi] Unable to invoke action guest/hello, because namespace:guest has exceeded its throttle limit, detail info: RejectRequest(429 Too Many Requests) Too many concurrent requests in flight (count: 0, allowed: 2) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] upgle opened a new pull request #4166: Update the package name in a document
upgle opened a new pull request #4166: Update the package name in a document URL: https://github.com/apache/incubator-openwhisk/pull/4166 ## Description Update the package name in a doc. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on a change in pull request #4164: Add warn log when too many requests happened
ningyougang commented on a change in pull request #4164: Add warn log when too
many requests happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r240521991
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
##
@@ -86,7 +89,11 @@ trait BasicAuthorizedRouteProvider extends Directives {
case NotFound =>
handleEntitlementFailure(
RejectRequest(NotFound,
Some(ErrorResponse(Messages.resourceDoesntExist(resource.fqname), transid
- case _ => handleEntitlementFailure(t)
+ case code =>
+if (code == TooManyRequests) {
+ logger.warn(this, s"${resource.id} invoked failed: ${t}")
+}
Review comment:
Just add `protected implicit val logging: Logging` in `trait
BasicAuthorizedRouteProvider` is enough,
because the subclass will implement the logging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on a change in pull request #4164: Add warn log when too many requests happened
ningyougang commented on a change in pull request #4164: Add warn log when too
many requests happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r240521627
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
##
@@ -64,6 +65,8 @@ trait BasicAuthorizedRouteProvider extends Directives {
/** Route directives for API. The methods that are supported on entities. */
protected lazy val entityOps = get
+ private val logger = new PrintStreamLogging()
Review comment:
Already applied AkkaLogging
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh opened a new pull request #4165: Update to Kamon 1.1.3 from 0.6 series
chetanmeh opened a new pull request #4165: Update to Kamon 1.1.3 from 0.6 series URL: https://github.com/apache/incubator-openwhisk/pull/4165 Updates Kamon to 1.x release (1.1.3) from current 0.6 version ## Description Going forward I would like to enable metrics reporting via Prometheus. [Kamon Prometheus][1] support was added with Kamon 1.0 series. Hence the need to update Kamon [Kamon 1.0][2] was a major release involving some breaking changes which needs some [migration work][3] ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. [1]: https://kamon.io/documentation/1.x/reporters/prometheus/ [2]: https://kamon.io/teamblog/2018/01/18/kamon-1.0.0-is-out/ [3]: https://kamon.io/documentation/1.x/recipes/migrating-from-kamon-0.6/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #4164: Add warn log when too many requests happened
markusthoemmes commented on a change in pull request #4164: Add warn log when
too many requests happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r240504779
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
##
@@ -86,7 +89,11 @@ trait BasicAuthorizedRouteProvider extends Directives {
case NotFound =>
handleEntitlementFailure(
RejectRequest(NotFound,
Some(ErrorResponse(Messages.resourceDoesntExist(resource.fqname), transid
- case _ => handleEntitlementFailure(t)
+ case code =>
+if (code == TooManyRequests) {
+ logger.warn(this, s"${resource.id} invoked failed: ${t}")
+}
Review comment:
Since we don't have a logger at hand here:
1. Should we pass a logger into the `authorizeAndDispatch` method?
2. Can we log outside of the method by inspecting it's return value?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #4164: Add warn log when too many requests happened
markusthoemmes commented on a change in pull request #4164: Add warn log when
too many requests happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r240504031
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
##
@@ -64,6 +65,8 @@ trait BasicAuthorizedRouteProvider extends Directives {
/** Route directives for API. The methods that are supported on entities. */
protected lazy val entityOps = get
+ private val logger = new PrintStreamLogging()
Review comment:
Please never use `PrintStreamLogging` in production code. It has severe
impact on performance. We always use `AkkaLogging` there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
