[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365702043 Okay, sorry @mrutkows for wasting your time with a terrible example. I have pushed a public repo that you can use to reproduce the error. I used the the version of wskdeploy that is in your current master branch. Go ahead and do this: ``` git clone g...@github.com:allen-servedio/wskdeploy-defect-740.git cd wskdeploy-defect-740/defect-740 wskdeploy -v -m manifest.yaml ``` And you will get this failure: ``` Info: action [hellopkg/hello] has been successfully deployed. panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2deb87] goroutine 1 [running]: github.com/apache/incubator-openwhisk-wskdeploy/deployers.(*ServiceDeployer).DeployDependencies(0x10983730, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go:472 +0x8d7 github.com/apache/incubator-openwhisk-wskdeploy/deployers.(*ServiceDeployer).deployAssets(0x10983730, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go:374 +0x3b github.com/apache/incubator-openwhisk-wskdeploy/deployers.(*ServiceDeployer).Deploy(0x10983730, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go:358 +0x3de github.com/apache/incubator-openwhisk-wskdeploy/cmd.Deploy(0x1, 0x1097f7ac) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:241 +0x45d github.com/apache/incubator-openwhisk-wskdeploy/cmd.RootCmdImp(0x565720, 0x109c9a40, 0x0, 0x3, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:54 +0x14 github.com/spf13/cobra.(*Command).execute(0x565720, 0x108ac388, 0x3, 0x3, 0x565720, 0x108ac388) /home/travis/gopath/src/github.com/spf13/cobra/command.go:632 +0x2df github.com/spf13/cobra.(*Command).ExecuteC(0x565720, 0x3, 0x0, 0x0) /home/travis/gopath/src/github.com/spf13/cobra/command.go:722 +0x285 github.com/spf13/cobra.(*Command).Execute(0x565720, 0x0, 0x0) /home/travis/gopath/src/github.com/spf13/cobra/command.go:681 +0x1b github.com/apache/incubator-openwhisk-wskdeploy/cmd.Execute() /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:68 +0x30 main.main() /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/main.go:26 +0x11 ``` I then run `wsk package list` and `wsk action list` and can see that it actually deployed the `hellopkg` into my namespace and the `hellopkg/hello` action into it. You can then use `wskdeploy undeploy -v -m manifest.yaml` to clean up your environment. Next time I'll give you a better example - thank you for your patience. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365689045 Sorry, I should have specified, the code I am running is based on this pull request: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/738 For you to get the segfault, it is going to have to point to a valid repo. The error you are seeing is documented in https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735 ... So basically, you have to have a valid repo to point to with another `manifest.yaml` there describing what to deploy. Once that is hooked up, then you will get to the segfault. I don't have a public repo for you to point at, I am hitting a private repo and #738 is letting me pass credentials to it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365689045 Sorry, I should have specified, the code I am running is based on this pull request: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/738 For you to get the segfault, it is going to have to point to a valid repo. The error you are seeing is documented in https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365689045 Sorry, I should have specified, the code I am running is based on this pull request: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/738 For you to get the segfault, it is going to have to point to a valid repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365682549 Okay. I created #742 for it ignoring the packages section. So the scope of this defect is the segfault issue. In case it helps, the `manifest.yaml` for the dependency looks like this: ``` project: name: PocCommonFunc version: 0.0.1 packages: rediskv: license: Apache-2.0 inputs: redisURL: type: string description: Redis database URL actions: kvget: function: retrieve/index.js runtime: nodejs kvput: function: store/index.js runtime: nodejs ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365614159 And, now that I am looking closer, it looks like I am wrong about - at least - the work around. When I add the `package` definition to the bottom, the tool ignores the dependency and ONLY tries to deploy the package. So, while it no longer segfaults, it also does not deploy the dependencies I defined... The first config that segfaults at the end at least deploys the dependencies okay (and can undeploy them). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #740: Segfault when root package is not defined
allen-servedio commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365611487 This is particularly concerning because: 1. It should have failed on manifest parsing as a required field. 2. You get this warning for the one that works: `WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
