[GitHub] cbickel commented on issue #3644: Allow more special characters in EntityName.

2018-05-14 Thread GitBox 
cbickel commented on issue #3644: Allow more special characters in EntityName.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3644#issuecomment-388837893
 
 
   PG5#319 is  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3644: Allow more special characters in EntityName.

2018-05-14 Thread GitBox 
cbickel commented on issue #3644: Allow more special characters in EntityName.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3644#issuecomment-388785670
 
 
   @rabbah There are already some tests, to check for forbidden characters. 
Nevertheless, I've added some more, for more special characters.
   
   @chetanmeh Thanks for your hint. I've changed the PR to only add the `&` 
character.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3644: Allow more special characters in EntityName.

2018-05-14 Thread GitBox 
cbickel commented on issue #3644: Allow more special characters in EntityName.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3644#issuecomment-388785670
 
 
   @rabbah There are already some tests, to check for forbidden characters. 
Nevertheless, I've added some more, for more special characters.
   
   @chetanmeh Thanks for your hint. I've changed the PR to the proposal of 
rodirc. Do you agree with this set of characters?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services