[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-391295950 Can this PR be reviewed and approved? As this is required for some other PRs #3453, Attachment In lining and S3AttachmentStore (branch exist but PR pending) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-389851869 Rebased to current master. @rabbah and @dubee would be helpful if you can review the proposed changes now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-378148473 Finally its green now! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377946685 This PR is now ready for review. Attachment inlining is done in a [separate branch][1] and can possibly be reviewed as part of separate PR. [1]: https://github.com/apache/incubator-openwhisk/compare/chetanmeh:immutable-attachments...chetanmeh:immutable-attachments-inline-2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377946685 This PR is now ready for review. Attachment inlining is done in a [separate branch][1] and can possibly be reviewed as part of separate PR. [1]: https://github.com/apache/incubator-openwhisk/compare/chetanmeh:immutable-attachments...chetanmeh:immutable-attachments-inline This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
URL:
https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377718828
Attachment Inlining
This feature would allow more natural inlining of attachment content solely
on the basis of attachment size compared to current runtime manifest based
approach. Under this if any
1. attachment length \>= `maxInlineSize` - Then its saved as proper
attachment
2. attachment length < `maxInlineSize` - Then its content would be converted
to URL encoded base64 string and would be stored as part of `attachmentName`
within the action document. Thus it can read without going to attachment storage
This is currently implemented as a [separate branch][1]. I am not sure if
this should be treated as separate PR or included in current PR (it changes
`readAttachment` api signature)
Probably we can include it in current PR and thus be done with all planned
changes in `ArtifactStore` API for once as of now
[1]:
https://github.com/apache/incubator-openwhisk/compare/chetanmeh:immutable-attachments...chetanmeh:immutable-attachments-inline
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377204137 @rabbah This is initial implementation of approach B (#3500) to check if this looks worth pursuing. If it looks ok would work further to add more test coverage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
