chetanmeh opened a new pull request #3689: Extend env 3477 URL: https://github.com/apache/incubator-openwhisk/pull/3689 Provides a way to extend the environment variable set for Controller and Invoker ## Description As mentioned in #3477 for some set of deployments like those using CosmosDB we need to add some extra environment variables like `CONFIG_whisk_spi_ArtifactStoreProvider`. To support that ansible playbook now supports add a set of environment variables conditionally. ### Usage To add extra environment variables user need to define them under `group_vars/all` for specific environment ```yaml cosmos: CONFIG_whisk_spi_ArtifactStoreProvider: whisk.core.database.cosmosdb.CosmosDBArtifactStoreProvider CONFIG_whisk_cosmosdb_endpoint : "https://<account name>.documents.azure.com:443/" CONFIG_whisk_cosmosdb_key : "some secret" CONFIG_whisk_cosmosdb_db : openwhisk ``` Here `cosmos` is the name of the environment variable set related to CosmosDB. To enable this set user needs to set an environment vairable ``` OPENWHISK_EXTRA_ENV_SETS=cosmos ``` Here `OPENWHISK_EXTRA_ENV_SETS` refers to a comma separated list of environment variable set which need to be added. If configured then all variables defined under `cosmos` key would be added to env of controller and invoker ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#3477) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
