[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r147012475 ## File path: docker-compose/docker-compose.yml ## @@ -81,12 +82,15 @@ services: - ~/tmp/openwhisk/local.env # generated during make setup environment: COMPONENT_NAME: invoker - SERVICE_NAME: invoker0 + INVOKER_NAME: invoker0 Review comment: > make the invokerName envvar optional see https://github.com/apache/incubator-openwhisk/pull/2902 as a first step This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146998430 ## File path: docker-compose/docker-compose.yml ## @@ -81,12 +82,15 @@ services: - ~/tmp/openwhisk/local.env # generated during make setup environment: COMPONENT_NAME: invoker - SERVICE_NAME: invoker0 + INVOKER_NAME: invoker0 Review comment: ``` [ERROR] [??] [Config] required property invoker.name still not set [ERROR] [??] [Invoker] Bad configuration, cannot start. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146998430 ## File path: docker-compose/docker-compose.yml ## @@ -81,12 +82,15 @@ services: - ~/tmp/openwhisk/local.env # generated during make setup environment: COMPONENT_NAME: invoker - SERVICE_NAME: invoker0 + INVOKER_NAME: invoker0 Review comment: ```[ERROR] [??] [Config] required property invoker.name still not set [ERROR] [??] [Invoker] Bad configuration, cannot start.``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146184088 ## File path: docker-compose/docker-compose.yml ## @@ -116,6 +116,8 @@ services: image: redis:2.8 expose: - "6379" +ports: + - "6379:6379" Review comment: I can move this `PORT` into a separate PR, but the reason it exists is to provide a local cache for some actions (i.e. auth via PassportJS which uses https://github.com/ddragosd/openwhisk-cache-redis) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146179323 ## File path: docker-compose/docker-compose.yml ## @@ -81,12 +82,15 @@ services: - ~/tmp/openwhisk/local.env # generated during make setup environment: COMPONENT_NAME: invoker - SERVICE_NAME: invoker0 + INVOKER_NAME: invoker0 Review comment: Given that Redis is not a dependency anymore, do you still think we should give it a distinct name ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146022911 ## File path: docker-compose/docker-compose.yml ## @@ -81,12 +82,15 @@ services: - ~/tmp/openwhisk/local.env # generated during make setup environment: COMPONENT_NAME: invoker - SERVICE_NAME: invoker0 + INVOKER_NAME: invoker0 Review comment: I think for compose we don't need to rely on Redis. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #62: added redis host for invoker
ddragosd commented on a change in pull request #62: added redis host for invoker URL: https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146022141 ## File path: docker-compose/docker-compose.yml ## @@ -73,6 +73,7 @@ services: links: - db:db.docker - kafka:kafka.docker + - redis:redis.docker depends_on: - db - kafka Review comment: :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
