[GitHub] dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel
dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel URL: https://github.com/apache/incubator-openwhisk/pull/3974#issuecomment-457598870 Closing this PR as it seems more fruitful to push on full integration with platform logging and/or fully structured logging instead of this partial solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel
dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel URL: https://github.com/apache/incubator-openwhisk/pull/3974#issuecomment-438794664 since it was easy, I rebased to resolve conflicts & squashed back to a single commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel
dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel URL: https://github.com/apache/incubator-openwhisk/pull/3974#issuecomment-438786143 Not much has happened. I do still think having a start sentinel is potentially useful, but there were some additional wrinkles I hadn't considered that came up in discussion of this PR. 1. We can't trust the `namespace` information in the start sentinel (malicious users could write actions that generate many spurious start sentinels to their action's logs targeting another namespace). So we still need an additional mechanism to associate the namespace for the log. 2. Depending on implementation details of the underlying container engine, we may need a way to block deletion of the container until log processing has completed (or we could lose user logs). This means there could still need to be some coupling between log processing and the invoker's container management state machine, which reduces the potential simplification of having purely streaming logs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel
dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel URL: https://github.com/apache/incubator-openwhisk/pull/3974#issuecomment-416277124 rebased to resolve conflicts with merged PR #3909 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel
dgrove-oss commented on issue #3974: Support for start-of-activation log sentinel URL: https://github.com/apache/incubator-openwhisk/pull/3974#issuecomment-413596880 A proof of concept implementation of the runtime changes for nodejs is in https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
