[GitHub] jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed

2018-11-28 Thread GitBox
jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed
URL: 
https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-442367251
 
 
   yes, we don't need that promise


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed

2018-11-27 Thread GitBox
jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed
URL: 
https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-441978510
 
 
   @cbickel 
   do you mean create an extra `Promise[Either[ActivationId, WhiskActivation]]` 
, saved it into the new map for blocking activations, and return this 
`promise.future` in the `publish` method,
   and for non-blocking activations, just keep the original way?
   
   or
   
   don't create promise for non-blocking activations, just return an 
`Future.successful(Left(aid))` in the `publish` method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services