jthomas commented on a change in pull request #99: Add Code Query Parameter
URL:
https://github.com/apache/incubator-openwhisk-client-js/pull/99#discussion_r174441059
##
File path: test/unit/actions.test.js
##
@@ -60,7 +79,7 @@ test('should retrieve action from string identifier', t => {
t.is(path, `namespaces/${ns}/actions/12345`)
}
- return actions.get('12345')
Review comment:
@dubeejw The test case was throwing an error because this change [broke that
API](https://github.com/apache/incubator-openwhisk-client-js#invoke-action).
Can you submit a PR to revert this test case change and modify the `get` method
to handle the string identifier. There's a `parse_options` method that you can
use to handle the string case correctly.
https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/resources.js#L64-L70
We'll push this out as a patch release.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
