[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-456131708 For doumentation purposes: 1) Rejection list if the validation rejection is overshadowed by another configured authetication method  This list is reduced to the first rejection only:  which is returned as request result https://user-images.githubusercontent.com/15377852/51486862-b7a8b700-1d99-11e9-9617-883500b87bfe.png;> The fix reduces the list to the ValidationRejection only which is returned correctly https://user-images.githubusercontent.com/15377852/51486938-e6269200-1d99-11e9-8e1b-22fe0830fac5.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-453931997 @rabbah Could you please have another look on this PR. Please see may comments to the test situation above. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-447851741 @ddragosd validations = our code that implements MiscDirectives.validate (mostly checks on a valid entity name format) IBM Cloud Functions supports the well known Basic authentication using an api key, but also authentication and authorization against IBM IAM by implementing our own authentication and entitlement SPI (Since these enhancements are not usable outside IBM we did not open source these SPIs. But I hope to find time in the near future to explain such a implementation on a example level). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-445886781 Since the SPI configured in open only configures Basic authentication only it is not easy to test here (there will never be a authentication rejection that overshadows an validation rejection). I have tested this manually to work with the IAM authentication we use in Cloud Functions (with different authentication sequences and no authentication given) Additionally it passes our test suite which runs on this configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-445884412 Rebased This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case
mhenke1 commented on issue #4163: Correct rejection behavior in the multi authentication case URL: https://github.com/apache/incubator-openwhisk/pull/4163#issuecomment-445881708 [PG 4|2463 succeeded] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
