[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365696202 @allen-servedio how do we automate a testcase for this (i.e., with someones private repo. credentials)? ... assuming we merge the other PR this one is predicated upon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365696202 @allen-servedio how do we automate a testcase for this (i.e., with someones private repo. credentials)? ... assuming we merge the other PR this issue is predicated upon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365696202 @allen-servedio how do we automate a testcase for this (i.e., with someones private repo. credentials)? ... assuming we merge the other PR this predicates. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365696202 @allen-servedio how do we automate a testcase for this (i.e., with someones private repo. credentials)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365690556 @allen-servedio I am confused. You submitted a PR to support dependencies on private repos that if we accept it results in an error elsewhere in the code? Why does the PR not address this further issue as well as add a testcase for it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365690556 @allen-servedio I am confused. You submitted a PR to support dependencies on private repos that if we accept it results in an error elsewhere in the code? Why does the PR not address this further issue as well as add a testcase for it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365688386 @allen-servedio Running the first manifest (above) that causes you a segfault works for me and correctly reports on error (Unix/Mac): ``` ./incubator-openwhisk-wskdeploy -i -v -m ~/manifest.yaml Info: Configuration: > WithinOpenWhisk: [false] > ApiHost: [] > Auth: [] > Namespace: [] > ApiVersion: [] > CfgFile: [/Users/Matt/.wskprops] > CliVersion: [unset] > CliBuild: [unset] > Verbose: [true] > ProjectPath: [.] > DeploymentPath: [] > ManifestPath: [/Users/Matt/manifest.yaml] > UseDefaults: [false] > UseInteractive: [true] > Strict: [false] > Key: [] > Cert: [] > Managed: [false] Info: The API host is [openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [_], from .wskprops. [ploy/utils.ParseOpenWhisk]:116:[Inf] Unmarshal OpenWhisk info from internet. Error: manifestreader.go [103]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [manifest.yaml]: ==> manifestreader.go [147]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [poc-common-func]: ==> ==> zip: not a valid zip file ==> ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365679802 @allen-servedio is it possible to open granular issues for each case (i.e., test, actual behavior, expected behavior)? of course, if there is nil pointer deref (even on incomplete schema) we want to catch and handle it gracefully. We can use this issue to track that fix against your first manifest. To me, it still seems like the non-deprecated, canonical schema (as described in spec.) works even by your last description. If so, then it is a matter of emitting the proper warnings and/or errors for those that follow deprecated (or incorrect) schema. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365679802 @allen-servedio is it possible to open granular issues for each case (i.e., test, actual behavior, expected behavior)? of course, if there is nil pointer deref (even on incomplete schema) we want to catch and handle it gracefully. To me, it still seems like the non-deprecated, canonical schema (as described in spec.) works even by your last description. If so, then it is a matter of emitting the proper warnings and/or errors for those that follow deprecated (or incorrect) schema. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365679802 @allen-servedio is it possible to open granular issues for each case (i.e., test, actual behavior, expected behavior)? To me, it still seems like the non-deprecated, canonical schema (as described in spec.) works even by your last description. If so, then it is a matter of emitting the proper warnings and/or errors for those that follow deprecated (or incorrect) schema. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365679802 @allen-servedio is it possible to open granular issues for each case? To me, it still seems like the non-deprecated, canonical schema (as described in spec.) works even by your last description. If so, then it is a matter of emitting the proper warnings and/or errors for those that follow deprecated (or incorrect) schema. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #740: Segfault when root package is not defined
mrutkows commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-365679802 @allen-servedio is it possible to open granular issues for each case? To me, it still seems like the non-deprecated, canonical schema (as described in spec.) works. Then it is a matter of emitting the proper warnings and/or errors for those that follow deprecated (or incorrect) schema. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
