[GitHub] rabbah commented on a change in pull request #4106: Update to Spray-json 1.3.5 security fix release
rabbah commented on a change in pull request #4106: Update to Spray-json 1.3.5 security fix release URL: https://github.com/apache/incubator-openwhisk/pull/4106#discussion_r232610524 ## File path: tests/src/test/scala/org/apache/openwhisk/core/entity/test/SchemaTests.scala ## @@ -46,6 +46,10 @@ class SchemaTests extends FlatSpec with BeforeAndAfter with ExecHelpers with Mat behavior of "Privilege" + private implicit class ExecJson(e: Exec) { +def asJson: JsObject = Exec.serdes.write(e).asJsObject Review comment: Is this printing to string then back to jsobject? Why do that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #4106: Update to Spray-json 1.3.5 security fix release
rabbah commented on a change in pull request #4106: Update to Spray-json 1.3.5 security fix release URL: https://github.com/apache/incubator-openwhisk/pull/4106#discussion_r232610524 ## File path: tests/src/test/scala/org/apache/openwhisk/core/entity/test/SchemaTests.scala ## @@ -46,6 +46,10 @@ class SchemaTests extends FlatSpec with BeforeAndAfter with ExecHelpers with Mat behavior of "Privilege" + private implicit class ExecJson(e: Exec) { +def asJson: JsObject = Exec.serdes.write(e).asJsObject Review comment: Is this printing to string then back to jsobject? Why do that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services