[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363549896 @csantanapr changes updated, can you update your review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363493141 @csantanapr I generally agree the intended behavior is to just update. The concern was about breaking existing code. There are create and update actions which do the more conservative behavior. So we can treat this as a bug, remove the parameter and just do the update on 404. I'm OK with that too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363455802 It would be nice to add a unit test similar to the one here https://github.com/apache/incubator-openwhisk-package-cloudant/blob/master/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala#L290. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363454906 Thanks for submitting the PR. Do you have an Apache ICLA on file? https://github.com/apache/incubator-openwhisk-package-cloudant/blob/master/CONTRIBUTING.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
