rabbah opened a new issue #3693: new invokers cause load balanacer to 
reallocate black box invokers
URL: https://github.com/apache/incubator-openwhisk/issues/3693
 
 
   The logic to update the set of managed and black box invokers will cause new 
invokers (when a sufficient number is added) to become black box invokers, and 
reallocates ones that were black box invokers as managed invokers.
   
   
https://github.com/apache/incubator-openwhisk/blob/166189a8f15c99d9237e7020865a34c5bc92a0c2/core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala#L422-L431
   
   This can cause new invokers to re-pull images, and activations which might 
have been warn start on previous invokers now become cold starts.
   
   Updating this test 
https://github.com/apache/incubator-openwhisk/blob/f64722498bc2f5eadc356b3ae26ebb85de1bcdbf/tests/src/test/scala/whisk/core/loadBalancer/test/ShardingContainerPoolBalancerTests.scala#L45
   
   ```
       // apply third update, growing the state
       val update3 = IndexedSeq(healthy(0), healthy(1), healthy(2))
       state.updateInvokers(update3)
   
       state.invokers shouldBe update3
       state.managedInvokers shouldBe update3.dropRight(1)
       state.blackboxInvokers shouldBe IndexedSeq(update3.last)
   ```
   
   shows the change in invoker sets.
   
   @markusthoemmes had a good suggestion in Slack which is better long term. 
I'll leave it to him to document in a future comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to