rabbah opened a new issue #927: action deploy even when runtime is deprecated
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/927
 
 
   I can reproduce by deploying openwhisk with the following manifest:
   
   ```
   > cat ansible/files/runtimes.json
   {
       "runtimes": {
           "nodejs": [
               {
                   "kind": "nodejs",
                   "image": {
                       "name": "nodejs6action"
                   },
                   "deprecated": true
               },
               {
                   "kind": "nodejs:6",
                   "default": true,
                   "image": {
                       "name": "nodejs6action"
                   },
                   "deprecated": false
               }
           ]
       },
       "blackboxes": [
           {
               "name": "dockerskeleton"
           }
       ]
   }
   ```
   
   and the following wskdeploy manifest
   ```
   packages:
     p:
       actions:
         hello:
           function: hello.js
           runtime: nodejs
   ```
   
   this is the output from `wskdeploy`:
   
   ```
   Info: The API host is [https://localhost], from .wskprops.
   Info: The auth key is set, from .wskprops.
   Info: The namespace is [_], from .wskprops.
   Info: Unmarshal OpenWhisk runtimes from local values.
   Warning: The mandatory key [package version] should be set. Using default 
value [0.0.1]...
   Warning: The value for key [package version] is not saved in the current 
version of wskdeploy.
   Warning: The mandatory key [package license] should be set. Using default 
value [unlicensed]...
   Warning: The value for key [package version] is not saved in the current 
version of wskdeploy.
   Warning: Invalid or missing runtime [nodejs] specified in manifest for the 
action [hello].
   Warning: Runtime changed to [nodejs:6] based on the action's source file 
extension for action [hello].
   Info: Deploying package [p] ...
   Info: package [p] has been successfully deployed.
   
   Info: Deploying action [p/hello] ...
   Info: action [p/hello] has been successfully deployed.
   Success: Deployment completed successfully.
   ```
   
   Note the `Warning: Invalid or missing runtime [nodejs] specified in manifest 
for the action [hello].` is correct but I think the action should not 
automatically deploy without an override from the user as there may be 
incompatible or breaking changes relative to the source code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to