rabbah opened a new issue #928: hardcoded protocol does not allow for http to 
be used
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/928
 
 
   this line hardcodes `https` as the protocol.
   
   
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L85
   
   if the api host already includes a protocol, wskdeploy fetches the runtime 
manifest from hardcoded values here:
   
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L229
   
   this is startling - instead `wskdeploy` should fail --- the hardcoded values 
could be very different from the deployment wrt action default, supported 
actions, etc... isn't this dangerous?!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to