[GitHub] tysonnorris commented on issue #2282: Distributed tracing support #2192

2018-06-08 Thread GitBox
tysonnorris commented on issue #2282: Distributed tracing support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-395804871
 
 
   @sandeep-paliwal can you add the ability to leverage the "extra logging" 
header to force a trace generation on demand? (since sample will not reliably 
create a trace for each activation)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tysonnorris commented on issue #2282: Distributed tracing support #2192

2017-06-14 Thread git
tysonnorris commented on issue #2282: Distributed tracing support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-308469527
 
 
   @rabbah is there anything else pending for this PR to get merged? I suggest 
merging it and (like many other things already in the system), refactoring to 
pluggable nature once a pattern for that is established. If there is concern 
about the weight of dependencies added here, let's discuss, but it seems a 
limited change in that way, and configurable to disable side affects if desired 
(and disabled state is default)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services