[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-11-06 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-436490820
 
 
   @rabbah test is passed. thank you for your support  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-11-01 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-435238002
 
 
   @rabbah ok, thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-10-19 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-431277851
 
 
   @ningyougang thank you, i'll rebase it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-08-09 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411977645
 
 
   @junoyoon no, i'm waiting for review.
   
   @rabbah ok, tell me if I missed something.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-07-31 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-409237580
 
 
   @rabbah Maybe it's done. could you please review it again? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-07-24 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-407599858
 
 
   I fixed a conflict. please review it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-07-17 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-405807606
 
 
   @rabbah 
   
   I modified it to check the entitlement and added tests.
   Now, It returns the authentication error if a web action has no entitlement.
   ```
   {
 "error": "The supplied authentication is not authorized to access 
'whisk.system/share'.",
 "code": "NmSIY4dJanMT7YS3MPwFoOPL4Np72g5B"
   }
   ```
   
   Could you please remove WIP label and review again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services