[GitHub] vvraskin commented on a change in pull request #3882: Use invoker id for metrics instead of the hostname.
vvraskin commented on a change in pull request #3882: Use invoker id for
metrics instead of the hostname.
URL:
https://github.com/apache/incubator-openwhisk/pull/3882#discussion_r203442006
##
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##
@@ -208,6 +210,17 @@ object LogMarkerToken {
}
+object MetricSupport {
Review comment:
The problem with controllers would appear if we specify from the outside
whether its only for activations or for crud operations. This is typically
reflected in the container hostname which makes the metrics from all controller
instances distinct. Given the current implementation, it would require some
additional refactoring in the controller code to follow the same approach as in
the invoker...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vvraskin commented on a change in pull request #3882: Use invoker id for metrics instead of the hostname.
vvraskin commented on a change in pull request #3882: Use invoker id for
metrics instead of the hostname.
URL:
https://github.com/apache/incubator-openwhisk/pull/3882#discussion_r203353403
##
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##
@@ -208,6 +210,17 @@ object LogMarkerToken {
}
+object MetricSupport {
Review comment:
@chetanmeh wondering if we indeed need this object since we only use it for
invoker. In case of controller we don't really override it in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
