[GitHub] zhy989 opened a new issue #210: How to use message feed
zhy989 opened a new issue #210: How to use message feed URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/210 I installed the message package successfully -wsk -i package list packages /whisk.system/messagingWeb private /whisk.system/messagingshared /whisk.system/alarmsWeb private /whisk.system/alarms shared /whisk.system/combinators shared /whisk.system/watson-speechToText shared /whisk.system/samples shared /whisk.system/watson-translatorshared /whisk.system/slackshared /whisk.system/websocketshared /whisk.system/github shared /whisk.system/utilsshared /whisk.system/weather shared /whisk.system/watson-textToSpeech shared - wsk -i package refresh error: Package refresh for namespace '_' failed: The requested resource could not be found. (code 7175) - wsk -i package refresh /whisk.system error: Package refresh for namespace 'whisk.system' failed: The requested resource could not be found. (code 7187) why the CLI "wsk -i package refresh" failed ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hsane2001 commented on issue #2221: Unable to create trigger
hsane2001 commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320166193 I kept it as ENV in each docker file, but build this time without "ansible-playbook API-gateway". Then Pinged externally from the controller, consul, Kafka, invoked containers and now I can get actions that reach external sites. However I still can't get trigger from whisk/alarm to work, it fails as soon as I provide the feed on socket,connect On failure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 closed pull request #2561: Execute stat command on localhost
style95 closed pull request #2561: Execute stat command on localhost URL: https://github.com/apache/incubator-openwhisk/pull/2561 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #2561: Execute stat command on localhost
style95 commented on issue #2561: Execute stat command on localhost URL: https://github.com/apache/incubator-openwhisk/pull/2561#issuecomment-320185492 ok I will close this PR. It is superseded by #2557 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #2414: SPI approach for pluggable implementations
markusthoemmes closed pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhy989 opened a new issue #81: can not compile successfully
zhy989 opened a new issue #81: can not compile successfully URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/81 - when I run CLI "./gradlew distDocker", it can not run successfully, the error is as below: - ./gradlew distDocker The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead. at docker_7r8ejptnt4f4tnx46yncyk4ag.run(/home/zhy/iot/incubator-openwhisk-package-alarms/gradle/docker.gradle:43) FAILURE: Build failed with an exception. * Where: Build file '/home/zhy/iot/incubator-openwhisk-package-alarms/tests/build.gradle' line: 28 * What went wrong: A problem occurred evaluating project ':tests'. > **Could not get unknown property 'sourceSets' for project ':whisktests' of type org.gradle.api.Project.** * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1.51 secs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Katiyman commented on issue #2221: Unable to create trigger
Katiyman commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320194648 I dont thing putting it as a ENV variable is required.. that was the mistake i did becoz of which i got issue export proxy in individual commands where ever proxy is required. like below RUN export http_proxy=http://1x.xx.xx.6:8080 && \ export https_proxy=https://1x.xx.xx.6:8080 && \ apk add --no-cache \ bzip2-dev \ gcc \ libc-dev \ libxslt-dev \ libxml2-dev \ libffi-dev \ linux-headers \ openssl-dev This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Katiyman commented on issue #2221: Unable to create trigger
Katiyman commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320194648 I dont thing putting proxy as a ENV variable is required.. that was the mistake i did, becoz of which i got issue export proxy in individual commands where ever proxy is required. like below RUN export http_proxy=http://1x.xx.xx.6:8080 && \ export https_proxy=https://1x.xx.xx.6:8080 && \ apk add --no-cache \ bzip2-dev \ gcc \ libc-dev \ libxslt-dev \ libxml2-dev \ libffi-dev \ linux-headers \ openssl-dev This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Katiyman commented on issue #2221: Unable to create trigger
Katiyman commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320194648 I dont think putting proxy as a ENV variable is required.. that was the mistake i did, becoz of which i got issue export proxy in individual commands where ever proxy is required. like below RUN export http_proxy=http://1x.xx.xx.6:8080 && \ export https_proxy=https://1x.xx.xx.6:8080 && \ apk add --no-cache \ bzip2-dev \ gcc \ libc-dev \ libxslt-dev \ libxml2-dev \ libffi-dev \ linux-headers \ openssl-dev This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhy989 commented on issue #210: How to use message feed
zhy989 commented on issue #210: How to use message feed
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/issues/210#issuecomment-320191488
- wsk trigger create MyMessageHubTrigger -f
/whisk.system/messaging/messageHubFeed -p topic mytopic -i
ok: invoked /whisk.system/messaging/messageHubFeed with id
69c08183c6c74241ba96c4ff6512f549
{
"activationId": "69c08183c6c74241ba96c4ff6512f549",
"annotations": [
{
"key": "limits",
"value": {
"logs": 10,
"memory": 256,
"timeout": 6
}
},
{
"key": "path",
"value": "whisk.system/messaging/messageHubFeed"
}
],
"duration": 2354,
"end": 1501835456247,
"logs": [],
"name": "messageHubFeed",
"namespace": "whisk.system",
"publish": false,
"response": {
"result": {
"error": {}
},
"status": "application error",
"success": false
},
"start": 1501835453893,
"subject": "whisk.system",
"version": "0.0.1"
}
ok: invoked /whisk.system/messaging/messageHubFeed with id
dcb2451ba38848dd98e1d3edfce3e9aa
{
"activationId": "dcb2451ba38848dd98e1d3edfce3e9aa",
"annotations": [
{
"key": "limits",
"value": {
"logs": 10,
"memory": 256,
"timeout": 6
}
},
{
"key": "path",
"value": "whisk.system/messaging/messageHubFeed"
}
],
"duration": 17,
"end": 1501835456401,
"logs": [],
"name": "messageHubFeed",
"namespace": "whisk.system",
"publish": false,
"response": {
"result": {
"error": {}
},
"status": "application error",
"success": false
},
"start": 1501835456384,
"subject": "whisk.system",
"version": "0.0.1"
}
**ok: deleted trigger MyMessageHubTrigger**
Run 'wsk --help' for usage.
I can not create trigger MyMessageHubTrigger successfully.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes opened a new pull request #2576: Configure components via pureconfig.
markusthoemmes opened a new pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576 **Disclaimer:** Super-duper WIP but opened to get early feedback. The goal of this is to eventually provide all configuration through TypesafeConfig files and keep defaults very close to the component itself vs. keeping them in ansible. That will enable different deployment methods much more easily and also facilitate quick local testing. For instance the controller should be startable only given CouchDb and Kafka connection data. This adds the ability to configure the main components (controller/invoker) via pureconfig case-classes vs. using WhiskConfig. **Benefits are:** - Automatic type derivation - Static loading of config vs. passing one instance around - Proper scoping of configuration - It's the standard in Scala (based on TypesafeConfig) **Implementation:** TypesafeConfig reads JSON-like configuration files, which we can nest as we please. Those namespaces can be read by each component independently. While TypesafeConfig supports expansion of environment variables, one has to do so explicitly. Which System properties, one can override specific values directly without the added overhead. To achieve the best of both worlds (for containers we only have environment variables available) there is a small script which translates environment variables to system properties in Java. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2576: Configure components via pureconfig.
rabbah commented on issue #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#issuecomment-320337995 Early feedback: awesome. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jlost commented on issue #35: TypeScript Typings
jlost commented on issue #35: TypeScript Typings URL: https://github.com/apache/incubator-openwhisk-client-js/issues/35#issuecomment-320307393 I ended up making some typings as I went, but nothing accurate enough to publish... Maybe I'll throw them here anyway in case others want to chip in. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #63: style: add .editorconfig, eslint and reformat js file
codecov-io commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-320281397 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=h1) Report > Merging [#63](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #63 +/- ## === Coverage 99.37% 99.37% === Files 14 14 Lines 318 318 === Hits 316 316 Misses 22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree) | Coverage ? | | |---|---|---| | [lib/activations.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2FjdGl2YXRpb25zLmpz) | `100% (?)` | :arrow_up: | | [lib/namespaces.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL25hbWVzcGFjZXMuanM=) | `100% (?)` | :arrow_up: | | [lib/names.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL25hbWVzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/triggers.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3RyaWdnZXJzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/feeds.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2ZlZWRzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/routes.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3JvdXRlcy5qcw==) | `100% <100%> (?)` | :arrow_up: | | [lib/base\_operation.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2Jhc2Vfb3BlcmF0aW9uLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/actions.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (?)` | :arrow_up: | | [lib/rules.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3J1bGVzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/openwhisk\_error.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL29wZW53aGlza19lcnJvci5qcw==) | `100% <100%> (?)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=footer). Last update [d4b69d7...f658757](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 commented on a change in pull request #2520: Prints
bashauto-completion install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131438180
##
File path: tools/cli/go-whisk-cli/commands/sdk.go
##
@@ -74,17 +74,27 @@ var sdkInstallCmd = {
case "ios":
err = iOSInstall()
case "bashauto":
-err = WskCmd.GenBashCompletionFile(BASH_AUTOCOMPLETE_FILENAME)
-if (err != nil) {
-whisk.Debug(whisk.DbgError, "GenBashCompletionFile('%s`)
error: \n", BASH_AUTOCOMPLETE_FILENAME, err)
-errStr := wski18n.T("Unable to generate '{{.name}}': {{.err}}",
-map[string]interface{}{"name":
BASH_AUTOCOMPLETE_FILENAME, "err": err})
-werr := whisk.MakeWskError(errors.New(errStr),
whisk.EXITCODE_ERR_GENERAL, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
-return werr
-}
-fmt.Printf(
-wski18n.T("bash_completion_msg",
+if flags.sdk.stdout {
+if err = WskCmd.GenBashCompletion(os.Stdout); err != nil {
Review comment:
One uses `GenBashCompletion` the other uses `GenBashCompletionFile`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This change simply changes the output of the Cobra auto-completion script from a file to STDOUT. Originally, `wsk sdk install autobash` would create the file `wsk_cli_bash_completion.sh`, but now it will print the contents of the Cobra auto-completion script to the terminal. You can now use the command ``eval "`wsk sdk install autobash`"`` to automatically install the script for that instance of the terminal. Adding the eval command to your `.bashrc` or `.profile` will keep you from rerunning this command. Closes #1221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw opened a new pull request #2575: Use Configuration File with Scan Code and Add Missing License Header
dubeejw opened a new pull request #2575: Use Configuration File with Scan Code and Add Missing License Header URL: https://github.com/apache/incubator-openwhisk/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2520: Prints bashauto-completion install script to STDOUT
csantanapr commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320328730 pg 4/633 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
mdeuser commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320322970 imho, i worry a bit about the semantics of "update" changing just because a particular command flag is used. > https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320044929 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw opened a new pull request #2575: Use Configuration File with Scan Code and Add Missing License Header
dubeejw opened a new pull request #2575: Use Configuration File with Scan Code and Add Missing License Header URL: https://github.com/apache/incubator-openwhisk/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw closed pull request #2575: Use Configuration File with Scan Code and Add Missing License Header
dubeejw closed pull request #2575: Use Configuration File with Scan Code and Add Missing License Header URL: https://github.com/apache/incubator-openwhisk/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ert78gb opened a new pull request #64: chore: Ignore .idea directory from git
ert78gb opened a new pull request #64: chore: Ignore .idea directory from git URL: https://github.com/apache/incubator-openwhisk-client-js/pull/64 Why do you ignore package.lock.json ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This change simply changes the output of the Cobra auto-completion script from a file to STDOUT. Originally, `wsk sdk install autobash` would create the file `wsk_cli_bash_completion.sh`, but now it will print the contents of the Cobra auto-completion script to the terminal. You can now use the command ``eval "`wsk sdk install autobash`"`` to automatically install the script for that instance of the terminal. Adding the eval command to your `.bashrc` or `.profile` will keep you from rerunning this command. Closes #1221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #304: List support for openwhisk entities
houshengbo opened a new issue #304: List support for openwhisk entities URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/304 We currently support multiple entities like triggers, actions and rules, described under one element, but in different sub-elements. For exmaple, ``` triggers: # Trigger named ?data-inserted-trigger? # Creating trigger to fire events when data is inserted into database data-inserted-trigger: source: openwhisk-cloudant/changes inputs: dbname: $CLOUDANT_DATABASE data-inserted-trigger_1: source: openwhisk-cloudant/changes inputs: dbname: $CLOUDANT_DATABASE ``` We should extend to support entities defined in list, since list is a commonly supported in yaml file, like ``` triggers: - name: data-inserted-trigger: source: openwhisk-cloudant/changes inputs: dbname: $CLOUDANT_DATABASE - name: data-inserted-trigger1: source: openwhisk-cloudant/changes inputs: dbname: $CLOUDANT_DATABASE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #1221: Improve UX to install/setup CLI autocomplete
csantanapr closed issue #1221: Improve UX to install/setup CLI autocomplete URL: https://github.com/apache/incubator-openwhisk/issues/1221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #2520: Prints bashauto-completion install script to STDOUT
csantanapr closed pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #304: List support for openwhisk entities
houshengbo commented on issue #304: List support for openwhisk entities URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/304#issuecomment-320309367 @lzbj Could you please take a look at this enhancement? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #64: chore: Ignore .idea directory from git
codecov-io commented on issue #64: chore: Ignore .idea directory from git URL: https://github.com/apache/incubator-openwhisk-client-js/pull/64#issuecomment-320306165 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=h1) Report > Merging [#64](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #64 +/- ## === Coverage 99.37% 99.37% === Files 14 14 Lines 318 318 === Hits 316 316 Misses 22 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=footer). Last update [d4b69d7...719f49f](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/64?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
csantanapr commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320316130 @dubeejw yes I think this is becoming to fix. Let's implement like you suggested in https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320044929 if `--web` present with other annotations being set in cmd line, only those annotations would be set. it would work like the other entity annotations. if `--web` present and no annotations in cmd, then annotations are not touch only the export-web this will unblock the bug, which I lot of people are using `action update` to provision This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #2547: CLI Experimental api removal
drcariel commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320335407 PG2~1907 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hsane2001 commented on issue #2175: Provide a performance test-harness
hsane2001 commented on issue #2175: Provide a performance test-harness
URL:
https://github.com/apache/incubator-openwhisk/issues/2175#issuecomment-320367376
Hi ,
Running this harness on a OpenWhisk deployment running on a native Ubuntu
system runs into failures.
The noopLatency action is created and can be invoked via "wsk cli" but in
the latency test "docker run" is used. Can you explain what is happening? It
seems loadtest is being run in a docker container (outside the wsk system,
since its not invoked by wsk) and then invokes the noop action "n" number of
times. Is that whats happening? - Anyway I hit this error:
docker run --rm markusthoemmes/loadtest loadtest -n 1 -k -m POST -H
Authorization: basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1AK
http://10.x.x.y:10001/api/v1/namespaces/_/actions/noopLatency?blocking=true
headers: object,
{"host":"10.x.x.y:10001","user-agent":"loadtest/2.3.0","accept":"*/*","authorization":"
basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1AK"}
[Fri Aug 04 2017 15:11:27 GMT+ (UTC)] INFO Requests: 0 (0%), requests
per second: 0, mean latency: 0 ms
[Fri Aug 04 2017 15:11:32 GMT+ (UTC)] INFO Requests: 3895 (39%),
requests per second: 779, mean latency: 1.3 ms
[Fri Aug 04 2017 15:11:32 GMT+ (UTC)] INFO Errors: 3836, accumulated
errors: 3836, 98.5% of total requests
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Target URL:
http://10.x.x.y:10001/api/v1/namespaces/_/actions/noopLatency?blocking=true
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Max requests:1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Concurrency level: 1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Agent: keepalive
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Completed requests: 1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Total errors:9941
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Total time:
9.84325037999 s
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Requests per second: 1016
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Mean latency:1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Percentage of the requests
served within a certain time
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 50% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 90% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 95% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 99% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 100% 388 ms (longest
request)
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 100% 388 ms (longest
request)
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 429: 9941 errors
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #2175: Provide a performance test-harness
markusthoemmes commented on issue #2175: Provide a performance test-harness URL: https://github.com/apache/incubator-openwhisk/issues/2175#issuecomment-320369775 @hsane2001 you need to "disable" the system limits if you want to run this test harness. Configure them in your environment using the `limits` key. You're getting 429, which means you're getting throttled. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #2547: CLI Experimental api removal
drcariel commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320376106 PG1~1906 All up to date This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbrowning opened a new pull request #2577: Support multiple response header values in raw web actions
bbrowning opened a new pull request #2577: Support multiple response header
values in raw web actions
URL: https://github.com/apache/incubator-openwhisk/pull/2577
This change allows multiple response header values to be set in raw
web actions by using a JSON array as the header value. For example:
```
function main() {
return {
headers: {
"Set-Cookie": ["a=b", "c=d"]
},
code: 200
}
}
```
I have signed the Apache CLA as "Benjamin M. Browning".
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhy989 commented on issue #81: can not compile successfully
zhy989 commented on issue #81: can not compile successfully URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/81#issuecomment-320393533 @jasonpet I set the OPENWHISK_HOME env variable in file /etc/profile, but the error is still there: - ./gradlew :distdocker Starting a Gradle Daemon (subsequent builds will be faster) The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead. at docker_7r8ejptnt4f4tnx46yncyk4ag.run(/home/zhy/iot/incubator-openwhisk-package-alarms/gradle/docker.gradle:43) FAILURE: Build failed with an exception. * Where: Build file '/home/zhy/iot/incubator-openwhisk-package-alarms/tests/build.gradle' line: 28 * What went wrong: A problem occurred evaluating project ':tests'. > Could not get unknown property 'sourceSets' for project ':whisktests' of type org.gradle.api.Project. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 11.0 secs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hsane2001 commented on issue #2175: Provide a performance test-harness
hsane2001 commented on issue #2175: Provide a performance test-harness
URL:
https://github.com/apache/incubator-openwhisk/issues/2175#issuecomment-320367376
Hi ,
Running this harness on a OpenWhisk deployment running on a native Ubuntu
system runs into failures.
The noopLatency action is created and can be invoked via "wsk cli" but in
the latency test "docker run" is used. Can you explain what is happening? It
seems loadtest is being run in a docker container (outside the wsk system,
since its not invoked by wsk) and then invokes the noop action "n" number of
times. Is that whats happening? - Anyway I hit this error:
```
docker run --rm markusthoemmes/loadtest loadtest -n 1 -k -m POST -H
Authorization: basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1AK
http://10.x.x.y:10001/api/v1/namespaces/_/actions/noopLatency?blocking=true
headers: object,
{"host":"10.x.x.y:10001","user-agent":"loadtest/2.3.0","accept":"*/*","authorization":"
basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1AK"}
[Fri Aug 04 2017 15:11:27 GMT+ (UTC)] INFO Requests: 0 (0%), requests
per second: 0, mean latency: 0 ms
[Fri Aug 04 2017 15:11:32 GMT+ (UTC)] INFO Requests: 3895 (39%),
requests per second: 779, mean latency: 1.3 ms
[Fri Aug 04 2017 15:11:32 GMT+ (UTC)] INFO Errors: 3836, accumulated
errors: 3836, 98.5% of total requests
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Target URL:
http://10.x.x.y:10001/api/v1/namespaces/_/actions/noopLatency?blocking=true
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Max requests:1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Concurrency level: 1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Agent: keepalive
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Completed requests: 1
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Total errors:9941
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Total time:
9.84325037999 s
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Requests per second: 1016
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Mean latency:1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO Percentage of the requests
served within a certain time
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 50% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 90% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 95% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 99% 1 ms
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 100% 388 ms (longest
request)
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 100% 388 ms (longest
request)
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO
[Fri Aug 04 2017 15:11:37 GMT+ (UTC)] INFO 429: 9941 errors
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #2175: Provide a performance test-harness
markusthoemmes commented on issue #2175: Provide a performance test-harness URL: https://github.com/apache/incubator-openwhisk/issues/2175#issuecomment-320369775 @hsane2001 you need to "disable" the system limits if you want to run this test harness. Configure them in your environment using the `limits` key. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #2547: CLI Experimental api removal
drcariel commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320365350 PG3~968 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #2547: CLI Experimental api removal
drcariel commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320370268 PG4~635 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320375177 @mdeuser, take another look. Made some updates to keep the current semantics in place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320233699 That works, I had something like that similar until I realized it was cutting off a bunch of resp information. Due to this I was just trying to find problematic fields and reduce them. If we are okay with losing resp body information looks fine to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320233699 That works, I had something similar to that until I realized it was cutting off a bunch of resp body information. Due to this I was just trying to find problematic fields and reduce them. If we are okay with losing resp body information looks fine to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#discussion_r131377101 ## File path: docs/rest_api.md ## @@ -70,7 +70,9 @@ The OpenWhisk API supports request-response calls from web clients. OpenWhisk re ## Using the CLI verbose mode The OpenWhisk CLI is an interface to the OpenWhisk REST API. -You can run the CLI in verbose mode with the flag `-v`, this will print all the information about the HTTP request and response. +You can run the CLI in verbose mode with the flag `-v`, this will print truncated information about the HTTP request and response. To print all information use the flag `-d` for debug. + +**Note** Only HTTP request and response bodies will be truncated if they exceed 1000 bytes. Review comment: Made update to docs here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#discussion_r131377079 ## File path: docs/rest_api.md ## @@ -70,7 +70,9 @@ The OpenWhisk API supports request-response calls from web clients. OpenWhisk re ## Using the CLI verbose mode The OpenWhisk CLI is an interface to the OpenWhisk REST API. -You can run the CLI in verbose mode with the flag `-v`, this will print all the information about the HTTP request and response. +You can run the CLI in verbose mode with the flag `-v`, this will print truncated information about the HTTP request and response. To print all information use the flag `-d` for debug. Review comment: Made update to docs here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320238882 If you want to work in every terminal don't you just put it in your .bashrc or .profile? Wouldn't you have to do the same with the script or am I lacking a piece of information? I thought the goal was so you don't have to put this huge line in your .bashrc `pushd $(mktemp -d) > /dev/null && wsk sdk install bashauto > /dev/null && source wsk_cli_bash_completion.sh && popd > /dev/null`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /
mdeuser commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-320105916 If an API happens to be created with a basepath and path of `/` each, subsequent APIs created after this "/" API can be affected -> successful API creation followed by API invocation results in a 404 status code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320233699 That works, I had something similar to that until I realized it was cutting off a bunch of resp information. Due to this I was just trying to find problematic fields and reduce them. If we are okay with losing resp body information looks fine to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on a change in pull request #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#discussion_r131377079 ## File path: docs/rest_api.md ## @@ -70,7 +70,9 @@ The OpenWhisk API supports request-response calls from web clients. OpenWhisk re ## Using the CLI verbose mode The OpenWhisk CLI is an interface to the OpenWhisk REST API. -You can run the CLI in verbose mode with the flag `-v`, this will print all the information about the HTTP request and response. +You can run the CLI in verbose mode with the flag `-v`, this will print truncated information about the HTTP request and response. To print all information use the flag `-d` for debug. Review comment: Made update to docs here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This change simply changes the output of the Cobra auto-completion script from a file to STDOUT. Originally, `wsk sdk install autobash` would create the file `wsk_cli_bash_completion.sh`, but now it will print the contents of the Cobra auto-completion script to the terminal. You can now use the command ``eval "`wsk sdk install autobash`"`` to automatically install the script for that instance of the terminal. Adding the eval command to your `.bashrc` or `.profile` will keep you from rerunning this command. Closes #1221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 closed pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320233699 That works, I had something similar to that until I realized it was cutting off a bunch of resp body information. Due to this, I was just trying to find problematic fields and reduce them. If we are fine with losing resp body information then it looks fine to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2491: Limit length of HTTP body displayed when debugging.
mdeuser commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320242383 @bpoole16 - what will be the output of `wsk action get LARGEACTION` when the exec.code field is quite large? will the rest of the action output be intact? i'm assuming the normal output won't be affected; only the debug stuff... correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320243433 Originally yes, it would just limit the code field and the rest of the resp body would be intact. The issue I had with that way is it looked pretty messy and wasn't working 100%. With James suggestion it cuts off the resp body after 1000 bytes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320243433 Originally yes, it would just limit the code field and the rest of the resp body would be intact. With James suggestion it cuts off the resp body after 1000 bytes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320243433 Originally yes, it would just limit the code field and the rest of the resp body would be intact. Issue I had with that way is it looked pretty messy and was working 100%. With James suggestion it cuts off the resp body after 1000 bytes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320243433 Originally yes, it would just limit the code field and the rest of the resp body would be normal. With James suggestion it cuts off the resp body after 1000 bytes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320244017 Ah okay. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320243433 Originally yes, it would just limit the code field and the rest of the resp body would be intact. The issue I had with that way is it looked pretty messy and wasn't working 100%. With James suggestion it cuts off the resp body after 1000 bytes. This all only being for --verbose. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2520: Prints bashauto-completion install script to STDOUT
mdeuser commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320248242 i like the idea of keeping the existing behavior with a `--stdout` flag that outputs to stdout. if the cli implements a self-updating feature, then using `eval 'wsk sdk install bashauto --stdout'` in the .profile or similar would always provide the latest command support. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bjustin-ibm commented on issue #210: How to use message feed
bjustin-ibm commented on issue #210: How to use message feed URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/210#issuecomment-320248773 @zhy989 For interactive support, please join us on Slack: https://openwhisk.incubator.apache.org/slack.html In the meantime, you will be able to find more details about why you cannot create a trigger successfully by looking at the logs for activation `69c08183c6c74241ba96c4ff6512f549`. To do this, run `wsk activation get 69c08183c6c74241ba96c4ff6512f549` and examine the `logs` field. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT
bpoole16 opened a new pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520 This change simply changes the output of the Cobra auto-completion script from a file to STDOUT. Originally, `wsk sdk install autobash` would create the file `wsk_cli_bash_completion.sh`, but now it will print the contents of the Cobra auto-completion script to the terminal. You can now use the command ``eval "`wsk sdk install autobash`"`` to automatically install the script for that instance of the terminal. Adding the eval command to your `.bashrc` or `.profile` will keep you from rerunning this command. Closes #1221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cfjedimaster opened a new pull request #62: Update readme.md to fix bug w/ retrieve
cfjedimaster opened a new pull request #62: Update readme.md to fix bug w/ retrieve URL: https://github.com/apache/incubator-openwhisk-client-js/pull/62 The example to get an action doesn't work - this change corrects it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #62: Update readme.md to fix bug w/ retrieve
codecov-io commented on issue #62: Update readme.md to fix bug w/ retrieve URL: https://github.com/apache/incubator-openwhisk-client-js/pull/62#issuecomment-320256349 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=h1) Report > Merging [#62](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #62 +/- ## === Coverage 99.37% 99.37% === Files 14 14 Lines 318 318 === Hits 316 316 Misses 22 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=footer). Last update [d4b69d7...566c766](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/62?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320298257 PG 4 633 passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cfjedimaster opened a new issue #2574: CLI should note the requirement of the bluemix CLI
cfjedimaster opened a new issue #2574: CLI should note the requirement of the bluemix CLI URL: https://github.com/apache/incubator-openwhisk/issues/2574 ## Environment details: * local deployment, vagrant, native ubuntu, Mac OS, Bluemix, ... Ubuntu on Windows ## Steps to reproduce the issue: I was trying to get a list of my APIs, but needed to wsk bluemix login first. I have to use the --sso option, and when I did, I got: Unable to authenticate with Bluemix: Error reading config file '/home/ray/.bluemix/.cf/config.json' When I installed the bluemix CLI itself (and logged in), I was then able to successfully login with wsk as well. I believe the wsk CLI should provide a quick message stating the folks need to install the bluemix CLI first (only for API stuff of course). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI
rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI URL: https://github.com/apache/incubator-openwhisk/issues/2574#issuecomment-320268121 This seems like an issue for the bluemix CLI wrapper and hence I'm inclined to close this issue as invalid for this repo. @csantanapr @mdeuser thoughts? My understanding is there is nothing in the openwhisk cli that is bluemix specific hence nothind to do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131416686
##
File path: tools/cli/go-whisk-cli/commands/sdk.go
##
@@ -74,17 +74,27 @@ var sdkInstallCmd = {
case "ios":
err = iOSInstall()
case "bashauto":
-err = WskCmd.GenBashCompletionFile(BASH_AUTOCOMPLETE_FILENAME)
-if (err != nil) {
-whisk.Debug(whisk.DbgError, "GenBashCompletionFile('%s`)
error: \n", BASH_AUTOCOMPLETE_FILENAME, err)
-errStr := wski18n.T("Unable to generate '{{.name}}': {{.err}}",
-map[string]interface{}{"name":
BASH_AUTOCOMPLETE_FILENAME, "err": err})
-werr := whisk.MakeWskError(errors.New(errStr),
whisk.EXITCODE_ERR_GENERAL, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
-return werr
-}
-fmt.Printf(
-wski18n.T("bash_completion_msg",
+if flags.sdk.stdout {
+if err = WskCmd.GenBashCompletion(os.Stdout); err != nil {
Review comment:
Alternatively set an string that is passed to the `GenBashCompletion`
command based on whether the flag is provided or not. And only have one call
`GenBashCompletion`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ert78gb commented on issue #35: TypeScript Typings
ert78gb commented on issue #35: TypeScript Typings URL: https://github.com/apache/incubator-openwhisk-client-js/issues/35#issuecomment-320279271 I could help, but I think better if the code convert to typescript. Every js file is typescript file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /
mhamann commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-320285418 @akrabat but would you really want an API that has a root endpoint and basically no base path? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] akrabat commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /
akrabat commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-320288451 To be honest I have no idea what the base path is and how it differs from the api path. I do want to be able to do `curl https://my-cnamed-domain.com/` and get back a response. I expect that this API needs to be in it's own namespace for this to work though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] perryibm commented on issue #2569: 1 million per second event processing using openwhisk ??
perryibm commented on issue #2569: 1 million per second event processing using openwhisk ?? URL: https://github.com/apache/incubator-openwhisk/issues/2569#issuecomment-320257008 1. It matters if you are considering steady state rather than a burst because it is then not a latency requirement but a bandwidth one. Assuming you want to continuously process 1 million events/second in steady state, then the amount of time the event handler takes times this rate is the computational load the system needs to handle because in a steady state assumption, over any longish window, the drain rate must equal the injection rate. But, if the load is spikey then another way to phrase the question would be at what larger time window can you determine an upper bound on injection rate. If you don't care about latency at all over any time window, then see below. The limit on the number of concurrent invocations is determined by a system setting so it's up to a sysadmin to determine. The queue lives in an internal Kafka. If the invocations are asynchronous and you don't mind a really high latency before service, then one could turn this up. For example, you could set up a system that could actually only handle 100K events/second in terms of actual computation, then a burst of 10 seconds at 1M/second will cause the queue to increase to 10 * 1M - 10 * 100K = 9M which will then take 90 seconds to drain. The gap between 100K and 1M is large and this example is a little extreme but if you actually know that is this burst happens say no more than hourly, then it's fine to choose such a config. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2547: CLI Experimental api removal
mdeuser commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320258364 @drcariel - there were 6 api-experimental tests removed from BasicUsageTests. most of these are applicable to the api command. please port these into the ApiGwTests.scala module, but only if the test is not already in that module. for example, i don't think there's an existing test for "invalid verb" checking. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #2574: CLI should note the requirement of the bluemix CLI
rabbah closed issue #2574: CLI should note the requirement of the bluemix CLI URL: https://github.com/apache/incubator-openwhisk/issues/2574 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2520: Prints bashauto-completion install script to STDOUT
csantanapr commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320277259 I'm OK with having a flag to print to stdout and leaving the current behavior of producing a file. This will allow me to put in my `$HOME/.profile` the following command ``` eval "$(wsk sdk install bashauto --stdout)" ``` This way every time I open a new terminal my autocomplete is up to date, and the script doesn't become stale. Meaning if we add flags or commands which we do very often then I don't have to worry about who a certain command is not working with autocomplete. This is just my use case, other people might have other ways of dealing on keeping the bash script up to date and that's OK also. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131415987 ## File path: docs/cli.md ## @@ -38,6 +38,41 @@ you can run the following command from your `openwhisk` directory: To verify your CLI setup, try [creating and running an action](#openwhisk-hello-world-example). +### Configure command completion for Openwhisk CLI + +For bash command completion to work, bash 4.1 or newer is required. The most recent Linux distributions should have the correct version of bash but Mac users will most likely have an older version. +Mac users can check their bash version and update it by running the following commands: + +``` +bash --version +brew install bash-completion +``` + +To download the bash command completion to your local directory run the following command: + +``` +wsk sdk install bashauto +``` +The command script will now be installed in your current directory. To enable command line completion of wsk commands, source the auto completion script into your bash environment. + +``` +source wsk_cli_bash_completion.sh +``` + +Alternatively, to install bash command completion run the following command: + +``` +eval "`wsk sdk install bashauto --stdout`" +``` + +**Note:** Every time a new terminal is opened this command must run to enable bash command completion. Alternatively, adding the previous command to the `.bashrc` or `.profile` will prevent this. + +For those who wish to do a custom installation, the following commands show how to output the wsk command completion script into a separate shell script file to be run later. You will need to explicitly run the script to install wsk command completion support. +``` Review comment: New line before the three tick marks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI
rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI URL: https://github.com/apache/incubator-openwhisk/issues/2574#issuecomment-320268121 This seems like an issue for the bluemix CLI wrapper and hence I'm inclined to close this issue as invalid for this repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131416139
##
File path: tests/src/test/scala/system/basic/WskSdkTests.scala
##
@@ -108,4 +108,10 @@ class WskSdkTests
}
}
+it should "print bash command completion script to STDOUT" in {
+val msg = "bash completion for wsk"// Subject to change, dependent
on Cobra script
+
+val stdout = wsk.cli(Seq("sdk", "install", "bashauto", "--stdout"),
expectedExitCode = SUCCESS_EXIT).stdout
Review comment:
`SUCCES_EXIT` is the default expected exit code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131415408
##
File path: tools/cli/go-whisk-cli/commands/sdk.go
##
@@ -74,17 +74,27 @@ var sdkInstallCmd = {
case "ios":
err = iOSInstall()
case "bashauto":
-err = WskCmd.GenBashCompletionFile(BASH_AUTOCOMPLETE_FILENAME)
-if (err != nil) {
-whisk.Debug(whisk.DbgError, "GenBashCompletionFile('%s`)
error: \n", BASH_AUTOCOMPLETE_FILENAME, err)
-errStr := wski18n.T("Unable to generate '{{.name}}': {{.err}}",
-map[string]interface{}{"name":
BASH_AUTOCOMPLETE_FILENAME, "err": err})
-werr := whisk.MakeWskError(errors.New(errStr),
whisk.EXITCODE_ERR_GENERAL, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
-return werr
-}
-fmt.Printf(
-wski18n.T("bash_completion_msg",
+if flags.sdk.stdout {
+if err = WskCmd.GenBashCompletion(os.Stdout); err != nil {
Review comment:
Seems like this can be a function that you pass the output stream/file to
instead of duplicating the code twice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131415556
##
File path: tools/cli/go-whisk-cli/commands/sdk.go
##
@@ -74,17 +74,27 @@ var sdkInstallCmd = {
case "ios":
err = iOSInstall()
case "bashauto":
-err = WskCmd.GenBashCompletionFile(BASH_AUTOCOMPLETE_FILENAME)
-if (err != nil) {
-whisk.Debug(whisk.DbgError, "GenBashCompletionFile('%s`)
error: \n", BASH_AUTOCOMPLETE_FILENAME, err)
-errStr := wski18n.T("Unable to generate '{{.name}}': {{.err}}",
-map[string]interface{}{"name":
BASH_AUTOCOMPLETE_FILENAME, "err": err})
-werr := whisk.MakeWskError(errors.New(errStr),
whisk.EXITCODE_ERR_GENERAL, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
-return werr
-}
-fmt.Printf(
-wski18n.T("bash_completion_msg",
+if flags.sdk.stdout {
+if err = WskCmd.GenBashCompletion(os.Stdout); err != nil {
Review comment:
Wouldn't worry about having two different error output messages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131415214
##
File path: tools/cli/go-whisk-cli/commands/flags.go
##
@@ -105,6 +105,10 @@ type Flags struct {
trigger struct {
summary bool
}
+//sdk
Review comment:
Add new line before `//sdk` consistency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131414279
##
File path: tests/src/test/scala/system/basic/WskSdkTests.scala
##
@@ -108,4 +108,10 @@ class WskSdkTests
}
}
+it should "print bash command completion script to STDOUT" in {
+val msg = "bash completion for wsk"// Subject to change, dependent
on Cobra script
+
+val stdout = wsk.cli(Seq("sdk", "install", "bashauto", "--stdout"),
expectedExitCode = SUCCESS_EXIT).stdout
Review comment:
Remove `expectedExitCode = SUCCESS_EXIT`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bjustin-ibm commented on issue #202: Produce action fixes
bjustin-ibm commented on issue #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#issuecomment-320262454 @dnwe I addressed all of your review comments, thanks a bunch! @dubeejw please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ert78gb opened a new pull request #63: style: add .editorconfig and reformat js file
ert78gb opened a new pull request #63: style: add .editorconfig and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63 use 2 space indent in every file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #63: style: add .editorconfig and reformat js file
codecov-io commented on issue #63: style: add .editorconfig and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-320281397 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=h1) Report > Merging [#63](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #63 +/- ## === Coverage 99.37% 99.37% === Files 14 14 Lines 318 318 === Hits 316 316 Misses 22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree) | Coverage ? | | |---|---|---| | [lib/activations.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2FjdGl2YXRpb25zLmpz) | `100% (?)` | :arrow_up: | | [lib/namespaces.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL25hbWVzcGFjZXMuanM=) | `100% (?)` | :arrow_up: | | [lib/base\_operation.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2Jhc2Vfb3BlcmF0aW9uLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/routes.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3JvdXRlcy5qcw==) | `100% <100%> (?)` | :arrow_up: | | [lib/triggers.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3RyaWdnZXJzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/actions.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (?)` | :arrow_up: | | [lib/client.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2NsaWVudC5qcw==) | `98.11% <100%> (?)` | :arrow_up: | | [lib/names.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL25hbWVzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/rules.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL3J1bGVzLmpz) | `100% <100%> (?)` | :arrow_up: | | [lib/feeds.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree#diff-bGliL2ZlZWRzLmpz) | `100% <100%> (?)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=footer). Last update [d4b69d7...a881564](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320262758 Please help me understand the difference between `source wsk_cli_bash_completion.sh` and `pushd $(mktemp -d) > /dev/null && wsk sdk install bashauto > /dev/null && source wsk_cli_bash_completion.sh && popd > /dev/null`. @csantanapr @bpoole16 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bjustin-ibm closed issue #928: Limit amount of HTTP body displayed to stdout when -d option is used
bjustin-ibm closed issue #928: Limit amount of HTTP body displayed to stdout when -d option is used URL: https://github.com/apache/incubator-openwhisk/issues/928 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI
rabbah commented on issue #2574: CLI should note the requirement of the bluemix CLI URL: https://github.com/apache/incubator-openwhisk/issues/2574#issuecomment-320268769 we could use this issue as a way of consolidating thoughts around `wsk login ` support that's being discussed in slack. FYI @tysonnorris This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hsane2001 commented on issue #2221: Unable to create trigger
hsane2001 commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320293907 OK that makes sense, I can try that. However I cant build the api-gateway (an additional component right now) if the http_proxy variable in my native ubuntu ENV is set - know any reason why? I cant find the Docker file for api-gateway since its not part of the "gradle" build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320261046 PG 4 632 passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
