[jira] [Commented] (ORC-368) [C++] Reader must return default version 0.11 instead of error for missing version values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ORC-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491728#comment-16491728
 ] 

ASF GitHub Bot commented on ORC-368:


Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/274
  
+1 LGTM


> [C++] Reader must return default version 0.11 instead of error for missing 
> version values
> -
>
> Key: ORC-368
> URL: https://issues.apache.org/jira/browse/ORC-368
> Project: ORC
>  Issue Type: Task
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>Priority: Major
>
> The Java reader returns the default version as well. The C++ reader must have 
> a similar behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ORC-368) [C++] Reader must return default version 0.11 instead of error for missing version values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ORC-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490877#comment-16490877
 ] 

ASF GitHub Bot commented on ORC-368:


GitHub user czxrrr opened a pull request:

https://github.com/apache/orc/pull/274

ORC-368:[C++] Reader must return default version 0.11 instead of error for 
missing version values



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/czxrrr/orc ORC-368

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #274


commit 914f84b733b0714cc03899aeca3bc58f0a4ca9d9
Author: zherui cao 
Date:   2018-05-25T15:30:22Z

deal with orc file without file format




> [C++] Reader must return default version 0.11 instead of error for missing 
> version values
> -
>
> Key: ORC-368
> URL: https://issues.apache.org/jira/browse/ORC-368
> Project: ORC
>  Issue Type: Task
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>Priority: Major
>
> The Java reader returns the default version as well. The C++ reader must have 
> a similar behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)