[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)
[ https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319820#comment-17319820 ] ASF GitHub Bot commented on PHOENIX-6247: - stoty commented on pull request #1196: URL: https://github.com/apache/phoenix/pull/1196#issuecomment-818383675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 5m 48s | root in master failed. | | +0 | hbaserecompile | 12m 46s | HBase recompiled. | | -1 :x: | compile | 1m 13s | phoenix-core in master failed. | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | -1 :x: | spotbugs | 0m 59s | phoenix-core in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 17s | root in the patch failed. | | +0 | hbaserecompile | 10m 56s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | phoenix-core generated 0 new + 4 unchanged - 46 fixed = 4 total (was 50) | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | | +1 :green_heart: | spotbugs | 3m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 22s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 151m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1196 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 4d2eb9b92100 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 82d346c | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/testReport/ | | Max. process+thread count | 11688 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from > logical name (Phoenix name) >
[GitHub] [phoenix] stoty commented on pull request #1196: PHOENIX-6247 Fix compile errors on master
stoty commented on pull request #1196: URL: https://github.com/apache/phoenix/pull/1196#issuecomment-818383675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 5m 48s | root in master failed. | | +0 | hbaserecompile | 12m 46s | HBase recompiled. | | -1 :x: | compile | 1m 13s | phoenix-core in master failed. | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | -1 :x: | spotbugs | 0m 59s | phoenix-core in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 17s | root in the patch failed. | | +0 | hbaserecompile | 10m 56s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | phoenix-core generated 0 new + 4 unchanged - 46 fixed = 4 total (was 50) | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | | +1 :green_heart: | spotbugs | 3m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 22s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 151m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1196 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 4d2eb9b92100 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 82d346c | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/testReport/ | | Max. process+thread count | 11688 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1196/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1195: PHOENIX-6435 Fix test flapper ImmutableIndexIT, PermissionNSDisabledW…
stoty commented on pull request #1195: URL: https://github.com/apache/phoenix/pull/1195#issuecomment-818338493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 51s | 4.x passed | | +1 :green_heart: | compile | 1m 8s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 27s | 4.x passed | | +1 :green_heart: | javadoc | 0m 51s | 4.x passed | | +0 :ok: | spotbugs | 3m 25s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 50s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 210m 13s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 252m 58s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT | | | phoenix.end2end.BackwardCompatibilityIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1195 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 3a47717d5564 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 33f2463 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/testReport/ | | Max. process+thread count | 5034 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6435) Fix test flapper ImmutableIndexIT, PermissionNSDisabledWithCustomAccessControllerIT and PermissionNSEnabledWithCustomAccessControllerIT
[ https://issues.apache.org/jira/browse/PHOENIX-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319785#comment-17319785 ] ASF GitHub Bot commented on PHOENIX-6435: - stoty commented on pull request #1195: URL: https://github.com/apache/phoenix/pull/1195#issuecomment-818338493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 51s | 4.x passed | | +1 :green_heart: | compile | 1m 8s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 27s | 4.x passed | | +1 :green_heart: | javadoc | 0m 51s | 4.x passed | | +0 :ok: | spotbugs | 3m 25s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 50s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 210m 13s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 252m 58s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT | | | phoenix.end2end.BackwardCompatibilityIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1195 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 3a47717d5564 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 33f2463 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/testReport/ | | Max. process+thread count | 5034 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1195/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix test flapper ImmutableIndexIT, > PermissionNSDisabledWithCustomAccessControllerIT and > PermissionNSEnabledWithCustomAccessControllerIT > > > Key: PHOENIX-6435 > URL: https://issues.apache.org/jira/browse/PHOENIX-6435 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Blocker > Fix For: 4.16.1, 4.17.0, 5.2.0 > > > [ERROR] Errors: > [ERROR] > PermissionNSDisabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1278->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] >
[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)
[ https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319778#comment-17319778 ] ASF GitHub Bot commented on PHOENIX-6247: - gokceni opened a new pull request #1196: URL: https://github.com/apache/phoenix/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from > logical name (Phoenix name) > > > Key: PHOENIX-6247 > URL: https://issues.apache.org/jira/browse/PHOENIX-6247 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Assignee: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6247-4.x-merged.patch, > PHOENIX-6247.master.merged.patch > > > Currently, the tables in Phoenix have the same name as the underlying Hbase > table. Separating logical and physical table name, ie. Having a Phoenix table > point to an Hbase table with a different name have some advantages. > An example is this: Let's say we want to have a different storage/encoding > scheme for an index. We can build the new index while the clients use the old > index and once the index is rebuilt, we can momentarily start pointing to the > new index table without much downtime or performance implications. For the > client, they are using the same index with the same name, but the physical > table is different. Today, in order to change the index like this, we have to > drop it and re-create which is a downtime for the index and the data table > full scans are used for queries impacting performance while the index > creation goes on. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] gokceni opened a new pull request #1196: PHOENIX-6247 Fix compile errors on master
gokceni opened a new pull request #1196: URL: https://github.com/apache/phoenix/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[ https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319765#comment-17319765 ] ASF GitHub Bot commented on PHOENIX-6434: - stoty commented on pull request #1194: URL: https://github.com/apache/phoenix/pull/1194#issuecomment-818289376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 47s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 13s | 4.x passed | | +1 :green_heart: | compile | 1m 34s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 50s | 4.x passed | | +1 :green_heart: | javadoc | 0m 55s | 4.x passed | | +0 :ok: | spotbugs | 3m 51s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 3s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 86 new + 4405 unchanged - 39 fixed = 4491 total (was ) | | -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | -1 :x: | spotbugs | 4m 5s | phoenix-core generated 2 new + 945 unchanged - 0 fixed = 947 total (was 945) | ||| _ Other Tests _ | | -1 :x: | unit | 264m 29s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 314m 29s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Possible null pointer dereference of dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:[line 594] | | | Redundant nullcheck of value which is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:[line 73] | | Failed junit tests | phoenix.tx.ParameterizedTransactionIT | | | phoenix.end2end.CsvBulkLoadToolIT | | | phoenix.util.IndexScrutinyIT | | | phoenix.tx.TransactionIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1194 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 946865c23673 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 33f2463 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/testReport/ | | Max. process+thread count | 4765 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output |
[GitHub] [phoenix] stoty commented on pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
stoty commented on pull request #1194: URL: https://github.com/apache/phoenix/pull/1194#issuecomment-818289376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 47s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 13s | 4.x passed | | +1 :green_heart: | compile | 1m 34s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 50s | 4.x passed | | +1 :green_heart: | javadoc | 0m 55s | 4.x passed | | +0 :ok: | spotbugs | 3m 51s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 3s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 86 new + 4405 unchanged - 39 fixed = 4491 total (was ) | | -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | -1 :x: | spotbugs | 4m 5s | phoenix-core generated 2 new + 945 unchanged - 0 fixed = 947 total (was 945) | ||| _ Other Tests _ | | -1 :x: | unit | 264m 29s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 314m 29s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Possible null pointer dereference of dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:[line 594] | | | Redundant nullcheck of value which is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:[line 73] | | Failed junit tests | phoenix.tx.ParameterizedTransactionIT | | | phoenix.end2end.CsvBulkLoadToolIT | | | phoenix.util.IndexScrutinyIT | | | phoenix.tx.TransactionIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1194 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 946865c23673 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 33f2463 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/testReport/ | | Max. process+thread count | 4765 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the
[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)
[
https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319705#comment-17319705
]
Hadoop QA commented on PHOENIX-6247:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
1s{color} | {color:green} master passed {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
24m 30s{color} | {color:black} HBase recompiled. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
14s{color} | {color:blue} phoenix-core in master has 955 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
7s{color} | {color:red} root in the patch failed. {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
12m 15s{color} | {color:black} HBase recompiled. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
59s{color} | {color:red} phoenix-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 59s{color} |
{color:red} phoenix-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 59s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m
6s{color} | {color:red} phoenix-core: The patch generated 250 new + 13161
unchanged - 98 fixed = 13411 total (was 13259) {color} |
| {color:green}+1{color} | {color:green} prototool {color} | {color:green} 0m
2s{color} | {color:green} There were no new prototool issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 0m
57s{color} | {color:red} phoenix-core in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 58s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/387/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6247 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13023729/PHOENIX-6247.master.merged.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild
hbaseanti checkstyle compile cc prototool |
| uname | Linux dbd7b9db17ef 4.15.0-101-generic #102-Ubuntu SMP Mon May 11
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7419f9d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
[jira] [Commented] (PHOENIX-6435) Fix test flapper ImmutableIndexIT, PermissionNSDisabledWithCustomAccessControllerIT and PermissionNSEnabledWithCustomAccessControllerIT
[ https://issues.apache.org/jira/browse/PHOENIX-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319699#comment-17319699 ] ASF GitHub Bot commented on PHOENIX-6435: - yanxinyi opened a new pull request #1195: URL: https://github.com/apache/phoenix/pull/1195 …ithCustomAccessControllerIT and PermissionNSEnabledWithCustomAccessControllerIT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix test flapper ImmutableIndexIT, > PermissionNSDisabledWithCustomAccessControllerIT and > PermissionNSEnabledWithCustomAccessControllerIT > > > Key: PHOENIX-6435 > URL: https://issues.apache.org/jira/browse/PHOENIX-6435 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Blocker > Fix For: 4.16.1, 4.17.0, 5.2.0 > > > [ERROR] Errors: > [ERROR] > PermissionNSDisabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1278->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] > PermissionNSEnabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1279->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] ImmutableIndexIT.testGlobalImmutableIndexDelete:407 ? StackOverflow > > mvn verify failed with the above error. We have to address and fix test > flappers before releasing the next 4.16.1RC. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] yanxinyi opened a new pull request #1195: PHOENIX-6435 Fix test flapper ImmutableIndexIT, PermissionNSDisabledW…
yanxinyi opened a new pull request #1195: URL: https://github.com/apache/phoenix/pull/1195 …ithCustomAccessControllerIT and PermissionNSEnabledWithCustomAccessControllerIT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[ https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319684#comment-17319684 ] Lars Hofhansl commented on PHOENIX-6434: So before we can use PHOENIX_ROW_TIMESTAMP for timed retrieval it seems we have some bugs to fix (this is with Phoenix 5.1) > Secondary Indexes on PHOENIX_ROW_TIMESTAMP() > > > Key: PHOENIX-6434 > URL: https://issues.apache.org/jira/browse/PHOENIX-6434 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.1.0, 4.16.0 >Reporter: Kadir Ozdemir >Priority: Major > Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch, > PHOENIX-6434.4.x.003.patch > > > PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the > last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a > projection column and referred in a WHERE clause. It is desirable to have > indexes on row timestamps. This will result in fast time range queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319683#comment-17319683
]
Lars Hofhansl commented on PHOENIX-6434:
And even worse (again with or without this):
{code:java}
> create table test2(pk1 integer not null primary key, v1 float, v2 float, v3
> float);
No rows affected (1.418 seconds)
> upsert into test2 values(rand() * 1, rand(), rand(), rand());
1 row affected (0.185 seconds)
> select * from test2 order by phoenix_row_timestamp();
org.apache.hadoop.hbase.DoNotRetryIOException:
org.apache.hadoop.hbase.DoNotRetryIOException:
TEST2,,1618257122882.f93ab0ca1bf32530d879c55908b6326c
.: Qualifier 11 is out of the valid range - (0, 0)
at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:114)
at org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:80)
at
org.apache.phoenix.iterate.RegionScannerFactory$1.nextRaw(RegionScannerFactory.java:271)
at
org.apache.phoenix.iterate.RegionScannerResultIterator.next(RegionScannerResultIterator.java:65)
at
org.apache.phoenix.iterate.OrderedResultIterator.getResultIterator(OrderedResultIterator.java:284)
at
org.apache.phoenix.iterate.OrderedResultIterator.next(OrderedResultIterator.java:260)
at
org.apache.phoenix.iterate.NonAggregateRegionScannerFactory.getTopNScanner(NonAggregateRegionScannerFactory.java:356)
at
org.apache.phoenix.iterate.NonAggregateRegionScannerFactory.getRegionScanner(NonAggregateRegionScannerFactory.java:186)
at
org.apache.phoenix.coprocessor.ScanRegionObserver.doPostScannerOpen(ScanRegionObserver.java:194)
at
org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.overrideDelegate(BaseScannerRegionObserver.java:273)
at
org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.nextRaw(BaseScannerRegionObserver.java:321)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3307)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3557)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45253)
{code}
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319680#comment-17319680
]
Lars Hofhansl commented on PHOENIX-6434:
Tried it and works.
There's a funny thing I noticed (which happens *with or without* this issue):
{code:java}
> create table test2(pk1 integer not null primary key, x.v1float, y.v2 float,
> z.v3 float);
No rows affected (1.418 seconds)
> upsert into test2 values(rand() * 1, rand(), rand(), rand());
1 row affected (0.185 seconds)
> select * from test2 order by
> phoenix_row_timestamp();+--+--++---+
| PK1| V1 | V2 |V3 |
+--+--++---+
| 48717214 | null | 0.54710484 | 0.8657283 |
+--+--++---+
1 row selected (0.06 seconds)
-- Note how v1 is NULL!
> select v1 from test2 order by phoenix_row_timestamp();
+---+
|V1 |
+---+
| 0.3282114 |
+---+
1 row selected (0.023 seconds)
{code}
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6431) Add support for auto assigning pmfs
[ https://issues.apache.org/jira/browse/PHOENIX-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319633#comment-17319633 ] ASF GitHub Bot commented on PHOENIX-6431: - stoty commented on pull request #1193: URL: https://github.com/apache/phoenix/pull/1193#issuecomment-818022063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 56s | master passed | | +0 | hbaserecompile | 22m 31s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 21s | master passed | | +1 :green_heart: | javadoc | 0m 23s | master passed | | +0 :ok: | spotbugs | 0m 55s | phoenix-pherf in master has 51 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 13s | the patch passed | | +0 | hbaserecompile | 16m 43s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | -1 :x: | checkstyle | 0m 19s | phoenix-pherf: The patch generated 26 new + 127 unchanged - 9 fixed = 153 total (was 136) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | | +1 :green_heart: | spotbugs | 1m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 51s | phoenix-pherf in the patch passed. | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 57m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1193 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml | | uname | Linux 306d227d2790 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 7419f9d | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/testReport/ | | Max. process+thread count | 2488 (vs. ulimit of 3) | | modules | C: phoenix-pherf U: phoenix-pherf | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for auto assigning pmfs > --- > > Key: PHOENIX-6431 > URL: https://issues.apache.org/jira/browse/PHOENIX-6431 > Project: Phoenix > Issue Type: Sub-task >Reporter: Jacob Isaac >Priority: Major > > When defining a load profile it may be convenient to not specify the > probability distribution weights at all times -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1193: PHOENIX-6431 Add support for auto assigning pmfs
stoty commented on pull request #1193: URL: https://github.com/apache/phoenix/pull/1193#issuecomment-818022063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 56s | master passed | | +0 | hbaserecompile | 22m 31s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 21s | master passed | | +1 :green_heart: | javadoc | 0m 23s | master passed | | +0 :ok: | spotbugs | 0m 55s | phoenix-pherf in master has 51 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 13s | the patch passed | | +0 | hbaserecompile | 16m 43s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | -1 :x: | checkstyle | 0m 19s | phoenix-pherf: The patch generated 26 new + 127 unchanged - 9 fixed = 153 total (was 136) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | | +1 :green_heart: | spotbugs | 1m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 51s | phoenix-pherf in the patch passed. | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 57m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1193 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml | | uname | Linux 306d227d2790 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 7419f9d | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/testReport/ | | Max. process+thread count | 2488 (vs. ulimit of 3) | | modules | C: phoenix-pherf U: phoenix-pherf | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1193/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1190: PHOENIX-6431 Add support for auto assigning pmfs
stoty commented on pull request #1190: URL: https://github.com/apache/phoenix/pull/1190#issuecomment-818007015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 9s | 4.x passed | | +1 :green_heart: | compile | 0m 37s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 13s | 4.x passed | | +1 :green_heart: | javadoc | 0m 17s | 4.x passed | | +0 :ok: | spotbugs | 0m 59s | phoenix-pherf in 4.x has 51 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 47s | the patch passed | | +1 :green_heart: | compile | 0m 37s | the patch passed | | +1 :green_heart: | javac | 0m 37s | the patch passed | | -1 :x: | checkstyle | 0m 13s | phoenix-pherf: The patch generated 26 new + 128 unchanged - 9 fixed = 154 total (was 137) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | | +1 :green_heart: | spotbugs | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 24s | phoenix-pherf in the patch passed. | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 38m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1190 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml | | uname | Linux 8a53fc36e85c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / d962363 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/testReport/ | | Max. process+thread count | 2159 (vs. ulimit of 3) | | modules | C: phoenix-pherf U: phoenix-pherf | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6431) Add support for auto assigning pmfs
[ https://issues.apache.org/jira/browse/PHOENIX-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319628#comment-17319628 ] ASF GitHub Bot commented on PHOENIX-6431: - stoty commented on pull request #1190: URL: https://github.com/apache/phoenix/pull/1190#issuecomment-818007015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 9s | 4.x passed | | +1 :green_heart: | compile | 0m 37s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 13s | 4.x passed | | +1 :green_heart: | javadoc | 0m 17s | 4.x passed | | +0 :ok: | spotbugs | 0m 59s | phoenix-pherf in 4.x has 51 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 47s | the patch passed | | +1 :green_heart: | compile | 0m 37s | the patch passed | | +1 :green_heart: | javac | 0m 37s | the patch passed | | -1 :x: | checkstyle | 0m 13s | phoenix-pherf: The patch generated 26 new + 128 unchanged - 9 fixed = 154 total (was 137) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | | +1 :green_heart: | spotbugs | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 24s | phoenix-pherf in the patch passed. | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 38m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1190 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml | | uname | Linux 8a53fc36e85c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / d962363 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/testReport/ | | Max. process+thread count | 2159 (vs. ulimit of 3) | | modules | C: phoenix-pherf U: phoenix-pherf | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1190/4/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for auto assigning pmfs > --- > > Key: PHOENIX-6431 > URL: https://issues.apache.org/jira/browse/PHOENIX-6431 > Project: Phoenix > Issue Type: Sub-task >Reporter: Jacob Isaac >Priority: Major > > When defining a load profile it may be convenient to not specify the > probability distribution weights at all times -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[ https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319611#comment-17319611 ] ASF GitHub Bot commented on PHOENIX-6434: - kadirozde opened a new pull request #1194: URL: https://github.com/apache/phoenix/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Secondary Indexes on PHOENIX_ROW_TIMESTAMP() > > > Key: PHOENIX-6434 > URL: https://issues.apache.org/jira/browse/PHOENIX-6434 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.1.0, 4.16.0 >Reporter: Kadir Ozdemir >Priority: Major > Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch, > PHOENIX-6434.4.x.003.patch > > > PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the > last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a > projection column and referred in a WHERE clause. It is desirable to have > indexes on row timestamps. This will result in fast time range queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] kadirozde opened a new pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
kadirozde opened a new pull request #1194: URL: https://github.com/apache/phoenix/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6431) Add support for auto assigning pmfs
[ https://issues.apache.org/jira/browse/PHOENIX-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319592#comment-17319592 ] ASF GitHub Bot commented on PHOENIX-6431: - jpisaac opened a new pull request #1193: URL: https://github.com/apache/phoenix/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for auto assigning pmfs > --- > > Key: PHOENIX-6431 > URL: https://issues.apache.org/jira/browse/PHOENIX-6431 > Project: Phoenix > Issue Type: Sub-task >Reporter: Jacob Isaac >Priority: Major > > When defining a load profile it may be convenient to not specify the > probability distribution weights at all times -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] jpisaac commented on pull request #1193: PHOENIX-6431 Add support for auto assigning pmfs
jpisaac commented on pull request #1193: URL: https://github.com/apache/phoenix/pull/1193#issuecomment-817983796 @yanxinyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6431) Add support for auto assigning pmfs
[ https://issues.apache.org/jira/browse/PHOENIX-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319593#comment-17319593 ] ASF GitHub Bot commented on PHOENIX-6431: - jpisaac commented on pull request #1193: URL: https://github.com/apache/phoenix/pull/1193#issuecomment-817983796 @yanxinyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for auto assigning pmfs > --- > > Key: PHOENIX-6431 > URL: https://issues.apache.org/jira/browse/PHOENIX-6431 > Project: Phoenix > Issue Type: Sub-task >Reporter: Jacob Isaac >Priority: Major > > When defining a load profile it may be convenient to not specify the > probability distribution weights at all times -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] jpisaac opened a new pull request #1193: PHOENIX-6431 Add support for auto assigning pmfs
jpisaac opened a new pull request #1193: URL: https://github.com/apache/phoenix/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1160: Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
yanxinyi commented on a change in pull request #1160:
URL: https://github.com/apache/phoenix/pull/1160#discussion_r611805217
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/BasePhoenixMetricsIT.java
##
@@ -102,30 +107,118 @@ void assertReadMetricsForMutatingSql(String tableName,
long tableSaltBuckets,
assertEquals("There should have been read metrics only for one table:
" + tableName, 1, numTables);
}
-void assertMutationMetrics(String tableName, int numRows, Map> mutationMetrics) {
-assertTrue("No mutation metrics present when there should have been",
mutationMetrics.size() > 0);
+static void assertMutationMetrics(String tableName, int numRows, boolean
isUpsert,
+Map> mutationMetrics) {
for (Map.Entry> entry :
mutationMetrics.entrySet()) {
String t = entry.getKey();
-assertEquals("Table name didn't match for mutation metrics",
tableName, t);
+assertEquals("Table names didn't match!", tableName, t);
Map p = entry.getValue();
-assertEquals("There should have been five metrics", 5, p.size());
+assertEquals("There should have been nine metrics", 15, p.size());
Review comment:
There should have been `nine` metrics? Why you are comparing 15 and
p.size here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
