[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325488#comment-17325488 ] ASF GitHub Bot commented on PHOENIX-6449: - stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822991102 The check fails, because PHOENIX-6443 is also needed. We have successful run in #51 , which has both fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #51: PHOENIX-6449 Cannot start minicluster in github CI check for connectors
stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822991102 The check fails, because PHOENIX-6443 is also needed. We have successful run in #51 , which has both fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325487#comment-17325487 ] Istvan Toth commented on PHOENIX-6449: -- Thank you [~larsh], this does the trick. PHOENIX-6443 is also needed for a successful run, as the snapshot phoenix artifacts used by HEAD are no longer available. > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-6089) Additional relocations for the 5.1.0 client
[ https://issues.apache.org/jira/browse/PHOENIX-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325463#comment-17325463 ] Istvan Toth edited comment on PHOENIX-6089 at 4/20/21, 4:24 AM: I think that this is solved by PHOENIX-6151 and can be closed, [~larsh] was (Author: stoty): I think that this is solved by PHOENIX-6151 and can be closed, @larsh > Additional relocations for the 5.1.0 client > --- > > Key: PHOENIX-6089 > URL: https://issues.apache.org/jira/browse/PHOENIX-6089 > Project: Phoenix > Issue Type: Bug >Reporter: Lars Hofhansl >Priority: Major > Fix For: 5.1.1 > > Attachments: 6089-master.txt, 6089.txt > > > I just update the Phoenix connector in Presto locally to work with Phoenix > 5.1.x. > Among other things I relocate a bunch of more classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6089) Additional relocations for the 5.1.0 client
[ https://issues.apache.org/jira/browse/PHOENIX-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325463#comment-17325463 ] Istvan Toth commented on PHOENIX-6089: -- I think that this is solved by PHOENIX-6151 and can be closed, @larsh > Additional relocations for the 5.1.0 client > --- > > Key: PHOENIX-6089 > URL: https://issues.apache.org/jira/browse/PHOENIX-6089 > Project: Phoenix > Issue Type: Bug >Reporter: Lars Hofhansl >Priority: Major > Fix For: 5.1.1 > > Attachments: 6089-master.txt, 6089.txt > > > I just update the Phoenix connector in Presto locally to work with Phoenix > 5.1.x. > Among other things I relocate a bunch of more classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325448#comment-17325448 ] ASF GitHub Bot commented on PHOENIX-6449: - stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822946200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 4 unchanged - 0 fixed = 11 total (was 4) | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 16s | The patch generated 1 ASF License warnings. | | | | 2m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/51 | | Optional Tests | dupname asflicense yamllint | | uname | Linux c12552a11198 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / e6f5512 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/whitespace-eol.txt | | yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/diff-patch-yamllint.txt | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/console | | versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #51: PHOENIX-6449 Cannot start minicluster in github CI check for connectors
stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822946200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 4 unchanged - 0 fixed = 11 total (was 4) | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 16s | The patch generated 1 ASF License warnings. | | | | 2m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/51 | | Optional Tests | dupname asflicense yamllint | | uname | Linux c12552a11198 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / e6f5512 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/whitespace-eol.txt | | yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/diff-patch-yamllint.txt | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/2/console | | versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325445#comment-17325445 ] ASF GitHub Bot commented on PHOENIX-6449: - stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822944794 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | yamllint | 0m 1s | There were no new yamllint issues. | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 11s | The patch generated 1 ASF License warnings. | | | | 2m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/51 | | Optional Tests | dupname asflicense yamllint | | uname | Linux 97d1f883df8e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / e6f5512 | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/console | | versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #51: PHOENIX-6449 Cannot start minicluster in github CI check for connectors
stoty commented on pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51#issuecomment-822944794 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | yamllint | 0m 1s | There were no new yamllint issues. | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 11s | The patch generated 1 ASF License warnings. | | | | 2m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/51 | | Optional Tests | dupname asflicense yamllint | | uname | Linux 97d1f883df8e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / e6f5512 | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-51/1/console | | versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325444#comment-17325444 ] ASF GitHub Bot commented on PHOENIX-6449: - stoty opened a new pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty opened a new pull request #51: PHOENIX-6449 Cannot start minicluster in github CI check for connectors
stoty opened a new pull request #51: URL: https://github.com/apache/phoenix-connectors/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325404#comment-17325404
]
ASF GitHub Bot commented on PHOENIX-6434:
-
lhofhansl commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616270883
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java
##
@@ -124,7 +127,7 @@ public boolean isStateless() {
@Override
public Determinism getDeterminism() {
-return Determinism.PER_ROW;
+return Determinism.ALWAYS;
Review comment:
Hmm... Interesting. If you do a transaction (or query) over 1000 rows
you would not expect that PHOENIX_ROW_TIMESTAMP() returning the same one value,
so ALWAYS seems wrong.
Doing a git blame it looks like I, myself, added PER_INVOCATION with
PHOENIX-1516, prior to that there was only ROW, STATEMENT, and ALWAYS.
I agree with you that indexes should be fine with PER_ROW and ALWAYS
determinism.
PER_INVOCATION should be disallowed. Not 100% sure about PER_STATEMENT,
seems that would cause problems. It is possible that some function are
incorrectly labeled, though, we do not seems to follow that logic correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] lhofhansl commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
lhofhansl commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616270883
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java
##
@@ -124,7 +127,7 @@ public boolean isStateless() {
@Override
public Determinism getDeterminism() {
-return Determinism.PER_ROW;
+return Determinism.ALWAYS;
Review comment:
Hmm... Interesting. If you do a transaction (or query) over 1000 rows
you would not expect that PHOENIX_ROW_TIMESTAMP() returning the same one value,
so ALWAYS seems wrong.
Doing a git blame it looks like I, myself, added PER_INVOCATION with
PHOENIX-1516, prior to that there was only ROW, STATEMENT, and ALWAYS.
I agree with you that indexes should be fine with PER_ROW and ALWAYS
determinism.
PER_INVOCATION should be disallowed. Not 100% sure about PER_STATEMENT,
seems that would cause problems. It is possible that some function are
incorrectly labeled, though, we do not seems to follow that logic correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325403#comment-17325403
]
ASF GitHub Bot commented on PHOENIX-6434:
-
lhofhansl commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616266445
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
Yeah... I found in my tests that these fail as well. Maybe comment them
with a jira number... Not important, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] lhofhansl commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
lhofhansl commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616266445
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
Yeah... I found in my tests that these fail as well. Maybe comment them
with a jira number... Not important, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325284#comment-17325284 ] ASF GitHub Bot commented on PHOENIX-6444: - stoty commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822740378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 55s | master passed | | +0 | hbaserecompile | 23m 56s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 59s | the patch passed | | +0 | hbaserecompile | 20m 25s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | -1 :x: | checkstyle | 0m 50s | phoenix-core: The patch generated 2 new + 1118 unchanged - 15 fixed = 1120 total (was 1133) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | spotbugs | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 22s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 174m 25s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.index.IndexMetadataIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1197 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0d935b4aa3a2 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / f4ee13b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/testReport/ | | Max. process+thread count | 11318 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But
[GitHub] [phoenix] stoty commented on pull request #1197: PHOENIX-6444 Extend Cell Tags to Delete object for Indexer coproc
stoty commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822740378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 55s | master passed | | +0 | hbaserecompile | 23m 56s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 59s | the patch passed | | +0 | hbaserecompile | 20m 25s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | -1 :x: | checkstyle | 0m 50s | phoenix-core: The patch generated 2 new + 1118 unchanged - 15 fixed = 1120 total (was 1133) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | spotbugs | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 22s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 174m 25s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.index.IndexMetadataIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1197 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0d935b4aa3a2 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / f4ee13b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/testReport/ | | Max. process+thread count | 11318 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/6/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325276#comment-17325276
]
ASF GitHub Bot commented on PHOENIX-6434:
-
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616124570
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java
##
@@ -124,7 +127,7 @@ public boolean isStateless() {
@Override
public Determinism getDeterminism() {
-return Determinism.PER_ROW;
+return Determinism.ALWAYS;
Review comment:
There is a check in MetaDataClient#createIndex(), which does not allow
non-deterministic expressions in index and considers that anything other than
Determinism.ALWAYS is non-deterministic. This does not seem right. SQL Server
agrees with me "Deterministic functions always return the same result any time
they are called with a specific set of input values and given the same state of
the database. Nondeterministic functions may return different results each time
they are called with a specific set of input values even if the database state
that they access remains the same. For example, the function AVG always returns
the same result given the qualifications stated above, but the GETDATE
function, which returns the current datetime value, always returns a different
result." Maybe I need to change the create index code to allow PER_ROW
determinism too. What do you say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] kadirozde commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616124570
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java
##
@@ -124,7 +127,7 @@ public boolean isStateless() {
@Override
public Determinism getDeterminism() {
-return Determinism.PER_ROW;
+return Determinism.ALWAYS;
Review comment:
There is a check in MetaDataClient#createIndex(), which does not allow
non-deterministic expressions in index and considers that anything other than
Determinism.ALWAYS is non-deterministic. This does not seem right. SQL Server
agrees with me "Deterministic functions always return the same result any time
they are called with a specific set of input values and given the same state of
the database. Nondeterministic functions may return different results each time
they are called with a specific set of input values even if the database state
that they access remains the same. For example, the function AVG always returns
the same result given the qualifications stated above, but the GETDATE
function, which returns the current datetime value, always returns a different
result." Maybe I need to change the create index code to allow PER_ROW
determinism too. What do you say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325271#comment-17325271 ] ASF GitHub Bot commented on PHOENIX-6444: - stoty commented on pull request #1200: URL: https://github.com/apache/phoenix/pull/1200#issuecomment-822722821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 1s | 4.x passed | | +1 :green_heart: | compile | 1m 11s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 49s | 4.x passed | | +1 :green_heart: | javadoc | 0m 52s | 4.x passed | | +0 :ok: | spotbugs | 3m 22s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 39s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | -1 :x: | checkstyle | 0m 56s | phoenix-core: The patch generated 12 new + 1120 unchanged - 14 fixed = 1132 total (was 1134) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | | +1 :green_heart: | spotbugs | 3m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 4s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 182m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1200 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux d2366ea93861 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / b0772eb | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/testReport/ | | Max. process+thread count | 6387 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But we added the logic to create TagRewriteCell and add it to > DeleteMarker only in IndexRegionObserver coproc. I missed adding the same > logic to Indexer coproc. Thank you [~tkhurana] for finding this bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1200: PHOENIX-6444 Add Cell Tags to Delete object for Indexer coproc
stoty commented on pull request #1200: URL: https://github.com/apache/phoenix/pull/1200#issuecomment-822722821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 1s | 4.x passed | | +1 :green_heart: | compile | 1m 11s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 49s | 4.x passed | | +1 :green_heart: | javadoc | 0m 52s | 4.x passed | | +0 :ok: | spotbugs | 3m 22s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 39s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | -1 :x: | checkstyle | 0m 56s | phoenix-core: The patch generated 12 new + 1120 unchanged - 14 fixed = 1132 total (was 1134) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | | +1 :green_heart: | spotbugs | 3m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 4s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 182m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1200 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux d2366ea93861 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / b0772eb | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/testReport/ | | Max. process+thread count | 6387 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325266#comment-17325266
]
ASF GitHub Bot commented on PHOENIX-6434:
-
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616111060
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
I attempted to add a case with /*+ NO_INDEX */ but it failed. it seems
PHOENIX_ROW_TIMESTAMP() does not work with MultiKeyValueComparisonFilter.
Please note this is not related to the no index hint, it is a bug in general
for data table with or without an index. I will file a bug on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] kadirozde commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616111060
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
I attempted to add a case with /*+ NO_INDEX */ but it failed. it seems
PHOENIX_ROW_TIMESTAMP() does not work with MultiKeyValueComparisonFilter.
Please note this is not related to the no index hint, it is a bug in general
for data table with or without an index. I will file a bug on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325265#comment-17325265
]
ASF GitHub Bot commented on PHOENIX-6434:
-
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616111060
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
I attempted to add a case with /*+ NO_INDEX */ but it failed. it seems
the PHOENIX_ROW_TIMESTAMP() does not work with MultiKeyValueComparisonFilter.
Please note this is not a just with the no index hint, it is a bug in general
for data table with or without an index. I will file a bug on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] kadirozde commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616111060
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##
@@ -167,6 +169,129 @@ public void testDelete() throws Exception {
}
}
+@Test
+public void testPhoenixRowTimestamp() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String dataTableName = generateUniqueName();
+String indexTableName = generateUniqueName();
+Timestamp initial = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() - 1);
+conn.createStatement().execute("create table " + dataTableName +
+" (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'ab', 'abc', 'abcd')");
+conn.commit();
+Timestamp before = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis());
+// Sleep 1ms to get a different row timestamps
+Thread.sleep(1);
+conn.createStatement().execute("upsert into " + dataTableName + "
values ('b', 'bc', 'bcd', 'bcde')");
+conn.commit();
+Timestamp after = new
Timestamp(EnvironmentEdgeManager.currentTimeMillis() + 1);
+conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
+dataTableName + " (val1, PHOENIX_ROW_TIMESTAMP()) " +
"include (val2, val3) " + (async ? "ASYNC" : "")+ this.indexDDLOptions);
+if (async) {
+// Run the index MR job to rebuild the index and verify that
index is built correctly
+IndexToolIT.runIndexTool(true, false, null, dataTableName,
+indexTableName, null, 0,
IndexTool.IndexVerifyType.AFTER);
+}
+
+String timeZoneID = Calendar.getInstance().getTimeZone().getID();
+// Write a query to get the val2 = 'bc' with a time range query
+String query = "SELECT val1, val2, PHOENIX_ROW_TIMESTAMP() from "
+ dataTableName + " WHERE val1 = 'bc' AND " +
Review comment:
I attempted to add a case with /*+ NO_INDEX */ but it failed. it seems
the PHOENIX_ROW_TIMESTAMP() does not work with MultiKeyValueComparisonFilter.
Please note this is not a just with the no index hint, it is a bug in general
for data table with or without an index. I will file a bug on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6434) Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
[
https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325259#comment-17325259
]
ASF GitHub Bot commented on PHOENIX-6434:
-
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616098790
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##
@@ -136,6 +136,9 @@ public void testMutableIndexWithUpdates() throws Exception {
if (!mutable) {
return;
}
+if (!localIndex && useSnapshot) {
Review comment:
No, it is not related and I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
>
>
> Key: PHOENIX-6434
> URL: https://issues.apache.org/jira/browse/PHOENIX-6434
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Kadir Ozdemir
>Priority: Major
> Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch,
> PHOENIX-6434.4.x.003.patch, PHOENIX-6434.4.x.004.patch,
> PHOENIX-6434.master.001.patch
>
>
> PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the
> last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a
> projection column and referred in a WHERE clause. It is desirable to have
> indexes on row timestamps. This will result in fast time range queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] kadirozde commented on a change in pull request #1194: PHOENIX-6434 Secondary Indexes on PHOENIX_ROW_TIMESTAMP()
kadirozde commented on a change in pull request #1194:
URL: https://github.com/apache/phoenix/pull/1194#discussion_r616098790
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##
@@ -136,6 +136,9 @@ public void testMutableIndexWithUpdates() throws Exception {
if (!mutable) {
return;
}
+if (!localIndex && useSnapshot) {
Review comment:
No, it is not related and I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325237#comment-17325237 ] ASF GitHub Bot commented on PHOENIX-6444: - shahrs87 commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822678169 @gjacoby126 Could you please review the patch ? All the unit tests are succeeding but unit test phase is failing with the following error. ``` [INFO] --- jacoco-maven-plugin:0.8.5:report (report) @ phoenix-core --- [INFO] Loading execution data file /home/jenkins/jenkins-agent/workspace/enix-PreCommit-GitHub-PR_PR-1197/yetus-general-check/src/phoenix-core/target/jacoco.exec [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 01:55 h [INFO] Finished at: 2021-04-19T16:52:02+00:00 [INFO] Final Memory: 78M/1632M [INFO] [ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.5:report (report) on project phoenix-core: An error has occurred in JaCoCo report generation. Error while creating report: malformed input around byte 2 -> [Help 1] [ERROR] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But we added the logic to create TagRewriteCell and add it to > DeleteMarker only in IndexRegionObserver coproc. I missed adding the same > logic to Indexer coproc. Thank you [~tkhurana] for finding this bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] shahrs87 commented on pull request #1197: PHOENIX-6444 Extend Cell Tags to Delete object for Indexer coproc
shahrs87 commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822678169 @gjacoby126 Could you please review the patch ? All the unit tests are succeeding but unit test phase is failing with the following error. ``` [INFO] --- jacoco-maven-plugin:0.8.5:report (report) @ phoenix-core --- [INFO] Loading execution data file /home/jenkins/jenkins-agent/workspace/enix-PreCommit-GitHub-PR_PR-1197/yetus-general-check/src/phoenix-core/target/jacoco.exec [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 01:55 h [INFO] Finished at: 2021-04-19T16:52:02+00:00 [INFO] Final Memory: 78M/1632M [INFO] [ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.5:report (report) on project phoenix-core: An error has occurred in JaCoCo report generation. Error while creating report: malformed input around byte 2 -> [Help 1] [ERROR] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[ https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325190#comment-17325190 ] Lars Hofhansl commented on PHOENIX-6449: We just ran into something similar with Trino when testing the Phoenix connector, which also has to start a minicluster. This might be helpful: [https://github.com/trinodb/trino/pull/7588] > Cannot start minicluster in github CI check for connectors > -- > > Key: PHOENIX-6449 > URL: https://issues.apache.org/jira/browse/PHOENIX-6449 > Project: Phoenix > Issue Type: Bug > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Priority: Major > > mvn verify cannot start minicluster when run by github actions. > It works locally. > Most likely a problem with name resolution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6448) ConnectionQueryServicesImpl init failure may cause Full GC.
[
https://issues.apache.org/jira/browse/PHOENIX-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325189#comment-17325189
]
Lars Hofhansl commented on PHOENIX-6448:
With [~kadir]'s client paced iteration, do we even still need the
lease-renewal, or can we just get rid of it?
> ConnectionQueryServicesImpl init failure may cause Full GC.
> ---
>
> Key: PHOENIX-6448
> URL: https://issues.apache.org/jira/browse/PHOENIX-6448
> Project: Phoenix
> Issue Type: Bug
>Reporter: Chen Feng
>Priority: Major
>
> in ConnectionQueryServicesImpl.init()
> In some cases(e.g. the user has not permissions to create SYSTEM.CATALOG),
> there's only LOGGER.WARN and return null directly.
> {code:java}
> // Some comments here
> {
> ...
> if (inspectIfAnyExceptionInChain(e, Collections. Exception>> singletonList(AccessDeniedException.class))) {
> // Pass
> LOGGER.warn("Could not check for Phoenix SYSTEM tables," +
> " assuming they exist and are properly configured");
>
> checkClientServerCompatibility(SchemaUtil.getPhysicalName(SYSTEM_CATALOG_NAME_BYTES,
> getProps()).getName());
> success = true;
> }
> ...
> return null;
> }
> ...
> scheduleRenewLeaseTasks();
> {code}
> Therefore, the following scheduleRenewLeaseTasks will be skipped and no
> exception is thrown.
>
> 1. scheduleRenewLeaseTasks not called
> 2. no renew task started
> 3. queries will call PhoenixConection.addIteratorForLeaseRenewal() as usual
> 4. the scannerQueue is unlimited therefore it will always adding new items.
> 5. Full GC.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325185#comment-17325185 ] ASF GitHub Bot commented on PHOENIX-6444: - stoty commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822622629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 17m 29s | master passed | | +0 | hbaserecompile | 25m 32s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 3m 16s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 57s | the patch passed | | +0 | hbaserecompile | 20m 17s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 0m 49s | phoenix-core: The patch generated 5 new + 1118 unchanged - 15 fixed = 1123 total (was 1133) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | spotbugs | 3m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 11s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 175m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1197 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0da2e36e54a6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / f4ee13b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/testReport/ | | Max. process+thread count | 12502 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But we added the logic to create TagRewriteCell and add it to > DeleteMarker only in IndexRegionObserver coproc. I
[GitHub] [phoenix] stoty commented on pull request #1197: PHOENIX-6444 Extend Cell Tags to Delete object for Indexer coproc
stoty commented on pull request #1197: URL: https://github.com/apache/phoenix/pull/1197#issuecomment-822622629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 17m 29s | master passed | | +0 | hbaserecompile | 25m 32s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 3m 16s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 57s | the patch passed | | +0 | hbaserecompile | 20m 17s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 0m 49s | phoenix-core: The patch generated 5 new + 1118 unchanged - 15 fixed = 1123 total (was 1133) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | spotbugs | 3m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 116m 11s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 175m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1197 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0da2e36e54a6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / f4ee13b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/testReport/ | | Max. process+thread count | 12502 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1197/5/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325164#comment-17325164 ] ASF GitHub Bot commented on PHOENIX-6444: - shahrs87 opened a new pull request #1200: URL: https://github.com/apache/phoenix/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But we added the logic to create TagRewriteCell and add it to > DeleteMarker only in IndexRegionObserver coproc. I missed adding the same > logic to Indexer coproc. Thank you [~tkhurana] for finding this bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] shahrs87 opened a new pull request #1200: PHOENIX-6444 Add Cell Tags to Delete object for Indexer coproc
shahrs87 opened a new pull request #1200: URL: https://github.com/apache/phoenix/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)
[ https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325119#comment-17325119 ] ASF GitHub Bot commented on PHOENIX-6247: - gokceni closed pull request #1192: URL: https://github.com/apache/phoenix/pull/1192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from > logical name (Phoenix name) > > > Key: PHOENIX-6247 > URL: https://issues.apache.org/jira/browse/PHOENIX-6247 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Assignee: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6247-4.x-merged.patch, > PHOENIX-6247.master.merged.patch > > > Currently, the tables in Phoenix have the same name as the underlying Hbase > table. Separating logical and physical table name, ie. Having a Phoenix table > point to an Hbase table with a different name have some advantages. > An example is this: Let's say we want to have a different storage/encoding > scheme for an index. We can build the new index while the clients use the old > index and once the index is rebuilt, we can momentarily start pointing to the > new index table without much downtime or performance implications. For the > client, they are using the same index with the same name, but the physical > table is different. Today, in order to change the index like this, we have to > drop it and re-create which is a downtime for the index and the data table > full scans are used for queries impacting performance while the index > creation goes on. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)
[ https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325118#comment-17325118 ] ASF GitHub Bot commented on PHOENIX-6247: - gokceni commented on pull request #1192: URL: https://github.com/apache/phoenix/pull/1192#issuecomment-822557741 @virajjasani I merged all of these on master and 4.x Closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from > logical name (Phoenix name) > > > Key: PHOENIX-6247 > URL: https://issues.apache.org/jira/browse/PHOENIX-6247 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Assignee: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6247-4.x-merged.patch, > PHOENIX-6247.master.merged.patch > > > Currently, the tables in Phoenix have the same name as the underlying Hbase > table. Separating logical and physical table name, ie. Having a Phoenix table > point to an Hbase table with a different name have some advantages. > An example is this: Let's say we want to have a different storage/encoding > scheme for an index. We can build the new index while the clients use the old > index and once the index is rebuilt, we can momentarily start pointing to the > new index table without much downtime or performance implications. For the > client, they are using the same index with the same name, but the physical > table is different. Today, in order to change the index like this, we have to > drop it and re-create which is a downtime for the index and the data table > full scans are used for queries impacting performance while the index > creation goes on. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] gokceni closed pull request #1192: Add more tests for PHOENIX-6247
gokceni closed pull request #1192: URL: https://github.com/apache/phoenix/pull/1192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] gokceni commented on pull request #1192: Add more tests for PHOENIX-6247
gokceni commented on pull request #1192: URL: https://github.com/apache/phoenix/pull/1192#issuecomment-822557741 @virajjasani I merged all of these on master and 4.x Closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6449) Cannot start minicluster in github CI check for connectors
[
https://issues.apache.org/jira/browse/PHOENIX-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325049#comment-17325049
]
Istvan Toth commented on PHOENIX-6449:
--
{noformat}
[INFO] Running org.apache.phoenix.hive.HiveMapReduceIT
Error: Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.011 s
<<< FAILURE! - in org.apache.phoenix.hive.HiveMapReduceIT
Error: org.apache.phoenix.hive.HiveMapReduceIT Time elapsed: 0.009 s <<<
ERROR!
java.lang.RuntimeException: java.io.IOException: Shutting down
at org.apache.phoenix.query.BaseTest.initMiniCluster(BaseTest.java:549)
at org.apache.phoenix.query.BaseTest.setUpTestCluster(BaseTest.java:449)
at
org.apache.phoenix.query.BaseTest.checkClusterInitialized(BaseTest.java:435)
at org.apache.phoenix.query.BaseTest.setUpTestDriver(BaseTest.java:517)
at org.apache.phoenix.query.BaseTest.setUpTestDriver(BaseTest.java:512)
at
org.apache.phoenix.hive.BaseHivePhoenixStoreIT.setup(BaseHivePhoenixStoreIT.java:78)
at
org.apache.phoenix.hive.HiveMapReduceIT.setUpBeforeClass(HiveMapReduceIT.java:31)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.apache.phoenix.SystemExitRule$1.evaluate(SystemExitRule.java:40)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.io.IOException: Shutting down
at
org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:236)
at
org.apache.hadoop.hbase.MiniHBaseCluster.(MiniHBaseCluster.java:98)
at
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1089)
at
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1045)
at
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:917)
at
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:899)
at
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:881)
at org.apache.phoenix.query.BaseTest.initMiniCluster(BaseTest.java:544)
... 40 more
Caused by: java.lang.RuntimeException: Failed construction of Master: class
[jira] [Commented] (PHOENIX-6443) Update Connectors Phoenix dependency to 5.1.1
[ https://issues.apache.org/jira/browse/PHOENIX-6443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325045#comment-17325045 ] ASF GitHub Bot commented on PHOENIX-6443: - stoty commented on pull request #50: URL: https://github.com/apache/phoenix-connectors/pull/50#issuecomment-822478509 The github check job is failing because of some internal name resolving issue. I was able to run the test suite successfully locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Connectors Phoenix dependency to 5.1.1 > - > > Key: PHOENIX-6443 > URL: https://issues.apache.org/jira/browse/PHOENIX-6443 > Project: Phoenix > Issue Type: Task > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Richárd Antal >Assignee: Istvan Toth >Priority: Major > Fix For: connectors-6.0.0 > > > Phoenix-connectors still use phoenix 5.1.0 snapshot, It should be updated to > 5.1.1 (or 5.2.0 snapshot when that is available). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #50: PHOENIX-6443 Update Phoenix dependency to 5.1.1
stoty commented on pull request #50: URL: https://github.com/apache/phoenix-connectors/pull/50#issuecomment-822478509 The github check job is failing because of some internal name resolving issue. I was able to run the test suite successfully locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6448) ConnectionQueryServicesImpl init failure may cause Full GC.
[
https://issues.apache.org/jira/browse/PHOENIX-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324913#comment-17324913
]
Chen Feng commented on PHOENIX-6448:
There're several ways to fix this bug.
Solution A: call scheduleRenewLeaseTasks() before return null.
Solution B: scannerQueue is inited with a capacity.
Solution C: if no renew task is started, no NOT add items into scannerQueue.
I think Solution A is better?
> ConnectionQueryServicesImpl init failure may cause Full GC.
> ---
>
> Key: PHOENIX-6448
> URL: https://issues.apache.org/jira/browse/PHOENIX-6448
> Project: Phoenix
> Issue Type: Bug
>Reporter: Chen Feng
>Priority: Major
>
> in ConnectionQueryServicesImpl.init()
> In some cases(e.g. the user has not permissions to create SYSTEM.CATALOG),
> there's only LOGGER.WARN and return null directly.
> {code:java}
> // Some comments here
> {
> ...
> if (inspectIfAnyExceptionInChain(e, Collections. Exception>> singletonList(AccessDeniedException.class))) {
> // Pass
> LOGGER.warn("Could not check for Phoenix SYSTEM tables," +
> " assuming they exist and are properly configured");
>
> checkClientServerCompatibility(SchemaUtil.getPhysicalName(SYSTEM_CATALOG_NAME_BYTES,
> getProps()).getName());
> success = true;
> }
> ...
> return null;
> }
> ...
> scheduleRenewLeaseTasks();
> {code}
> Therefore, the following scheduleRenewLeaseTasks will be skipped and no
> exception is thrown.
>
> 1. scheduleRenewLeaseTasks not called
> 2. no renew task started
> 3. queries will call PhoenixConection.addIteratorForLeaseRenewal() as usual
> 4. the scannerQueue is unlimited therefore it will always adding new items.
> 5. Full GC.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] virajjasani merged pull request #1199: PHOENIX-6446 : Bump default HBase version on 2.3 profile to 2.3.5
virajjasani merged pull request #1199: URL: https://github.com/apache/phoenix/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6446) Bump default HBase version on 2.3 profile to 2.3.5
[ https://issues.apache.org/jira/browse/PHOENIX-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324894#comment-17324894 ] ASF GitHub Bot commented on PHOENIX-6446: - virajjasani merged pull request #1199: URL: https://github.com/apache/phoenix/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bump default HBase version on 2.3 profile to 2.3.5 > -- > > Key: PHOENIX-6446 > URL: https://issues.apache.org/jira/browse/PHOENIX-6446 > Project: Phoenix > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.2.0, 5.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
