[jira] [Commented] (PHOENIX-5838) Add Histograms for Table level Metrics.
[ https://issues.apache.org/jira/browse/PHOENIX-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344329#comment-17344329 ] ASF GitHub Bot commented on PHOENIX-5838: - vmeka2020 opened a new pull request #1231: URL: https://github.com/apache/phoenix/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Histograms for Table level Metrics. > > > Key: PHOENIX-5838 > URL: https://issues.apache.org/jira/browse/PHOENIX-5838 > Project: Phoenix > Issue Type: Sub-task >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Labels: metric-collector, metrics > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] vmeka2020 opened a new pull request #1231: PHOENIX-5838 Add Histograms for Table level Metrics
vmeka2020 opened a new pull request #1231: URL: https://github.com/apache/phoenix/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6442) Phoenix should depend on the appropriate tephra-hbase-compat-x.y module
[ https://issues.apache.org/jira/browse/PHOENIX-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344315#comment-17344315 ] ASF GitHub Bot commented on PHOENIX-6442: - stoty closed pull request #1209: URL: https://github.com/apache/phoenix/pull/1209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Phoenix should depend on the appropriate tephra-hbase-compat-x.y module > --- > > Key: PHOENIX-6442 > URL: https://issues.apache.org/jira/browse/PHOENIX-6442 > Project: Phoenix > Issue Type: Bug > Components: core, tephra >Affects Versions: 5.1.0, 5.1.1, 4.16.0, 4.16.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.2 > > > For the master branch, we depend on tephra-hbase-compat-2.0 dependency which > doesn't actually work with any of the supported HBase releases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6442) Phoenix should depend on the appropriate tephra-hbase-compat-x.y module
[ https://issues.apache.org/jira/browse/PHOENIX-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344314#comment-17344314 ] ASF GitHub Bot commented on PHOENIX-6442: - stoty closed pull request #1208: URL: https://github.com/apache/phoenix/pull/1208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Phoenix should depend on the appropriate tephra-hbase-compat-x.y module > --- > > Key: PHOENIX-6442 > URL: https://issues.apache.org/jira/browse/PHOENIX-6442 > Project: Phoenix > Issue Type: Bug > Components: core, tephra >Affects Versions: 5.1.0, 5.1.1, 4.16.0, 4.16.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.2 > > > For the master branch, we depend on tephra-hbase-compat-2.0 dependency which > doesn't actually work with any of the supported HBase releases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6470) Bump Tephra to 0.16.1 in 4.x
[ https://issues.apache.org/jira/browse/PHOENIX-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344313#comment-17344313 ] ASF GitHub Bot commented on PHOENIX-6470: - stoty opened a new pull request #1230: URL: https://github.com/apache/phoenix/pull/1230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bump Tephra to 0.16.1 in 4.x > > > Key: PHOENIX-6470 > URL: https://issues.apache.org/jira/browse/PHOENIX-6470 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 4.16.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > In PHOENIX-6442 depends on Tephra 0.16.1 on master, and includes the version > bump. > On 4.x, PHOENIX-6442 works with Tephra 0.16, so I didn't (actually forgot) to > also bump Tephra to 0.16.1. > However, for consistency's sake, we should upgrade to Tephra 0.16.1 in 4.x, > too. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty closed pull request #1209: PHOENIX-6442 Phoenix should depend on the appropriate tephra-hbase-co…
stoty closed pull request #1209: URL: https://github.com/apache/phoenix/pull/1209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1208: PHOENIX-6442 Phoenix should depend on the appropriate tephra-hbase-co…
stoty closed pull request #1208: URL: https://github.com/apache/phoenix/pull/1208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] stoty opened a new pull request #1230: PHOENIX-6470 Bump Tephra to 0.16.1 in 4.x
stoty opened a new pull request #1230: URL: https://github.com/apache/phoenix/pull/1230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344242#comment-17344242 ] Lars Hofhansl commented on PHOENIX-6447: Should this one be in branch-5.1 (i.e. Phoenix 5.1.2)? > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.1, 4.17.0, 5.2.0 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6444) Extend Cell Tags to Delete object for Indexer coproc
[ https://issues.apache.org/jira/browse/PHOENIX-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344244#comment-17344244 ] Lars Hofhansl commented on PHOENIX-6444: What about branch-5.1 (Phoenix 5.1.2)? > Extend Cell Tags to Delete object for Indexer coproc > > > Key: PHOENIX-6444 > URL: https://issues.apache.org/jira/browse/PHOENIX-6444 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 4.17.0, 5.2.0 > > > In PHOENIX-6213 we added support for adding source of operation cell tag to > Delete Markers. But we added the logic to create TagRewriteCell and add it to > DeleteMarker only in IndexRegionObserver coproc. I missed adding the same > logic to Indexer coproc. Thank you [~tkhurana] for finding this bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6454) Add feature to SchemaTool to get the DDL in specification mode
[ https://issues.apache.org/jira/browse/PHOENIX-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344239#comment-17344239 ] Lars Hofhansl commented on PHOENIX-6454: Should this one be in branch-5.1 (i.e. Phoenix 5.1.2) too? > Add feature to SchemaTool to get the DDL in specification mode > -- > > Key: PHOENIX-6454 > URL: https://issues.apache.org/jira/browse/PHOENIX-6454 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Fix For: 4.17.0, 5.2.0 > > > Currently, SchemExtractionTool uses PTable representation to get the > effective DDL on the cluster. > Rename SchemaExtractionTool to SchemaTool, add a feature that accepts create > DDL and alter DDL to give effective DDL without using PTable implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6457) Optionally store schema version string in SYSTEM.CATALOG
[ https://issues.apache.org/jira/browse/PHOENIX-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344237#comment-17344237 ] Lars Hofhansl commented on PHOENIX-6457: I think. Thanks [~gjacoby] > Optionally store schema version string in SYSTEM.CATALOG > > > Key: PHOENIX-6457 > URL: https://issues.apache.org/jira/browse/PHOENIX-6457 > Project: Phoenix > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 4.17.0, 5.2.0 > > > In many environments, schema changes to Phoenix tables are applied in batches > associated with a version of an application. (For example, v1.0 of an app may > start with one set of CREATE statements, v1.1 then adds some ALTER > statements, etc.) > It can be useful to be able to look up the latest app version in which a > table or view was changed; this could potentially be added as a feature of > the Schema Tool. > This change would add an optional property to CREATE and ALTER statements, > SCHEMA_VERSION, which would take a user-supplied string. > This is also a pre-req for PHOENIX-6227, because we would want to pass the > schema version string, if any, to an external schema repository in > environments where we're integrating with one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6442) Phoenix should depend on the appropriate tephra-hbase-compat-x.y module
[ https://issues.apache.org/jira/browse/PHOENIX-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344121#comment-17344121 ] ASF GitHub Bot commented on PHOENIX-6442: - stoty commented on pull request #1209: URL: https://github.com/apache/phoenix/pull/1209#issuecomment-840820331 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 18s | 4.x passed | | +1 :green_heart: | compile | 1m 32s | 4.x passed | | +1 :green_heart: | javadoc | 1m 55s | 4.x passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 43s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 58s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 137m 24s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 43s | The patch does not generate ASF License warnings. | | | | 173m 38s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.UpsertSelectIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1209 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux d75a378a7340 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 67f1f1c | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/testReport/ | | Max. process+thread count | 5923 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Phoenix should depend on the appropriate tephra-hbase-compat-x.y module > --- > > Key: PHOENIX-6442 > URL: https://issues.apache.org/jira/browse/PHOENIX-6442 > Project: Phoenix > Issue Type: Bug > Components: core, tephra >Affects Versions: 5.1.0, 5.1.1, 4.16.0, 4.16.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.2 > > > For the master branch, we depend on tephra-hbase-compat-2.0 dependency which > doesn't actually work with any of the supported HBase releases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1209: PHOENIX-6442 Phoenix should depend on the appropriate tephra-hbase-co…
stoty commented on pull request #1209: URL: https://github.com/apache/phoenix/pull/1209#issuecomment-840820331 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 18s | 4.x passed | | +1 :green_heart: | compile | 1m 32s | 4.x passed | | +1 :green_heart: | javadoc | 1m 55s | 4.x passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 43s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 58s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 137m 24s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 43s | The patch does not generate ASF License warnings. | | | | 173m 38s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.UpsertSelectIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1209 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux d75a378a7340 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 67f1f1c | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/testReport/ | | Max. process+thread count | 5923 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1209/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6442) Phoenix should depend on the appropriate tephra-hbase-compat-x.y module
[ https://issues.apache.org/jira/browse/PHOENIX-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344115#comment-17344115 ] ASF GitHub Bot commented on PHOENIX-6442: - stoty commented on pull request #1208: URL: https://github.com/apache/phoenix/pull/1208#issuecomment-840814626 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 3s | master passed | | +0 | hbaserecompile | 22m 39s | HBase recompiled. | | +1 :green_heart: | compile | 1m 32s | master passed | | +1 :green_heart: | javadoc | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 20s | the patch passed | | +0 | hbaserecompile | 14m 48s | HBase recompiled. | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 14s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 113m 4s | root in the patch failed. | | -1 :x: | asflicense | 1m 46s | The patch generated 613 ASF License warnings. | | | | 163m 34s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1208 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux a86e1813994a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 877457e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 15580 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Phoenix should depend on the appropriate tephra-hbase-compat-x.y module > --- > > Key: PHOENIX-6442 > URL: https://issues.apache.org/jira/browse/PHOENIX-6442 > Project: Phoenix > Issue Type: Bug > Components: core, tephra >Affects Versions: 5.1.0, 5.1.1, 4.16.0, 4.16.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.2 > > > For the master branch, we depend on tephra-hbase-compat-2.0 dependency which > doesn't actually work with any of the supported HBase releases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1208: PHOENIX-6442 Phoenix should depend on the appropriate tephra-hbase-co…
stoty commented on pull request #1208: URL: https://github.com/apache/phoenix/pull/1208#issuecomment-840814626 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 3s | master passed | | +0 | hbaserecompile | 22m 39s | HBase recompiled. | | +1 :green_heart: | compile | 1m 32s | master passed | | +1 :green_heart: | javadoc | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 20s | the patch passed | | +0 | hbaserecompile | 14m 48s | HBase recompiled. | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 14s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 113m 4s | root in the patch failed. | | -1 :x: | asflicense | 1m 46s | The patch generated 613 ASF License warnings. | | | | 163m 34s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1208 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux a86e1813994a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 877457e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 15580 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1208/3/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6454) Add feature to SchemaTool to get the DDL in specification mode
[ https://issues.apache.org/jira/browse/PHOENIX-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344034#comment-17344034 ] ASF GitHub Bot commented on PHOENIX-6454: - stoty commented on pull request #1229: URL: https://github.com/apache/phoenix/pull/1229#issuecomment-840724857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 4m 56s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 12m 44s | master passed | | +0 | hbaserecompile | 24m 40s | HBase recompiled. | | +1 :green_heart: | compile | 1m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 53s | master passed | | +1 :green_heart: | javadoc | 1m 13s | master passed | | +0 :ok: | spotbugs | 3m 25s | phoenix-core in master has 960 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in master has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 32s | root in the patch failed. | | +0 | hbaserecompile | 10m 18s | HBase recompiled. | | -1 :x: | compile | 0m 22s | phoenix-core in the patch failed. | | -1 :x: | compile | 0m 31s | phoenix-tools in the patch failed. | | -1 :x: | javac | 0m 22s | phoenix-core in the patch failed. | | -1 :x: | javac | 0m 31s | phoenix-tools in the patch failed. | | -1 :x: | checkstyle | 0m 55s | phoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211) | | -1 :x: | checkstyle | 0m 24s | phoenix-tools: The patch generated 157 new + 249 unchanged - 13 fixed = 406 total (was 262) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 27s | the patch passed | | -1 :x: | spotbugs | 0m 20s | phoenix-core in the patch failed. | | -1 :x: | spotbugs | 0m 33s | phoenix-tools in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 21s | phoenix-core in the patch failed. | | -1 :x: | unit | 0m 34s | phoenix-tools in the patch failed. | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 55m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1229 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux d216818e5e73 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / df32aec | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle |
[GitHub] [phoenix] stoty commented on pull request #1229: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…
stoty commented on pull request #1229: URL: https://github.com/apache/phoenix/pull/1229#issuecomment-840724857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 4m 56s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 12m 44s | master passed | | +0 | hbaserecompile | 24m 40s | HBase recompiled. | | +1 :green_heart: | compile | 1m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 53s | master passed | | +1 :green_heart: | javadoc | 1m 13s | master passed | | +0 :ok: | spotbugs | 3m 25s | phoenix-core in master has 960 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in master has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 32s | root in the patch failed. | | +0 | hbaserecompile | 10m 18s | HBase recompiled. | | -1 :x: | compile | 0m 22s | phoenix-core in the patch failed. | | -1 :x: | compile | 0m 31s | phoenix-tools in the patch failed. | | -1 :x: | javac | 0m 22s | phoenix-core in the patch failed. | | -1 :x: | javac | 0m 31s | phoenix-tools in the patch failed. | | -1 :x: | checkstyle | 0m 55s | phoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211) | | -1 :x: | checkstyle | 0m 24s | phoenix-tools: The patch generated 157 new + 249 unchanged - 13 fixed = 406 total (was 262) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 27s | the patch passed | | -1 :x: | spotbugs | 0m 20s | phoenix-core in the patch failed. | | -1 :x: | spotbugs | 0m 33s | phoenix-tools in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 21s | phoenix-core in the patch failed. | | -1 :x: | unit | 0m 34s | phoenix-tools in the patch failed. | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 55m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1229 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux d216818e5e73 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / df32aec | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | spotbugs |
[jira] [Commented] (PHOENIX-6442) Phoenix should depend on the appropriate tephra-hbase-compat-x.y module
[ https://issues.apache.org/jira/browse/PHOENIX-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344031#comment-17344031 ] Istvan Toth commented on PHOENIX-6442: -- Rebasing now that we have Tephra 0.16.1 > Phoenix should depend on the appropriate tephra-hbase-compat-x.y module > --- > > Key: PHOENIX-6442 > URL: https://issues.apache.org/jira/browse/PHOENIX-6442 > Project: Phoenix > Issue Type: Bug > Components: core, tephra >Affects Versions: 5.1.0, 5.1.1, 4.16.0, 4.16.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.2 > > > For the master branch, we depend on tephra-hbase-compat-2.0 dependency which > doesn't actually work with any of the supported HBase releases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6397) Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
[ https://issues.apache.org/jira/browse/PHOENIX-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344011#comment-17344011 ] ASF GitHub Bot commented on PHOENIX-6397: - yanxinyi merged pull request #1224: URL: https://github.com/apache/phoenix/pull/1224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement TableMetricsManager class and its associated functions for select. > upsert and Delete Queries > -- > > Key: PHOENIX-6397 > URL: https://issues.apache.org/jira/browse/PHOENIX-6397 > Project: Phoenix > Issue Type: Sub-task >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6397) Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
[ https://issues.apache.org/jira/browse/PHOENIX-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344010#comment-17344010 ] ASF GitHub Bot commented on PHOENIX-6397: - yanxinyi merged pull request #1223: URL: https://github.com/apache/phoenix/pull/1223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement TableMetricsManager class and its associated functions for select. > upsert and Delete Queries > -- > > Key: PHOENIX-6397 > URL: https://issues.apache.org/jira/browse/PHOENIX-6397 > Project: Phoenix > Issue Type: Sub-task >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] yanxinyi merged pull request #1224: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
yanxinyi merged pull request #1224: URL: https://github.com/apache/phoenix/pull/1224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] yanxinyi merged pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
yanxinyi merged pull request #1223: URL: https://github.com/apache/phoenix/pull/1223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6453) Possible ArrayIndexOutOfBoundsException while preparing scan start key with multiple key range queries
[
https://issues.apache.org/jira/browse/PHOENIX-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343849#comment-17343849
]
ASF GitHub Bot commented on PHOENIX-6453:
-
stoty commented on a change in pull request #1220:
URL: https://github.com/apache/phoenix/pull/1220#discussion_r631781475
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##
@@ -363,10 +363,12 @@ public static void setTimeRange(Scan scan, long minStamp,
long maxStamp) {
}
int[] position = new int[slots.size()];
int maxLength = 0;
+int slotEndingFieldPos = 0;
for (int i = 0; i < position.length; i++) {
position[i] = bound == Bound.LOWER ? 0 : slots.get(i).size()-1;
KeyRange range = slots.get(i).get(position[i]);
-Field field = schema.getField(i + slotSpan[i]);
+slotEndingFieldPos = slotEndingFieldPos + slotSpan[i] + (i>0? 1:
0);
Review comment:
nit:
This is quite confusing : `+ (i>0? 1: 0);` .
Can we increment slotEndingFieldPos at the end of the for cycle body instead?
Or just initialize slotEndingFieldPos to -1 , and increment it here
unconditionally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Possible ArrayIndexOutOfBoundsException while preparing scan start key with
> multiple key range queries
> --
>
> Key: PHOENIX-6453
> URL: https://issues.apache.org/jira/browse/PHOENIX-6453
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Blocker
> Fix For: 4.17.0, 5.1.2
>
>
> There is possible AIOOE when there are multiple key range conditions on
> columns in a query.
> {noformat}
> java.lang.ArrayIndexOutOfBoundsException: 25
> at org.apache.phoenix.util.ScanUtil.setKey(ScanUtil.java:474)
> at org.apache.phoenix.util.ScanUtil.setKey(ScanUtil.java:408)
> at org.apache.phoenix.util.ScanUtil.getKey(ScanUtil.java:380)
> at org.apache.phoenix.util.ScanUtil.getMinKey(ScanUtil.java:353)
> at org.apache.phoenix.compile.ScanRanges.create(ScanRanges.java:134)
> at
> org.apache.phoenix.compile.WhereOptimizer.pushKeyExpressionsToScan(WhereOptimizer.java:355)
> at
> org.apache.phoenix.compile.WhereCompiler.compile(WhereCompiler.java:171)
> at
> org.apache.phoenix.compile.WhereCompiler.compile(WhereCompiler.java:118)
> at
> org.apache.phoenix.compile.QueryCompiler.compileSingleFlatQuery(QueryCompiler.java:747)
> at
> org.apache.phoenix.compile.QueryCompiler.compileSingleQuery(QueryCompiler.java:674)
> at
> org.apache.phoenix.compile.QueryCompiler.compileSelect(QueryCompiler.java:251)
> at
> org.apache.phoenix.compile.QueryCompiler.compile(QueryCompiler.java:178)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:501)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:464)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:306)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:295)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeQuery(PhoenixStatement.java:294)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeQuery(PhoenixStatement.java:287)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1930)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] stoty commented on a change in pull request #1220: PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing …
stoty commented on a change in pull request #1220:
URL: https://github.com/apache/phoenix/pull/1220#discussion_r631781475
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##
@@ -363,10 +363,12 @@ public static void setTimeRange(Scan scan, long minStamp,
long maxStamp) {
}
int[] position = new int[slots.size()];
int maxLength = 0;
+int slotEndingFieldPos = 0;
for (int i = 0; i < position.length; i++) {
position[i] = bound == Bound.LOWER ? 0 : slots.get(i).size()-1;
KeyRange range = slots.get(i).get(position[i]);
-Field field = schema.getField(i + slotSpan[i]);
+slotEndingFieldPos = slotEndingFieldPos + slotSpan[i] + (i>0? 1:
0);
Review comment:
nit:
This is quite confusing : `+ (i>0? 1: 0);` .
Can we increment slotEndingFieldPos at the end of the for cycle body instead?
Or just initialize slotEndingFieldPos to -1 , and increment it here
unconditionally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-6397) Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
[ https://issues.apache.org/jira/browse/PHOENIX-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343773#comment-17343773 ] ASF GitHub Bot commented on PHOENIX-6397: - stoty commented on pull request #1223: URL: https://github.com/apache/phoenix/pull/1223#issuecomment-840402468 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 12s | 4.x passed | | +1 :green_heart: | compile | 1m 0s | 4.x passed | | +1 :green_heart: | checkstyle | 3m 2s | 4.x passed | | +1 :green_heart: | javadoc | 0m 49s | 4.x passed | | +0 :ok: | spotbugs | 3m 5s | phoenix-core in 4.x has 946 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 39s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | | -1 :x: | spotbugs | 3m 16s | phoenix-core generated 5 new + 946 unchanged - 0 fixed = 951 total (was 946) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 203m 5s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 241m 5s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1223 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux aef3e5dd294e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 5159f6e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
stoty commented on pull request #1223: URL: https://github.com/apache/phoenix/pull/1223#issuecomment-840402468 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 12s | 4.x passed | | +1 :green_heart: | compile | 1m 0s | 4.x passed | | +1 :green_heart: | checkstyle | 3m 2s | 4.x passed | | +1 :green_heart: | javadoc | 0m 49s | 4.x passed | | +0 :ok: | spotbugs | 3m 5s | phoenix-core in 4.x has 946 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 39s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | | -1 :x: | spotbugs | 3m 16s | phoenix-core generated 5 new + 946 unchanged - 0 fixed = 951 total (was 946) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 203m 5s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 241m 5s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] | | | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1223 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux aef3e5dd294e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 5159f6e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | Test Results |
[jira] [Commented] (PHOENIX-6466) Update Tephra site https://phoenix.apache.org/tephra
[ https://issues.apache.org/jira/browse/PHOENIX-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343735#comment-17343735 ] Istvan Toth commented on PHOENIX-6466: -- See https://lists.apache.org/thread.html/ra753f74c19f2d544cf9ba0a48dbd0142d363ad25cf04275020211792%40%3Cdev.phoenix.apache.org%3E for some useful information > Update Tephra site https://phoenix.apache.org/tephra > > > Key: PHOENIX-6466 > URL: https://issues.apache.org/jira/browse/PHOENIX-6466 > Project: Phoenix > Issue Type: Task >Reporter: Viraj Jasani >Priority: Major > > We should update Tephra site [https://phoenix.apache.org/tephra] and retire > [https://tephra.incubator.apache.org/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
