[jira] [Commented] (PHOENIX-6476) Index tool when verifying from index to data doesn't correctly split page into tasks
[ https://issues.apache.org/jira/browse/PHOENIX-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352285#comment-17352285 ] ASF GitHub Bot commented on PHOENIX-6476: - stoty commented on pull request #1240: URL: https://github.com/apache/phoenix/pull/1240#issuecomment-849323255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 14s | 4.x passed | | +1 :green_heart: | compile | 1m 5s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 30s | 4.x passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x passed | | +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 951 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 44s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 0m 30s | phoenix-core: The patch generated 11 new + 123 unchanged - 1 fixed = 134 total (was 124) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 200m 53s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 236m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1240 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 31b2d5fcc797 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 69a9ec3 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/testReport/ | | Max. process+thread count | 5056 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Index tool when verifying from index to data doesn't correctly split page > into tasks > > > Key: PHOENIX-6476 > URL: https://issues.apache.org/jira/browse/PHOENIX-6476 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.14.3, 4.16.0, 4.16.1 >Reporter: Tanuj Khurana >Assignee: Tanuj Khurana >Priority: Major > > When running index tool with index table as source, it splits a page into > tasks when the page size is greater than the configured task size (default > 2048) and runs each task in parallel. Each task is assigned a set of data row > keys but the index mutation map is not split according to the data row keys > assigned to a particular task. As a result, the tool reports wrong results > because the index mutation map is per page but the set of
[GitHub] [phoenix] stoty commented on pull request #1240: PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks
stoty commented on pull request #1240: URL: https://github.com/apache/phoenix/pull/1240#issuecomment-849323255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 14s | 4.x passed | | +1 :green_heart: | compile | 1m 5s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 30s | 4.x passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x passed | | +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 951 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 44s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 0m 30s | phoenix-core: The patch generated 11 new + 123 unchanged - 1 fixed = 134 total (was 124) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 200m 53s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 236m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1240 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 31b2d5fcc797 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 69a9ec3 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/testReport/ | | Max. process+thread count | 5056 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1240/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352269#comment-17352269
]
Istvan Toth commented on PHOENIX-6475:
--
Thank you for your offer of setting up ARM tests.
Please make the offer on the phoenix-dev list, so that the community can
discuss.
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352269#comment-17352269
]
Istvan Toth edited comment on PHOENIX-6475 at 5/27/21, 4:11 AM:
Thank you for your offer of setting up ARM tests, [~mgrigorov].
Please make the offer on the phoenix-dev list, so that the community can
discuss.
was (Author: stoty):
Thank you for your offer of setting up ARM tests.
Please make the offer on the phoenix-dev list, so that the community can
discuss.
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352267#comment-17352267
]
Istvan Toth commented on PHOENIX-6475:
--
Committed to master and 4.x
Thank you [~mgrigorov]
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352266#comment-17352266
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty closed pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] stoty closed pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
stoty closed pull request #1238: URL: https://github.com/apache/phoenix/pull/1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6476) Index tool when verifying from index to data doesn't correctly split page into tasks
[ https://issues.apache.org/jira/browse/PHOENIX-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352221#comment-17352221 ] ASF GitHub Bot commented on PHOENIX-6476: - tkhurana edited a comment on pull request #1240: URL: https://github.com/apache/phoenix/pull/1240#issuecomment-848384888 @kadirozde @gokceni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Index tool when verifying from index to data doesn't correctly split page > into tasks > > > Key: PHOENIX-6476 > URL: https://issues.apache.org/jira/browse/PHOENIX-6476 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.14.3, 4.16.0, 4.16.1 >Reporter: Tanuj Khurana >Assignee: Tanuj Khurana >Priority: Major > > When running index tool with index table as source, it splits a page into > tasks when the page size is greater than the configured task size (default > 2048) and runs each task in parallel. Each task is assigned a set of data row > keys but the index mutation map is not split according to the data row keys > assigned to a particular task. As a result, the tool reports wrong results > because the index mutation map is per page but the set of data row keys is > per task. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] tkhurana edited a comment on pull request #1240: PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks
tkhurana edited a comment on pull request #1240: URL: https://github.com/apache/phoenix/pull/1240#issuecomment-848384888 @kadirozde @gokceni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352203#comment-17352203 ] Daniel Wong commented on PHOENIX-5812: -- Coming back to this a bit wondering if we want 1 or 2 Jira for phoenix connection level reaping vs hconnection level reaping? [~elserj] [~jisaac] > Automatically Close "Idle" Long Open Connections > > > Key: PHOENIX-5812 > URL: https://issues.apache.org/jira/browse/PHOENIX-5812 > Project: Phoenix > Issue Type: Improvement >Reporter: Daniel Wong >Priority: Major > Labels: quality-improvement > > As Phoenix may keep a maximum default number of connections. Badly > performing client calls or internal errors (See PHOENIX-5802). Can cause > total available connections to go to 0. Proposing a client connection > monitor with a connection reaper like task to reap idle connections. > Definition of "Idle" > Simple may be simple time based say if a connection has been open for > configurable amount of minutes simply close. > More complicated solution may be keeping track of last interaction time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352095#comment-17352095 ] Sandeep Pal commented on PHOENIX-6447: -- [~larsh] Thank you very much, I got side tracked from this :) > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352011#comment-17352011
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-849019261
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 7m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 1s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 11s | master passed |
| +0 | hbaserecompile | 25m 20s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 44s | master passed |
| +1 :green_heart: | javadoc | 2m 31s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 10m 16s | the patch passed |
| +0 | hbaserecompile | 17m 45s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 37s | the patch passed |
| +1 :green_heart: | javac | 1m 37s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 44s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 137m 16s | root in the patch failed. |
| -1 :x: | asflicense | 1m 40s | The patch generated 614 ASF License
warnings. |
| | | 201m 1s | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | phoenix.end2end.BackwardCompatibilityIT |
| | phoenix.end2end.AuditLoggingIT |
| | phoenix.end2end.UpsertSelectIT |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1238 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 36b2dbc588e9 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 3231aad |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 7635 (vs. ulimit of 3) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1)
[GitHub] [phoenix] stoty commented on pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
stoty commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-849019261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 1s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 13m 11s | master passed | | +0 | hbaserecompile | 25m 20s | HBase recompiled. | | +1 :green_heart: | compile | 1m 44s | master passed | | +1 :green_heart: | javadoc | 2m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 10m 16s | the patch passed | | +0 | hbaserecompile | 17m 45s | HBase recompiled. | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 44s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 137m 16s | root in the patch failed. | | -1 :x: | asflicense | 1m 40s | The patch generated 614 ASF License warnings. | | | | 201m 1s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.BackwardCompatibilityIT | | | phoenix.end2end.AuditLoggingIT | | | phoenix.end2end.UpsertSelectIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1238 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 36b2dbc588e9 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 3231aad | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 7635 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/3/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5639) Exception during DROP TABLE CASCADE with VIEW and INDEX in phoenix_sandbox
[
https://issues.apache.org/jira/browse/PHOENIX-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352006#comment-17352006
]
Lars Hofhansl commented on PHOENIX-5639:
Removing release targets of a 18 months old issue.
> Exception during DROP TABLE CASCADE with VIEW and INDEX in phoenix_sandbox
> --
>
> Key: PHOENIX-5639
> URL: https://issues.apache.org/jira/browse/PHOENIX-5639
> Project: Phoenix
> Issue Type: Bug
>Reporter: Lars Hofhansl
>Priority: Trivial
>
> {code:java}
> > CREATE TABLE TEST_5 (ID INTEGER NOT NULL PRIMARY KEY, HOST VARCHAR(10),
> > FLAG BOOLEAN);
> > CREATE VIEW TEST_5_VIEW (col1 INTEGER, col2 INTEGER, col3 INTEGER, col4
> > INTEGER, col5 INTEGER) AS SELECT * FROM TEST_5 WHERE ID>10;
> > CREATE INDEX TEST_5_INDEX ON TEST_5_VIEW(COL4);
> > DROP TABLE test_5 CASCASE;{code}
> Table, view, and index are dropped, but in the sandbox' log I see:
> {code:java}
> 19/12/18 07:17:41 WARN iterate.BaseResultIterators: Unable to find parent
> table "TEST_5_VIEW" of table "TEST_5_INDEX" to determine
> USE_STATS_FOR_PARALLELIZATION
> org.apache.phoenix.schema.TableNotFoundException: ERROR 1012 (42M03): Table
> undefined. tableName=TEST_5_VIEW
> at
> org.apache.phoenix.schema.PMetaDataImpl.getTableRef(PMetaDataImpl.java:73)
> at
> org.apache.phoenix.jdbc.PhoenixConnection.getTable(PhoenixConnection.java:584)
> at
> org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getStatsForParallelizationProp(PhoenixConfigurationUtil.java:712)
> at
> org.apache.phoenix.iterate.BaseResultIterators.(BaseResultIterators.java:513)
> at
> org.apache.phoenix.iterate.ParallelIterators.(ParallelIterators.java:62)
> at
> org.apache.phoenix.iterate.ParallelIterators.(ParallelIterators.java:69)
> at
> org.apache.phoenix.execute.AggregatePlan.newIterator(AggregatePlan.java:287)
> at
> org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:365)
> at
> org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:217)
> at
> org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:212)
> at
> org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:207)
> at
> org.apache.phoenix.compile.PostDDLCompiler$PostDDLMutationPlan.execute(PostDDLCompiler.java:273)
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.updateData(ConnectionQueryServicesImpl.java:4426)
> at
> org.apache.phoenix.query.DelegateConnectionQueryServices.updateData(DelegateConnectionQueryServices.java:166)
> at
> org.apache.phoenix.schema.MetaDataClient.dropTable(MetaDataClient.java:3238)
> at
> org.apache.phoenix.schema.MetaDataClient.dropTable(MetaDataClient.java:3055)
> at org.apache.phoenix.util.ViewUtil.dropChildViews(ViewUtil.java:218)
> at
> org.apache.phoenix.coprocessor.tasks.DropChildViewsTask.run(DropChildViewsTask.java:63)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.phoenix.coprocessor.TaskRegionObserver$SelfHealingTask.run(TaskRegionObserver.java:203)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Note that this only happens in the sandbox, so it's not important to fix.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6437) Delete marker for parent-child rows does not get replicated via SystemCatalogWALEntryFilter
[ https://issues.apache.org/jira/browse/PHOENIX-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352003#comment-17352003 ] Lars Hofhansl commented on PHOENIX-6437: I cherry-picked it into branch-5.1. > Delete marker for parent-child rows does not get replicated via > SystemCatalogWALEntryFilter > --- > > Key: PHOENIX-6437 > URL: https://issues.apache.org/jira/browse/PHOENIX-6437 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Ankit Jain >Assignee: Ankit Jain >Priority: Major > Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2 > > > As part of PHOENIX-3639 SystemCatalogWALEntryFilter was introduced to > replicate tenant owned rows from system.catalog and ignore the non-tenant > rows. During recent testing it was realized that delete markers for > parent-child rows does not get replicated. As part of this Jira we want to > fix that. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6435) Fix ViewTTLIT test flapper
[ https://issues.apache.org/jira/browse/PHOENIX-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351996#comment-17351996 ] Lars Hofhansl commented on PHOENIX-6435: Done. > Fix ViewTTLIT test flapper > -- > > Key: PHOENIX-6435 > URL: https://issues.apache.org/jira/browse/PHOENIX-6435 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Blocker > Fix For: 4.16.1, 4.17.0, 5.2.0, 5.1.2 > > > [ERROR] Errors: > [ERROR] > PermissionNSDisabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1278->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] > PermissionNSEnabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1279->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] ImmutableIndexIT.testGlobalImmutableIndexDelete:407 ? StackOverflow > > mvn verify failed with the above error. We have to address and fix test > flappers before releasing the next 4.16.1RC. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6435) Fix ViewTTLIT test flapper
[ https://issues.apache.org/jira/browse/PHOENIX-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351995#comment-17351995 ] Lars Hofhansl commented on PHOENIX-6435: I'm going to cherry-pick this into 5.1. > Fix ViewTTLIT test flapper > -- > > Key: PHOENIX-6435 > URL: https://issues.apache.org/jira/browse/PHOENIX-6435 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Blocker > Fix For: 4.16.1, 4.17.0, 5.2.0 > > > [ERROR] Errors: > [ERROR] > PermissionNSDisabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1278->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] > PermissionNSEnabledWithCustomAccessControllerIT>BasePermissionsIT.testAutomaticGrantWithIndexAndView:1279->BasePermissionsIT.verifyAllowed:769->BasePermissionsIT.verifyAllowed:776 > ? UndeclaredThrowable > [ERROR] ImmutableIndexIT.testGlobalImmutableIndexDelete:407 ? StackOverflow > > mvn verify failed with the above error. We have to address and fix test > flappers before releasing the next 4.16.1RC. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6437) Delete marker for parent-child rows does not get replicated via SystemCatalogWALEntryFilter
[ https://issues.apache.org/jira/browse/PHOENIX-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351994#comment-17351994 ] Lars Hofhansl commented on PHOENIX-6437: What about 5.1? Since it's in 4.16.2 it should be in 5.1.2 as well, right? > Delete marker for parent-child rows does not get replicated via > SystemCatalogWALEntryFilter > --- > > Key: PHOENIX-6437 > URL: https://issues.apache.org/jira/browse/PHOENIX-6437 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Ankit Jain >Assignee: Ankit Jain >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2 > > > As part of PHOENIX-3639 SystemCatalogWALEntryFilter was introduced to > replicate tenant owned rows from system.catalog and ignore the non-tenant > rows. During recent testing it was realized that delete markers for > parent-child rows does not get replicated. As part of this Jira we want to > fix that. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351991#comment-17351991 ] Lars Hofhansl commented on PHOENIX-6447: I cherry-picked the change in. All done. All good :) > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351988#comment-17351988 ] Lars Hofhansl commented on PHOENIX-6447: [~sandeep.pal] did you get a chance yet? If the change applies you can also just cherry-pick from master into the 5.1 branch. > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351850#comment-17351850
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848847922
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 8s | master passed |
| +0 | hbaserecompile | 23m 28s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 33s | master passed |
| +1 :green_heart: | javadoc | 2m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 3s | the patch passed |
| +0 | hbaserecompile | 14m 29s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 29s | the patch passed |
| +1 :green_heart: | javac | 1m 29s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 13s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 118m 31s | root in the patch failed. |
| -1 :x: | asflicense | 2m 18s | The patch generated 614 ASF License
warnings. |
| | | 170m 51s | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1238 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux bbf39ec11ce4 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 3231aad |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 11587 (vs. ulimit of 3) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the
[GitHub] [phoenix] stoty commented on pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
stoty commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848847922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 8s | master passed | | +0 | hbaserecompile | 23m 28s | HBase recompiled. | | +1 :green_heart: | compile | 1m 33s | master passed | | +1 :green_heart: | javadoc | 2m 12s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 3s | the patch passed | | +0 | hbaserecompile | 14m 29s | HBase recompiled. | | +1 :green_heart: | compile | 1m 29s | the patch passed | | +1 :green_heart: | javac | 1m 29s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 13s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 118m 31s | root in the patch failed. | | -1 :x: | asflicense | 2m 18s | The patch generated 614 ASF License warnings. | | | | 170m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.AuditLoggingIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1238 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux bbf39ec11ce4 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 3231aad | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 11587 (vs. ulimit of 3) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1238/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351817#comment-17351817
]
ASF GitHub Bot commented on PHOENIX-6475:
-
martin-g commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848809055
I could offer my help doing the extra work and maintenance!
Since Phoenix is mainly Java based I don't expect much work related to
ARM64. But having CI to notify us when there is a regression would be nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] martin-g commented on pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
martin-g commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848809055 I could offer my help doing the extra work and maintenance! Since Phoenix is mainly Java based I don't expect much work related to ARM64. But having CI to notify us when there is a regression would be nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351812#comment-17351812
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848802499
In theory it'd be nice to test on ARM, but it's not enough of a priority at
the moment to put in the work to set up the tests and maintain them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core, omid
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
stoty commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848802499 In theory it'd be nice to test on ARM, but it's not enough of a priority at the moment to put in the work to set up the tests and maintain them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351763#comment-17351763
]
ASF GitHub Bot commented on PHOENIX-6475:
-
martin-g edited a comment on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848742161
@stoty about hardware to test it: few other Hadoop related projects use
Linux ARM64 Jenkins agents. See https://ci-hadoop.apache.org/computer/ and look
for `arm`.
Are you interested to test Phoenix on these too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] martin-g edited a comment on pull request #1238: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc when building on Linux ARM64
martin-g edited a comment on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848742161 @stoty about hardware to test it: few other Hadoop related projects use Linux ARM64 Jenkins agents. See https://ci-hadoop.apache.org/computer/ and look for `arm`. Are you interested to test Phoenix on these too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351762#comment-17351762
]
ASF GitHub Bot commented on PHOENIX-6475:
-
martin-g commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848742161
@stoty about hardware to test it: few other Hadoop related projects use few
(3, I think) Linux ARM64 Jenkins agents. See
https://ci-hadoop.apache.org/computer/ and look for `arm`.
Are you interested to test Phoenix on these too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] martin-g commented on pull request #1238: PHOENIX-6475 Use github.com/os72/protoc-jar when building on Linux ARM64
martin-g commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848742161 @stoty about hardware to test it: few other Hadoop related projects use few (3, I think) Linux ARM64 Jenkins agents. See https://ci-hadoop.apache.org/computer/ and look for `arm`. Are you interested to test Phoenix on these too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351749#comment-17351749
]
ASF GitHub Bot commented on PHOENIX-6475:
-
martin-g commented on a change in pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#discussion_r639670670
##
File path: pom.xml
##
@@ -107,7 +107,10 @@
1.2.17
3.3.6
1.7.25
-2.5.0
+
+com.google.protobuf
+2.6.1
Review comment:
Reverted to 2.5.0 for both x86_64 and aarch64!
The OpenLabTesting guys released 2.5.0.2 which brings statically linked
Protoc.
Here is its build script:
https://gist.github.com/liusheng/64aee1b27de037f8b9ccf1873b82c413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] martin-g commented on a change in pull request #1238: PHOENIX-6475 Use github.com/os72/protoc-jar when building on Linux ARM64
martin-g commented on a change in pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#discussion_r639670670 ## File path: pom.xml ## @@ -107,7 +107,10 @@ 1.2.17 3.3.6 1.7.25 -2.5.0 + +com.google.protobuf +2.6.1 Review comment: Reverted to 2.5.0 for both x86_64 and aarch64! The OpenLabTesting guys released 2.5.0.2 which brings statically linked Protoc. Here is its build script: https://gist.github.com/liusheng/64aee1b27de037f8b9ccf1873b82c413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] martin-g commented on a change in pull request #1238: PHOENIX-6475 Use github.com/os72/protoc-jar when building on Linux ARM64
martin-g commented on a change in pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#discussion_r639669755 ## File path: phoenix-pherf/pom.xml ## @@ -133,10 +133,6 @@ org.apache.phoenix.thirdparty phoenix-shaded-commons-cli - - commons-io - commons-io - Review comment: Done! #1241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351748#comment-17351748
]
ASF GitHub Bot commented on PHOENIX-6475:
-
martin-g commented on a change in pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#discussion_r639669755
##
File path: phoenix-pherf/pom.xml
##
@@ -133,10 +133,6 @@
org.apache.phoenix.thirdparty
phoenix-shaded-commons-cli
-
- commons-io
- commons-io
-
Review comment:
Done! #1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6378) Unbundle sqlline from phoenix-client
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351692#comment-17351692 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#issuecomment-848671390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 12m 43s | master passed | | +0 | hbaserecompile | 25m 47s | HBase recompiled. | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | javadoc | 3m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 10m 1s | root in the patch failed. | | +0 | hbaserecompile | 17m 49s | HBase recompiled. | | -1 :x: | compile | 1m 35s | root in the patch failed. | | -1 :x: | javac | 1m 35s | root in the patch failed. | | -1 :x: | pylint | 0m 7s | The patch generated 22 new + 115 unchanged - 10 fixed = 137 total (was 125) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 11s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 1m 26s | root in the patch failed. | | -1 :x: | javadoc | 0m 13s | phoenix-assembly in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 115m 28s | root in the patch failed. | | -1 :x: | asflicense | 3m 40s | The patch generated 614 ASF License warnings. | | | | 176m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1239 | | Optional Tests | dupname asflicense pylint javac javadoc unit xml compile | | uname | Linux 6a0da1a9988b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 3231aad | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-compile-root.txt | | pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/diff-patch-pylint.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 15461 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-client-parent/phoenix-client phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/console | | versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 | | Powered by | Apache Yetus
[GitHub] [phoenix] stoty commented on pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client
stoty commented on pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#issuecomment-848671390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 12m 43s | master passed | | +0 | hbaserecompile | 25m 47s | HBase recompiled. | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | javadoc | 3m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 10m 1s | root in the patch failed. | | +0 | hbaserecompile | 17m 49s | HBase recompiled. | | -1 :x: | compile | 1m 35s | root in the patch failed. | | -1 :x: | javac | 1m 35s | root in the patch failed. | | -1 :x: | pylint | 0m 7s | The patch generated 22 new + 115 unchanged - 10 fixed = 137 total (was 125) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 11s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 1m 26s | root in the patch failed. | | -1 :x: | javadoc | 0m 13s | phoenix-assembly in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 115m 28s | root in the patch failed. | | -1 :x: | asflicense | 3m 40s | The patch generated 614 ASF License warnings. | | | | 176m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1239 | | Optional Tests | dupname asflicense pylint javac javadoc unit xml compile | | uname | Linux 6a0da1a9988b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 3231aad | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-compile-root.txt | | pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/diff-patch-pylint.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 15461 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-client-parent/phoenix-client phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/2/console | | versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[GitHub] [phoenix] stoty commented on pull request #1241: Remove duplicate entry of commons-io dependency in phoenix-pherf
stoty commented on pull request #1241: URL: https://github.com/apache/phoenix/pull/1241#issuecomment-848616182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 42s | master passed | | +0 | hbaserecompile | 23m 9s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 10s | the patch passed | | +0 | hbaserecompile | 39m 30s | HBase recompiled. | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 8m 37s | phoenix-pherf in the patch failed. | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 51m 19s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.pherf.PherfMainIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1241/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1241 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux e54a9250a6dc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 3231aad | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1241/1/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1241/1/testReport/ | | Max. process+thread count | 2326 (vs. ulimit of 3) | | modules | C: phoenix-pherf U: phoenix-pherf | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1241/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] martin-g opened a new pull request #1241: Remove duplicate entry of commons-io dependency in phoenix-pherf
martin-g opened a new pull request #1241: URL: https://github.com/apache/phoenix/pull/1241 Resolves the following warning in Maven logs: ``` [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.phoenix:phoenix-pherf:jar:5.2.0-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: commons-io:commons-io:jar -> duplicate declaration of version (?) @ line 136, column 17 [WARNING] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351532#comment-17351532
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty edited a comment on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848491742
Thanks for the explanation and your work on it.
I was suggesting the Openlabtesting version because HBase use(d) that one,
and it had 2.5.0 available for arm.
However, if that one has dependency problems, then of course it is not
useful for us.
I can see two solutions:
1. You can abandon this change, and specify the compiled ARM protoc binary
location in a system property on the maven command line when building.
2. Use the (only ?) known working os72 2.6.1 version of protoc in the
aarch64 profile.
However, in this case please do not change the x86_64 protobuf artifact for
2.5.0, nor the java library versions, only the protoc artifact groupId and
version, and only for the arm profile.
(You'll still need to extract the version and groupId into properties of
course)
If you choose 2.) please also add a comment to the profile that we're using
2.6.x here because there is no public 2.5.0 artifact for arm available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6475) Build failure on Linux ARM64
[
https://issues.apache.org/jira/browse/PHOENIX-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351521#comment-17351521
]
ASF GitHub Bot commented on PHOENIX-6475:
-
stoty commented on pull request #1238:
URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848491742
Thanks for the explanation and your work on it.
I was suggesting the Openlabtesting version because HBase use(d) that one,
and it had 2.5.0 available for arm.
However, if that one has dependency problems, then of course it is not
useful for us.
I can see two solutions:
1. You can abandon this change, and specify the compiled ARM protoc binary
location in a system property on the maven command line when building.
2. Use the (only ?) known working os72 2.6.1 version of protoc in the
aarch64 profile.
However, in this case please do not change the x86_64 protobuf artifact for
2.5.0, nor the java library versions, only the protoc artifact groupId and
version, and only for the arm profile.
(You'll still need to extract the version and groupId into properties of
course)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on Linux ARM64
>
>
> Key: PHOENIX-6475
> URL: https://issues.apache.org/jira/browse/PHOENIX-6475
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 5.1.1
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>
> The build fails on Linux ARM64 architecture because Protobuf-Java 2.5.0 does
> not provide protoc binary for aarch64:
>
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project phoenix-core: Unable to resolve artifact: Missing:
> [ERROR] --
> [ERROR] 1) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf
> -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=linux-aarch_64
> -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR] 2) com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0
> [ERROR]
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] org.apache.phoenix:phoenix-core:jar:5.2.0-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache release
> (https://repository.apache.org/content/repositories/releases/, releases=true,
> snapshots=true),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {code}
>
> As discussed at
> [https://lists.apache.org/thread.html/ra5405789376bdb9e16ffa014f1d0a098af34d4946e41ca09efc95a84%40%3Cdev.phoenix.apache.org%3E]
> updating to Protobuf 3.5+ is not an option at the moment.
> To preserve backward compatibility Phoenix should continue using Protobuf 2.x.
> The only working solution I was able to find is to use
> [https://github.com/os72/protoc-jar:2.6.1-build3] on Linux ARM64
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] stoty edited a comment on pull request #1238: PHOENIX-6475 Use github.com/os72/protoc-jar when building on Linux ARM64
stoty edited a comment on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848491742 Thanks for the explanation and your work on it. I was suggesting the Openlabtesting version because HBase use(d) that one, and it had 2.5.0 available for arm. However, if that one has dependency problems, then of course it is not useful for us. I can see two solutions: 1. You can abandon this change, and specify the compiled ARM protoc binary location in a system property on the maven command line when building. 2. Use the (only ?) known working os72 2.6.1 version of protoc in the aarch64 profile. However, in this case please do not change the x86_64 protobuf artifact for 2.5.0, nor the java library versions, only the protoc artifact groupId and version, and only for the arm profile. (You'll still need to extract the version and groupId into properties of course) If you choose 2.) please also add a comment to the profile that we're using 2.6.x here because there is no public 2.5.0 artifact for arm available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1238: PHOENIX-6475 Use github.com/os72/protoc-jar when building on Linux ARM64
stoty commented on pull request #1238: URL: https://github.com/apache/phoenix/pull/1238#issuecomment-848491742 Thanks for the explanation and your work on it. I was suggesting the Openlabtesting version because HBase use(d) that one, and it had 2.5.0 available for arm. However, if that one has dependency problems, then of course it is not useful for us. I can see two solutions: 1. You can abandon this change, and specify the compiled ARM protoc binary location in a system property on the maven command line when building. 2. Use the (only ?) known working os72 2.6.1 version of protoc in the aarch64 profile. However, in this case please do not change the x86_64 protobuf artifact for 2.5.0, nor the java library versions, only the protoc artifact groupId and version, and only for the arm profile. (You'll still need to extract the version and groupId into properties of course) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
